115979 2013-05-11 22:45:44 -0700 [Mac] Give every Clipboard an underlying Pasteboard 2013-05-12 18:25:05 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115980 1 darin darin commit-queue esprehn+autocc kling oldest_to_newest 887902 0 darin 2013-05-11 22:45:44 -0700 [Mac] Give every Clipboard an underlying Pasteboard 887904 1 201481 darin 2013-05-11 22:49:19 -0700 Created attachment 201481 Patch 888022 2 201481 kling 2013-05-12 15:45:46 -0700 Comment on attachment 201481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201481&action=review r=me, glad to see this is moving :) > Source/WebCore/dom/Clipboard.h:37 > +#define USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS !PLATFORM(MAC) I would have named this WTF_USE_LEGACY_... and used #if USE(LEGACY_...) > Source/WebCore/platform/mac/ClipboardMac.mm:60 > - : Clipboard(policy, clipboardType) > + : Clipboard(policy, clipboardType, Pasteboard::create(m_pasteboardName)) > , m_pasteboardName(pasteboardName) Is m_pasteboardName guaranteed to be initialized before you pass it to the base class ctor here? 888047 3 darin 2013-05-12 18:20:15 -0700 (In reply to comment #2) > > Source/WebCore/dom/Clipboard.h:37 > > +#define USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS !PLATFORM(MAC) > > I would have named this WTF_USE_LEGACY_... and used #if USE(LEGACY_...) OK. I can change that. > > Source/WebCore/platform/mac/ClipboardMac.mm:60 > > - : Clipboard(policy, clipboardType) > > + : Clipboard(policy, clipboardType, Pasteboard::create(m_pasteboardName)) > > , m_pasteboardName(pasteboardName) > > Is m_pasteboardName guaranteed to be initialized before you pass it to the base class ctor here? It’s not. I thought I had fixed that! I’ll land with it fixed. 888048 4 darin 2013-05-12 18:25:05 -0700 Committed r149972: <http://trac.webkit.org/changeset/149972> 201481 2013-05-11 22:49:19 -0700 2013-05-12 18:19:48 -0700 Patch bug-115979-20130511224819.patch text/plain 6691 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTM3YWNhM2JkODkyNjM5 MzBkNGIwMjM5NjIyNzNiMDMzYWE3MmM4MS4uYjMwN2ZjOTBiZDU0ZmNlMThhOTA2ZjM5NmI3NGJj NWNhMDhkNGFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEzLTA1LTExICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBHaXZlIGV2ZXJ5IENs aXBib2FyZCBhbiB1bmRlcmx5aW5nIFBhc3RlYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhlIGZpcnN0IHN0ZXAgaW4gQ2xpcGJv YXJkIGFuZCBQYXN0ZWJvYXJkIHJlZmFjdG9yaW5nCisgICAgICAgIHRvIGZpeCB0aGUgb3Zlcmxh cCBhbmQgbWFueSBsYXllcmluZyB2aW9sYXRpb25zLgorCisgICAgICAgICogZG9tL0NsaXBib2Fy ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmQ6OkNsaXBib2FyZCk6IEFkZCBhbiBt X3Bhc3RlYm9hcmQgZGF0YSBtZW1iZXIsCisgICAgICAgIE1hYy1vbmx5IGZvciBub3csIGJ1dCBl dmVudHVhbGx5IGZvciBhbGwgcGxhdGZvcm1zLgorICAgICAgICAoV2ViQ29yZTo6Q2xpcGJvYXJk Ojp+Q2xpcGJvYXJkKTogTm8gbG9uZ2VyIGlubGluZSB0aGUgZGVzdHJ1Y3Rvci4KKworICAgICAg ICAqIGRvbS9DbGlwYm9hcmQuaDogQWRkIGEgVVNFX0xFR0FDWV9TVFlMRV9BQlNUUkFDVF9DTElQ Qk9BUkRfQ0xBU1MKKyAgICAgICAgZmxhZywgY3VycmVudGx5IHRydWUgZm9yIGFsbCBub24tTWFj IHBsYXRmb3Jtcy4gTWFrZSB0aGUgY29uc3RydWN0b3IKKyAgICAgICAgbm8gbG9uZ2VyIGlubGlu ZS4gQWRkZWQgYSBQYXNzT3duUHRyPFBhc3RlYm9hcmQ+IGFyZ3VtZW50IHRvIHRoZQorICAgICAg ICBjb25zdHJ1Y3RvciBhbmQgYW4gT3duUHRyPFBhc3RlYm9hcmQ+IGRhdGEgbWVtYmVyLgorCisg ICAgICAgICogcGxhdGZvcm0vUGFzdGVib2FyZC5oOiBBZGRlZCBhIGNyZWF0ZSBmdW5jdGlvbiB0 byBtYWtlIGl0IGVhc3kKKyAgICAgICAgdG8gY3JlYXRlIGEgcGFzdGVib2FyZCBnaXZlbiBhIHBh c3RlYm9hcmQgbmFtZS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMubW06 CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmRNYWM6OkNsaXBib2FyZE1hYyk6IENyZWF0ZSBh IHBhc3RlYm9hcmQgYW5kIHBhc3MKKyAgICAgICAgaXQgdG8gdGhlIENsaXBib2FyZCBjb25zdHJ1 Y3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9QYXN0ZWJvYXJkTWFjLm1tOgorICAgICAg ICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6Y3JlYXRlKTogQWRkZWQuCisKIDIwMTMtMDUtMTAgIExh c3psbyBHb21ib3MgIDxsLmdvbWJvc0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgTWFj IE9TIFggTGVvcGFyZCAoMTAuNSkgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0NsaXBib2FyZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAppbmRl eCBiMmMwNzE2ZTVkN2NjYWVlZmYxZTBlNzgxZTYzYzUyZWY5ZGQ3MDUyLi45MTcwMWM5ZjkyYzU3 MDBjMDcwMTg1M2M5NzE0ZTQ1MzdhOTg2NDBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vQ2xpcGJvYXJkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcApA QCAtMzAsMTUgKzMwLDI3IEBACiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJGcmFtZUxv YWRlci5oIgogI2luY2x1ZGUgIkltYWdlLmgiCisjaW5jbHVkZSAiUGFzdGVib2FyZC5oIgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKLUNsaXBib2FyZDo6Q2xpcGJvYXJkKENsaXBib2FyZEFjY2Vz c1BvbGljeSBwb2xpY3ksIENsaXBib2FyZFR5cGUgY2xpcGJvYXJkVHlwZSkgCitDbGlwYm9hcmQ6 OkNsaXBib2FyZChDbGlwYm9hcmRBY2Nlc3NQb2xpY3kgcG9saWN5LCBDbGlwYm9hcmRUeXBlIGNs aXBib2FyZFR5cGUKKyNpZiAhVVNFX0xFR0FDWV9TVFlMRV9BQlNUUkFDVF9DTElQQk9BUkRfQ0xB U1MKKyAgICAsIFBhc3NPd25QdHI8UGFzdGVib2FyZD4gcGFzdGVib2FyZAorI2VuZGlmCispCiAg ICAgOiBtX3BvbGljeShwb2xpY3kpCiAgICAgLCBtX2Ryb3BFZmZlY3QoInVuaW5pdGlhbGl6ZWQi KQogICAgICwgbV9lZmZlY3RBbGxvd2VkKCJ1bmluaXRpYWxpemVkIikKICAgICAsIG1fZHJhZ1N0 YXJ0ZWQoZmFsc2UpCiAgICAgLCBtX2NsaXBib2FyZFR5cGUoY2xpcGJvYXJkVHlwZSkKKyNpZiAh VVNFX0xFR0FDWV9TVFlMRV9BQlNUUkFDVF9DTElQQk9BUkRfQ0xBU1MKKyAgICAsIG1fcGFzdGVi b2FyZChwYXN0ZWJvYXJkKQorI2VuZGlmCit7Cit9CisKK0NsaXBib2FyZDo6fkNsaXBib2FyZCgp CiB7CiB9CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmgg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmgKaW5kZXggOTk0Y2QxN2Q1YjY1NjhlODhj OTMzNzYzOGU4NDY5ZmMwNjc0MDFlNS4uY2I2NmRlOTViMTk2YWEzNmQ1M2VmNWMzNGVkODYzYzZl MzI5YmQ3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9DbGlwYm9hcmQuaApAQCAtMzEsNiArMzEsMTEgQEAKICNpbmNs dWRlICJJbnRQb2ludC5oIgogI2luY2x1ZGUgIk5vZGUuaCIKIAorLy8gVGhpcyBET00gb2JqZWN0 IG5vdyB3b3JrcyBieSBjYWxsaW5nIHRocm91Z2ggdG8gY2xhc3NlcyBpbiB0aGUgcGxhdGZvcm0g bGF5ZXIuCisvLyBTcGVjaWZpY2FsbHksIHRoZSBjbGFzcyBjdXJyZW50bHkgbmFtZWQgUGFzdGVi b2FyZC4gVGhlIGxlZ2FjeSBzdHlsZSBpbnN0ZWFkCisvLyB1c2VzIHRoaXMgYXMgYW4gYWJzdHJh Y3QgYmFzZSBjbGFzcy4KKyNkZWZpbmUgVVNFX0xFR0FDWV9TVFlMRV9BQlNUUkFDVF9DTElQQk9B UkRfQ0xBU1MgIVBMQVRGT1JNKE1BQykKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgY2xh c3MgQ2FjaGVkSW1hZ2U7CkBAIC0zOCw2ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAg ICBjbGFzcyBEcmFnRGF0YTsKICAgICBjbGFzcyBGaWxlTGlzdDsKICAgICBjbGFzcyBGcmFtZTsK KyAgICBjbGFzcyBQYXN0ZWJvYXJkOwogCiAgICAgLy8gU3RhdGUgYXZhaWxhYmxlIGR1cmluZyBJ RSdzIGV2ZW50cyBmb3IgZHJhZyBhbmQgZHJvcCBhbmQgY29weS9wYXN0ZQogICAgIGNsYXNzIENs aXBib2FyZCA6IHB1YmxpYyBSZWZDb3VudGVkPENsaXBib2FyZD4gewpAQCAtNTAsNyArNTYsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIAogICAgICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxDbGlwYm9hcmQ+IGNyZWF0ZShDbGlwYm9hcmRBY2Nlc3NQb2xpY3ksIERyYWdEYXRhKiwgRnJh bWUqKTsKIAotICAgICAgICB2aXJ0dWFsIH5DbGlwYm9hcmQoKSB7IH0KKyAgICAgICAgdmlydHVh bCB+Q2xpcGJvYXJkKCk7CiAKICAgICAgICAgYm9vbCBpc0ZvckNvcHlBbmRQYXN0ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fY2xpcGJvYXJkVHlwZSA9PSBDb3B5QW5kUGFzdGU7IH0KICAgICAgICAgYm9v bCBpc0ZvckRyYWdBbmREcm9wKCkgY29uc3QgeyByZXR1cm4gbV9jbGlwYm9hcmRUeXBlID09IERy YWdBbmREcm9wOyB9CkBAIC0xMTAsNyArMTE2LDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNl bmRpZgogICAgICAgICAKICAgICBwcm90ZWN0ZWQ6CisjaWYgIVVTRV9MRUdBQ1lfU1RZTEVfQUJT VFJBQ1RfQ0xJUEJPQVJEX0NMQVNTCisgICAgICAgIENsaXBib2FyZChDbGlwYm9hcmRBY2Nlc3NQ b2xpY3ksIENsaXBib2FyZFR5cGUsIFBhc3NPd25QdHI8UGFzdGVib2FyZD4pOworI2Vsc2UKICAg ICAgICAgQ2xpcGJvYXJkKENsaXBib2FyZEFjY2Vzc1BvbGljeSwgQ2xpcGJvYXJkVHlwZSk7Cisj ZW5kaWYKIAogICAgICAgICBib29sIGRyYWdTdGFydGVkKCkgY29uc3QgeyByZXR1cm4gbV9kcmFn U3RhcnRlZDsgfQogICAgICAgICAKQEAgLTEyOSw2ICsxMzksMTEgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICBJbnRQb2ludCBtX2RyYWdMb2M7CiAgICAgICAgIENhY2hlZFJlc291cmNl SGFuZGxlPENhY2hlZEltYWdlPiBtX2RyYWdJbWFnZTsKICAgICAgICAgUmVmUHRyPE5vZGU+IG1f ZHJhZ0ltYWdlRWxlbWVudDsKKworI2lmICFVU0VfTEVHQUNZX1NUWUxFX0FCU1RSQUNUX0NMSVBC T0FSRF9DTEFTUworICAgIHByaXZhdGU6CisgICAgICAgIE93blB0cjxQYXN0ZWJvYXJkPiBtX3Bh c3RlYm9hcmQ7CisjZW5kaWYKICAgICB9OwogCiAgICAgRHJhZ09wZXJhdGlvbiBjb252ZXJ0RHJv cFpvbmVPcGVyYXRpb25Ub0RyYWdPcGVyYXRpb24oY29uc3QgU3RyaW5nJiBkcmFnT3BlcmF0aW9u KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bhc3RlYm9hcmQuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bhc3RlYm9hcmQuaAppbmRleCBkYjZmMmVmNDgzOGI4Zjky MzI0N2U0NjIxYWUxNTRmNDhlY2NiNDQzLi5iYTBlMDc3ZGVkM2QxYjBmNTc2NmVkM2RlMTY5Y2Nj ODM3ZDcwNTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QYXN0ZWJvYXJk LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGFzdGVib2FyZC5oCkBAIC04NCw2ICs4 NCw4IEBAIHB1YmxpYzoKICAgICB9OwogCiAjaWYgUExBVEZPUk0oTUFDKQorICAgIHN0YXRpYyBQ YXNzT3duUHRyPFBhc3RlYm9hcmQ+IGNyZWF0ZShjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1l KTsKKwogICAgIC8vIFRoaXMgaXMgcmVxdWlyZWQgdG8gc3VwcG9ydCBPUyBYIHNlcnZpY2VzLgog ICAgIHZvaWQgd3JpdGVTZWxlY3Rpb25Gb3JUeXBlcyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFz dGVib2FyZFR5cGVzLCBib29sIGNhblNtYXJ0Q29weU9yRGVsZXRlLCBGcmFtZSosIFNob3VsZFNl cmlhbGl6ZVNlbGVjdGVkVGV4dEZvckNsaXBib2FyZCk7CiAgICAgZXhwbGljaXQgUGFzdGVib2Fy ZChjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvQ2xpcGJvYXJkTWFjLm1tCmluZGV4IGM3ZmEyYTRjNzYwMjczNzRiZjQzN2FlNmIwZGUz Y2EyMGRjMjk0NWYuLmM1OTVjOTM0OTIxOGVmMDcyNDRmNmQ0ZWI4MGJkZGQzM2Y5NDNmM2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DbGlwYm9hcmRNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0NsaXBib2FyZE1hYy5tbQpAQCAtNTYsNyAr NTYsNyBAQCBQYXNzUmVmUHRyPENsaXBib2FyZD4gQ2xpcGJvYXJkOjpjcmVhdGUoQ2xpcGJvYXJk QWNjZXNzUG9saWN5IHBvbGljeSwgRHJhZ0RhdGEqCiAjZW5kaWYKIAogQ2xpcGJvYXJkTWFjOjpD bGlwYm9hcmRNYWMoQ2xpcGJvYXJkVHlwZSBjbGlwYm9hcmRUeXBlLCBjb25zdCBTdHJpbmcmIHBh c3RlYm9hcmROYW1lLCBDbGlwYm9hcmRBY2Nlc3NQb2xpY3kgcG9saWN5LCBDbGlwYm9hcmRDb250 ZW50cyBjbGlwYm9hcmRDb250ZW50cywgRnJhbWUgKmZyYW1lKQotICAgIDogQ2xpcGJvYXJkKHBv bGljeSwgY2xpcGJvYXJkVHlwZSkKKyAgICA6IENsaXBib2FyZChwb2xpY3ksIGNsaXBib2FyZFR5 cGUsIFBhc3RlYm9hcmQ6OmNyZWF0ZShtX3Bhc3RlYm9hcmROYW1lKSkKICAgICAsIG1fcGFzdGVi b2FyZE5hbWUocGFzdGVib2FyZE5hbWUpCiAgICAgLCBtX2NsaXBib2FyZENvbnRlbnRzKGNsaXBi b2FyZENvbnRlbnRzKQogICAgICwgbV9mcmFtZShmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9QYXN0ZWJvYXJkTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMubW0KaW5kZXggZTY0MGYwYzhjZWJhYWU2MjZmZTk4NDg4 YTE0NjZlODFjM2I4YjE5NS4uMzBjZmNlNzA1NTE3NDBkOTNmZTk3ZGVkZDI2MzE2ZDlkY2I4ZDMw ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMubW0KQEAg LTEzMCw2ICsxMzAsMTEgQEAgUGFzdGVib2FyZDo6UGFzdGVib2FyZChjb25zdCBTdHJpbmcmIHBh c3RlYm9hcmROYW1lKQogICAgIEFTU0VSVChwYXN0ZWJvYXJkTmFtZSk7CiB9CiAKK1Bhc3NPd25Q dHI8UGFzdGVib2FyZD4gUGFzdGVib2FyZDo6Y3JlYXRlKGNvbnN0IFN0cmluZyYgcGFzdGVib2Fy ZE5hbWUpCit7CisgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBQYXN0ZWJvYXJkKHBhc3RlYm9hcmRO YW1lKSk7Cit9CisKIHZvaWQgUGFzdGVib2FyZDo6Y2xlYXIoKQogewogICAgIHBsYXRmb3JtU3Ry YXRlZ2llcygpLT5wYXN0ZWJvYXJkU3RyYXRlZ3koKS0+c2V0VHlwZXMoVmVjdG9yPFN0cmluZz4o KSwgbV9wYXN0ZWJvYXJkTmFtZSk7Cg==