115968 2013-05-11 13:41:15 -0700 [Mac] The captions menu should not use a canned max-width and max-height 2013-05-11 14:42:05 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue eric.carlson esprehn+autocc glenn jer.noble macpherson menard webkit-bug-importer oldest_to_newest 887831 0 graouts 2013-05-11 13:41:15 -0700 Currently, the captions menu (::-webkit-media-controls-closed-captions-track-list) has "max-width" and "max-height" set to 250px. When the captions name are long, it may happen that the name of the caption is clipped even though there is plenty of space available to display the full title over the video. The max-width and max-height of the captions menu should be dependent on the available video real-estate. 887832 1 graouts 2013-05-11 13:41:33 -0700 <rdar://problem/13760800> 887833 2 201470 graouts 2013-05-11 13:45:51 -0700 Created attachment 201470 Patch 887842 3 201470 commit-queue 2013-05-11 14:42:03 -0700 Comment on attachment 201470 Patch Clearing flags on attachment: 201470 Committed r149942: <http://trac.webkit.org/changeset/149942> 887843 4 commit-queue 2013-05-11 14:42:05 -0700 All reviewed patches have been landed. Closing bug. 201470 2013-05-11 13:45:51 -0700 2013-05-11 14:42:03 -0700 Patch bug-115968-20130511224450.patch text/plain 3243 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRiZTllN2E0OTU2MTEw ZTg1MzY3NzFiNWY5ODcxNmFhNDU4NDI0NS4uNjUxMmI3MjhhZTkzNTM3Y2I1YzNjOGM0ODk3ZWI0 NzRjZDY1YjQ4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA1LTExICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVGhlIGNhcHRp b25zIG1lbnUgc2hvdWxkIG5vdCB1c2UgYSBjYW5uZWQgbWF4LXdpZHRoIGFuZCBtYXgtaGVpZ2h0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU5NjgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgbW9y ZSByZWFsIGVzdGF0ZSB0byBkaXNwbGF5IHRoZSBjYXB0aW9ucyBtZW51IHNob3VsZCB0aGUgY2Fw dGlvbiBuYW1lcworICAgICAgICBiZSBsb25nLgorCisgICAgICAgICogY3NzL21lZGlhQ29udHJv bHNRdWlja1RpbWUuY3NzOgorICAgICAgICAodmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMt Y2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lcik6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRp YS1jb250cm9scy1jbG9zZWQtY2FwdGlvbnMtdHJhY2stbGlzdCk6CisgICAgICAgIE1ha2UgdGhl IGNhcHRpb25zIG1lbnUgc2NhbGUgdG8gYSBtYXgtd2lkdGggYW5kIG1heC1oZWlnaHQgdG8gYWxs b3cgNHB4CisgICAgICAgIGFib3ZlIGFuZCBiZWxvdyB0aGUgbWVudSwgZXhjZXB0IG9uIHRoZSBy aWdodCB3aGVyZSBpdCBhbHdheXMgYWxpZ25zIHdpdGgKKyAgICAgICAgdGhlIGNhcHRpb25zIGlj b24gaW4gdGhlIG1lZGlhIGNvbnRyb2xsZXIuCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFD b250cm9sc0FwcGxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbHNBcHBsZTo6 Y3JlYXRlQ29udHJvbHMpOgorICAgICAgICBNb3ZlIHRoZSBjYXB0aW9ucyBtZW51IGVsZW1lbnQg dG8gYmUgYSBjaGlsZCBvZiB0aGUgY29udHJvbHMgaW5zdGVhZCBvZgorICAgICAgICB0aGUgcGFu ZWwgc3VjaCB0aGF0IGl0IG1heSBzY2FsZSByZWxhdGl2ZSB0byB0aGUgY29udHJvbHMgd2hlbiB1 c2luZyAlCisgICAgICAgIENTUyB2YWx1ZXMuCisKIDIwMTMtMDUtMTEgIEJlbmphbWluIFBvdWxh aW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBDYW52YXNTdHlsZSBhIHBs YWluIG9iamVjdCBpbnN0ZWFkIG9mIGFuIFJlZkNvdW50ZWQgb2JqZWN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc1F1aWNrVGltZS5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWVkaWFDb250cm9sc1F1aWNrVGltZS5jc3MKaW5kZXggNzA5Y2E5MjQ4NmRkZjk0 ODZmOTQ4ZjI4NjI2ZWU2YjgyMWUyMWEwNS4uYzhkYjNjZTU2MzIwZGY5ZmZhNmVlZWMwZDQwNmJm N2JjOTNkZWNjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNR dWlja1RpbWUuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzUXVpY2tU aW1lLmNzcwpAQCAtMjUyLDYgKzI1MiwxMCBAQCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9s cy1jbG9zZWQtY2FwdGlvbnMtY29udGFpbmVyIHsKICAgICBkaXNwbGF5OiBibG9jazsKICAgICBy aWdodDogMzhweDsKICAgICBib3R0b206IDI5cHg7CisgICAgbWF4LXdpZHRoOiAtd2Via2l0LWNh bGMoMTAwJSAtIDQ4cHgpOyAvKiByaWdodCArIDEwcHggKi8KKyAgICBtYXgtaGVpZ2h0OiAtd2Vi a2l0LWNhbGMoMTAwJSAtIDM5cHgpOyAvKiBib3R0b20gKyAxMHB4ICovCisgICAgb3ZlcmZsb3ct eDogaGlkZGVuOworICAgIG92ZXJmbG93LXk6IHNjcm9sbDsKICAgICBiYWNrZ3JvdW5kLWNvbG9y OiByZ2JhKDAsIDAsIDAsIDAuODUpOwogICAgIGJvcmRlcjogM3B4IHNvbGlkIHJnYmEoMTI4LCAx MjgsIDEyOCwgMC43NSk7CiAgICAgYm9yZGVyLXJhZGl1czogMTBweDsKQEAgLTI2MSwxMCArMjY1 LDYgQEAgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRh aW5lciB7CiAKIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0aW9ucy10 cmFjay1saXN0IHsKICAgICBkaXNwbGF5OiBibG9jazsKLSAgICBtYXgtd2lkdGg6IDI1MHB4Owot ICAgIG1heC1oZWlnaHQ6IDI1MHB4OwotICAgIG92ZXJmbG93LXg6IGhpZGRlbjsKLSAgICBvdmVy Zmxvdy15OiBzY3JvbGw7CiAgICAgdGV4dC1hbGlnbjogbGVmdDsKICAgICBmb250LWZhbWlseTog IkhlbHZldGljYSBCb2xkIiwgSGVsdmV0aWNhOwogICAgIGZvbnQtc2l6ZTogMTBwdDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHNBcHBsZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzQXBwbGUuY3BwCmluZGV4 IGMxYjYyZGFkMTNiNGNjNmIxOWUyN2E2MTMyY2I3MmVhOTQwZDQ3ZGIuLjYzMmU0NDZlNzBlMzQw YzcwYjI2M2Y5ZWRmZGQzNWY3NzhmMDllMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L01lZGlhQ29udHJvbHNBcHBsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvTWVkaWFDb250cm9sc0FwcGxlLmNwcApAQCAtMTYzLDcgKzE2Myw3IEBAIFBhc3NS ZWZQdHI8TWVkaWFDb250cm9sc0FwcGxlPiBNZWRpYUNvbnRyb2xzQXBwbGU6OmNyZWF0ZUNvbnRy b2xzKERvY3VtZW50KiBkb2N1CiAgICAgICAgICAgICByZXR1cm4gMDsKIAogICAgICAgICBjb250 cm9scy0+bV9jbG9zZWRDYXB0aW9uc0NvbnRhaW5lciA9IGNsb3NlZENhcHRpb25zQ29udGFpbmVy LmdldCgpOwotICAgICAgICBwYW5lbC0+YXBwZW5kQ2hpbGQoY2xvc2VkQ2FwdGlvbnNDb250YWlu ZXIucmVsZWFzZSgpLCBlYywgQXR0YWNoTGF6aWx5KTsKKyAgICAgICAgY29udHJvbHMtPmFwcGVu ZENoaWxkKGNsb3NlZENhcHRpb25zQ29udGFpbmVyLnJlbGVhc2UoKSwgZWMsIEF0dGFjaExhemls eSk7CiAgICAgICAgIGlmIChlYykKICAgICAgICAgICAgIHJldHVybiAwOwogICAgIH0K