115958 2013-05-11 08:46:47 -0700 Make it a build error to put invalid C++ symbol names in WebCore.exp.in 2013-05-12 13:38:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca andersca bfulgham kling oldest_to_newest 887780 0 andersca 2013-05-11 08:46:47 -0700 Make it a build error to put invalid C++ symbol names in WebCore.exp.in 887781 1 201459 andersca 2013-05-11 08:48:49 -0700 Created attachment 201459 Patch 887782 2 201459 kling 2013-05-11 08:59:07 -0700 Comment on attachment 201459 Patch Cool idea. 887783 3 andersca 2013-05-11 09:09:11 -0700 Committed r149932: <http://trac.webkit.org/changeset/149932> 887903 4 bfulgham 2013-05-11 22:48:16 -0700 I didn't think that <cxxabi.h> existed on Windows. At least, my local build now fails. I wonder why the build bots are happy? 887907 5 bfulgham 2013-05-11 23:07:56 -0700 Yeah, looking at other cases of <cxxabi.h> use on the web, it appears to be something Microsoft has not yet implemented. We should probably enclose this in an OS(WINDOWS) guard or something. Note that the VS2010 version of this generator was not touched by this change. Maybe the right fix here is to copy an old version of the generator script to the vcproj folder and use it exclusively for VS2005 builds. Either way, I'm guessing the Windows bots will start failing soon when they do a full clean build, or something touches the symbol file kicking of a rebuild of the WebKitExportGenerator project. For better or for worse, the actual script that generates the source file is not 'seen' by the VS dependency checker, so it does not trigger a build when changed. That's probably why the builds are still running. 887908 6 bfulgham 2013-05-11 23:17:54 -0700 I committed a change to resolve the problem on my side: Committed r149951: <http://trac.webkit.org/changeset/149951> Please double-check I did not hurt anything in your new functionality. Thanks! 888015 7 andersca 2013-05-12 13:38:02 -0700 (In reply to comment #6) > I committed a change to resolve the problem on my side: > > Committed r149951: <http://trac.webkit.org/changeset/149951> > > Please double-check I did not hurt anything in your new functionality. > > Thanks! Sorry about that, I didn't know that ExportFileGenerator runs on Windows! (I don't think it needs to though). 201459 2013-05-11 08:48:49 -0700 2013-05-11 08:59:07 -0700 Patch bug-115958-20130511084750.patch text/plain 1968 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA4ZmZmMzMxZmRkZDUy MWRhYTZmNzI2ZjBlZDM4M2U3Zjk0Y2JjZC4uM2M2MTc5ZmYwZjBkY2JmY2M0OGVkZjUxYzQzMGVh YjFmNDBhYjM4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBpdCBhIGJ1 aWxkIGVycm9yIHRvIHB1dCBpbnZhbGlkIEMrKyBzeW1ib2wgbmFtZXMgaW4gV2ViQ29yZS5leHAu aW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTk1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxl IGludmFsaWQgQysrIHN5bWJvbHMgd2lsbCBldmVudHVhbGx5IHNob3cgdXAgYXMgYSBsaW5rIGVy cm9yIHNpbmNlIHRoZSBzeW1ib2wgd29uJ3QgYmUgZm91bmQsCisgICAgICAgIHRoaXMgbWFrZXMg aXQgZWFzaWVyIHRvIGNhdGNoIGludmFsaWQgc3ltYm9scyBpbnNpZGUgb2YgI2lmZGVmcy4KKwor ICAgICAgICAqIG1ha2UtZXhwb3J0LWZpbGUtZ2VuZXJhdG9yOgorICAgICAgICBUcnkgdG8gZGVt YW5nbGUgQysrIHN5bWJvbHMgYmVmb3JlIHByaW50aW5nIHRoZW0uCisKIDIwMTMtMDUtMTEgIERh dmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCVUlMRCBGSVggKHIx NDk3MTgpOiBNb3ZlIGV4cG9ydGVkIHN5bWJvbCBpbnRvIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkg c2VjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbWFrZS1leHBvcnQtZmlsZS1nZW5l cmF0b3IgYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWV4cG9ydC1maWxlLWdlbmVyYXRvcgppbmRleCBj OWZmMzA0MDY3NGE4YjlmOGEwNjBlZmY3ZDcxOTNiOTg3NTlhNGNjLi40NjFmMDA3N2E0NjQ0NTNj ZjZjZDBhNWYxYjIxOTNmNjZlNGQ4Mzk4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9tYWtl LWV4cG9ydC1maWxlLWdlbmVyYXRvcgorKysgYi9Tb3VyY2UvV2ViQ29yZS9tYWtlLWV4cG9ydC1m aWxlLWdlbmVyYXRvcgpAQCAtMzAsMTMgKzMwLDI5IEBAIHJlcXVpcmUgJ2VyYicKIAogZGVmIGxp bmVfZm9yX291dHB1dCBsaW5lCiAgIHJldHVybiBsaW5lLmNob21wIGlmIGxpbmUgPX4gLyMvCi0g ICIgICAgcHJpbnRmKFwiI3tsaW5lLmNob21wfVxcblwiKTsiCisgICIgICAgdmFsaWRhdGVBbmRQ cmludChcIiN7bGluZS5jaG9tcH1cIik7IgogZW5kCiAKIFRFTVBMQVRFID0gPDwtRU9GCiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0 aW9ucy5oPgorI2luY2x1ZGUgPGN4eGFiaS5oPgorCitzdGF0aWMgdm9pZCB2YWxpZGF0ZUFuZFBy aW50KGNvbnN0IGNoYXIqIHN5bWJvbCkKK3sKKyAgICBpZiAoIXN0cm5jbXAoc3ltYm9sLCAiX19a Iiwgc3RybGVuKCJfX1oiKSkpIHsKKyAgICAgIGNoYXIqIGRlbWFuZ2xlZE5hbWUgPSBhYmk6Ol9f Y3hhX2RlbWFuZ2xlKHN5bWJvbCArIDEsIG51bGxwdHIsIG51bGxwdHIsIG51bGxwdHIpOworICAg ICAgaWYgKCFkZW1hbmdsZWROYW1lKSB7CisgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRVJST1I6 IFxcIiVzXFwiIGlzIG5vdCBhIHZhbGlkIEMrKyBtYW5nbGVkIG5hbWUuXFxuIiwgc3ltYm9sKTsK KyAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOworICAgICAgfQorICAgICAgCisgICAgICBmcmVl KGRlbWFuZ2xlZE5hbWUpOworICAgIH0KKworICAgIHByaW50ZigiJXNcXG4iLCBzeW1ib2wpOwor fQogCiBpbnQgbWFpbihpbnQsIGNoYXIqKikKIHsK