115952 2013-05-10 22:42:15 -0700 Improve stringProtoFuncLastIndexOf for the prefix case 2013-05-13 16:10:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough cmarcelo commit-queue ggaren joepeck oliver oldest_to_newest 887744 0 benjamin 2013-05-10 22:42:15 -0700 Improve stringProtoFuncLastIndexOf for the prefix case 887746 1 201448 benjamin 2013-05-10 22:47:31 -0700 Created attachment 201448 Patch 887747 2 commit-queue 2013-05-10 22:50:16 -0700 Attachment 201448 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/StringPrototype.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/StringImpl.cpp', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h']" exit_code: 1 Source/WTF/wtf/text/StringImpl.h:704: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 887751 3 201448 buildbot 2013-05-10 23:27:51 -0700 Comment on attachment 201448 Patch Attachment 201448 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/297111 887760 4 201452 benjamin 2013-05-11 00:56:08 -0700 Created attachment 201452 Patch 887761 5 commit-queue 2013-05-11 00:57:36 -0700 Attachment 201452 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in', u'Source/JavaScriptCore/runtime/StringPrototype.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/StringImpl.cpp', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h']" exit_code: 1 Source/WTF/wtf/text/StringImpl.h:704: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 887791 6 201452 ggaren 2013-05-11 10:23:09 -0700 Comment on attachment 201452 Patch r=me 887829 7 201452 joepeck 2013-05-11 13:38:47 -0700 Comment on attachment 201452 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201452&action=review Nice! > Source/JavaScriptCore/ChangeLog:12 > + On Joseph Pecoraro's tests, this gives a ~30% speed improvment. Typo: "improvment" => "improvement" 888562 8 benjamin 2013-05-13 16:10:42 -0700 Committed r150042: <http://trac.webkit.org/changeset/150042> 201448 2013-05-10 22:47:31 -0700 2013-05-11 00:56:05 -0700 Patch bug-115952-20130510224632.patch text/plain 5734 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi OWQ3YzYyNjNlMmZjOWYwNjBjYWMzNWVmZTc4M2U1ZDJhZTk1NWE3Li4xYjdkMGE0NDkwOWJkNDZk ZTRlMDViYzJlZTI0MTljMWFmNjA2ZmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNS0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgSW1wcm92ZSBzdHJpbmdQcm90b0Z1bmNMYXN0SW5kZXhPZiBmb3Ig dGhlIHByZWZpeCBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTU5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6c3Ry aW5nUHJvdG9GdW5jTGFzdEluZGV4T2YpOgorICAgICAgICBVc2UgdGhlIG9wdGltaXplZCBzdHJp bmcgc2VhcmNoIHdoZW4gcG9zc2libGUuCisKKyAgICAgICAgT24gSm9zZXBoIFBlY29yYXJvIGFk IGhvYyB0ZXN0cywgdGhpcyBnaXZlcyBhIH4zMCUgc3BlZWQgaW1wcm92bWVudC4KKwogMjAxMy0w NS0xMCAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJl bW92ZSBVU0UoT1NfUkFORE9NTkVTUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n IGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggNzdkMmZiZGYzMTIyYzk4Njk2ODMxNjBmZjEz MjUwMmRhZTUwYzA0YS4uNTg2OTlkNDA4ZjBiZGYxM2RiNDgwNGY3ZmFlMDM3ZjM1ZTQ5MWM4OCAx MDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMy0wNS0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmph bWluQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW1wcm92ZSBzdHJpbmdQcm90b0Z1bmNMYXN0SW5k ZXhPZiBmb3IgdGhlIHByZWZpeCBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTU5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYW4gb3B0aW1pemVkIHZlcnNpb24gb2YgU3RyaW5nSW1wbDo6 c3RhcnRzV2l0aCgpIG9yIEphdmFTY3JpcHRDb3JlLgorCisgICAgICAgICogd3RmL3RleHQvU3Ry aW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnN0YXJ0c1dpdGgpOgorICAg ICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAgICAgKFN0cmluZ0ltcGwpOgorICAg ICAgICAoV1RGOjpTdHJpbmdJbXBsOjpzdGFydHNXaXRoKToKKyAgICAgICAgKiB3dGYvdGV4dC9X VEZTdHJpbmcuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpzdGFydHNXaXRoKToKKwogMjAxMy0w NS0xMCAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJl bW92ZSBVU0UoT1NfUkFORE9NTkVTUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCmluZGV4IGI0MmZlMDg5YWQ2OGM4MTc5ZmFkNjBmZGVh YzcxZjM1NmFhMTFhMTMuLjcxYjRkYzk5ZWZjNmI0NTBjYmVkZmZjNjc2N2NkODIwZDE5ZmE4ZDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlw ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBl LmNwcApAQCAtNzk3LDcgKzc5NywxMiBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHN0 cmluZ1Byb3RvRnVuY0xhc3RJbmRleE9mKEV4ZWNTdGF0ZSogZXhlYykKICAgICBlbHNlIGlmICgh KGRwb3MgPD0gbGVuKSkgLy8gdHJ1ZSBmb3IgTmFOCiAgICAgICAgIGRwb3MgPSBsZW47CiAKLSAg ICBzaXplX3QgcmVzdWx0ID0gcy5yZXZlcnNlRmluZCh1Miwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KGRwb3MpKTsKKyAgICBzaXplX3QgcmVzdWx0OworICAgIHVuc2lnbmVkIHN0YXJ0UG9zaXRpb24g PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oZHBvcyk7CisgICAgaWYgKCFzdGFydFBvc2l0aW9uKQor ICAgICAgICByZXN1bHQgPSBzLnN0YXJ0c1dpdGgodTIpID8gMCA6IG5vdEZvdW5kOworICAgIGVs c2UKKyAgICAgICAgcmVzdWx0ID0gcy5yZXZlcnNlRmluZCh1Miwgc3RhcnRQb3NpdGlvbik7CiAg ICAgaWYgKHJlc3VsdCA9PSBub3RGb3VuZCkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc051bWJlcigtMSkpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIocmVz dWx0KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwIGIv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCA5MTgwNzlmNGRkMTExYjgy NjVjNGZkMWEyYzNhMDhlMzUyZDg0OTBiLi5iMzA1YTE3ZmY4NGViMTVmYjc5YTY4NTNlYjM5YjJm YTVkZWZiMTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3Bw CisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKQEAgLTEyNTIsNiArMTI1 MiwyNCBAQCBBTFdBWVNfSU5MSU5FIHN0YXRpYyBib29sIGVxdWFsSW5uZXIoY29uc3QgU3RyaW5n SW1wbCogc3RyaW5nSW1wbCwgdW5zaWduZWQgc3RhcgogICAgIHJldHVybiBlcXVhbElnbm9yaW5n Q2FzZShzdHJpbmdJbXBsLT5jaGFyYWN0ZXJzMTYoKSArIHN0YXJ0T2Zmc2V0LCByZWludGVycHJl dF9jYXN0PGNvbnN0IExDaGFyKj4obWF0Y2hTdHJpbmcpLCBtYXRjaExlbmd0aCk7CiB9CiAKK2Jv b2wgU3RyaW5nSW1wbDo6c3RhcnRzV2l0aChjb25zdCBTdHJpbmdJbXBsKiBzdHIpIGNvbnN0Cit7 CisgICAgaWYgKCFzdHIpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmIChzdHItPmxl bmd0aCgpID4gbGVuZ3RoKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmIChpczhC aXQoKSkgeworICAgICAgICBpZiAoc3RyLT5pczhCaXQoKSkKKyAgICAgICAgICAgIHJldHVybiBl cXVhbChjaGFyYWN0ZXJzOCgpLCBzdHItPmNoYXJhY3RlcnM4KCksIHN0ci0+bGVuZ3RoKCkpOwor ICAgICAgICByZXR1cm4gZXF1YWwoY2hhcmFjdGVyczgoKSwgc3RyLT5jaGFyYWN0ZXJzMTYoKSwg c3RyLT5sZW5ndGgoKSk7CisgICAgfQorICAgIGlmIChzdHItPmlzOEJpdCgpKQorICAgICAgICBy ZXR1cm4gZXF1YWwoY2hhcmFjdGVyczE2KCksIHN0ci0+Y2hhcmFjdGVyczgoKSwgc3RyLT5sZW5n dGgoKSk7CisgICAgcmV0dXJuIGVxdWFsKGNoYXJhY3RlcnMxNigpLCBzdHItPmNoYXJhY3RlcnMx NigpLCBzdHItPmxlbmd0aCgpKTsKK30KKwogYm9vbCBTdHJpbmdJbXBsOjpzdGFydHNXaXRoKFVD aGFyIGNoYXJhY3RlcikgY29uc3QKIHsKICAgICByZXR1cm4gbV9sZW5ndGggJiYgKCp0aGlzKVsw XSA9PSBjaGFyYWN0ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0lt cGwuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IGFjNDcwNGQ3MzUx NWZkZGU4MDAxNGZkZDFhYjg5MmU2OTY1YWQwM2UuLjczMTliMGI1NmI1ZTAwNDY5M2YwNTEwODEw ODg4NWQzNjZmOGVhMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1w bC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC03MDAsNyArNzAw LDggQEAgcHVibGljOgogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzaXplX3QgcmV2ZXJzZUZp bmQoU3RyaW5nSW1wbCosIHVuc2lnbmVkIGluZGV4ID0gVUlOVF9NQVgpOwogICAgIFdURl9FWFBP UlRfU1RSSU5HX0FQSSBzaXplX3QgcmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2UoU3RyaW5nSW1wbCos IHVuc2lnbmVkIGluZGV4ID0gVUlOVF9NQVgpOwogCi0gICAgYm9vbCBzdGFydHNXaXRoKFN0cmlu Z0ltcGwqIHN0ciwgYm9vbCBjYXNlU2Vuc2l0aXZlID0gdHJ1ZSkgeyByZXR1cm4gKGNhc2VTZW5z aXRpdmUgPyByZXZlcnNlRmluZChzdHIsIDApIDogcmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2Uoc3Ry LCAwKSkgPT0gMDsgfQorICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBib29sIHN0YXJ0c1dpdGgo Y29uc3QgU3RyaW5nSW1wbCopIGNvbnN0OworICAgIGJvb2wgc3RhcnRzV2l0aChTdHJpbmdJbXBs KiBzdHIsIGJvb2wgY2FzZVNlbnNpdGl2ZSkgeyByZXR1cm4gY2FzZVNlbnNpdGl2ZSA/IHN0YXJ0 c1dpdGgoc3RyKSA6IChyZXZlcnNlRmluZElnbm9yaW5nQ2FzZShzdHIsIDApID09IDApOyB9CiAg ICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIGJvb2wgc3RhcnRzV2l0aChVQ2hhcikgY29uc3Q7CiAg ICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIGJvb2wgc3RhcnRzV2l0aChjb25zdCBjaGFyKiwgdW5z aWduZWQgbWF0Y2hMZW5ndGgsIGJvb2wgY2FzZVNlbnNpdGl2ZSkgY29uc3Q7CiAgICAgdGVtcGxh dGU8dW5zaWduZWQgbWF0Y2hMZW5ndGg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAppbmRleCBjM2Nh YjE5OGJkOTQ5ZWEwZTgwZWUyYTI5YzJjYjYwYWY0ZDZhY2Y2Li41OTUyNDE2MGI4OTExY2NhNDE1 YjM0ZGFmMGFlMzI0Y2JkMTE0YzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dU RlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTI4OSw3 ICsyODksOSBAQCBwdWJsaWM6CiAgICAgYm9vbCBjb250YWlucyhjb25zdCBMQ2hhciogc3RyLCBi b29sIGNhc2VTZW5zaXRpdmUgPSB0cnVlKSBjb25zdCB7IHJldHVybiBmaW5kKHN0ciwgMCwgY2Fz ZVNlbnNpdGl2ZSkgIT0gbm90Rm91bmQ7IH0KICAgICBib29sIGNvbnRhaW5zKGNvbnN0IFN0cmlu ZyYgc3RyLCBib29sIGNhc2VTZW5zaXRpdmUgPSB0cnVlKSBjb25zdCB7IHJldHVybiBmaW5kKHN0 ciwgMCwgY2FzZVNlbnNpdGl2ZSkgIT0gbm90Rm91bmQ7IH0KIAotICAgIGJvb2wgc3RhcnRzV2l0 aChjb25zdCBTdHJpbmcmIHMsIGJvb2wgY2FzZVNlbnNpdGl2ZSA9IHRydWUpIGNvbnN0CisgICAg Ym9vbCBzdGFydHNXaXRoKGNvbnN0IFN0cmluZyYgcykgY29uc3QKKyAgICAgICAgeyByZXR1cm4g bV9pbXBsID8gbV9pbXBsLT5zdGFydHNXaXRoKHMuaW1wbCgpKSA6IHMuaXNFbXB0eSgpOyB9Cisg ICAgYm9vbCBzdGFydHNXaXRoKGNvbnN0IFN0cmluZyYgcywgYm9vbCBjYXNlU2Vuc2l0aXZlKSBj b25zdAogICAgICAgICB7IHJldHVybiBtX2ltcGwgPyBtX2ltcGwtPnN0YXJ0c1dpdGgocy5pbXBs KCksIGNhc2VTZW5zaXRpdmUpIDogcy5pc0VtcHR5KCk7IH0KICAgICBib29sIHN0YXJ0c1dpdGgo VUNoYXIgY2hhcmFjdGVyKSBjb25zdAogICAgICAgICB7IHJldHVybiBtX2ltcGwgPyBtX2ltcGwt PnN0YXJ0c1dpdGgoY2hhcmFjdGVyKSA6IGZhbHNlOyB9Cg== 201452 2013-05-11 00:56:08 -0700 2013-05-11 13:38:47 -0700 Patch bug-115952-20130511005509.patch text/plain 7574 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi OWQ3YzYyNjNlMmZjOWYwNjBjYWMzNWVmZTc4M2U1ZDJhZTk1NWE3Li4zODIzYWZlN2EzMzc2NDJh YjU5NTYwNjgyNDdhNzU2MWI0ZDg3YzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNS0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgSW1wcm92ZSBzdHJpbmdQcm90b0Z1bmNMYXN0SW5kZXhPZiBmb3Ig dGhlIHByZWZpeCBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTU5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6c3Ry aW5nUHJvdG9GdW5jTGFzdEluZGV4T2YpOgorICAgICAgICBVc2UgdGhlIG9wdGltaXplZCBzdHJp bmcgc2VhcmNoIHdoZW4gcG9zc2libGUuCisKKyAgICAgICAgT24gSm9zZXBoIFBlY29yYXJvJ3Mg dGVzdHMsIHRoaXMgZ2l2ZXMgYSB+MzAlIHNwZWVkIGltcHJvdm1lbnQuCisKIDIwMTMtMDUtMTAg IExhc3psbyBHb21ib3MgIDxsLmdvbWJvc0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUg VVNFKE9TX1JBTkRPTU5FU1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc3ZDJmYmRmMzEyMmM5ODY5NjgzMTYwZmYxMzI1MDJk YWU1MGMwNGEuLjQ2ZDA0NWNlZjhjNmU3NjVhNGQyMWI3ZTdhZDMyMDFiODU2OTkzZWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTMtMDUtMTEgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3 ZWJraXQub3JnPgorCisgICAgICAgIEltcHJvdmUgc3RyaW5nUHJvdG9GdW5jTGFzdEluZGV4T2Yg Zm9yIHRoZSBwcmVmaXggY2FzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE1OTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGFuIG9wdGltaXplZCB2ZXJzaW9uIG9mIFN0cmluZ0ltcGw6OnN0YXJ0 c1dpdGgoKSBmb3IgSmF2YVNjcmlwdENvcmUuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJ bXBsLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6c3RhcnRzV2l0aCk6CisgICAgICAg ICogd3RmL3RleHQvU3RyaW5nSW1wbC5oOgorICAgICAgICAoU3RyaW5nSW1wbCk6CisgICAgICAg IChXVEY6OlN0cmluZ0ltcGw6OnN0YXJ0c1dpdGgpOgorICAgICAgICAqIHd0Zi90ZXh0L1dURlN0 cmluZy5oOgorICAgICAgICAoV1RGOjpTdHJpbmc6OnN0YXJ0c1dpdGgpOgorCiAyMDEzLTA1LTEw ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3Zl IFVTRShPU19SQU5ET01ORVNTKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZUV4cG9ydHMu ZGVmIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZUV4cG9ydHMuZGVmCmluZGV4IDNlOWM2Y2U2MWY0YWYyYTUz NWVjYTM5ZWQ0YjZkNTA3ZDQwNjM1YjQuLmE4YWI2OWViMzNmOGVmNzEyYjhkYTk1NzNmYTUxOWFh MTg4Mzc4YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmVFeHBvcnRzLmRlZgorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlRXhwb3J0cy5kZWYKQEAgLTQ3Niw2ICs0NzYsNyBAQCBFWFBPUlRTCiAg ICAgP3N0YXJ0UHJvZmlsaW5nQExlZ2FjeVByb2ZpbGVyQEpTQ0BAUUFFWFBBVkV4ZWNTdGF0ZUAy QEFCVlN0cmluZ0BXVEZAQEBaCiAgICAgP3N0YXJ0U2FtcGxpbmdAVk1ASlNDQEBRQUVYWFoKICAg ICA/c3RhcnRzV2l0aEBTdHJpbmdJbXBsQFdURkBAUUJFX05QQkRJX05AWgorICAgID9zdGFydHNX aXRoQFN0cmluZ0ltcGxAV1RGQEBRQkVfTlBCVjEyQEBaCiAgICAgP3N0YXJ0c1dpdGhAU3RyaW5n SW1wbEBXVEZAQFFCRV9OX1dAWgogICAgID9zdG9wUHJvZmlsaW5nQExlZ2FjeVByb2ZpbGVyQEpT Q0BAUUFFP0FWPyRQYXNzUmVmUHRyQFZQcm9maWxlQEpTQ0BAQFdURkBAUEFWRXhlY1N0YXRlQDJA QUJWU3RyaW5nQDRAQFoKICAgICA/c3RvcFNhbXBsaW5nQFZNQEpTQ0BAUUFFWFhaCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2Ny aXB0Q29yZUV4cG9ydEdlbmVyYXRvci9KYXZhU2NyaXB0Q29yZUV4cG9ydHMuZGVmLmluIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmVF eHBvcnRHZW5lcmF0b3IvSmF2YVNjcmlwdENvcmVFeHBvcnRzLmRlZi5pbgppbmRleCAxY2JhMThh ZWNmYzhiZGJhZmQ1YzM4ZjVkNWMyM2RlZmViZDIxMzQ2Li4zZmUyZWEwOGNmODBhOTNiM2FkNzBj NGZmOWEyN2QyNTczZDgzMWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZUV4cG9ydEdlbmVyYXRvci9KYXZhU2Ny aXB0Q29yZUV4cG9ydHMuZGVmLmluCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlRXhwb3J0R2VuZXJhdG9yL0phdmFTY3JpcHRD b3JlRXhwb3J0cy5kZWYuaW4KQEAgLTQ3NCw2ICs0NzQsNyBAQCBFWFBPUlRTCiAgICAgP3N0YXJ0 UHJvZmlsaW5nQExlZ2FjeVByb2ZpbGVyQEpTQ0BAUUFFWFBBVkV4ZWNTdGF0ZUAyQEFCVlN0cmlu Z0BXVEZAQEBaCiAgICAgP3N0YXJ0U2FtcGxpbmdAVk1ASlNDQEBRQUVYWFoKICAgICA/c3RhcnRz V2l0aEBTdHJpbmdJbXBsQFdURkBAUUJFX05QQkRJX05AWgorICAgID9zdGFydHNXaXRoQFN0cmlu Z0ltcGxAV1RGQEBRQkVfTlBCVjEyQEBaCiAgICAgP3N0YXJ0c1dpdGhAU3RyaW5nSW1wbEBXVEZA QFFCRV9OX1dAWgogICAgID9zdG9wUHJvZmlsaW5nQExlZ2FjeVByb2ZpbGVyQEpTQ0BAUUFFP0FW PyRQYXNzUmVmUHRyQFZQcm9maWxlQEpTQ0BAQFdURkBAUEFWRXhlY1N0YXRlQDJAQUJWU3RyaW5n QDRAQFoKICAgICA/c3RvcFNhbXBsaW5nQFZNQEpTQ0BAUUFFWFhaCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAppbmRleCBiNDJmZTA4OWFk NjhjODE3OWZhZDYwZmRlYWM3MWYzNTZhYTExYTEzLi43MWI0ZGM5OWVmYzZiNDUwY2JlZGZmYzY3 NjdjZDgyMGQxOWZhOGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TdHJpbmdQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cmluZ1Byb3RvdHlwZS5jcHAKQEAgLTc5Nyw3ICs3OTcsMTIgQEAgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBzdHJpbmdQcm90b0Z1bmNMYXN0SW5kZXhPZihFeGVjU3RhdGUqIGV4ZWMp CiAgICAgZWxzZSBpZiAoIShkcG9zIDw9IGxlbikpIC8vIHRydWUgZm9yIE5hTgogICAgICAgICBk cG9zID0gbGVuOwogCi0gICAgc2l6ZV90IHJlc3VsdCA9IHMucmV2ZXJzZUZpbmQodTIsIHN0YXRp Y19jYXN0PHVuc2lnbmVkPihkcG9zKSk7CisgICAgc2l6ZV90IHJlc3VsdDsKKyAgICB1bnNpZ25l ZCBzdGFydFBvc2l0aW9uID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGRwb3MpOworICAgIGlmICgh c3RhcnRQb3NpdGlvbikKKyAgICAgICAgcmVzdWx0ID0gcy5zdGFydHNXaXRoKHUyKSA/IDAgOiBu b3RGb3VuZDsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdCA9IHMucmV2ZXJzZUZpbmQodTIsIHN0 YXJ0UG9zaXRpb24pOwogICAgIGlmIChyZXN1bHQgPT0gbm90Rm91bmQpCiAgICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoLTEpKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzTnVtYmVyKHJlc3VsdCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9T dHJpbmdJbXBsLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKaW5kZXgg OTE4MDc5ZjRkZDExMWI4MjY1YzRmZDFhMmMzYTA4ZTM1MmQ4NDkwYi4uYjMwNWExN2ZmODRlYjE1 ZmI3OWE2ODUzZWIzOWIyZmE1ZGVmYjE3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3Bw CkBAIC0xMjUyLDYgKzEyNTIsMjQgQEAgQUxXQVlTX0lOTElORSBzdGF0aWMgYm9vbCBlcXVhbElu bmVyKGNvbnN0IFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwsIHVuc2lnbmVkIHN0YXIKICAgICByZXR1 cm4gZXF1YWxJZ25vcmluZ0Nhc2Uoc3RyaW5nSW1wbC0+Y2hhcmFjdGVyczE2KCkgKyBzdGFydE9m ZnNldCwgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBMQ2hhcio+KG1hdGNoU3RyaW5nKSwgbWF0Y2hM ZW5ndGgpOwogfQogCitib29sIFN0cmluZ0ltcGw6OnN0YXJ0c1dpdGgoY29uc3QgU3RyaW5nSW1w bCogc3RyKSBjb25zdAoreworICAgIGlmICghc3RyKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICBpZiAoc3RyLT5sZW5ndGgoKSA+IGxlbmd0aCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7 CisKKyAgICBpZiAoaXM4Qml0KCkpIHsKKyAgICAgICAgaWYgKHN0ci0+aXM4Qml0KCkpCisgICAg ICAgICAgICByZXR1cm4gZXF1YWwoY2hhcmFjdGVyczgoKSwgc3RyLT5jaGFyYWN0ZXJzOCgpLCBz dHItPmxlbmd0aCgpKTsKKyAgICAgICAgcmV0dXJuIGVxdWFsKGNoYXJhY3RlcnM4KCksIHN0ci0+ Y2hhcmFjdGVyczE2KCksIHN0ci0+bGVuZ3RoKCkpOworICAgIH0KKyAgICBpZiAoc3RyLT5pczhC aXQoKSkKKyAgICAgICAgcmV0dXJuIGVxdWFsKGNoYXJhY3RlcnMxNigpLCBzdHItPmNoYXJhY3Rl cnM4KCksIHN0ci0+bGVuZ3RoKCkpOworICAgIHJldHVybiBlcXVhbChjaGFyYWN0ZXJzMTYoKSwg c3RyLT5jaGFyYWN0ZXJzMTYoKSwgc3RyLT5sZW5ndGgoKSk7Cit9CisKIGJvb2wgU3RyaW5nSW1w bDo6c3RhcnRzV2l0aChVQ2hhciBjaGFyYWN0ZXIpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fbGVu Z3RoICYmICgqdGhpcylbMF0gPT0gY2hhcmFjdGVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvdGV4dC9TdHJpbmdJbXBsLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaApp bmRleCBhYzQ3MDRkNzM1MTVmZGRlODAwMTRmZGQxYWI4OTJlNjk2NWFkMDNlLi43MzE5YjBiNTZi NWUwMDQ2OTNmMDUxMDgxMDg4ODVkMzY2ZjhlYTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi90ZXh0L1N0cmluZ0ltcGwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwu aApAQCAtNzAwLDcgKzcwMCw4IEBAIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkg c2l6ZV90IHJldmVyc2VGaW5kKFN0cmluZ0ltcGwqLCB1bnNpZ25lZCBpbmRleCA9IFVJTlRfTUFY KTsKICAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkgc2l6ZV90IHJldmVyc2VGaW5kSWdub3JpbmdD YXNlKFN0cmluZ0ltcGwqLCB1bnNpZ25lZCBpbmRleCA9IFVJTlRfTUFYKTsKIAotICAgIGJvb2wg c3RhcnRzV2l0aChTdHJpbmdJbXBsKiBzdHIsIGJvb2wgY2FzZVNlbnNpdGl2ZSA9IHRydWUpIHsg cmV0dXJuIChjYXNlU2Vuc2l0aXZlID8gcmV2ZXJzZUZpbmQoc3RyLCAwKSA6IHJldmVyc2VGaW5k SWdub3JpbmdDYXNlKHN0ciwgMCkpID09IDA7IH0KKyAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkg Ym9vbCBzdGFydHNXaXRoKGNvbnN0IFN0cmluZ0ltcGwqKSBjb25zdDsKKyAgICBib29sIHN0YXJ0 c1dpdGgoU3RyaW5nSW1wbCogc3RyLCBib29sIGNhc2VTZW5zaXRpdmUpIHsgcmV0dXJuIGNhc2VT ZW5zaXRpdmUgPyBzdGFydHNXaXRoKHN0cikgOiAocmV2ZXJzZUZpbmRJZ25vcmluZ0Nhc2Uoc3Ry LCAwKSA9PSAwKTsgfQogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBib29sIHN0YXJ0c1dpdGgo VUNoYXIpIGNvbnN0OwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBib29sIHN0YXJ0c1dpdGgo Y29uc3QgY2hhciosIHVuc2lnbmVkIG1hdGNoTGVuZ3RoLCBib29sIGNhc2VTZW5zaXRpdmUpIGNv bnN0OwogICAgIHRlbXBsYXRlPHVuc2lnbmVkIG1hdGNoTGVuZ3RoPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3Ry aW5nLmgKaW5kZXggYzNjYWIxOThiZDk0OWVhMGU4MGVlMmEyOWMyY2I2MGFmNGQ2YWNmNi4uNTk1 MjQxNjBiODkxMWNjYTQxNWIzNGRhZjBhZTMyNGNiZDExNGMwMSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0 cmluZy5oCkBAIC0yODksNyArMjg5LDkgQEAgcHVibGljOgogICAgIGJvb2wgY29udGFpbnMoY29u c3QgTENoYXIqIHN0ciwgYm9vbCBjYXNlU2Vuc2l0aXZlID0gdHJ1ZSkgY29uc3QgeyByZXR1cm4g ZmluZChzdHIsIDAsIGNhc2VTZW5zaXRpdmUpICE9IG5vdEZvdW5kOyB9CiAgICAgYm9vbCBjb250 YWlucyhjb25zdCBTdHJpbmcmIHN0ciwgYm9vbCBjYXNlU2Vuc2l0aXZlID0gdHJ1ZSkgY29uc3Qg eyByZXR1cm4gZmluZChzdHIsIDAsIGNhc2VTZW5zaXRpdmUpICE9IG5vdEZvdW5kOyB9CiAKLSAg ICBib29sIHN0YXJ0c1dpdGgoY29uc3QgU3RyaW5nJiBzLCBib29sIGNhc2VTZW5zaXRpdmUgPSB0 cnVlKSBjb25zdAorICAgIGJvb2wgc3RhcnRzV2l0aChjb25zdCBTdHJpbmcmIHMpIGNvbnN0Cisg ICAgICAgIHsgcmV0dXJuIG1faW1wbCA/IG1faW1wbC0+c3RhcnRzV2l0aChzLmltcGwoKSkgOiBz LmlzRW1wdHkoKTsgfQorICAgIGJvb2wgc3RhcnRzV2l0aChjb25zdCBTdHJpbmcmIHMsIGJvb2wg Y2FzZVNlbnNpdGl2ZSkgY29uc3QKICAgICAgICAgeyByZXR1cm4gbV9pbXBsID8gbV9pbXBsLT5z dGFydHNXaXRoKHMuaW1wbCgpLCBjYXNlU2Vuc2l0aXZlKSA6IHMuaXNFbXB0eSgpOyB9CiAgICAg Ym9vbCBzdGFydHNXaXRoKFVDaGFyIGNoYXJhY3RlcikgY29uc3QKICAgICAgICAgeyByZXR1cm4g bV9pbXBsID8gbV9pbXBsLT5zdGFydHNXaXRoKGNoYXJhY3RlcikgOiBmYWxzZTsgfQo=