115919 2013-05-10 10:57:27 -0700 [css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set 2013-05-14 10:39:21 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 116059 1 betravis betravis cdumez commit-queue syoichi zarvai oldest_to_newest 887427 0 betravis 2013-05-10 10:57:27 -0700 To enable user testing, CSS Exclusions should be turned on in the WebKit nightlies. For this particular feature, which has a runtime and compile-time flag, this can be accomplished by setting the default value of the runtime flag to true. 887458 1 201369 betravis 2013-05-10 11:42:30 -0700 Created attachment 201369 Initial Patch 888364 2 201369 dino 2013-05-13 11:07:52 -0700 Comment on attachment 201369 Initial Patch Simon commented that it really should be areCSSExclusionsEnabled, but this is only the variable name so I don't think it matters. 888382 3 201369 commit-queue 2013-05-13 11:36:35 -0700 Comment on attachment 201369 Initial Patch Clearing flags on attachment: 201369 Committed r150025: <http://trac.webkit.org/changeset/150025> 888383 4 commit-queue 2013-05-13 11:36:37 -0700 All reviewed patches have been landed. Closing bug. 888498 5 cdumez 2013-05-13 13:34:31 -0700 This change has caused the following test to fail on EFL WK2: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r150025%20(8365)/fast/css/variables/var-inside-shape-diffs.html 888499 6 betravis 2013-05-13 13:39:57 -0700 Investigating test failure. If nothing else, Exclusions can be explicitly turned off for that test case. 888732 7 zarvai 2013-05-14 01:38:12 -0700 (In reply to comment #5) > This change has caused the following test to fail on EFL WK2: > http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r150025%20(8365)/fast/css/variables/var-inside-shape-diffs.html This test fails on Qt WK1 and WK2 also. http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r150056%20%2850958%29/fast/css/variables/var-inside-shape-expected.html 888735 8 zarvai 2013-05-14 01:39:45 -0700 Here is the right link, sorry for the noise: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r150056%20%2835480%29/fast/css/variables/var-inside-shape-diffs.html 888738 9 zarvai 2013-05-14 01:50:23 -0700 (In reply to comment #8) > Here is the right link, sorry for the noise: > > http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r150056%20%2835480%29/fast/css/variables/var-inside-shape-diffs.html CSS Variable is disabled on Qt. Next time I do more investigation before commenting, I swear :) 888915 10 betravis 2013-05-14 10:39:21 -0700 I have filed bug 116059 to track the css variable test regressions this patch has caused. fast/css/variables/var-inside-shape in particular is buggy. 201369 2013-05-10 11:42:30 -0700 2013-05-13 11:36:35 -0700 Initial Patch bug-115919-20130510114132.patch text/plain 6049 betravis U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5ODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDIwMmNkOThmOWI1OTcx NzI5MWUxNzJlNjc1MDk3YWMyZjExZjc4ZC4uOGEzMzk0OGJkMTA5OWJmMjExZGRkNGIyZDNjY2U1 OGFiODU2NzY0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTEwICBCZWFy IFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbY3NzIGV4Y2x1c2lvbnNd IEVuYWJsZSBDU1MgRXhjbHVzaW9ucyBieSBkZWZhdWx0IHdoZW4gQ1NTX0VYQ0xVU0lPTlMgaXMg c2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU5 MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2UgdGhlIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzQ1NTRXhjbHVzaW9uc0VuYWJsZWQgYm9v bGVhbiB0byBkZWZhdWx0CisgICAgICAgIHRvIHRydWUuIENTUyBFeGNsdXNpb25zIGNhbiBzdGls bCBiZSBlbmFibGVkIC8gZGlzYWJsZWQgaW4gcGxhdGZvcm1zIGJ5CisgICAgICAgIHNldHRpbmcg dGhlIENTU19FWENMVVNJT05TIGNvbXBpbGUgZmxhZyBpbiBvbmUgb2YgdGhlIEZlYXR1cmVEZWZp bmUgZmlsZXMuCisKKyAgICAgICAgVGVzdDogZmFzdC9leGNsdXNpb25zL2Nzcy1leGNsdXNpb25z LWVuYWJsZWQuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxl ZEZlYXR1cmVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEzLTA1LTEwICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE1lbW9yeVVz YWdlU3VwcG9ydCBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2Vu ZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKaW5kZXggZDJmMDczZDBiZWM0MTBl NzUxMjFjYjA2N2IwNDcyYTlmMDM4MGZkNS4uNWEyYTEzOThlZDVjNjg2OTcxNTMxNzU1YWJmYzc2 NDNhYjI5ZDQwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9S dW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n ZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCkBAIC01NSw3ICs1NSw3IEBAIGJvb2wg UnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNEZXZpY2VNb3Rpb25FbmFibGVkID0gdHJ1ZTsKIGJv b2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNEZXZpY2VPcmllbnRhdGlvbkVuYWJsZWQgPSB0 cnVlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc1NwZWVjaElucHV0RW5hYmxlZCA9 IHRydWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzQ2FudmFzUGF0aEVuYWJsZWQg PSBmYWxzZTsKLWJvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNDU1NFeGNsdXNpb25zRW5h YmxlZCA9IGZhbHNlOworYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0NTU0V4Y2x1c2lv bnNFbmFibGVkID0gdHJ1ZTsKIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNDU1NSZWdp b25zRW5hYmxlZCA9IGZhbHNlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0NTU0Nv bXBvc2l0aW5nRW5hYmxlZCA9IGZhbHNlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpp c0xhbmdBdHRyaWJ1dGVBd2FyZUZvcm1Db250cm9sVUlFbmFibGVkID0gZmFsc2U7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NTUwYzlmNTcyM2RjM2YyOGI2OTM1ZGI5OGQwZmMzNGU0ODVjNjk2NS4uYTU1Y2ExODQ2MDgxNzhm ZWQ3ZDlmY2U5ZmM4NTBmNDM3YmEyY2M2NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1 LTEwICBCZWFyIFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbY3NzIGV4 Y2x1c2lvbnNdIEVuYWJsZSBDU1MgRXhjbHVzaW9ucyBieSBkZWZhdWx0IHdoZW4gQ1NTX0VYQ0xV U0lPTlMgaXMgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTU5MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRpbmcgYSB0ZXN0IHRvIG1ha2Ugc3VyZSBDU1MgRXhjbHVzaW9ucyBjYW4gYmUgZW5h YmxlZCwgYW5kIGFyZSBlbmFibGVkIGJ5CisgICAgICAgIGRlZmF1bHQuCisKKyAgICAgICAgKiBm YXN0L2V4Y2x1c2lvbnMvY3NzLWV4Y2x1c2lvbnMtZW5hYmxlZC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZXhjbHVzaW9ucy9jc3MtZXhjbHVzaW9ucy1lbmFibGVkLmh0bWw6 IEFkZGVkLgorCiAyMDEzLTA1LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJFR1JFU1NJT04gKHIxNDk2NTIpOiBWaWRlb3MgZG8gbm90IHBsYXkgb24gY25u LmNvbSwganVzdCBibGFjayBib3gKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVz aW9ucy9jc3MtZXhjbHVzaW9ucy1lbmFibGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZXhjbHVzaW9ucy9jc3MtZXhjbHVzaW9ucy1lbmFibGVkLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi41NjU4Y2JkZGFiZjNhNGFlMDE4ZmNlZmMwMzNiZmUzZjE3NTc4ZDQwCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL2Nzcy1leGNsdXNpb25zLWVuYWJs ZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKK1Rlc3QgdGhhdCBwYXJzaW5nIG9mIGNz cyBleGNsdXNpb25zIHJlbGF0ZWQgcHJvcGVydGllcyBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuCisK K09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHRlc3RJbmxpbmVTdHlsZSgiLXdl YmtpdC13cmFwLWZsb3ciLCAiYm90aCIpIGlzICJib3RoIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHls ZSgiLXdlYmtpdC13cmFwLWZsb3ciLCAiYm90aCIpIGlzICJib3RoIgorUEFTUyB0ZXN0SW5saW5l U3R5bGUoIi13ZWJraXQtc2hhcGUtbWFyZ2luIiwgIjEwcHgiKSBpcyAiMTBweCIKK1BBU1MgdGVz dENvbXB1dGVkU3R5bGUoIi13ZWJraXQtc2hhcGUtbWFyZ2luIiwgIjEwcHgiKSBpcyAiMTBweCIK K1BBU1MgdGVzdElubGluZVN0eWxlKCItd2Via2l0LXNoYXBlLXBhZGRpbmciLCAiMTBweCIpIGlz ICIxMHB4IgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1zaGFwZS1wYWRkaW5nIiwg IjEwcHgiKSBpcyAiMTBweCIKK1BBU1MgdGVzdElubGluZVN0eWxlKCItd2Via2l0LXdyYXAtdGhy b3VnaCIsICJub25lIikgaXMgIm5vbmUiCitQQVNTIHRlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0 LXdyYXAtdGhyb3VnaCIsICJub25lIikgaXMgIm5vbmUiCitQQVNTIHRlc3RJbmxpbmVTdHlsZSgi LXdlYmtpdC1zaGFwZS1vdXRzaWRlIiwgImNpcmNsZSgxMHB4LCAxMHB4LCAxMHB4KSIpIGlzICJj aXJjbGUoMTBweCwgMTBweCwgMTBweCkiCitQQVNTIHRlc3RDb21wdXRlZFN0eWxlKCItd2Via2l0 LXNoYXBlLW91dHNpZGUiLCAiY2lyY2xlKDEwcHgsIDEwcHgsIDEwcHgpIikgaXMgImNpcmNsZSgx MHB4LCAxMHB4LCAxMHB4KSIKK1BBU1MgdGVzdElubGluZVN0eWxlKCItd2Via2l0LXNoYXBlLWlu c2lkZSIsICJjaXJjbGUoMTBweCwgMTBweCwgMTBweCkiKSBpcyAiY2lyY2xlKDEwcHgsIDEwcHgs IDEwcHgpIgorUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAi Y2lyY2xlKDEwcHgsIDEwcHgsIDEwcHgpIikgaXMgImNpcmNsZSgxMHB4LCAxMHB4LCAxMHB4KSIK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvY3NzLWV4Y2x1c2lvbnMtZW5hYmxl ZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL2Nzcy1leGNsdXNpb25zLWVuYWJs ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5hZTcyNDkyMWUwYzU2ZjE2NmZmZDIxNjllNzU0NWMzZGQxYTY2 MWVhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL2Nzcy1l eGNsdXNpb25zLWVuYWJsZWQuaHRtbApAQCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCdUZXN0IHRoYXQgcGFyc2lu ZyBvZiBjc3MgZXhjbHVzaW9ucyByZWxhdGVkIHByb3BlcnRpZXMgaXMgZW5hYmxlZCBieSBkZWZh dWx0LicpOworCitmdW5jdGlvbiB0ZXN0SW5saW5lU3R5bGUocHJvcGVydHksIHZhbHVlKSB7Cisg ICAgdmFyIGRpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgIGRpdi5zZXRB dHRyaWJ1dGUoInN0eWxlIiwgcHJvcGVydHkgKyAiOiAiICsgdmFsdWUpOworICAgIHJldHVybiBk aXYuc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShwcm9wZXJ0eSk7Cit9CisKK2Z1bmN0aW9uIHRlc3RD b21wdXRlZFN0eWxlKHByb3BlcnR5LCB2YWx1ZSkgeworICAgIHZhciBkaXYgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdik7 CisgICAgZGl2LnN0eWxlLnNldFByb3BlcnR5KHByb3BlcnR5LCB2YWx1ZSk7CisgICAgdmFyIGNv bXB1dGVkVmFsdWUgPSBnZXRDb21wdXRlZFN0eWxlKGRpdikuZ2V0UHJvcGVydHlWYWx1ZShwcm9w ZXJ0eSk7CisgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkaXYpOworICAgIHJldHVybiBj b21wdXRlZFZhbHVlOworfQorCitmdW5jdGlvbiB0ZXN0U3R5bGUocHJvcGVydHksIHZhbHVlLCBl eHBlY3RlZCkgeworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdElubGluZVN0eWxlKCIn ICsgcHJvcGVydHkgKyAnIiwgIicgKyB2YWx1ZSArICciKScsIGV4cGVjdGVkKTsKKyAgICBzaG91 bGRCZUVxdWFsVG9TdHJpbmcoJ3Rlc3RDb21wdXRlZFN0eWxlKCInICsgcHJvcGVydHkgKyAnIiwg IicgKyB2YWx1ZSArICciKScsIGV4cGVjdGVkKTsKK30KKwordGVzdFN0eWxlKCItd2Via2l0LXdy YXAtZmxvdyIsICJib3RoIiwgImJvdGgiKTsKKwordGVzdFN0eWxlKCItd2Via2l0LXNoYXBlLW1h cmdpbiIsICIxMHB4IiwgIjEwcHgiKTsKK3Rlc3RTdHlsZSgiLXdlYmtpdC1zaGFwZS1wYWRkaW5n IiwgIjEwcHgiLCAiMTBweCIpOworCit0ZXN0U3R5bGUoIi13ZWJraXQtd3JhcC10aHJvdWdoIiwg Im5vbmUiLCAibm9uZSIpOworCit0ZXN0U3R5bGUoIi13ZWJraXQtc2hhcGUtb3V0c2lkZSIsICJj aXJjbGUoMTBweCwgMTBweCwgMTBweCkiLCAiY2lyY2xlKDEwcHgsIDEwcHgsIDEwcHgpIik7Cit0 ZXN0U3R5bGUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImNpcmNsZSgxMHB4LCAxMHB4LCAxMHB4 KSIsICJjaXJjbGUoMTBweCwgMTBweCwgMTBweCkiKTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==