115906 2013-05-10 06:55:48 -0700 Disallow a window to focus itself via javascript URLs or using target _self 2017-07-27 04:56:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen ap commit-queue ggaren japhet kling mjs rniwa oldest_to_newest 887329 0 jochen 2013-05-10 06:55:48 -0700 Disallow a window to focus itself via javascript URLs or using target _self 887331 1 201342 jochen 2013-05-10 06:57:09 -0700 Created attachment 201342 Patch 887610 2 ggaren 2013-05-10 14:08:51 -0700 What's the rationale for this change? Is this some sort of popup blocking, or something else? 887770 3 jochen 2013-05-11 03:24:53 -0700 In http://trac.webkit.org/changeset/118916, I added a restriction to window.focus() that disallows a window to focus itself. Apparently, some popunder scripts are using this workaround to get around the window.focus() restriction. 887789 4 201342 ggaren 2013-05-11 10:22:06 -0700 Comment on attachment 201342 Patch r=me 887817 5 201342 commit-queue 2013-05-11 12:08:21 -0700 Comment on attachment 201342 Patch Clearing flags on attachment: 201342 Committed r149936: <http://trac.webkit.org/changeset/149936> 887818 6 commit-queue 2013-05-11 12:08:23 -0700 All reviewed patches have been landed. Closing bug. 1332637 7 annevk 2017-07-27 04:56:42 -0700 *** Bug 115706 has been marked as a duplicate of this bug. *** 201342 2013-05-10 06:57:09 -0700 2013-05-11 12:08:20 -0700 Patch bug-115906-20130510155610.patch text/plain 5501 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjlkMmQzMmQ0MDI4NzMx NzRhNzk1Mjc1M2UzZGNjMWE5ZWM2ODFmZC4uMjQ5NTFkYjA0MjBkNmNlZDRjZWRmMjgzMTQ3ODU1 NTk1ODc5ZGRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTEwICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FsbG93IGEg d2luZG93IHRvIGZvY3VzIGl0c2VsZiB2aWEgamF2YXNjcmlwdCBVUkxzIG9yIHVzaW5nIHRhcmdl dCBfc2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE1OTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVzdDogZmFzdC9kb20vV2luZG93L3dpbmRvdy1mb2N1cy1zZWxmLmh0bWwKKworICAgICAgICAq IGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVXaW5kb3cp OgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdp bmRvdzo6Zm9jdXMpOgorCiAyMDEzLTA1LTEwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKaW5kZXggYTI3OWRlYzhhYzQ1ZDFkZDc1MTIxMDQ2YzA5YjY4MTBiZWQzYWQ1Ny4u NWE1Nzg0MGUxNzgxNDAyZGJjZjhlYTNmZTE0OGM2ZTc2NGY4MDc5MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0zMzM1LDggKzMzMzUsMTAgQEAgUGFzc1JlZlB0cjxG cmFtZT4gY3JlYXRlV2luZG93KEZyYW1lKiBvcGVuZXJGcmFtZSwgRnJhbWUqIGxvb2t1cEZyYW1l LCBjb25zdCBGcmEKIAogICAgIGlmICghcmVxdWVzdC5mcmFtZU5hbWUoKS5pc0VtcHR5KCkgJiYg cmVxdWVzdC5mcmFtZU5hbWUoKSAhPSAiX2JsYW5rIikgewogICAgICAgICBpZiAoRnJhbWUqIGZy YW1lID0gbG9va3VwRnJhbWUtPmxvYWRlcigpLT5maW5kRnJhbWVGb3JOYXZpZ2F0aW9uKHJlcXVl c3QuZnJhbWVOYW1lKCksIG9wZW5lckZyYW1lLT5kb2N1bWVudCgpKSkgewotICAgICAgICAgICAg aWYgKFBhZ2UqIHBhZ2UgPSBmcmFtZS0+cGFnZSgpKQotICAgICAgICAgICAgICAgIHBhZ2UtPmNo cm9tZSgpLT5mb2N1cygpOworICAgICAgICAgICAgaWYgKHJlcXVlc3QuZnJhbWVOYW1lKCkgIT0g Il9zZWxmIikgeworICAgICAgICAgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZnJhbWUtPnBhZ2Uo KSkKKyAgICAgICAgICAgICAgICAgICAgcGFnZS0+Y2hyb21lKCktPmZvY3VzKCk7CisgICAgICAg ICAgICB9CiAgICAgICAgICAgICBjcmVhdGVkID0gZmFsc2U7CiAgICAgICAgICAgICByZXR1cm4g ZnJhbWU7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCBiOGFmMDJm NmUzMTE1NWIwZWNhYjg2NGI1NDEyZjJjNzk2ZWMxNzVlLi5kYTM0YWI0MTk3MjRkNTEzOWZlNmY3 YmYxNjAzODcwMDczZjE3YjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdp bmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC05NDEs NyArOTQxLDcgQEAgdm9pZCBET01XaW5kb3c6OmZvY3VzKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQpCiAgICAgaWYgKGNvbnRleHQpIHsKICAgICAgICAgQVNTRVJUKGlzTWFpblRocmVh ZCgpKTsKICAgICAgICAgRG9jdW1lbnQqIGFjdGl2ZURvY3VtZW50ID0gdG9Eb2N1bWVudChjb250 ZXh0KTsKLSAgICAgICAgaWYgKG9wZW5lcigpICYmIGFjdGl2ZURvY3VtZW50LT5kb21XaW5kb3co KSA9PSBvcGVuZXIoKSkKKyAgICAgICAgaWYgKG9wZW5lcigpICYmIG9wZW5lcigpICE9IHRoaXMg JiYgYWN0aXZlRG9jdW1lbnQtPmRvbVdpbmRvdygpID09IG9wZW5lcigpKQogICAgICAgICAgICAg YWxsb3dGb2N1cyA9IHRydWU7CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTRjMTI0ODM0OTc0Mjg1YjJkMWJj NGE1ZWEzZmNhNDIzYWJjZWQ0Ny4uZGE1ODhkZDNiYTI2YWY1NzdlYzE1MTFmYjI3MjRmYWFkMjdi YmJlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTEwICBKb2NoZW4gRWlzaW5nZXIg IDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FsbG93IGEgd2luZG93IHRvIGZv Y3VzIGl0c2VsZiB2aWEgamF2YXNjcmlwdCBVUkxzIG9yIHVzaW5nIHRhcmdldCBfc2VsZgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1OTA2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9X aW5kb3cvd2luZG93LWZvY3VzLXNlbGYtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2RvbS9XaW5kb3cvd2luZG93LWZvY3VzLXNlbGYuaHRtbDogQWRkZWQuCisgICAgICAgICog cGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnM6IHRlc3QgdXNlcyB1bmltcGxlbWVudGVkIHNl dFdpbmRvd0lzS2V5LgorCiAyMDEzLTA1LTEwICBab2x0YW4gQXJ2YWkgIDx6YXJ2YWlAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LWZvY3VzLXNlbGYtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1mb2N1cy1zZWxmLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iOWE2MDRhYzgzY2JmZGRmODg5NjQ1NzJiZDc1NDQ3ZjQw YmE1MzkyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dp bmRvdy1mb2N1cy1zZWxmLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1RoaXMgdGVzdHMg dGhhdCBhIHdpbmRvdyBjYW5ub3QgZm9jdXMgaXRzZWxmIGJ5IHVzaW5nIGphdmFzY3JpcHQ6IHVy bHMuCitXaW5kb3cgd2FzIGJsdXJyZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L1dpbmRvdy93aW5kb3ctZm9jdXMtc2VsZi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2lu ZG93L3dpbmRvdy1mb2N1cy1zZWxmLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTFmYjZkYmUzZTIzMGIyMDNm OWNiMDc3ZWM2ZmI5MGE1YjExODNkMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZG9tL1dpbmRvdy93aW5kb3ctZm9jdXMtc2VsZi5odG1sCkBAIC0wLDAgKzEsNDEgQEAKKzwh RE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0 KCkgeworICAgIHdpbmRvdy5vbmZvY3VzID0gd2luZG93Rm9jdXNlZDsKKyAgICB3aW5kb3cub25i bHVyID0gd2luZG93Qmx1cnJlZDsKKworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAg ICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1w QXNUZXh0KCk7CisgICAgICAgIHRlc3RSdW5uZXIuc2V0V2luZG93SXNLZXkoZmFsc2UpOworICAg ICAgICB3aW5kb3cub3BlbignamF2YXNjcmlwdDp3aW5kb3cuZm9jdXMoKScsICdfc2VsZicsICcn KTsKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsgdGVzdFJ1bm5lci5ub3RpZnlEb25l KCk7IH0sIDApOworICAgIH0KK30KKworZnVuY3Rpb24gbG9nKG1lc3NhZ2UpIHsKKyAgICB2YXIg Y29uc29sZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CisgICAgdmFyIGxp ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGkiKTsKKyAgICB2YXIgdGV4dCA9IGRvY3VtZW50 LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpOworCisgICAgY29uc29sZS5hcHBlbmRDaGlsZChsaSk7 CisgICAgbGkuYXBwZW5kQ2hpbGQodGV4dCk7Cit9CisKK2Z1bmN0aW9uIHdpbmRvd0ZvY3VzZWQo KSB7CisgICAgbG9nKCJGQUlMOiBXaW5kb3cgd2FzIGZvY3VzZWQiKTsKK30KKworZnVuY3Rpb24g d2luZG93Qmx1cnJlZCgpIHsKKyAgICBsb2coIldpbmRvdyB3YXMgYmx1cnJlZCIpOworfQorPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICBUaGlzIHRlc3RzIHRoYXQgYSB3aW5kb3cgY2Fu bm90IGZvY3VzIGl0c2VsZiBieSB1c2luZyBqYXZhc2NyaXB0OiB1cmxzLgorICAgIDx1bCBpZD0i Y29uc29sZSI+PC91bD4KKyAgICA8c2NyaXB0PnJ1blRlc3QoKTs8L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg MjVhMWU3OTYxYjAzYjM1ZTk2Yjk4NTc3MzBiYjhkODQwNjhkN2M4My4uZmVhOGYxZGZkZTc3YjQ4 YmNkYjUwOTg3OTk2ZDE2MmUxNjliNDAzMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTI1Miw2ICsyNTIsNyBAQCBodHRwL3Rlc3RzL211bHRpcGFydC9t dWx0aXBhcnQtd2FpdC1iZWZvcmUtYm91bmRhcnkuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3MzYgcmRhcjovL3Byb2JsZW0vMTEwODgyNjgKIGZhc3Qv ZXZlbnRzL2JsdXItZm9jdXMtd2luZG93LXNob3VsZC1ibHVyLWZvY3VzLWVsZW1lbnQuaHRtbAog ZmFzdC9zZWxlY3RvcnMvc2VsZWN0aW9uLXdpbmRvdy1pbmFjdGl2ZS5odG1sCitmYXN0L2RvbS9X aW5kb3cvd2luZG93LWZvY3VzLXNlbGYuaHRtbAogCiAjIFdlYktpdDIgbmVlZHMgYW4gaW1wbGVt ZW50YXRpb24gb2YgSW5zcGVjdG9yQ2xpZW50OjpvdmVycmlkZURldmljZU1ldHJpY3MoKSBhbmQK ICMgYXV0b1pvb21QYWdlVG9GaXRXaWR0aCgpLgo=