115883 2013-05-09 17:24:27 -0700 Don't trust character widths for internal OS X fonts in form controls 2013-10-23 17:04:34 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino enrica simon.fraser oldest_to_newest 887172 0 dino 2013-05-09 17:24:27 -0700 There are a few fonts we mark as having invalid character widths when laying out form controls. Some internal fonts on OS X are not listed, but these all start with a ".", so they should be easy to test for. 887173 1 dino 2013-05-09 17:24:39 -0700 <rdar://problem/13817757> 887174 2 201306 dino 2013-05-09 17:28:05 -0700 Created attachment 201306 Patch 887187 3 201306 darin 2013-05-09 18:26:11 -0700 Comment on attachment 201306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201306&action=review > Source/WebCore/rendering/RenderTextControl.cpp:234 > + if (family.startsWith('.')) > + return false; Needs a “why” comment. Also, I’d put this before the map building code. It seems strange to have this in between the map building and the use of the map. 887383 4 dino 2013-05-10 09:18:06 -0700 Committed r149880: <http://trac.webkit.org/changeset/149880> 942915 5 simon.fraser 2013-10-23 17:04:34 -0700 This caused bug 123235. 201306 2013-05-09 17:28:05 -0700 2013-05-09 18:26:11 -0700 Patch bug-115883-20130509172709.patch text/plain 1724 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM4MmZhMmEwOTFlNzI5 NjczZDA5YjgyMTUzMmNmYmM4OTJlNDFiOC4uMDhiNWJiMmIwNmM4N2I1YWE0ZDU1YjhiNDdkYWVi MTI3NDI4NDhlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTA5ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCB0cnVzdCBjaGFyYWN0 ZXIgd2lkdGhzIGZvciBpbnRlcm5hbCBPUyBYIGZvbnRzIGluIGZvcm0gY29udHJvbHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTg4MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGlnbm9yZSB0aGUg Y2hhcmFjdGVyIHdpZHRoIGZvciBhIGJ1bmNoIG9mIGZvbnRzIHdoZW4gcHJlZGljdGluZworICAg ICAgICB0aGUgd2lkdGggb2YgYSBmb3JtIGNvbnRyb2wuIFNvbWUgb2YgdGhlIGludGVybmFsIGZv bnRzIGluIE9TIFggYXJlCisgICAgICAgIG5vdCBpbiB0aGUgaWdub3JlZCBsaXN0LiBSYXRoZXIg dGhhbiBhZGQgdGhlbSwgc2ltcGx5IHRlc3QgZm9yIAorICAgICAgICBmb250cyB3aG9zZSBmYW1p bHkgYmVnaW5zIHdpdGggYSBwZXJpb2QgY2hhcmFjdGVyICIuIi4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0 Q29udHJvbDo6aGFzVmFsaWRBdmdDaGFyV2lkdGgpOiBSZXR1cm4gZmFsc2UgZm9yCisgICAgICAg ICAgICBhbnkgZmFtaWx5IHRoYXQgc3RhcnRzIHdpdGggIi4iCisKIDIwMTMtMDUtMDggIEVyaWMg Q2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUHJldmVudCBjcmFz aCB3aGVuIHRyYWNrIGlzIGRlbGV0ZWQgZHVyaW5nIHZpZGVvIGVsZW1lbnQgZGVsZXRpb24uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAppbmRleCBk Y2Y1NDdhODRjY2Y1NzJiM2NkZmZlMTgyNjQ4ZjMwMjdhNWM0MWJhLi41NjYwZGZhYTZkYmI1MmEx OGVhOWUzOTFjZGU2ZTdhZDJlYzBkNDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0Q29udHJvbC5jcHAKQEAgLTIzMCw2ICsyMzAsOSBAQCBib29sIFJlbmRlclRl eHRDb250cm9sOjpoYXNWYWxpZEF2Z0NoYXJXaWR0aChBdG9taWNTdHJpbmcgZmFtaWx5KQogICAg ICAgICAgICAgZm9udEZhbWlsaWVzV2l0aEludmFsaWRDaGFyV2lkdGhNYXAtPmFkZChBdG9taWNT dHJpbmcoZm9udEZhbWlsaWVzV2l0aEludmFsaWRDaGFyV2lkdGhbaV0pKTsKICAgICB9CiAKKyAg ICBpZiAoZmFtaWx5LnN0YXJ0c1dpdGgoJy4nKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAg ICAgcmV0dXJuICFmb250RmFtaWxpZXNXaXRoSW52YWxpZENoYXJXaWR0aE1hcC0+Y29udGFpbnMo ZmFtaWx5KTsKIH0KIAo=