115862 2013-05-09 09:08:34 -0700 [Mac] CFError leak under Objective-C garbage collection 2013-05-09 18:18:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue ddkilzer oldest_to_newest 886904 0 darin 2013-05-09 09:08:34 -0700 [Mac] ResourceError leak under Objective-C garbage collection 886907 1 201244 darin 2013-05-09 09:11:20 -0700 Created attachment 201244 Patch 886993 2 201244 commit-queue 2013-05-09 11:42:08 -0700 Comment on attachment 201244 Patch Clearing flags on attachment: 201244 Committed r149828: <http://trac.webkit.org/changeset/149828> 886994 3 commit-queue 2013-05-09 11:42:09 -0700 All reviewed patches have been landed. Closing bug. 887065 4 ddkilzer 2013-05-09 14:00:08 -0700 USE(CFNETWORK) is only defined for PLATFORM(IOS) and PLATFORM(WIN), neither of which ever supported Objective-C garbage collection. I'm certain ResourceErrorMac.mm isn't compiled on the Apple Windows port, either. So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell. Am I missing something? 887183 5 darin 2013-05-09 18:17:01 -0700 (In reply to comment #4) > So while this code is semantically more correct, it also doesn't actually fix an actual leak as far as I can tell. That’s right. It fixes a leak we’d have if we turned USE(CFNETWORK) on for Mac. 887184 6 darin 2013-05-09 18:18:27 -0700 To give you some context: Anders spotted some other leaks due to code like this, and I believe he fixed those others yesterday. 201244 2013-05-09 09:11:20 -0700 2013-05-09 11:42:08 -0700 Patch bug-115862-20130509091023.patch text/plain 1863 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5ODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZjYmFlZGViNjY1MTEw NmFmZGUzZDQzZTg0ZjAyMDFkOTYyMmQ0OS4uMTZlMTk3YWRjZGQyOTk4NjhiYTk1ZWVlZmMyZjQ2 OTIwYjQzNzAxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTA5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBDRkVycm9yIGxlYWsg dW5kZXIgT2JqZWN0aXZlLUMgZ2FyYmFnZSBjb2xsZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU4NjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291 cmNlRXJyb3JNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUVycm9yOjpuc0Vycm9y KTogVXNlIGFkb3B0Q0YgaW5zdGVhZCBvZiBhZG9wdE5TIHNpbmNlCisgICAgICAgIHRoZSBDRkVy cm9yIG5lZWRzIGEgQ0ZSZWxlYXNlLCBub3QgYW4gLVtOU09iamVjdCByZWxlYXNlXS4KKwogMjAx My0wNS0wOSAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogUmVtb3ZlIE1lbW9yeSBEaXN0cmlidXRpb24gYW5kIE1lbW9yeSBTbmFw c2hvdHMgUGFuZWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L21hYy9SZXNvdXJjZUVycm9yTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9tYWMvUmVzb3VyY2VFcnJvck1hYy5tbQppbmRleCBjZmJhZWQ1Mzg1ZWQ5ZDNlOThlYzFkNDE4 OWIzNWNiNzlhMTA3MTZmLi44MzMxNWIwMTdjMDM0OGQyZDlkZWNhODRhN2FkYjE0YjI1MTM2ZDU1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJj ZUVycm9yTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jl c291cmNlRXJyb3JNYWMubW0KQEAgLTc2LDggKzc2LDggQEAgTlNFcnJvciAqUmVzb3VyY2VFcnJv cjo6bnNFcnJvcigpIGNvbnN0CiAKICAgICBpZiAobV9wbGF0Zm9ybUVycm9yKSB7CiAgICAgICAg IENGRXJyb3JSZWYgZXJyb3IgPSBtX3BsYXRmb3JtRXJyb3IuZ2V0KCk7Ci0gICAgICAgIFJldGFp blB0cjxOU0RpY3Rpb25hcnk+IHVzZXJJbmZvID0gYWRvcHROUygoTlNEaWN0aW9uYXJ5ICopIENG RXJyb3JDb3B5VXNlckluZm8oZXJyb3IpKTsKLSAgICAgICAgbV9wbGF0Zm9ybU5TRXJyb3IgPSBh ZG9wdE5TKFtbTlNFcnJvciBhbGxvY10gaW5pdFdpdGhEb21haW46KE5TU3RyaW5nICopQ0ZFcnJv ckdldERvbWFpbihlcnJvcikgY29kZTpDRkVycm9yR2V0Q29kZShlcnJvcikgdXNlckluZm86dXNl ckluZm8uZ2V0KCldKTsKKyAgICAgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gdXNlcklu Zm8gPSBhZG9wdENGKENGRXJyb3JDb3B5VXNlckluZm8oZXJyb3IpKTsKKyAgICAgICAgbV9wbGF0 Zm9ybU5TRXJyb3IgPSBhZG9wdE5TKFtbTlNFcnJvciBhbGxvY10gaW5pdFdpdGhEb21haW46KE5T U3RyaW5nICopQ0ZFcnJvckdldERvbWFpbihlcnJvcikgY29kZTpDRkVycm9yR2V0Q29kZShlcnJv cikgdXNlckluZm86KE5TRGljdGlvbmFyeSAqKXVzZXJJbmZvLmdldCgpXSk7CiAgICAgICAgIHJl dHVybiBtX3BsYXRmb3JtTlNFcnJvci5nZXQoKTsKICAgICB9CiAK