115854 2013-05-09 03:38:39 -0700 [GTK] Module Cairo fails to build under jhbuild 2013-05-10 10:03:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 brian.holt webkit-unassigned commit-queue gtk-ews gustavo mrobinson xan.lopez zan oldest_to_newest 886723 0 brian.holt 2013-05-09 03:38:39 -0700 The Cairo library depends on glib and fails to build because the dependent library (glib) is not yet built. It may build on some systems that have a newer version of glib by defaulting to the system installation. 886724 1 brian.holt 2013-05-09 03:45:30 -0700 This is the error before the patch: CC libcairo_gobject_la-cairo-gobject-structs.lo In file included from /usr/include/glib-2.0/glib/galloca.h:34:0, from /usr/include/glib-2.0/glib.h:32, from /usr/include/glib-2.0/gobject/gbinding.h:30, from /usr/include/glib-2.0/glib-object.h:25, from cairo-gobject.h:44, from cairo-gobject-structs.c:41: /usr/include/glib-2.0/glib/gtypes.h:34:24: fatal error: glibconfig.h: No such file or directory 886725 2 201178 brian.holt 2013-05-09 03:49:45 -0700 Created attachment 201178 Patch 886729 3 201178 gtk-ews 2013-05-09 04:44:19 -0700 Comment on attachment 201178 Patch Attachment 201178 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/398134 886785 4 201178 mrobinson 2013-05-09 07:48:53 -0700 Comment on attachment 201178 Patch Looks good, but please check out the EWS failure. 887256 5 brian.holt 2013-05-10 01:24:26 -0700 The EWS failure was due to derived sources not building, but since fixed by zdobersek: GEN: DerivedSources/WebCore/InternalSettingsGenerated.cpp make: *** No rule to make target 'DerivedSources/WebCore/JSMallocStatistics.h' needed by 'DerivedSources/WebCore/JSMallocStatistics.cpp'. Stop. Author: zandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Thu May 9 14:26:28 2013 +0000 Unreviewed GTK build fix after r149796. * GNUmakefile.am: Add a phony target for the window constructors file and include it among the dependencies for the non-generated code. 887336 6 zan 2013-05-10 07:16:22 -0700 Affirmative, plus the gtk-wk2 EWS reported no issues. I can cq+ the patch once the current build failure gets fixed. 887398 7 201178 commit-queue 2013-05-10 10:03:51 -0700 Comment on attachment 201178 Patch Clearing flags on attachment: 201178 Committed r149883: <http://trac.webkit.org/changeset/149883> 887399 8 commit-queue 2013-05-10 10:03:54 -0700 All reviewed patches have been landed. Closing bug. 201178 2013-05-09 03:49:45 -0700 2013-05-10 10:03:50 -0700 Patch bug-115854-20130509115001.patch text/plain 1149 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5Nzk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjljNGQzMzE3ODYzYWYwYWFkZWJlNDJjNTU0MGUxZTQ4 NzQ2N2ZmMi4uYWM4NWRmY2I4NjQ2MTk3NjAwNzVlYWI1ODQwOWY3ZjQ5YTY0MGUyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTA1LTA5ICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSBNb2R1bGUgQ2Fpcm8gZmFpbHMgdG8gYnVpbGQgdW5kZXIgamhidWlsZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODU0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBjYWly byBkZXBlbmQgb24gZ2xpYiBpbiBqaGJ1aWxkLm1vZHVsZXMuCisKKyAgICAgICAgKiBndGsvamhi dWlsZC5tb2R1bGVzOgorCiAyMDEzLTA1LTA5ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpA c2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgW05vSW50ZXJmYWNl T2JqZWN0XSBXZWIgSURMIGV4dGVuZGVkIGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr L2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNGNkODMz MTAxMTlmNGI0Mzk3YjgxZGJjZmM3YTk2NTNlMmM5N2U5ZC4uYmI2MzRjN2JkYTg3ZDA2ZTU4YTMx ZWFiNTc0Y2MwNzAzNWZjODQyYiAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxl cworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC02OCw2ICs2OCw3IEBACiAgICAg PGRlcGVuZGVuY2llcz4KICAgICAgIDxkZXAgcGFja2FnZT0iZm9udGNvbmZpZyIvPgogICAgICAg PGRlcCBwYWNrYWdlPSJwaXhtYW4iLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgogICAg IDwvZGVwZW5kZW5jaWVzPgogICAgIDxicmFuY2ggbW9kdWxlPSJyZWxlYXNlcy9jYWlyby0xLjEy LjgudGFyLnh6IiB2ZXJzaW9uPSIxLjEyLjgiCiAgICAgICAgICAgICByZXBvPSJjYWlyb2dyYXBo aWNzLm9yZyIK