115831 2013-05-08 16:52:28 -0700 Remove Editor::setSelectionOffsets 2013-05-08 18:10:58 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap benjamin darin enrica kling koivisto oldest_to_newest 886520 0 rniwa 2013-05-08 16:52:28 -0700 Editor::setSelectionOffsets was added in http://trac.webkit.org/changeset/120985 for Chromium Android port. We can delete this function now that Chromium port is gone. 886521 1 201115 rniwa 2013-05-08 16:53:31 -0700 Created attachment 201115 Cleanup 886526 2 201115 kling 2013-05-08 17:06:41 -0700 Comment on attachment 201115 Cleanup rs=me 886556 3 rniwa 2013-05-08 18:10:58 -0700 Committed r149785: <http://trac.webkit.org/changeset/149785> 201115 2013-05-08 16:53:31 -0700 2013-05-08 17:06:40 -0700 Cleanup bug-115831-20130508165235.patch text/plain 2129 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTc4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTA4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBFZGl0b3I6OnNldFNl bGVjdGlvbk9mZnNldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNTgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZWQgdGhlIGZ1bmN0aW9uIGFkZGVkIGluIHIxMjA5ODUgZm9yIENocm9taXVt IEFuZHJvaWQgcG9ydC4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAg KiBlZGl0aW5nL0VkaXRvci5oOgorCiAyMDEzLTA1LTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFBvdGVudGlhbCB1c2UtYWZ0ZXItZnJlZSBvZiBGcmFtZQpJ bmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24gMTQ5NzYzKQorKysgU291 cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTI0LDE5 ICsyNTI0LDYgQEAgYm9vbCBFZGl0b3I6OmdldENvbXBvc2l0aW9uU2VsZWN0aW9uKHVucwogICAg IHJldHVybiB0cnVlOwogfQogCi1ib29sIEVkaXRvcjo6c2V0U2VsZWN0aW9uT2Zmc2V0cyhpbnQg c2VsZWN0aW9uU3RhcnQsIGludCBzZWxlY3Rpb25FbmQpCi17Ci0gICAgRWxlbWVudCogcm9vdEVk aXRhYmxlRWxlbWVudCA9IG1fZnJhbWUtPnNlbGVjdGlvbigpLT5yb290RWRpdGFibGVFbGVtZW50 KCk7Ci0gICAgaWYgKCFyb290RWRpdGFibGVFbGVtZW50KQotICAgICAgICByZXR1cm4gZmFsc2U7 Ci0KLSAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUZyb21Mb2Nh dGlvbkFuZExlbmd0aChyb290RWRpdGFibGVFbGVtZW50LCBzZWxlY3Rpb25TdGFydCwgc2VsZWN0 aW9uRW5kIC0gc2VsZWN0aW9uU3RhcnQpOwotICAgIGlmICghcmFuZ2UpCi0gICAgICAgIHJldHVy biBmYWxzZTsKLQotICAgIHJldHVybiBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0U2VsZWN0ZWRS YW5nZShyYW5nZS5nZXQoKSwgVlBfREVGQVVMVF9BRkZJTklUWSwgZmFsc2UpOwotfQotCiB2b2lk IEVkaXRvcjo6dHJhbnNwb3NlKCkKIHsKICAgICBpZiAoIWNhbkVkaXQoKSkKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZWRpdGluZy9FZGl0b3IuaAkocmV2aXNpb24gMTQ5NzYzKQorKysgU291cmNlL1dlYkNvcmUvZWRp dGluZy9FZGl0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMzEzLDcgKzMxMyw2IEBAIHB1YmxpYzoK ICAgICBib29sIGNhbmNlbENvbXBvc2l0aW9uSWZTZWxlY3Rpb25Jc0ludmFsaWQoKTsKICAgICBQ YXNzUmVmUHRyPFJhbmdlPiBjb21wb3NpdGlvblJhbmdlKCkgY29uc3Q7CiAgICAgYm9vbCBnZXRD b21wb3NpdGlvblNlbGVjdGlvbih1bnNpZ25lZCYgc2VsZWN0aW9uU3RhcnQsIHVuc2lnbmVkJiBz ZWxlY3Rpb25FbmQpIGNvbnN0OwotICAgIGJvb2wgc2V0U2VsZWN0aW9uT2Zmc2V0cyhpbnQgc2Vs ZWN0aW9uU3RhcnQsIGludCBzZWxlY3Rpb25FbmQpOwogCiAgICAgLy8gZ2V0dGluZyBpbnRlcm5h dGlvbmFsIHRleHQgaW5wdXQgY29tcG9zaXRpb24gc3RhdGUgKGZvciB1c2UgYnkgSW5saW5lVGV4 dEJveCkKICAgICBUZXh0KiBjb21wb3NpdGlvbk5vZGUoKSBjb25zdCB7IHJldHVybiBtX2NvbXBv c2l0aW9uTm9kZS5nZXQoKTsgfQo=