115823 2013-05-08 13:54:23 -0700 Assert at compile time that we don't pass Objective-C object pointers to adoptCF 2013-05-08 15:01:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue simon.fraser oldest_to_newest 886460 0 andersca 2013-05-08 13:54:23 -0700 Assert at compile time that we don't pass Objective-C object pointers to adoptCF 886462 1 201104 andersca 2013-05-08 13:57:20 -0700 Created attachment 201104 Patch 886464 2 201104 ggaren 2013-05-08 13:58:41 -0700 Comment on attachment 201104 Patch r=me 886467 3 benjamin 2013-05-08 14:09:17 -0700 Great idea! 886486 4 andersca 2013-05-08 15:01:45 -0700 Committed r149768: <http://trac.webkit.org/changeset/149768> 201104 2013-05-08 13:57:20 -0700 2013-05-08 13:58:41 -0700 Patch bug-115823-20130508135625.patch text/plain 6387 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM1ZjQwYjc4OTFkMThlMmU4Yjc2MDYz NmU1ODZhOGU4MTE3Mzc2NzEuLmM0OWU4YjM1OGQxNDc4MWM2OGEwNjQ4OGU1NjFmYTdjY2ZhMDQ5 NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTMtMDUtMDggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBBc3NlcnQgYXQgY29tcGlsZSB0aW1lIHRoYXQg d2UgZG9uJ3QgcGFzcyBPYmplY3RpdmUtQyBvYmplY3QgcG9pbnRlcnMgdG8gYWRvcHRDRgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODIzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc3RhdGljX2Fzc2Vy dCBpbiBhZG9wdENGIHRoYXQgdGhlIG9iamVjdCBwYXNzZWQgaW4gaXMgbm90IGFuIE9iamVjdGl2 ZS1DIG9iamVjdC4KKyAgICAgICAgKiB3dGYvUmV0YWluUHRyLmg6CisKKzIwMTMtMDUtMDggIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgUmV0 YWluUHRyOjphZG9wdE5TIGFuZCBSZXRhaW5QdHI6OmFkb3B0Q0YKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTgxNwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgy ZDA3ZDExMjhmOGQzODgwZGY0MWJlZTc2YmJiYzFiNTA1ZTE4ZS4uNjI3NmZlYmNlNDgyZjU2ZWMz MjMyYTU0ZTM0YTc2NTY2YTllMGRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEz LTA1LTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg QXNzZXJ0IGF0IGNvbXBpbGUgdGltZSB0aGF0IHdlIGRvbid0IHBhc3MgT2JqZWN0aXZlLUMgb2Jq ZWN0IHBvaW50ZXJzIHRvIGFkb3B0Q0YKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNTgyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVy Lm1tOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OlRpbGVDb250cm9sbGVyKToK KyAgICAgICAgVXNlIGFkb3B0TlMgZm9yIENBTGF5ZXIuCisKIDIwMTMtMDUtMDggIEpvc8OpIERh cGVuYSBQYXogIDxqZGFwZW5hQGlnYWxpYS5jb20+IGFuZCBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBQbHVtYiB0aGUgQXV0b21ha2UgYnVpbGQg c3lzdGVtIGZvciB0aGUgQmF0dGVyeSBTdGF0dXMgQVBJIGZlYXR1cmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBk MjEzNzhlOWQ0ZDA0YjNjMzI3NDljOWIwM2MxMjVjYTM5YmQyMGFmLi4zYWVkMjgyMWIwMzdjOGI4 MzU1MmJjZjgxNmY1M2ExZmJiMzEwMTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTMtMDUtMDggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAg ICBBc3NlcnQgYXQgY29tcGlsZSB0aW1lIHRoYXQgd2UgZG9uJ3QgcGFzcyBPYmplY3RpdmUtQyBv YmplY3QgcG9pbnRlcnMgdG8gYWRvcHRDRgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IGFkb3B0TlMvYWRvcHRDRiBtaXNtYXRjaGVzLiBGb3IgdGhl IGFkb3B0KGxlYWtSZWYoKSkgY2FzZSB3ZSdkIGlkZWFsbHkgd2FudCBhIHN0YXRpY19wb2ludGVy X2Nhc3Qgb3ZlcmxvYWQgZm9yIFJldGFpblB0ciwKKyAgICAgICAgYnV0IHRoaXMgd2lsbCBkbyBm b3Igbm93LgorICAgICAgICAKKyAgICAgICAgKiBTaGFyZWQvbWFjL0FyZ3VtZW50Q29kZXJzTWFj Lm1tOgorICAgICAgICAoQ29yZUlQQzo6ZGVjb2RlKToKKwogMjAxMy0wNS0wOCAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTM3 NzYyMjA+IDEzQTQ1MTogUGx1Z2luUHJvY2VzcygyMjI1KSBkZW55IGZpbGUtcmVhZC1kYXRhIH4v TGlicmFyeS9JbnB1dE1hbmFnZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZXRhaW5Q dHIuaCBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCmluZGV4IDEzNjY5M2U2OTJjYWVlZDBl M2FjMTFiMzAwNzdmOGRlMjI5Y2ZjYzEuLjlhZDFkYmNkNzBmZDQ1MWU1YjcxNmQ3MTc3Y2RlZjYy NTdkN2ZkYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCkBAIC03NCw4ICs3NCwxOSBAQCBuYW1lc3BhY2UgV1RG IHsKICAgICAgICAgUmV0YWluUHRyKCkgOiBtX3B0cigwKSB7fQogICAgICAgICBSZXRhaW5QdHIo UHRyVHlwZSBwdHIpIDogbV9wdHIocHRyKSB7IGlmIChwdHIpIENGUmV0YWluKHB0cik7IH0KIAot ICAgICAgICBSZXRhaW5QdHIoQWRvcHRDRlRhZywgUHRyVHlwZSBwdHIpIDogbV9wdHIocHRyKSB7 IH0KLSAgICAgICAgUmV0YWluUHRyKEFkb3B0TlNUYWcsIFB0clR5cGUgcHRyKSA6IG1fcHRyKHB0 cikgeyBhZG9wdE5TUmVmZXJlbmNlKHB0cik7IH0KKyAgICAgICAgUmV0YWluUHRyKEFkb3B0Q0ZU YWcsIFB0clR5cGUgcHRyKQorICAgICAgICAgICAgOiBtX3B0cihwdHIpCisgICAgICAgIHsKKyNp ZmRlZiBfX09CSkNfXworICAgICAgICAgICAgc3RhdGljX2Fzc2VydCghc3RkOjppc19jb252ZXJ0 aWJsZTxULCBpZD46OnZhbHVlLCAiRG9uJ3QgdXNlIGFkb3B0Q0Ygd2l0aCBPYmplY3RpdmUtQyBw b2ludGVyIHR5cGVzLCB1c2UgYWRvcHROUy4iKTsKKyNlbmRpZgorICAgICAgICB9CisKKyAgICAg ICAgUmV0YWluUHRyKEFkb3B0TlNUYWcsIFB0clR5cGUgcHRyKQorICAgICAgICAgICAgOiBtX3B0 cihwdHIpCisgICAgICAgIHsKKyAgICAgICAgICAgIGFkb3B0TlNSZWZlcmVuY2UocHRyKTsKKyAg ICAgICAgfQogICAgICAgICAKICAgICAgICAgUmV0YWluUHRyKGNvbnN0IFJldGFpblB0ciYgbykg OiBtX3B0cihvLm1fcHRyKSB7IGlmIChQdHJUeXBlIHB0ciA9IG1fcHRyKSBDRlJldGFpbihwdHIp OyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21h Yy9UaWxlQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh L21hYy9UaWxlQ29udHJvbGxlci5tbQppbmRleCBlMjVjYTk2MWE1ZmU4NWMwNTZhM2IzNjM4ZTg4 OTI4MjFlODliNTE4Li4yYmNhMzE2YTU1OWQwMzhhNzA0MWU2MTZkMTNlMzU2YzdlZDNiOWFhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNv bnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFj L1RpbGVDb250cm9sbGVyLm1tCkBAIC05Niw3ICs5Niw3IEBAIFBhc3NPd25QdHI8VGlsZUNvbnRy b2xsZXI+IFRpbGVDb250cm9sbGVyOjpjcmVhdGUoV2ViVGlsZWRCYWNraW5nTGF5ZXIqIHRpbGVD YWNoCiAKIFRpbGVDb250cm9sbGVyOjpUaWxlQ29udHJvbGxlcihXZWJUaWxlZEJhY2tpbmdMYXll ciogdGlsZUNhY2hlTGF5ZXIpCiAgICAgOiBtX3RpbGVDYWNoZUxheWVyKHRpbGVDYWNoZUxheWVy KQotICAgICwgbV90aWxlQ29udGFpbmVyTGF5ZXIoYWRvcHRDRihbW0NBTGF5ZXIgYWxsb2NdIGlu aXRdKSkKKyAgICAsIG1fdGlsZUNvbnRhaW5lckxheWVyKGFkb3B0TlMoW1tDQUxheWVyIGFsbG9j XSBpbml0XSkpCiAgICAgLCBtX3RpbGVTaXplKGRlZmF1bHRUaWxlV2lkdGgsIGRlZmF1bHRUaWxl SGVpZ2h0KQogICAgICwgbV90aWxlUmV2YWxpZGF0aW9uVGltZXIodGhpcywgJlRpbGVDb250cm9s bGVyOjp0aWxlUmV2YWxpZGF0aW9uVGltZXJGaXJlZCkKICAgICAsIG1fY29ob3J0UmVtb3ZhbFRp bWVyKHRoaXMsICZUaWxlQ29udHJvbGxlcjo6Y29ob3J0UmVtb3ZhbFRpbWVyRmlyZWQpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0FyZ3VtZW50Q29kZXJzTWFjLm1tIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9Bcmd1bWVudENvZGVyc01hYy5tbQppbmRleCAwODJl NTkxNmI5MDMzMzRkZTc4MjEyMDM5NzFkNmU2MDQ0ZTA1ZTNlLi44ZjU0MGVhN2NjNTMwNTY5MjZm ZmFjY2I4MmI0NzBiOTJiMDFiMmY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL0FyZ3VtZW50Q29kZXJzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMv QXJndW1lbnRDb2RlcnNNYWMubW0KQEAgLTI3Nyw3ICsyNzcsNyBAQCBib29sIGRlY29kZShBcmd1 bWVudERlY29kZXImIGRlY29kZXIsIFJldGFpblB0cjxOU0F0dHJpYnV0ZWRTdHJpbmc+JiByZXN1 bHQpCiAgICAgICAgIFtyZXN1bHRTdHJpbmcuZ2V0KCkgYWRkQXR0cmlidXRlczphdHRyaWJ1dGVz LmdldCgpIHJhbmdlOk5TTWFrZVJhbmdlKHJhbmdlTG9jYXRpb24sIHJhbmdlTGVuZ3RoKV07CiAg ICAgfQogCi0gICAgcmVzdWx0ID0gYWRvcHRDRihyZXN1bHRTdHJpbmcubGVha1JlZigpKTsKKyAg ICByZXN1bHQgPSBhZG9wdE5TKHJlc3VsdFN0cmluZy5sZWFrUmVmKCkpOwogICAgIHJldHVybiB0 cnVlOwogfQogCkBAIC0zNDQsNyArMzQ0LDcgQEAgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVy JiBkZWNvZGVyLCBSZXRhaW5QdHI8TlNEaWN0aW9uYXJ5PiYgcmVzdWx0KQogICAgICAgICBbZGlj dGlvbmFyeS5nZXQoKSBzZXRPYmplY3Q6dmFsdWUuZ2V0KCkgZm9yS2V5OmtleS5nZXQoKV07CiAg ICAgfQogCi0gICAgcmVzdWx0ID0gYWRvcHRDRihkaWN0aW9uYXJ5LmxlYWtSZWYoKSk7CisgICAg cmVzdWx0ID0gYWRvcHROUyhkaWN0aW9uYXJ5LmxlYWtSZWYoKSk7CiAgICAgcmV0dXJuIHRydWU7 CiB9CiAKQEAgLTM3OSw3ICszNzksNyBAQCBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImIGRl Y29kZXIsIFJldGFpblB0cjxOU051bWJlcj4mIHJlc3VsdCkKICAgICBpZiAoIWRlY29kZShkZWNv ZGVyLCBudW1iZXIpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXN1bHQgPSBhZG9w dENGKChOU051bWJlciAqKW51bWJlci5sZWFrUmVmKCkpOworICAgIHJlc3VsdCA9IGFkb3B0TlMo KE5TTnVtYmVyICopbnVtYmVyLmxlYWtSZWYoKSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAg LTM5NCw3ICszOTQsNyBAQCBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIFJl dGFpblB0cjxOU1N0cmluZz4mIHJlc3VsdCkKICAgICBpZiAoIWRlY29kZShkZWNvZGVyLCBzdHJp bmcpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXN1bHQgPSBhZG9wdENGKChOU1N0 cmluZyAqKXN0cmluZy5sZWFrUmVmKCkpOworICAgIHJlc3VsdCA9IGFkb3B0TlMoKE5TU3RyaW5n ICopc3RyaW5nLmxlYWtSZWYoKSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTQ0NCw3ICs0 NDQsNyBAQCBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIFJldGFpblB0cjxO U0RhdGU+JiByZXN1bHQpCiAgICAgaWYgKCFkZWNvZGUoZGVjb2RlciwgZGF0ZSkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAotICAgIHJlc3VsdCA9IGFkb3B0Q0YoKE5TRGF0ZSAqKWRhdGUubGVh a1JlZigpKTsKKyAgICByZXN1bHQgPSBhZG9wdE5TKChOU0RhdGUgKilkYXRlLmxlYWtSZWYoKSk7 CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTQ1OSw3ICs0NTksNyBAQCBib29sIGRlY29kZShB cmd1bWVudERlY29kZXImIGRlY29kZXIsIFJldGFpblB0cjxOU0RhdGE+JiByZXN1bHQpCiAgICAg aWYgKCFkZWNvZGUoZGVjb2RlciwgZGF0YSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IHJlc3VsdCA9IGFkb3B0Q0YoKE5TRGF0YSAqKWRhdGEubGVha1JlZigpKTsKKyAgICByZXN1bHQg PSBhZG9wdE5TKChOU0RhdGEgKilkYXRhLmxlYWtSZWYoKSk7CiAgICAgcmV0dXJuIHRydWU7CiB9 CiAK