115821 2013-05-08 13:09:11 -0700 TextTrackCue should support empty content 2013-05-08 13:52:45 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue dino esprehn+autocc glenn jer.noble webkit-bug-importer oldest_to_newest 886446 0 eric.carlson 2013-05-08 13:09:11 -0700 'new TextTrackCue(start, end, "")' is valid but it currently creates a cue that causes WebKit to crash. Don't do that. 886447 1 webkit-bug-importer 2013-05-08 13:09:42 -0700 <rdar://problem/13841113> 886449 2 201101 eric.carlson 2013-05-08 13:19:57 -0700 Created attachment 201101 Proposed patch 886452 3 201101 jer.noble 2013-05-08 13:25:56 -0700 Comment on attachment 201101 Proposed patch Null checks are awesome. 886458 4 201101 commit-queue 2013-05-08 13:52:43 -0700 Comment on attachment 201101 Proposed patch Clearing flags on attachment: 201101 Committed r149766: <http://trac.webkit.org/changeset/149766> 886459 5 commit-queue 2013-05-08 13:52:45 -0700 All reviewed patches have been landed. Closing bug. 201101 2013-05-08 13:19:57 -0700 2013-05-08 13:52:43 -0700 Proposed patch patch_2.txt text/plain 6437 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTc2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA1LTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFRleHRUcmFja0N1ZSBz aG91bGQgc3VwcG9ydCBlbXB0eSBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU4MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUZXN0OiBtZWRpYS90cmFjay90cmFjay1jdWUtZW1wdHktdGV4 dC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJF bGVtZW50Ojp1cGRhdGVEaXNwbGF5KTogRG9uJ3QgYm90aGVyIHRyeWluZyB0byByZW5kZXIKKyAg ICAgICAgICAgIGN1ZXMgd2l0aCBubyBjb250ZW50LgorCisgICAgICAgICogaHRtbC90cmFjay9U ZXh0VHJhY2tDdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFRyYWNrQ3VlOjpnZXRDdWVB c0hUTUwpOiBSZXR1cm4gZWFybHkgaWYgdGhlcmUgaXNuJ3QgYSBub2RlIHRyZWUuCisgICAgICAg IChXZWJDb3JlOjpUZXh0VHJhY2tDdWU6OmNyZWF0ZUN1ZVJlbmRlcmluZ1RyZWUpOiBEaXR0by4K KyAgICAgICAgKFdlYkNvcmU6OlRleHRUcmFja0N1ZTo6ZGV0ZXJtaW5lVGV4dERpcmVjdGlvbik6 IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6VGV4dFRyYWNrQ3VlOjp1cGRhdGVEaXNwbGF5VHJl ZSk6IFJldHVybiBlYXJseSBpZiB0aGVyZSBpc24ndCBhIGN1ZSByZW5kZXJpbmcgdHJlZS4KKwog MjAxMy0wNS0wOCAgSm9zw6kgRGFwZW5hIFBheiAgPGpkYXBlbmFAaWdhbGlhLmNvbT4gYW5kIFph biBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFBsdW1i IHRoZSBBdXRvbWFrZSBidWlsZCBzeXN0ZW0gZm9yIHRoZSBCYXR0ZXJ5IFN0YXR1cyBBUEkgZmVh dHVyZQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVu dHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29u dHJvbEVsZW1lbnRzLmNwcAkocmV2aXNpb24gMTQ5NzQwKQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcz LDcgKzEyNzMsNyBAQCB2b2lkIE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lCiAg ICAgICAgIFRleHRUcmFja0N1ZSogY3VlID0gYWN0aXZlQ3Vlc1tpXS5kYXRhKCk7CiAKICAgICAg ICAgQVNTRVJUKGN1ZS0+aXNBY3RpdmUoKSk7Ci0gICAgICAgIGlmICghY3VlLT50cmFjaygpIHx8 ICFjdWUtPnRyYWNrKCktPmlzUmVuZGVyZWQoKSB8fCAhY3VlLT5pc0FjdGl2ZSgpKQorICAgICAg ICBpZiAoIWN1ZS0+dHJhY2soKSB8fCAhY3VlLT50cmFjaygpLT5pc1JlbmRlcmVkKCkgfHwgIWN1 ZS0+aXNBY3RpdmUoKSB8fCBjdWUtPnRleHQoKS5pc0VtcHR5KCkpCiAgICAgICAgICAgICBjb250 aW51ZTsKIAogICAgICAgICBSZWZQdHI8VGV4dFRyYWNrQ3VlQm94PiBkaXNwbGF5Qm94ID0gY3Vl LT5nZXREaXNwbGF5VHJlZShtX3ZpZGVvRGlzcGxheVNpemUuc2l6ZSgpKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHAJKHJldmlzaW9uIDE0OTc0MCkK KysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTE3LDYgKzUxNyw5IEBAIHZvaWQgVGV4dFRyYWNrQ3VlOjpjb3B5V2ViVlRUTm9k ZVRvRE9NVHIKIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gVGV4dFRyYWNrQ3VlOjpnZXRD dWVBc0hUTUwoKQogewogICAgIGNyZWF0ZVdlYlZUVE5vZGVUcmVlKCk7CisgICAgaWYgKCFtX3dl YlZUVE5vZGVUcmVlKQorICAgICAgICByZXR1cm4gMDsKKwogICAgIFJlZlB0cjxEb2N1bWVudEZy YWdtZW50PiBjbG9uZWRGcmFnbWVudCA9IERvY3VtZW50RnJhZ21lbnQ6OmNyZWF0ZShvd25lckRv Y3VtZW50KCkpOwogICAgIGNvcHlXZWJWVFROb2RlVG9ET01UcmVlKG1fd2ViVlRUTm9kZVRyZWUu Z2V0KCksIGNsb25lZEZyYWdtZW50LmdldCgpKTsKICAgICByZXR1cm4gY2xvbmVkRnJhZ21lbnQu cmVsZWFzZSgpOwpAQCAtNTI2LDYgKzUyOSw5IEBAIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVu dD4gVGV4dFRyYWNrQ3UKIHsKICAgICBSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gY2xvbmVkRnJh Z21lbnQ7CiAgICAgY3JlYXRlV2ViVlRUTm9kZVRyZWUoKTsKKyAgICBpZiAoIW1fd2ViVlRUTm9k ZVRyZWUpCisgICAgICAgIHJldHVybiAwOworCiAgICAgY2xvbmVkRnJhZ21lbnQgPSBEb2N1bWVu dEZyYWdtZW50OjpjcmVhdGUob3duZXJEb2N1bWVudCgpKTsKICAgICBtX3dlYlZUVE5vZGVUcmVl LT5jbG9uZUNoaWxkTm9kZXMoY2xvbmVkRnJhZ21lbnQuZ2V0KCkpOwogICAgIHJldHVybiBjbG9u ZWRGcmFnbWVudC5yZWxlYXNlKCk7CkBAIC02MTMsNiArNjE5LDggQEAgdm9pZCBUZXh0VHJhY2tD dWU6OmRldGVybWluZVRleHREaXJlY3RpbwogewogICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29u c3QgU3RyaW5nLCBydFRhZywgKEFTQ0lJTGl0ZXJhbCgicnQiKSkpOwogICAgIGNyZWF0ZVdlYlZU VE5vZGVUcmVlKCk7CisgICAgaWYgKCFtX3dlYlZUVE5vZGVUcmVlKQorICAgICAgICByZXR1cm47 CiAKICAgICAvLyBBcHBseSB0aGUgVW5pY29kZSBCaWRpcmVjdGlvbmFsIEFsZ29yaXRobSdzIFBh cmFncmFwaCBMZXZlbCBzdGVwcyB0byB0aGUKICAgICAvLyBjb25jYXRlbmF0aW9uIG9mIHRoZSB2 YWx1ZXMgb2YgZWFjaCBXZWJWVFQgVGV4dCBPYmplY3QgaW4gbm9kZXMsIGluIGEKQEAgLTc4Miw2 ICs3OTAsOSBAQCB2b2lkIFRleHRUcmFja0N1ZTo6dXBkYXRlRGlzcGxheVRyZWUoZG91CiAKICAg ICAvLyBVcGRhdGUgdGhlIHR3byBzZXRzIGNvbnRhaW5pbmcgcGFzdCBhbmQgZnV0dXJlIFdlYlZU VCBvYmplY3RzLgogICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiByZWZlcmVuY2VUcmVlID0g Y3JlYXRlQ3VlUmVuZGVyaW5nVHJlZSgpOworICAgIGlmICghcmVmZXJlbmNlVHJlZSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgbWFya0Z1dHVyZUFuZFBhc3ROb2RlcyhyZWZlcmVuY2VUcmVlLmdl dCgpLCBzdGFydFRpbWUoKSwgbW92aWVUaW1lKTsKICAgICBtX2N1ZUJhY2tncm91bmRCb3gtPmFw cGVuZENoaWxkKHJlZmVyZW5jZVRyZWUpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5NzYyKQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTMtMDUtMDggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAg ICAgICAgVGV4dFRyYWNrQ3VlIHNob3VsZCBzdXBwb3J0IGVtcHR5IGNvbnRlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTgyMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdHJhY2svdHJh Y2stY3VlLWVtcHR5LXRleHQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBt ZWRpYS90cmFjay90cmFjay1jdWUtZW1wdHktdGV4dC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAx My0wNS0wOCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNpc2Euc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgQWRkIGxheW91dCB0ZXN0IHRoYXQgbGlzdHMgYWxsIGdsb2JhbCBjb25zdHJ1Y3Rv cnMKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1lbXB0eS10ZXh0LWNy YXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay1jdWUtZW1wdHktdGV4dC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtZW1wdHktdGV4dC1jcmFzaC1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorKiogQWRkIGEgdGV4dCB0cmFj ayB0byB0aGUgdmlkZW8gZWxlbWVudC4uLgorKiogQWRkIGFuIGVtcHR5IGN1ZSB0byB0aGUgdHJh Y2suLi4KKyoqIFBsYXkgdGhlIHZpZGVvIHNvIHRoZSBjdWUgaXMgc2NoZWR1bGVkIHRvIHJlbmRl ci4uLgorCitFVkVOVChwbGF5aW5nKQorCitQQVNTIC0gbm8gY3Jhc2guCisKK0VORCBPRiBURVNU CisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1lbXB0eS10ZXh0LWNy YXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3Vl LWVtcHR5LXRleHQtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlh L3RyYWNrL3RyYWNrLWN1ZS1lbXB0eS10ZXh0LWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAg ICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9dXRmLTgiIC8+CisKKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vbWVkaWEtZmlsZS5qcz48 L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vdmlkZW8tdGVzdC5qcz48L3NjcmlwdD4K KyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIGZ1bmN0aW9uIHBsYXlpbmcoKQorICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJyPlBBU1MgLSBubyBjcmFz aC48YnI+Iik7CisgICAgICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICAgICAgfQorCisg ICAgICAgICAgICBmdW5jdGlvbiBzdGFydFRlc3QoKQorICAgICAgICAgICAgeworICAgICAgICAg ICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICB2aWRlby5zcmMgPSBm aW5kTWVkaWFGaWxlKCd2aWRlbycsICcuLi9jb250ZW50L3Rlc3QnKTsKKworICAgICAgICAgICAg ICAgIGNvbnNvbGVXcml0ZSgiKiogQWRkIGEgdGV4dCB0cmFjayB0byB0aGUgdmlkZW8gZWxlbWVu dC4uLiIpOworICAgICAgICAgICAgICAgIHZpZGVvLmFkZFRleHRUcmFjaygiY2FwdGlvbnMiLCAi cmVndWxhciBjYXB0aW9ucyB0cmFjayIsICJlbiIpOworCisgICAgICAgICAgICAgICAgY29uc29s ZVdyaXRlKCIqKiBBZGQgYW4gZW1wdHkgY3VlIHRvIHRoZSB0cmFjay4uLiIpOworICAgICAgICAg ICAgICAgIHZpZGVvLnRleHRUcmFja3NbMF0uYWRkQ3VlKG5ldyBUZXh0VHJhY2tDdWUoMC4wMCwg NC4wMCwgIiIpKTsKKyAgICAgICAgICAgICAgICB2aWRlby50ZXh0VHJhY2tzWzBdLm1vZGUgPSAi c2hvd2luZyI7CisKKyAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIioqIFBsYXkgdGhlIHZp ZGVvIHNvIHRoZSBjdWUgaXMgc2NoZWR1bGVkIHRvIHJlbmRlci4uLjxicj4iKTsKKyAgICAgICAg ICAgICAgICB2aWRlby5wbGF5KCk7CisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdwbGF5 aW5nJywgcGxheWluZyk7CisgICAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAg PC9oZWFkPgorCisgICAgPGJvZHkgb25sb2FkPSJzdGFydFRlc3QoKSI+CisgICAgICAgIDx2aWRl byBjb250cm9scyAvPgorICAgICAgICA8cD5UZXN0cyB0aGF0IGEgY3VlIHdpdGggbm8gdGV4dCBk b2VzIG5vdCBjcmFzaCB0aGUgYnJvd3Nlci48L3A+CisgICAgPC9ib2R5PgorPC9odG1sPgo=