115816 2013-05-08 12:10:44 -0700 new-run-webkit-websocketserver doesn't work after Chromium removal 2013-05-08 12:25:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap benjamin dpranke jberlin joepeck oldest_to_newest 886418 0 rniwa 2013-05-08 12:10:44 -0700 new-run-webkit-websocketserver doesn't work after Chromium removal 886419 1 201092 rniwa 2013-05-08 12:11:11 -0700 Created attachment 201092 Fixes the bug 886421 2 201092 joepeck 2013-05-08 12:16:01 -0700 Comment on attachment 201092 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=201092&action=review Looks good to me! Thanks. > Tools/Scripts/new-run-webkit-websocketserver:38 > +from webkitpy.port import platform_options Alphabetical order? Or does that style not matter in py. > Tools/Scripts/new-run-webkit-websocketserver:106 > # FIXME: Make this work with other ports as well. Seems like you can remove the FIXME now. 886428 3 rniwa 2013-05-08 12:25:36 -0700 Committed r149757: <http://trac.webkit.org/changeset/149757> 201092 2013-05-08 12:11:11 -0700 2013-05-08 12:16:01 -0700 Fixes the bug bug-115816-20130508121015.patch text/plain 1934 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0OTc1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA1LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIG5ldy1ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlciBkb2Vzbid0IHdvcmsgYWZ0 ZXIgQ2hyb21pdW0gcmVtb3ZhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE1ODE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IHRoZSBidWcgYnkgaW5zdGFudGlhdGluZyB0aGUgY29ycmVjdCBwb3J0 IG9iamVjdC4KKworICAgICAgICAqIFNjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2Vy dmVyOgorICAgICAgICAobWFpbik6CisKIDIwMTMtMDUtMDcgIEx1Y2FzIEZvcnNjaGxlciAgPGxm b3JzY2hsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENvbmZpZ3VyZSBidWlsZGJvdCBmb3IgMzJi aXQgYnVpbGRlci4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0 c2VydmVyCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29j a2V0c2VydmVyCShyZXZpc2lvbiAxNDk3MDkpCisrKyBUb29scy9TY3JpcHRzL25ldy1ydW4td2Vi a2l0LXdlYnNvY2tldHNlcnZlcgkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQCBpbXBv cnQgb3B0cGFyc2UKIGltcG9ydCB0ZW1wZmlsZQogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5ob3N0 IGltcG9ydCBIb3N0Citmcm9tIHdlYmtpdHB5LnBvcnQgaW1wb3J0IHBsYXRmb3JtX29wdGlvbnMK IGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnNlcnZlcnMgaW1wb3J0IHdlYnNvY2tldF9zZXJ2 ZXIKIAogCkBAIC03MSw2ICs3MiwxMSBAQCBkZWYgbWFpbigpOgogICAgIG9wdGlvbl9wYXJzZXIu YWRkX29wdGlvbignLXYnLCAnLS12ZXJib3NlJywgYWN0aW9uPSdzdG9yZV90cnVlJywKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaGVscD0nSW5jbHVkZSBkZWJ1Zy1sZXZlbCBsb2dnaW5nLicpCisKKyAgICBv cHRpb25fZ3JvdXAgPSBvcHRwYXJzZS5PcHRpb25Hcm91cChvcHRpb25fcGFyc2VyLCAiUGxhdGZv cm0gb3B0aW9ucyIpCisgICAgb3B0aW9uX2dyb3VwLmFkZF9vcHRpb25zKHBsYXRmb3JtX29wdGlv bnMoKSkKKyAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb25fZ3JvdXAob3B0aW9uX2dyb3VwKQor CiAgICAgb3B0aW9ucywgYXJncyA9IG9wdGlvbl9wYXJzZXIucGFyc2VfYXJncygpCiAKICAgICBp ZiBub3Qgb3B0aW9ucy5wb3J0OgpAQCAtOTgsNyArMTA0LDcgQEAgZGVmIG1haW4oKToKIAogICAg IGhvc3QgPSBIb3N0KCkKICAgICAjIEZJWE1FOiBNYWtlIHRoaXMgd29yayB3aXRoIG90aGVyIHBv cnRzIGFzIHdlbGwuCi0gICAgcG9ydF9vYmogPSBob3N0LnBvcnRfZmFjdG9yeS5nZXQocG9ydF9u YW1lPSdjaHJvbWl1bScsIG9wdGlvbnM9b3B0aW9ucykKKyAgICBwb3J0X29iaiA9IGhvc3QucG9y dF9mYWN0b3J5LmdldChvcHRpb25zLnBsYXRmb3JtLCBvcHRpb25zPW9wdGlvbnMpCiAgICAgcHl3 ZWJzb2NrZXQgPSB3ZWJzb2NrZXRfc2VydmVyLlB5V2ViU29ja2V0KHBvcnRfb2JqLCBvcHRpb25z Lm91dHB1dF9kaXIsICoqa3dkcykKIAogICAgIGxvZ19sZXZlbCA9IGxvZ2dpbmcuV0FSTgo=