115802 2013-05-08 07:21:08 -0700 Allow blank spaces before colon (:) on CSS variable definition 2013-05-08 08:18:37 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar commit-queue darin esprehn+autocc glenn kling macpherson menard pfeldman svillar oldest_to_newest 886330 0 svillar 2013-05-08 07:21:08 -0700 Something like: :root { -webkit-var-mycolor : red; } won't define a new CSS variable "mycolor" because there is a space before the colon. 886331 1 201071 svillar 2013-05-08 07:25:52 -0700 Created attachment 201071 Patch 886334 2 201072 svillar 2013-05-08 07:27:04 -0700 Created attachment 201072 Patch 886335 3 201072 darin 2013-05-08 07:30:18 -0700 Comment on attachment 201072 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201072&action=review r=me, but please do this without adding a new production > Source/WebCore/css/CSSGrammar.y.in:1623 > - VAR_DEFINITION ':' maybe_space expr prio { > + var_definition ':' maybe_space expr prio { > #if ENABLE_CSS_VARIABLES > parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5); > $$ = true; It’s unnecessary to add a new production for this. Instead you should just add the maybe_space to this production, and change $4 to $5 and $5 to $6. 886356 4 svillar 2013-05-08 08:18:37 -0700 Committed r149740: <http://trac.webkit.org/changeset/149740> 201071 2013-05-08 07:25:52 -0700 2013-05-08 07:26:41 -0700 Patch bug-115802-20130508162456.patch text/plain 3611 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZkMjM1NWVkMTBhODk1 Zjc1NjA5YjRlYTNjZmQ1YzFlMTVkZjcyOC4uN2MzN2FiNjM4NGU0ZDEyMzNlZWMyYTlmYzMyMmM1 YjlmZWY4OGUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTA4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFsbG93IGJs YW5rIHNwYWNlcyBiZWZvcmUgY29sb24gKDopIG9uIENTUyB2YXJpYWJsZSBkZWZpbml0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU4MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjc3Mz L2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLmh0bWwKKworICAgICAgICBNb2RpZmllZCB0aGUgZ3Jh bW1hciB0byBhbGxvdyBibGFuayBzcGFjZXMgYmVmb3JlIHRoZSBjb2xvbiBvbiBDU1MKKyAgICAg ICAgdmFyaWFibGUgZGVmaW5pdGlvbnMuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55Lmlu OgorCiAyMDEzLTA1LTAxICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgogCiAgICAgICAgIFNob3cgYSBibG9jayBjdXJzb3IgaW4gb3ZlcnR5cGUgbW9kZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbiBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NHcmFtbWFyLnkuaW4KaW5kZXggMmZlNzkxYjEzNDNkY2YzNTkyY2RhMWQ0YjNiZjFm Y2EzYWY1OTYyMS4uNDZhMzU4OGE1NTI5ZWQ2YTE4YTdjYzNkZTgyMDQxNzA3ZjhhZjE0ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluCkBAIC0zNDAsNiArMzQwLDggQEAgc3RhdGljIGlu bGluZSBib29sIGlzQ1NTVG9rZW5BU3RyaW5nKGludCB5eXR5cGUpCiAldHlwZSA8bG9jYXRpb24+ IGVycm9ycwogJXR5cGUgPGxvY2F0aW9uPiBlcnJvcl9sb2NhdGlvbgogCisldHlwZSA8c3RyaW5n PiB2YXJfZGVmaW5pdGlvbgorCiAlJQogCiBzdHlsZXNoZWV0OgpAQCAtMTYxNSw3ICsxNjE3LDcg QEAgZGVjbF9saXN0OgogICAgIDsKIAogZGVjbGFyYXRpb246Ci0gICAgVkFSX0RFRklOSVRJT04g JzonIG1heWJlX3NwYWNlIGV4cHIgcHJpbyB7CisgICAgdmFyX2RlZmluaXRpb24gJzonIG1heWJl X3NwYWNlIGV4cHIgcHJpbyB7CiAjaWYgRU5BQkxFX0NTU19WQVJJQUJMRVMKICAgICAgICAgcGFy c2VyLT5zdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24oJDEsIHBhcnNlci0+c2lua0Zsb2F0aW5nVmFs dWVMaXN0KCQ0KSwgJDUpOwogICAgICAgICAkJCA9IHRydWU7CkBAIC0yMDQ5LDUgKzIwNTEsMTEg QEAgZXJyb3JfbG9jYXRpb246IHsKICAgICB9CiAgICAgOwogCit2YXJfZGVmaW5pdGlvbjoKKyAg ICBWQVJfREVGSU5JVElPTiBtYXliZV9zcGFjZSB7CisgICAgICAgICQkID0gJDE7CisgICAgfQor ICAgIDsKKwogJSUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ0ODA4NWIyYjdmYTZiODFkNGVmMjYzZGRiZTMyMWE3MzAw YjRhZjUuLjlhMjlmODljOTg4MjVmNjBiNzdhZjgzMTJkYTI0OTczOThkZmU4MWEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wOCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJA aWdhbGlhLmNvbT4KKworICAgICAgICBBbGxvdyBibGFuayBzcGFjZXMgYmVmb3JlIGNvbG9uICg6 KSBvbiBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgdG8gY2hlY2sgdGhhdCBzcGFjZXMgYXJlIGFs bG93ZWQgYmVmb3JlIHRoZSBjb2xvciBvbiBDU1MKKyAgICAgICAgdmFyaWFibGUgZGVmaW5pdGlv bnMuCisKKyAgICAgICAgKiBjc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGNzczMvY3NzLXZhcmlhYmxlLWRlZmluaXRpb24uaHRtbDog QWRkZWQuCisKIDIwMTMtMDUtMDEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp YS5jb20+CiAKICAgICAgICAgU2hvdyBhIGJsb2NrIGN1cnNvciBpbiBvdmVydHlwZSBtb2RlCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVj dGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVj dGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZjUzMDRiNDkwOTgwNTA5NzA0NzljM2EyMTRmYWU2NGI5MjA5 ZmI4NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlhYmxlLWRl ZmluaXRpb24tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE0IEBACis8aHRtbD4KKzxzdHlsZT4K KyAgOnJvb3QgeworICAgICAgLXdlYmtpdC12YXItbXljb2xvcjogcmVkOworICB9CisgIGRpdiB7 CisgICAgICBjb2xvcjogLXdlYmtpdC12YXIobXljb2xvcik7CisgIH0KKzwvc3R5bGU+Cis8Ym9k eT4KKyAgPHA+Q2hlY2sgdGhhdCBhIENTUyB2YXJpYWJsZSBkZWZpbml0aW9uIGFjY2VwdHMgc3Bh Y2VzIGJlZm9yZSB0aGUgJzonPC9wPgorICA8ZGl2PlRoaXMgdGV4dCBzaG91bGQgYmUgcmVkPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12 YXJpYWJsZS1kZWZpbml0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1k ZWZpbml0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTdjZjg2NTliY2UzNzNhYjE2NDk1NTgyOWZhYzk0 ZTBkMjA3MWIzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlh YmxlLWRlZmluaXRpb24uaHRtbApAQCAtMCwwICsxLDE0IEBACis8aHRtbD4KKzxzdHlsZT4KKyAg OnJvb3QgeworICAgICAgLXdlYmtpdC12YXItbXljb2xvciA6IHJlZDsKKyAgfQorICBkaXYgewor ICAgICAgY29sb3I6IC13ZWJraXQtdmFyKG15Y29sb3IpOworICB9Cis8L3N0eWxlPgorPGJvZHk+ CisgIDxwPkNoZWNrIHRoYXQgYSBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbiBhY2NlcHRzIHNwYWNl cyBiZWZvcmUgdGhlICc6JzwvcD4KKyAgPGRpdj5UaGlzIHRleHQgc2hvdWxkIGJlIHJlZDwvZGl2 PgorPC9ib2R5PgorPC9odG1sPgo= 201072 2013-05-08 07:27:04 -0700 2013-05-08 07:30:18 -0700 Patch bug-115802-20130508162608.patch text/plain 3611 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZkMjM1NWVkMTBhODk1 Zjc1NjA5YjRlYTNjZmQ1YzFlMTVkZjcyOC4uN2MzN2FiNjM4NGU0ZDEyMzNlZWMyYTlmYzMyMmM1 YjlmZWY4OGUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTA4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFsbG93IGJs YW5rIHNwYWNlcyBiZWZvcmUgY29sb24gKDopIG9uIENTUyB2YXJpYWJsZSBkZWZpbml0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU4MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjc3Mz L2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLmh0bWwKKworICAgICAgICBNb2RpZmllZCB0aGUgZ3Jh bW1hciB0byBhbGxvdyBibGFuayBzcGFjZXMgYmVmb3JlIHRoZSBjb2xvbiBvbiBDU1MKKyAgICAg ICAgdmFyaWFibGUgZGVmaW5pdGlvbnMuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55Lmlu OgorCiAyMDEzLTA1LTAxICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgogCiAgICAgICAgIFNob3cgYSBibG9jayBjdXJzb3IgaW4gb3ZlcnR5cGUgbW9kZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbiBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NHcmFtbWFyLnkuaW4KaW5kZXggMmZlNzkxYjEzNDNkY2YzNTkyY2RhMWQ0YjNiZjFm Y2EzYWY1OTYyMS4uNDZhMzU4OGE1NTI5ZWQ2YTE4YTdjYzNkZTgyMDQxNzA3ZjhhZjE0ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluCkBAIC0zNDAsNiArMzQwLDggQEAgc3RhdGljIGlu bGluZSBib29sIGlzQ1NTVG9rZW5BU3RyaW5nKGludCB5eXR5cGUpCiAldHlwZSA8bG9jYXRpb24+ IGVycm9ycwogJXR5cGUgPGxvY2F0aW9uPiBlcnJvcl9sb2NhdGlvbgogCisldHlwZSA8c3RyaW5n PiB2YXJfZGVmaW5pdGlvbgorCiAlJQogCiBzdHlsZXNoZWV0OgpAQCAtMTYxNSw3ICsxNjE3LDcg QEAgZGVjbF9saXN0OgogICAgIDsKIAogZGVjbGFyYXRpb246Ci0gICAgVkFSX0RFRklOSVRJT04g JzonIG1heWJlX3NwYWNlIGV4cHIgcHJpbyB7CisgICAgdmFyX2RlZmluaXRpb24gJzonIG1heWJl X3NwYWNlIGV4cHIgcHJpbyB7CiAjaWYgRU5BQkxFX0NTU19WQVJJQUJMRVMKICAgICAgICAgcGFy c2VyLT5zdG9yZVZhcmlhYmxlRGVjbGFyYXRpb24oJDEsIHBhcnNlci0+c2lua0Zsb2F0aW5nVmFs dWVMaXN0KCQ0KSwgJDUpOwogICAgICAgICAkJCA9IHRydWU7CkBAIC0yMDQ5LDUgKzIwNTEsMTEg QEAgZXJyb3JfbG9jYXRpb246IHsKICAgICB9CiAgICAgOwogCit2YXJfZGVmaW5pdGlvbjoKKyAg ICBWQVJfREVGSU5JVElPTiBtYXliZV9zcGFjZSB7CisgICAgICAgICQkID0gJDE7CisgICAgfQor ICAgIDsKKwogJSUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ0ODA4NWIyYjdmYTZiODFkNGVmMjYzZGRiZTMyMWE3MzAw YjRhZjUuLjlhMjlmODljOTg4MjVmNjBiNzdhZjgzMTJkYTI0OTczOThkZmU4MWEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wNS0wOCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJA aWdhbGlhLmNvbT4KKworICAgICAgICBBbGxvdyBibGFuayBzcGFjZXMgYmVmb3JlIGNvbG9uICg6 KSBvbiBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgdG8gY2hlY2sgdGhhdCBzcGFjZXMgYXJlIGFs bG93ZWQgYmVmb3JlIHRoZSBjb2xvciBvbiBDU1MKKyAgICAgICAgdmFyaWFibGUgZGVmaW5pdGlv bnMuCisKKyAgICAgICAgKiBjc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGNzczMvY3NzLXZhcmlhYmxlLWRlZmluaXRpb24uaHRtbDog QWRkZWQuCisKIDIwMTMtMDUtMDEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp YS5jb20+CiAKICAgICAgICAgU2hvdyBhIGJsb2NrIGN1cnNvciBpbiBvdmVydHlwZSBtb2RlCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVj dGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1kZWZpbml0aW9uLWV4cGVj dGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZjUzMDRiNDkwOTgwNTA5NzA0NzljM2EyMTRmYWU2NGI5MjA5 ZmI4NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlhYmxlLWRl ZmluaXRpb24tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE0IEBACis8aHRtbD4KKzxzdHlsZT4K KyAgOnJvb3QgeworICAgICAgLXdlYmtpdC12YXItbXljb2xvcjogcmVkOworICB9CisgIGRpdiB7 CisgICAgICBjb2xvcjogLXdlYmtpdC12YXIobXljb2xvcik7CisgIH0KKzwvc3R5bGU+Cis8Ym9k eT4KKyAgPHA+Q2hlY2sgdGhhdCBhIENTUyB2YXJpYWJsZSBkZWZpbml0aW9uIGFjY2VwdHMgc3Bh Y2VzIGJlZm9yZSB0aGUgJzonPC9wPgorICA8ZGl2PlRoaXMgdGV4dCBzaG91bGQgYmUgcmVkPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12 YXJpYWJsZS1kZWZpbml0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2Nzcy12YXJpYWJsZS1k ZWZpbml0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTdjZjg2NTliY2UzNzNhYjE2NDk1NTgyOWZhYzk0 ZTBkMjA3MWIzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvY3NzLXZhcmlh YmxlLWRlZmluaXRpb24uaHRtbApAQCAtMCwwICsxLDE0IEBACis8aHRtbD4KKzxzdHlsZT4KKyAg OnJvb3QgeworICAgICAgLXdlYmtpdC12YXItbXljb2xvciA6IHJlZDsKKyAgfQorICBkaXYgewor ICAgICAgY29sb3I6IC13ZWJraXQtdmFyKG15Y29sb3IpOworICB9Cis8L3N0eWxlPgorPGJvZHk+ CisgIDxwPkNoZWNrIHRoYXQgYSBDU1MgdmFyaWFibGUgZGVmaW5pdGlvbiBhY2NlcHRzIHNwYWNl cyBiZWZvcmUgdGhlICc6JzwvcD4KKyAgPGRpdj5UaGlzIHRleHQgc2hvdWxkIGJlIHJlZDwvZGl2 PgorPC9ib2R5PgorPC9odG1sPgo=