115795 2013-05-08 05:02:58 -0700 [Qt][Mac] WRT build broken after r149692 2013-05-08 05:29:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 42324 1 zarvai webkit-unassigned abecsi achristensen hausmann jturcotte kadam timothy zeno oldest_to_newest 886291 0 zarvai 2013-05-08 05:02:58 -0700 In r149692 DOMAsWebArchive added to WTR. In Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp #if USE(CF) #include "WebArchiveDumpSupport.h" #endif section is true on Qt Mac, but not true on other Qt port. If we want DOMAsWebArchive feature on Qt Mac we should add it to Target.pri. Probably it's better to disable it by changing "#if USE(CF)" to "#if USE(CF) && !PLATFORM(Qt)" to get the same WTR on Qt Linux and Qt Mac. What is your opinion about that? 886292 1 201060 zarvai 2013-05-08 05:08:17 -0700 Created attachment 201060 Speculative fix Exclude Qt Mac from include. 886294 2 abecsi 2013-05-08 05:24:48 -0700 (In reply to comment #1) > Created an attachment (id=201060) [details] > Speculative fix > > Exclude Qt Mac from include. I just landed the fix for that, sorry :) http://trac.webkit.org/changeset/149731 886295 3 zarvai 2013-05-08 05:27:43 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=201060) [details] [details] > > Speculative fix > > > > Exclude Qt Mac from include. > > I just landed the fix for that, sorry :) > > http://trac.webkit.org/changeset/149731 No problem, thanks for fixing it :-) 201060 2013-05-08 05:08:17 -0700 2013-05-08 05:29:34 -0700 Speculative fix qtmac.patch text/plain 1042 zarvai ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YzJk NTRiLi5mOWMxMjg4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDUtMDggIFpvbHRhbiBBcnZhaSAgPHphcnZh aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBGaXggV1RSIGJ1aWxkIG9uIFF0IE1v dW50YWluIExpb24gYWZ0ZXIgcjE0OTY5Mi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNTc5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZVBhZ2UuY3BwOgorCiAyMDEzLTA1LTA4ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8 bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkZWQgQW50 b24gT2J6aGlyb3YgdG8gdGhlIGxpc3Qgb2YgY29udHJpYnV0b3JzIGFuZCBteXNlbGYKZGlmZiAt LWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5k bGVQYWdlLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGVQYWdlLmNwcAppbmRleCBjODQxYmUxLi4wMjRjZmNlIDEwMDY0NAotLS0gYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAK KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRs ZVBhZ2UuY3BwCkBAIC00OCw3ICs0OCw3IEBACiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5o PgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAotI2lmIFVTRShDRikKKyNp ZiBVU0UoQ0YpICYmICFQTEFURk9STShRVCkKICNpbmNsdWRlICJXZWJBcmNoaXZlRHVtcFN1cHBv cnQuaCIKICNlbmRpZgogCg==