115782 2013-05-08 02:01:30 -0700 Crash properly on iOS 2013-05-16 12:02:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin ap barraclough cmarcelo commit-queue darin ddkilzer eflews.bot ggaren gyuyoung.kim webkit-ews oldest_to_newest 886238 0 benjamin 2013-05-08 02:01:30 -0700 Crash properly on iOS 886239 1 201045 benjamin 2013-05-08 02:02:46 -0700 Created attachment 201045 Patch 886242 2 201045 eflews.bot 2013-05-08 02:10:23 -0700 Comment on attachment 201045 Patch Attachment 201045 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/436022 886243 3 201045 eflews.bot 2013-05-08 02:11:18 -0700 Comment on attachment 201045 Patch Attachment 201045 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/380470 886244 4 201045 webkit-ews 2013-05-08 02:11:42 -0700 Comment on attachment 201045 Patch Attachment 201045 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/274187 886245 5 201045 webkit-ews 2013-05-08 02:13:50 -0700 Comment on attachment 201045 Patch Attachment 201045 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/318308 886248 6 201045 buildbot 2013-05-08 02:26:31 -0700 Comment on attachment 201045 Patch Attachment 201045 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/406485 886382 7 201045 ap 2013-05-08 09:38:49 -0700 Comment on attachment 201045 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201045&action=review I'm concerned that this change will break aggregation with existing crash reports. Can you try a known crash with and without this change to compare? > Source/WTF/wtf/Assertions.cpp:343 > + ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ This comment now looks as if it claims that this is more reliable than __builtin_trap(). 886509 8 benjamin 2013-05-08 16:33:29 -0700 <rdar://problem/13842771> 886514 9 benjamin 2013-05-08 16:44:16 -0700 (In reply to comment #7) > (From update of attachment 201045 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201045&action=review > > I'm concerned that this change will break aggregation with existing crash reports. Can you try a known crash with and without this change to compare? You have WTFCrash on top for crash reporter. Would that be a problem? WTFReportBacktrace already skip 2 frames so it is just one level deeper. > > Source/WTF/wtf/Assertions.cpp:343 > > + ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ > > This comment now looks as if it claims that this is more reliable than __builtin_trap(). To be honest I have no clue what this comment mean by "More reliable". 886531 10 201117 benjamin 2013-05-08 17:18:02 -0700 Created attachment 201117 Patch 886543 11 201117 buildbot 2013-05-08 17:43:08 -0700 Comment on attachment 201117 Patch Attachment 201117 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/375014 887185 12 201117 darin 2013-05-09 18:23:35 -0700 Comment on attachment 201117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201117&action=review This changes things so that all crashes happen inside a function. The old code went out of its way to crash at the call site, not inside a function. I think the reason we wanted that was to make debugging easier. Not sure if that is important any more. Seems a little risky to change, though. I’m assuming the Windows build failures are due to changes in the exported symbols that are needed. > Source/WTF/wtf/Assertions.cpp:333 > +static void invokeCrashHook() > { > if (globalHook) > globalHook(); > } Why is this still a function? Why not just call the hook directly in WTFCrash? > Source/WTF/wtf/Assertions.cpp:339 > + (*(int *)(uintptr_t)0xbbadbeef = 0); There are extra unneeded parentheses here. > Source/WTF/wtf/Assertions.cpp:344 > + (*(int *)(uintptr_t)0xbbadbeef = 0); > +#if COMPILER(CLANG) > + __builtin_trap(); > +#else > + ((void(*)())0)(); > +#endif Really could use a why comment explaining the bbadbeef thing. 887186 13 darin 2013-05-09 18:24:57 -0700 (In reply to comment #9) > > > Source/WTF/wtf/Assertions.cpp:343 > > > + ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ > > > > This comment now looks as if it claims that this is more reliable than __builtin_trap(). > > To be honest I have no clue what this comment mean by "More reliable". More reliable meant that in some cases accessing 0xbbadbeef would not cause a crash. That could be valid memory that happens to be mapped in, particularly on a 64-bit system. Whereas calling 0 or __builtin_trap was guaranteed to actually cause a crash. 887757 14 201451 benjamin 2013-05-11 00:26:30 -0700 Created attachment 201451 Patch 889945 15 201451 benjamin 2013-05-16 12:02:39 -0700 Comment on attachment 201451 Patch Clearing flags on attachment: 201451 Committed r150196: <http://trac.webkit.org/changeset/150196> 889946 16 benjamin 2013-05-16 12:02:45 -0700 All reviewed patches have been landed. Closing bug. 201045 2013-05-08 02:02:46 -0700 2013-05-08 17:17:59 -0700 Patch bug-115782-20130508020151.patch text/plain 2668 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZlZDZlZTZmNDJjNGUzMWFiYTkwZmFm ZGU3MDU2OGMxMzk2ZGU1ZmUuLmFkNjg4NWUzMTdiMDhhM2FkNTZjY2M4YTNkNGExNWYzZTE3MzFh NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDUtMDggIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIHByb3Blcmx5IG9uIGlPUworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzgyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmlyc3Qgb2YgYSBz ZXJpZSBvZiBjcmFzaCBpbXByb3ZlbWVudCA6KQorCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMu Y3BwOgorICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTMtMDUtMDcgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQWx3YXlzSW5s aW5lLmggZnJvbSBXVEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3Bw IGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggYmU2NThmYTk1ODhjMTU2MTNl Yjk2NTE4MzU4ZjBiNTA4NDYzNjdiYS4uODU3NzM4ZGYyZTc5NmI2NjgyY2M5MGE1YjdjNWE1ZGI1 MDkyMmQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTMyNiwxMiArMzI2LDI0IEBAIHZvaWQg V1RGU2V0Q3Jhc2hIb29rKFdURkNyYXNoSG9va0Z1bmN0aW9uIGZ1bmN0aW9uKQogICAgIGdsb2Jh bEhvb2sgPSBmdW5jdGlvbjsKIH0KIAotdm9pZCBXVEZJbnZva2VDcmFzaEhvb2soKQorc3RhdGlj IHZvaWQgaW52b2tlQ3Jhc2hIb29rKCkKIHsKICAgICBpZiAoZ2xvYmFsSG9vaykKICAgICAgICAg Z2xvYmFsSG9vaygpOwogfQogCit2b2lkIFdURkNyYXNoKCkKK3sKKyAgICBpbnZva2VDcmFzaEhv b2soKTsKKyAgICBXVEZSZXBvcnRCYWNrdHJhY2UoKTsKKyAgICAoKihpbnQgKikodWludHB0cl90 KTB4YmJhZGJlZWYgPSAwKTsKKyNpZiBDT01QSUxFUihDTEFORykKKyAgICBfX2J1aWx0aW5fdHJh cCgpOworI2Vsc2UKKyAgICAoKHZvaWQoKikoKSkwKSgpOyAvKiBNb3JlIHJlbGlhYmxlLCBidXQg ZG9lc24ndCBzYXkgQkJBREJFRUYgKi8KKyNlbmRpZgorfQorCiAjaWYgSEFWRShTSUdOQUxfSCkK IHN0YXRpYyBOT19SRVRVUk4gdm9pZCBkdW1wQmFja3RyYWNlU2lnbmFsSGFuZGxlcihpbnQgc2ln KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oIGIvU291cmNlL1dU Ri93dGYvQXNzZXJ0aW9ucy5oCmluZGV4IDYyNjNlNTBlZDkxYjcyYWJiOGI0ZWE4YzI5ZjQ4MTRj NDViMGNiNTcuLjM2NDVlYTAzMTIwMzJlZTVkMDlhOWI4MDZlYWIzODYwYTliNTk5YjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9B c3NlcnRpb25zLmgKQEAgLTE1MSw4ICsxNTEsOCBAQCBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBX VEZQcmludEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCBzaXplKTsKIAogdHlwZWRlZiB2b2lk ICgqV1RGQ3Jhc2hIb29rRnVuY3Rpb24pKCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZT ZXRDcmFzaEhvb2soV1RGQ3Jhc2hIb29rRnVuY3Rpb24pOwotV1RGX0VYUE9SVF9QUklWQVRFIHZv aWQgV1RGSW52b2tlQ3Jhc2hIb29rKCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZJbnN0 YWxsUmVwb3J0QmFja3RyYWNlT25DcmFzaEhvb2soKTsKK1dURl9FWFBPUlRfUFJJVkFURSB2b2lk IFdURkNyYXNoKCkgTk9fUkVUVVJOOwogCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KQEAgLTE2Nywy MCArMTY3LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0 cmFjZU9uQ3Jhc2hIb29rKCk7CiAgICBTaWduYWxzIGFyZSBpZ25vcmVkIGJ5IHRoZSBjcmFzaCBy ZXBvcnRlciBvbiBPUyBYIHNvIHdlIG11c3QgZG8gYmV0dGVyLgogKi8KICNpZm5kZWYgQ1JBU0gK LSNpZiBDT01QSUxFUihDTEFORykKLSNkZWZpbmUgQ1JBU0goKSBcCi0gICAgKFdURlJlcG9ydEJh Y2t0cmFjZSgpLCBcCi0gICAgIFdURkludm9rZUNyYXNoSG9vaygpLCBcCi0gICAgICgqKGludCAq KSh1aW50cHRyX3QpMHhiYmFkYmVlZiA9IDApLCBcCi0gICAgIF9fYnVpbHRpbl90cmFwKCkpCi0j ZWxzZQotI2RlZmluZSBDUkFTSCgpIFwKLSAgICAoV1RGUmVwb3J0QmFja3RyYWNlKCksIFwKLSAg ICAgV1RGSW52b2tlQ3Jhc2hIb29rKCksIFwKLSAgICAgKCooaW50ICopKHVpbnRwdHJfdCkweGJi YWRiZWVmID0gMCksIFwKLSAgICAgKCh2b2lkKCopKCkpMCkoKSAvKiBNb3JlIHJlbGlhYmxlLCBi dXQgZG9lc24ndCBzYXkgQkJBREJFRUYgKi8gXAotICAgICkKLSNlbmRpZgorI2RlZmluZSBDUkFT SCgpIFdURkNyYXNoKCkKICNlbmRpZgogCiAjaWYgQ09NUElMRVIoQ0xBTkcpCg== 201117 2013-05-08 17:18:02 -0700 2013-05-11 00:26:25 -0700 Patch bug-115782-20130508171706.patch text/plain 2868 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU2ZGViZWQ2NGI3MTE0NWU0ZTMwY2E4 NmE0MGFlMGI2ZjQ0MmFmOGMuLmQ0ZmNhMDQ5ZmY1MzMzOTU0ZjBmMzljMDhiOGE1MmFlM2M2ODhm ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDUtMDggIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIHByb3Blcmx5IG9uIGlPUworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzgyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBjcmFz aCBoYW5kbGluZy4gPHJkYXI6Ly9wcm9ibGVtLzEzODQyNzcxPgorCisgICAgICAgICogd3RmL0Fz c2VydGlvbnMuY3BwOgorICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTMtMDUtMDgg IE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAg ICAgICAgU2ltcGxpZnkgUmV0YWluUHRyT2JqZWN0SGFzaFRyYWl0cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNw cAppbmRleCBiZTY1OGZhOTU4OGMxNTYxM2ViOTY1MTgzNThmMGI1MDg0NjM2N2JhLi44MGFlZGM5 MmRlYjBmNjhhMTUwYzViNjIwMTNmZDhlNDliYjUyOWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcApA QCAtMzI2LDEyICszMjYsMjQgQEAgdm9pZCBXVEZTZXRDcmFzaEhvb2soV1RGQ3Jhc2hIb29rRnVu Y3Rpb24gZnVuY3Rpb24pCiAgICAgZ2xvYmFsSG9vayA9IGZ1bmN0aW9uOwogfQogCi12b2lkIFdU Rkludm9rZUNyYXNoSG9vaygpCitzdGF0aWMgdm9pZCBpbnZva2VDcmFzaEhvb2soKQogewogICAg IGlmIChnbG9iYWxIb29rKQogICAgICAgICBnbG9iYWxIb29rKCk7CiB9CiAKK3ZvaWQgV1RGQ3Jh c2goKQoreworICAgIGludm9rZUNyYXNoSG9vaygpOworICAgIFdURlJlcG9ydEJhY2t0cmFjZSgp OworICAgICgqKGludCAqKSh1aW50cHRyX3QpMHhiYmFkYmVlZiA9IDApOworI2lmIENPTVBJTEVS KENMQU5HKQorICAgIF9fYnVpbHRpbl90cmFwKCk7CisjZWxzZQorICAgICgodm9pZCgqKSgpKTAp KCk7CisjZW5kaWYKK30KKwogI2lmIEhBVkUoU0lHTkFMX0gpCiBzdGF0aWMgTk9fUkVUVVJOIHZv aWQgZHVtcEJhY2t0cmFjZVNpZ25hbEhhbmRsZXIoaW50IHNpZykKIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaApp bmRleCA2MjYzZTUwZWQ5MWI3MmFiYjhiNGVhOGMyOWY0ODE0YzQ1YjBjYjU3Li5iM2VmOGFmM2Nh Y2Y4MTZiNTBkMGI1YzcxZmYyNTg0MDJlY2FiM2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC0xNTEs NyArMTUxLDYgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGUHJpbnRCYWNrdHJhY2Uodm9p ZCoqIHN0YWNrLCBpbnQgc2l6ZSk7CiAKIHR5cGVkZWYgdm9pZCAoKldURkNyYXNoSG9va0Z1bmN0 aW9uKSgpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGU2V0Q3Jhc2hIb29rKFdURkNyYXNo SG9va0Z1bmN0aW9uKTsKLVdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURkludm9rZUNyYXNoSG9v aygpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFjZU9u Q3Jhc2hIb29rKCk7CiAKICNpZmRlZiBfX2NwbHVzcGx1cwpAQCAtMTY2LDI5ICsxNjUsMjMgQEAg V1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFjZU9uQ3Jhc2hI b29rKCk7CiAKICAgIFNpZ25hbHMgYXJlIGlnbm9yZWQgYnkgdGhlIGNyYXNoIHJlcG9ydGVyIG9u IE9TIFggc28gd2UgbXVzdCBkbyBiZXR0ZXIuCiAqLwotI2lmbmRlZiBDUkFTSAotI2lmIENPTVBJ TEVSKENMQU5HKQotI2RlZmluZSBDUkFTSCgpIFwKLSAgICAoV1RGUmVwb3J0QmFja3RyYWNlKCks IFwKLSAgICAgV1RGSW52b2tlQ3Jhc2hIb29rKCksIFwKLSAgICAgKCooaW50ICopKHVpbnRwdHJf dCkweGJiYWRiZWVmID0gMCksIFwKLSAgICAgX19idWlsdGluX3RyYXAoKSkKLSNlbHNlCi0jZGVm aW5lIENSQVNIKCkgXAotICAgIChXVEZSZXBvcnRCYWNrdHJhY2UoKSwgXAotICAgICBXVEZJbnZv a2VDcmFzaEhvb2soKSwgXAotICAgICAoKihpbnQgKikodWludHB0cl90KTB4YmJhZGJlZWYgPSAw KSwgXAotICAgICAoKHZvaWQoKikoKSkwKSgpIC8qIE1vcmUgcmVsaWFibGUsIGJ1dCBkb2Vzbid0 IHNheSBCQkFEQkVFRiAqLyBcCi0gICAgKQotI2VuZGlmCi0jZW5kaWYKLQogI2lmIENPTVBJTEVS KENMQU5HKQogI2RlZmluZSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIE5PX1JFVFVSTgogI2Vsc2UK ICNkZWZpbmUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSAogI2VuZGlmCiAKKyNpZm5kZWYgQ1JBU0gK KyNkZWZpbmUgQ1JBU0goKSBXVEZDcmFzaCgpCisjZW5kaWYKKworI2lmZGVmIF9fY3BsdXNwbHVz CitleHRlcm4gIkMiIHsKKyNlbmRpZgorV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGQ3Jhc2go KSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIOworI2lmZGVmIF9fY3BsdXNwbHVzCit9CisjZW5kaWYK IAogLyogQkFDS1RSQUNFCiAK 201451 2013-05-11 00:26:30 -0700 2013-05-16 12:02:39 -0700 Patch bug-115782-20130511002532.patch text/plain 4289 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc3ZDJmYmRmMzEyMmM5ODY5NjgzMTYw ZmYxMzI1MDJkYWU1MGMwNGEuLmZiNDFkYTRjOWYzZTU0ZDA3YzI5YTAyYTg0NTc5NWUxMTY2Yzli MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDUtMTEgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIHByb3Blcmx5IG9uIGlPUworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzgyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgSW1wcm92ZSBjcmFzaCBo YW5kbGluZy4gPHJkYXI6Ly9wcm9ibGVtLzEzODQyNzcxPgorCisgICAgICAgICogd3RmL0Fzc2Vy dGlvbnMuY3BwOgorICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMTMtMDUtMTAgIExh c3psbyBHb21ib3MgIDxsLmdvbWJvc0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgVVNF KE9TX1JBTkRPTU5FU1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlRXhwb3J0cy5kZWYg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlRXhwb3J0cy5kZWYKaW5kZXggM2U5YzZjZTYxZjRhZjJhNTM1ZWNh MzllZDRiNmQ1MDdkNDA2MzViNC4uMGMxN2JjZjdjZmE0NjY5ZTM0MzllOGVmMzVlZDIzODQ0OWFh MzdlZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZj cHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZUV4cG9ydHMuZGVmCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmVFeHBvcnRzLmRlZgpAQCAtNTUzLDggKzU1Myw4IEBAIEVYUE9SVFMKICAgICA/ d3JpdGVCYXJyaWVyQEhhbmRsZVNldEBKU0NAQFFBRVhQQVZKU1ZhbHVlQDJAQUJWMzJAQFoKICAg ICA/eWllbGRAV1RGQEBZQVhYWgogICAgID96ZXJvVGltZUBNZWRpYVRpbWVAV1RGQEBTQUFCVjEy QFhaCisgICAgV1RGQ3Jhc2gKICAgICBXVEZHZXRCYWNrdHJhY2UKLSAgICBXVEZJbnZva2VDcmFz aEhvb2sKICAgICBXVEZMb2cKICAgICBXVEZMb2dBbHdheXMKICAgICBXVEZMb2dWZXJib3NlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9K YXZhU2NyaXB0Q29yZUV4cG9ydEdlbmVyYXRvci9KYXZhU2NyaXB0Q29yZUV4cG9ydHMuZGVmLmlu IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlw dENvcmVFeHBvcnRHZW5lcmF0b3IvSmF2YVNjcmlwdENvcmVFeHBvcnRzLmRlZi5pbgppbmRleCAx Y2JhMThhZWNmYzhiZGJhZmQ1YzM4ZjVkNWMyM2RlZmViZDIxMzQ2Li4zMzQ5OTdlNTQ3YTM3MWZm Y2MwY2Y2YzRjN2Q5Y2RkNzQ1MzI1NWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZUV4cG9ydEdlbmVyYXRvci9K YXZhU2NyaXB0Q29yZUV4cG9ydHMuZGVmLmluCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlRXhwb3J0R2VuZXJhdG9yL0phdmFT Y3JpcHRDb3JlRXhwb3J0cy5kZWYuaW4KQEAgLTU1Miw4ICs1NTIsOCBAQCBFWFBPUlRTCiAgICAg P3dyaXRlQmFycmllckBIYW5kbGVTZXRASlNDQEBRQUVYUEFWSlNWYWx1ZUAyQEFCVjMyQEBaCiAg ICAgP3lpZWxkQFdURkBAWUFYWFoKICAgICA/emVyb1RpbWVATWVkaWFUaW1lQFdURkBAU0FBQlYx MkBYWgorICAgIFdURkNyYXNoCiAgICAgV1RGR2V0QmFja3RyYWNlCi0gICAgV1RGSW52b2tlQ3Jh c2hIb29rCiAgICAgV1RGTG9nCiAgICAgV1RGTG9nQWx3YXlzCiAgICAgV1RGTG9nVmVyYm9zZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0 Zi9Bc3NlcnRpb25zLmNwcAppbmRleCBiZTY1OGZhOTU4OGMxNTYxM2ViOTY1MTgzNThmMGI1MDg0 NjM2N2JhLi5iMDZmNWNjNmRiNjU5MTE2NzkwZTJhNDg4ZGQ0YWJlZjIxYjc2NGY0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9B c3NlcnRpb25zLmNwcApAQCAtMzI2LDEwICszMjYsMTkgQEAgdm9pZCBXVEZTZXRDcmFzaEhvb2so V1RGQ3Jhc2hIb29rRnVuY3Rpb24gZnVuY3Rpb24pCiAgICAgZ2xvYmFsSG9vayA9IGZ1bmN0aW9u OwogfQogCi12b2lkIFdURkludm9rZUNyYXNoSG9vaygpCit2b2lkIFdURkNyYXNoKCkKIHsKICAg ICBpZiAoZ2xvYmFsSG9vaykKICAgICAgICAgZ2xvYmFsSG9vaygpOworCisgICAgV1RGUmVwb3J0 QmFja3RyYWNlKCk7CisgICAgKihpbnQgKikodWludHB0cl90KTB4YmJhZGJlZWYgPSAwOworICAg IC8vIE1vcmUgcmVsaWFibGUsIGJ1dCBkb2Vzbid0IHNheSBCQkFEQkVFRi4KKyNpZiBDT01QSUxF UihDTEFORykKKyAgICBfX2J1aWx0aW5fdHJhcCgpOworI2Vsc2UKKyAgICAoKHZvaWQoKikoKSkw KSgpOworI2VuZGlmCiB9CiAKICNpZiBIQVZFKFNJR05BTF9IKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvQXNzZXJ0aW9ucy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCmluZGV4 IDYyNjNlNTBlZDkxYjcyYWJiOGI0ZWE4YzI5ZjQ4MTRjNDViMGNiNTcuLmIzZWY4YWYzY2FjZjgx NmI1MGQwYjVjNzFmZjI1ODQwMmVjYWIzYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fz c2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTE1MSw3ICsx NTEsNiBAQCBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZQcmludEJhY2t0cmFjZSh2b2lkKiog c3RhY2ssIGludCBzaXplKTsKIAogdHlwZWRlZiB2b2lkICgqV1RGQ3Jhc2hIb29rRnVuY3Rpb24p KCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZTZXRDcmFzaEhvb2soV1RGQ3Jhc2hIb29r RnVuY3Rpb24pOwotV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW52b2tlQ3Jhc2hIb29rKCk7 CiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZJbnN0YWxsUmVwb3J0QmFja3RyYWNlT25DcmFz aEhvb2soKTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCkBAIC0xNjYsMjkgKzE2NSwyMyBAQCBXVEZf RVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZJbnN0YWxsUmVwb3J0QmFja3RyYWNlT25DcmFzaEhvb2so KTsKIAogICAgU2lnbmFscyBhcmUgaWdub3JlZCBieSB0aGUgY3Jhc2ggcmVwb3J0ZXIgb24gT1Mg WCBzbyB3ZSBtdXN0IGRvIGJldHRlci4KICovCi0jaWZuZGVmIENSQVNICi0jaWYgQ09NUElMRVIo Q0xBTkcpCi0jZGVmaW5lIENSQVNIKCkgXAotICAgIChXVEZSZXBvcnRCYWNrdHJhY2UoKSwgXAot ICAgICBXVEZJbnZva2VDcmFzaEhvb2soKSwgXAotICAgICAoKihpbnQgKikodWludHB0cl90KTB4 YmJhZGJlZWYgPSAwKSwgXAotICAgICBfX2J1aWx0aW5fdHJhcCgpKQotI2Vsc2UKLSNkZWZpbmUg Q1JBU0goKSBcCi0gICAgKFdURlJlcG9ydEJhY2t0cmFjZSgpLCBcCi0gICAgIFdURkludm9rZUNy YXNoSG9vaygpLCBcCi0gICAgICgqKGludCAqKSh1aW50cHRyX3QpMHhiYmFkYmVlZiA9IDApLCBc Ci0gICAgICgodm9pZCgqKSgpKTApKCkgLyogTW9yZSByZWxpYWJsZSwgYnV0IGRvZXNuJ3Qgc2F5 IEJCQURCRUVGICovIFwKLSAgICApCi0jZW5kaWYKLSNlbmRpZgotCiAjaWYgQ09NUElMRVIoQ0xB TkcpCiAjZGVmaW5lIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggTk9fUkVUVVJOCiAjZWxzZQogI2Rl ZmluZSBOT19SRVRVUk5fRFVFX1RPX0NSQVNICiAjZW5kaWYKIAorI2lmbmRlZiBDUkFTSAorI2Rl ZmluZSBDUkFTSCgpIFdURkNyYXNoKCkKKyNlbmRpZgorCisjaWZkZWYgX19jcGx1c3BsdXMKK2V4 dGVybiAiQyIgeworI2VuZGlmCitXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZDcmFzaCgpIE5P X1JFVFVSTl9EVUVfVE9fQ1JBU0g7CisjaWZkZWYgX19jcGx1c3BsdXMKK30KKyNlbmRpZgogCiAv KiBCQUNLVFJBQ0UKIAo=