115770 2013-05-07 19:33:12 -0700 Remove unused method and de-virtualize others in Element.h 2013-05-08 00:57:34 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa andersca benjamin cmarcelo commit-queue esprehn+autocc kling koivisto oldest_to_newest 886108 0 rniwa 2013-05-07 19:33:12 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49 The de-virtualization possibilities were noted whilst "FINALizing" the Node hierarchy. If a method is successfully marked FINAL but then fails when marked OVERRIDE as well, the method by definition does not need to be virtual. 886109 1 201017 rniwa 2013-05-07 19:34:20 -0700 Created attachment 201017 Cleanup 886203 2 201017 commit-queue 2013-05-08 00:57:31 -0700 Comment on attachment 201017 Cleanup Clearing flags on attachment: 201017 Committed r149718: <http://trac.webkit.org/changeset/149718> 886204 3 commit-queue 2013-05-08 00:57:34 -0700 All reviewed patches have been landed. Closing bug. 201017 2013-05-07 19:34:20 -0700 2013-05-08 00:57:31 -0700 Cleanup bug-115770-20130507193326.patch text/plain 2587 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTcwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA1LTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgbWV0aG9k IGFuZCBkZS12aXJ0dWFsaXplIG90aGVycyBpbiBFbGVtZW50LmgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTc3MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lcmdlIGh0dHBzOi8vY2hyb21pdW0uZ29v Z2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rL2MyYzJmZjljYjY5ZjQ2ZjVjYzlkMjg5YjJi ZmJkYjhhYjViZDNlNDkKKworICAgICAgICBUaGUgZGUtdmlydHVhbGl6YXRpb24gcG9zc2liaWxp dGllcyB3ZXJlIG5vdGVkIHdoaWxzdCAiRklOQUxpemluZyIgdGhlIE5vZGUKKyAgICAgICAgaGll cmFyY2h5LiBJZiBhIG1ldGhvZCBpcyBzdWNjZXNzZnVsbHkgbWFya2VkIEZJTkFMIGJ1dCB0aGVu IGZhaWxzIHdoZW4gbWFya2VkCisgICAgICAgIE9WRVJSSURFIGFzIHdlbGwsIHRoZSBtZXRob2Qg YnkgZGVmaW5pdGlvbiBkb2VzIG5vdCBuZWVkIHRvIGJlIHZpcnR1YWwuCisKKyAgICAgICAgKiBX ZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6aGFzQXV0aG9yU2hhZG93Um9vdCk6CisKIDIwMTMtMDUtMDcgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTZWxlY3RSdWxlRmVh dHVyZVNldApJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9uIDE0OTcwNCkKKysrIFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xNjA5LDYgKzE2 MDksNyBAQCBfX1pOSzdXZWJDb3JlN0VsZW1lbnQxMmdldEF0dHJpYnV0ZUVSS04zCiBfX1pOSzdX ZWJDb3JlN0VsZW1lbnQxMmdldEF0dHJpYnV0ZUVSS05TXzEzUXVhbGlmaWVkTmFtZUUKIF9fWk5L N1dlYkNvcmU3RWxlbWVudDEyaGFzQXR0cmlidXRlRVJLTjNXVEYxMkF0b21pY1N0cmluZ0UKIF9f Wk5LN1dlYkNvcmU3RWxlbWVudDEzcHNldWRvRWxlbWVudEVOU184UHNldWRvSWRFCitfX1pOSzdX ZWJDb3JlN0VsZW1lbnQyNWNvbnRhaW5zRnVsbFNjcmVlbkVsZW1lbnRFdgogX19aTks3V2ViQ29y ZTdFbGVtZW50NnNoYWRvd0V2CiBfX1pOSzdXZWJDb3JlN0ludFJlY3QxMGludGVyc2VjdHNFUktT MF8KIF9fWk5LN1dlYkNvcmU3SW50UmVjdDhjb250YWluc0VSS1MwXwpJbmRleDogU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5oCShyZXZpc2lvbiAxNDk3MDQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5o CSh3b3JraW5nIGNvcHkpCkBAIC00MTgsNyArNDE4LDYgQEAgcHVibGljOgogICAgIFNoYWRvd1Jv b3QqIGF1dGhvclNoYWRvd1Jvb3QoKSBjb25zdDsKIAogICAgIGJvb2wgaGFzQXV0aG9yU2hhZG93 Um9vdCgpIGNvbnN0IHsgcmV0dXJuIGF1dGhvclNoYWRvd1Jvb3QoKTsgfQotICAgIHZpcnR1YWwg dm9pZCB3aWxsQWRkQXV0aG9yU2hhZG93Um9vdCgpIHsgfQogCiAgICAgU2hhZG93Um9vdCogdXNl ckFnZW50U2hhZG93Um9vdCgpIGNvbnN0OwogICAgIFNoYWRvd1Jvb3QqIGVuc3VyZVVzZXJBZ2Vu dFNoYWRvd1Jvb3QoKTsKQEAgLTU4OCw5ICs1ODcsOSBAQCBwdWJsaWM6CiAgICAgfTsKICAgICAK ICAgICB2b2lkIHdlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKHVuc2lnbmVkIHNob3J0IGZsYWdzKTsK LSAgICB2aXJ0dWFsIGJvb2wgY29udGFpbnNGdWxsU2NyZWVuRWxlbWVudCgpIGNvbnN0OwotICAg IHZpcnR1YWwgdm9pZCBzZXRDb250YWluc0Z1bGxTY3JlZW5FbGVtZW50KGJvb2wpOwotICAgIHZp cnR1YWwgdm9pZCBzZXRDb250YWluc0Z1bGxTY3JlZW5FbGVtZW50T25BbmNlc3RvcnNDcm9zc2lu Z0ZyYW1lQm91bmRhcmllcyhib29sKTsKKyAgICBib29sIGNvbnRhaW5zRnVsbFNjcmVlbkVsZW1l bnQoKSBjb25zdDsKKyAgICB2b2lkIHNldENvbnRhaW5zRnVsbFNjcmVlbkVsZW1lbnQoYm9vbCk7 CisgICAgdm9pZCBzZXRDb250YWluc0Z1bGxTY3JlZW5FbGVtZW50T25BbmNlc3RvcnNDcm9zc2lu Z0ZyYW1lQm91bmRhcmllcyhib29sKTsKIAogICAgIC8vIFczQyBBUEkKICAgICB2b2lkIHdlYmtp dFJlcXVlc3RGdWxsc2NyZWVuKCk7Cg==