115753 2013-05-07 13:43:15 -0700 Still possible to fire paint-related LayoutMilestones before CA has committed the changes 2013-05-28 21:57:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin commit-queue esprehn+autocc glenn simon.fraser thorton oldest_to_newest 885947 0 bdakin 2013-05-07 13:43:15 -0700 It is still possible to fire paint-related LayoutMilestones before CA has committed the changes. To ensure we wait for the commit, we should wait until the end of the runloop with a zero-delay timer. <rdar://problem/13822315> 885950 1 200968 bdakin 2013-05-07 13:45:45 -0700 Created attachment 200968 Patch 885954 2 200968 thorton 2013-05-07 13:51:56 -0700 Comment on attachment 200968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200968&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::RenderLayerCompositor::firePaintRelatedMilestonesTimerFired): What a bizarre name, with fire in it twice :) 885957 3 200971 bdakin 2013-05-07 14:02:34 -0700 Created attachment 200971 Patch Tim has a good point. Here's a patch with a better name. 885961 4 bdakin 2013-05-07 14:12:36 -0700 Thank you, Simon! http://trac.webkit.org/changeset/149691 894661 5 200971 simon.fraser 2013-05-28 21:56:10 -0700 Comment on attachment 200971 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200971&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:377 > + if (!m_paintRelatedMilestonesTimer.isActive()) > + m_paintRelatedMilestonesTimer.startOneShot(0); This made it so that _every_ layer flush we start a timer, which most of the time does nothing :( 894663 6 simon.fraser 2013-05-28 21:57:08 -0700 Filed bug 116908. 200968 2013-05-07 13:45:45 -0700 2013-05-07 14:02:34 -0700 Patch for-review.txt text/plain 3681 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTY4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA1LTA3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTdGlsbCBwb3NzaWJsZSB0byBmaXJl IHBhaW50LXJlbGF0ZWQgTGF5b3V0TWlsZXN0b25lcyBiZWZvcmUgQ0EgaGFzIGNvbW1pdHRlZCB0 aGUgCisgICAgICAgIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNTc1MworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xMzgyMjMxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUbyBlbnN1cmUgd2Ugd2FpdCBmb3IgdGhlIENBIGNvbW1pdCwg d2Ugc2hvdWxkIHdhaXQgdW50aWwgdGhlIGVuZCBvZiB0aGUgcnVubG9vcCAKKyAgICAgICAgd2l0 aCBhIHplcm8tZGVsYXkgdGltZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6 UmVuZGVyTGF5ZXJDb21wb3NpdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29t cG9zaXRvcjo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyQ29tcG9zaXRvcjo6ZmlyZVBhaW50UmVsYXRlZE1pbGVzdG9uZXNUaW1lckZpcmVk KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuaDoKKyAgICAgICAgKFJlbmRlckxheWVyQ29tcG9zaXRvcik6CisKIDIwMTMtMDUt MDcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBUaGUg c3RvcmFnZSBkYXRhYmFzZSB0cmFja2VyIHNob3VsZCBrbm93IHdoZW4gZGF0YWJhc2VzIGNvbWUg YW5kIGdvCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTQ5Njc4KQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNCw2 ICsyMTQsNyBAQCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OlJlbmRlckxheWVyQ29tcG9zCiAgICAg LCBtX2xheWVyRmx1c2hUaHJvdHRsaW5nRW5hYmxlZChmYWxzZSkKICAgICAsIG1fbGF5ZXJGbHVz aFRocm90dGxpbmdUZW1wb3JhcmlseURpc2FibGVkRm9ySW50ZXJhY3Rpb24oZmFsc2UpCiAgICAg LCBtX2hhc1BlbmRpbmdMYXllckZsdXNoKGZhbHNlKQorICAgICwgbV9maXJlUGFpbnRSZWxhdGVk TWlsZXN0b25lc1RpbWVyKHRoaXMsICZSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZpcmVQYWludFJl bGF0ZWRNaWxlc3RvbmVzVGltZXJGaXJlZCkKICNpZiAhTE9HX0RJU0FCTEVECiAgICAgLCBtX3Jv b3RMYXllclVwZGF0ZUNvdW50KDApCiAgICAgLCBtX29ibGlnYXRlQ29tcG9zaXRlZExheWVyQ291 bnQoMCkKQEAgLTM3Miw4ICszNzMsOCBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Zmx1 c2hQZW5kaW5nCiAgICAgQVNTRVJUKG1fZmx1c2hpbmdMYXllcnMpOwogICAgIG1fZmx1c2hpbmdM YXllcnMgPSBmYWxzZTsKIAotICAgIGlmIChmcmFtZVZpZXcpCi0gICAgICAgIGZyYW1lVmlldy0+ ZmlyZVBhaW50UmVsYXRlZE1pbGVzdG9uZXMoKTsKKyAgICBpZiAoIW1fZmlyZVBhaW50UmVsYXRl ZE1pbGVzdG9uZXNUaW1lci5pc0FjdGl2ZSgpKQorICAgICAgICBtX2ZpcmVQYWludFJlbGF0ZWRN aWxlc3RvbmVzVGltZXIuc3RhcnRPbmVTaG90KDApOwogCiAgICAgaWYgKCFtX3ZpZXdwb3J0Q29u c3RyYWluZWRMYXllcnNOZWVkaW5nVXBkYXRlLmlzRW1wdHkoKSkgewogICAgICAgICBIYXNoU2V0 PFJlbmRlckxheWVyKj46OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fdmlld3BvcnRDb25zdHJhaW5l ZExheWVyc05lZWRpbmdVcGRhdGUuZW5kKCk7CkBAIC0zMTg4LDYgKzMxODksMTMgQEAgdm9pZCBS ZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVyRmx1c2hUaQogICAgIHNjaGVkdWxlTGF5ZXJGbHVz aE5vdygpOwogfQogCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZmlyZVBhaW50UmVsYXRl ZE1pbGVzdG9uZXNUaW1lckZpcmVkKFRpbWVyPFJlbmRlckxheWVyQ29tcG9zaXRvcj4qKQorewor ICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gbV9yZW5kZXJWaWV3ID8gbV9yZW5kZXJWaWV3LT5m cmFtZVZpZXcoKSA6IDA7CisgICAgaWYgKGZyYW1lVmlldykKKyAgICAgICAgZnJhbWVWaWV3LT5m aXJlUGFpbnRSZWxhdGVkTWlsZXN0b25lcygpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CiAKICNlbmRpZiAvLyBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCShyZXZpc2lv biAxNDk2NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM4NSw2ICszODUsOCBAQCBwcml2YXRlOgogICAgIHZv aWQgc3RhcnRMYXllckZsdXNoVGltZXJJZk5lZWRlZCgpOwogICAgIHZvaWQgbGF5ZXJGbHVzaFRp bWVyRmlyZWQoVGltZXI8UmVuZGVyTGF5ZXJDb21wb3NpdG9yPiopOwogCisgICAgdm9pZCBmaXJl UGFpbnRSZWxhdGVkTWlsZXN0b25lc1RpbWVyRmlyZWQoVGltZXI8UmVuZGVyTGF5ZXJDb21wb3Np dG9yPiopOworCiAjaWYgIUxPR19ESVNBQkxFRAogICAgIGNvbnN0IGNoYXIqIGxvZ1JlYXNvbnNG b3JDb21wb3NpdGluZyhjb25zdCBSZW5kZXJMYXllciopOwogICAgIHZvaWQgbG9nTGF5ZXJJbmZv KGNvbnN0IFJlbmRlckxheWVyKiwgaW50IGRlcHRoKTsKQEAgLTQ1MCw2ICs0NTIsOCBAQCBwcml2 YXRlOgogICAgIGJvb2wgbV9sYXllckZsdXNoVGhyb3R0bGluZ1RlbXBvcmFyaWx5RGlzYWJsZWRG b3JJbnRlcmFjdGlvbjsKICAgICBib29sIG1faGFzUGVuZGluZ0xheWVyRmx1c2g7CiAKKyAgICBU aW1lcjxSZW5kZXJMYXllckNvbXBvc2l0b3I+IG1fZmlyZVBhaW50UmVsYXRlZE1pbGVzdG9uZXNU aW1lcjsKKwogI2lmICFMT0dfRElTQUJMRUQKICAgICBpbnQgbV9yb290TGF5ZXJVcGRhdGVDb3Vu dDsKICAgICBpbnQgbV9vYmxpZ2F0ZUNvbXBvc2l0ZWRMYXllckNvdW50OyAvLyBjb3VudCBvZiBs YXllciB0aGF0IGhhdmUgdG8gYmUgY29tcG9zaXRlZC4K 200971 2013-05-07 14:02:34 -0700 2013-05-28 21:56:10 -0700 Patch for-review-2.txt text/plain 3649 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTY4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA1LTA3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTdGlsbCBwb3NzaWJsZSB0byBmaXJl IHBhaW50LXJlbGF0ZWQgTGF5b3V0TWlsZXN0b25lcyBiZWZvcmUgQ0EgaGFzIGNvbW1pdHRlZCB0 aGUgCisgICAgICAgIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNTc1MworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xMzgyMjMxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUbyBlbnN1cmUgd2Ugd2FpdCBmb3IgdGhlIENBIGNvbW1pdCwg d2Ugc2hvdWxkIHdhaXQgdW50aWwgdGhlIGVuZCBvZiB0aGUgcnVubG9vcCAKKyAgICAgICAgd2l0 aCBhIHplcm8tZGVsYXkgdGltZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6 UmVuZGVyTGF5ZXJDb21wb3NpdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29t cG9zaXRvcjo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyQ29tcG9zaXRvcjo6cGFpbnRSZWxhdGVkTWlsZXN0b25lc1RpbWVyRmlyZWQpOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5oOgorICAgICAgICAoUmVuZGVyTGF5ZXJDb21wb3NpdG9yKToKKwogMjAxMy0wNS0wNyAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFRoZSBzdG9y YWdlIGRhdGFiYXNlIHRyYWNrZXIgc2hvdWxkIGtub3cgd2hlbiBkYXRhYmFzZXMgY29tZSBhbmQg Z28KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCShyZXZpc2lvbiAxNDk2NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE0LDYgKzIx NCw3IEBAIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6UmVuZGVyTGF5ZXJDb21wb3MKICAgICAsIG1f bGF5ZXJGbHVzaFRocm90dGxpbmdFbmFibGVkKGZhbHNlKQogICAgICwgbV9sYXllckZsdXNoVGhy b3R0bGluZ1RlbXBvcmFyaWx5RGlzYWJsZWRGb3JJbnRlcmFjdGlvbihmYWxzZSkKICAgICAsIG1f aGFzUGVuZGluZ0xheWVyRmx1c2goZmFsc2UpCisgICAgLCBtX3BhaW50UmVsYXRlZE1pbGVzdG9u ZXNUaW1lcih0aGlzLCAmUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpwYWludFJlbGF0ZWRNaWxlc3Rv bmVzVGltZXJGaXJlZCkKICNpZiAhTE9HX0RJU0FCTEVECiAgICAgLCBtX3Jvb3RMYXllclVwZGF0 ZUNvdW50KDApCiAgICAgLCBtX29ibGlnYXRlQ29tcG9zaXRlZExheWVyQ291bnQoMCkKQEAgLTM3 Miw4ICszNzMsOCBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Zmx1c2hQZW5kaW5nCiAg ICAgQVNTRVJUKG1fZmx1c2hpbmdMYXllcnMpOwogICAgIG1fZmx1c2hpbmdMYXllcnMgPSBmYWxz ZTsKIAotICAgIGlmIChmcmFtZVZpZXcpCi0gICAgICAgIGZyYW1lVmlldy0+ZmlyZVBhaW50UmVs YXRlZE1pbGVzdG9uZXMoKTsKKyAgICBpZiAoIW1fcGFpbnRSZWxhdGVkTWlsZXN0b25lc1RpbWVy LmlzQWN0aXZlKCkpCisgICAgICAgIG1fcGFpbnRSZWxhdGVkTWlsZXN0b25lc1RpbWVyLnN0YXJ0 T25lU2hvdCgwKTsKIAogICAgIGlmICghbV92aWV3cG9ydENvbnN0cmFpbmVkTGF5ZXJzTmVlZGlu Z1VwZGF0ZS5pc0VtcHR5KCkpIHsKICAgICAgICAgSGFzaFNldDxSZW5kZXJMYXllcio+Ojpjb25z dF9pdGVyYXRvciBlbmQgPSBtX3ZpZXdwb3J0Q29uc3RyYWluZWRMYXllcnNOZWVkaW5nVXBkYXRl LmVuZCgpOwpAQCAtMzE4OCw2ICszMTg5LDEzIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9y OjpsYXllckZsdXNoVGkKICAgICBzY2hlZHVsZUxheWVyRmx1c2hOb3coKTsKIH0KIAordm9pZCBS ZW5kZXJMYXllckNvbXBvc2l0b3I6OnBhaW50UmVsYXRlZE1pbGVzdG9uZXNUaW1lckZpcmVkKFRp bWVyPFJlbmRlckxheWVyQ29tcG9zaXRvcj4qKQoreworICAgIEZyYW1lVmlldyogZnJhbWVWaWV3 ID0gbV9yZW5kZXJWaWV3ID8gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKSA6IDA7CisgICAgaWYg KGZyYW1lVmlldykKKyAgICAgICAgZnJhbWVWaWV3LT5maXJlUGFpbnRSZWxhdGVkTWlsZXN0b25l cygpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5oCShyZXZpc2lvbiAxNDk2NzgpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgJKHdvcmtpbmcgY29weSkKQEAg LTM4NSw2ICszODUsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgc3RhcnRMYXllckZsdXNoVGltZXJJ Zk5lZWRlZCgpOwogICAgIHZvaWQgbGF5ZXJGbHVzaFRpbWVyRmlyZWQoVGltZXI8UmVuZGVyTGF5 ZXJDb21wb3NpdG9yPiopOwogCisgICAgdm9pZCBwYWludFJlbGF0ZWRNaWxlc3RvbmVzVGltZXJG aXJlZChUaW1lcjxSZW5kZXJMYXllckNvbXBvc2l0b3I+Kik7CisKICNpZiAhTE9HX0RJU0FCTEVE CiAgICAgY29uc3QgY2hhciogbG9nUmVhc29uc0ZvckNvbXBvc2l0aW5nKGNvbnN0IFJlbmRlckxh eWVyKik7CiAgICAgdm9pZCBsb2dMYXllckluZm8oY29uc3QgUmVuZGVyTGF5ZXIqLCBpbnQgZGVw dGgpOwpAQCAtNDUwLDYgKzQ1Miw4IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2xheWVyRmx1c2hU aHJvdHRsaW5nVGVtcG9yYXJpbHlEaXNhYmxlZEZvckludGVyYWN0aW9uOwogICAgIGJvb2wgbV9o YXNQZW5kaW5nTGF5ZXJGbHVzaDsKIAorICAgIFRpbWVyPFJlbmRlckxheWVyQ29tcG9zaXRvcj4g bV9wYWludFJlbGF0ZWRNaWxlc3RvbmVzVGltZXI7CisKICNpZiAhTE9HX0RJU0FCTEVECiAgICAg aW50IG1fcm9vdExheWVyVXBkYXRlQ291bnQ7CiAgICAgaW50IG1fb2JsaWdhdGVDb21wb3NpdGVk TGF5ZXJDb3VudDsgLy8gY291bnQgb2YgbGF5ZXIgdGhhdCBoYXZlIHRvIGJlIGNvbXBvc2l0ZWQu Cg==