115732 2013-05-07 09:38:05 -0700 [Automake] Pass --no-demangle to the linker by default to get the mangled symbols 2013-05-08 00:03:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96514 1 zan zan gustavo oldest_to_newest 885790 0 zan 2013-05-07 09:38:05 -0700 [Automake] Pass --no-demangle to the linker by default to get the mangled symbols 885791 1 200921 zan 2013-05-07 09:47:39 -0700 Created attachment 200921 Patch 886007 2 200921 gustavo 2013-05-07 15:18:12 -0700 Comment on attachment 200921 Patch LGTM, except I'm worry it works in our jhbuilt environments just because it sets LDFLAGS, so your += works. If you could make sure it also works when no LDFLAGS are set in the environment, that would be great. 886172 3 zan 2013-05-07 23:59:41 -0700 It also works with no LDFLAGS present in the environment. Thanks for the review! 886174 4 200921 zan 2013-05-08 00:03:06 -0700 Comment on attachment 200921 Patch Clearing flags on attachment: 200921 Committed r149714: <http://trac.webkit.org/changeset/149714> 886175 5 zan 2013-05-08 00:03:13 -0700 All reviewed patches have been landed. Closing bug. 200921 2013-05-07 09:47:39 -0700 2013-05-08 00:03:06 -0700 Patch bug-115732-20130507184646.patch text/plain 1691 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjY3CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggMmViZTIxYWEzOWUzYmRhYjNhY2M5ODA4YzhlYzRkZmFhOWMyNThlNi4uZjVl YThiYjU3OTQyZTdhZTdiMDMxYTUwNGVjMzRhOTY5Njg0OGY1ZiAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTA3ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQXV0b21ha2VdIFBhc3Mg LS1uby1kZW1hbmdsZSB0byB0aGUgbGlua2VyIGJ5IGRlZmF1bHQgdG8gZ2V0IHRoZSBtYW5nbGVk IHN5bWJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNTczMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogR05VbWFrZWZpbGUuYW06IFBhc3MgdGhlIC0tbm8tZGVtYW5nbGUgb3B0aW9uIHRvIHRoZSBs aW5rZXIgYnkgZGVmYXVsdC4gVGhpcyBpcyBkb25lIGJ5IGFwcGVuZGluZworICAgICAgICB0aGUg ZmxhZyB0byB0aGUgTERGTEFHUyB2YXJpYWJsZS4gV2hpbGUgdGhlIEFNX0xERkxBR1MgdmFyaWFi bGUgd291bGQgYmUgbW9yZSBhcHByb3ByaWF0ZSwgaXQncyBub3QKKyAgICAgICAgYXQgYWxsIHVz ZWQgd2hlbiBsaW5raW5nIGluc3RhbGxhYmxlIGxpYnJhcmllcyBsaWtlIGxpYndlYmtpdGd0ayBh bmQgbGlid2Via2l0Mmd0aywgc28gdGhlIExERkxBR1MKKyAgICAgICAgdmFyaWFibGUgaXMgdXNl ZCBpbnN0ZWFkLgorCiAyMDEzLTA1LTA2ICBNaWtlIExhdHRhbnppbyAgPG1sYXR0YW56aW9AYmxh Y2tiZXJyeS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEVuYWJsZSBhbmQgRXhwb3NlIFRl eHQgQXV0b3NpemluZyB0aHJvdWdoIEJsYWNrQmVycnk6OldlYktpdDo6V2ViU2V0dGluZ3MKZGlm ZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggNjk0MmQyMGM5 MTU0NDYzMWY3ODUwMDQ3YmQ1ODIzZGVjNmNhOTRkNC4uMTE5YTNlNThjNTQzZDI0MTE5MTc4N2Yw ZjYwMWJmNmEwZTVkYzJmZSAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFr ZWZpbGUuYW0KQEAgLTE3OCw2ICsxNzgsMTEgQEAgZ2xvYmFsX2NwcGZsYWdzICs9IFwKIAktREdD Q19JTlNUUlVNRU5UX1BST0dSQU1fRkxPV19BUkNTCiBlbmRpZgogCisjIERlZmF1bHQgdG8gb3V0 cHV0dGluZyBkZW1hbmdsZWQgc3ltYm9scyBpbiBjYXNlIG9mIHJlcG9ydGluZyB1bnJlc29sdmVk IHJlZmVyZW5jZXMgb3Igc2ltaWxhci4KKyMgVXNpbmcgQU1fTERGTEFHUyB3b3VsZCBiZSBtb3Jl IGFwcHJvcHJpYXRlIGhlcmUsIGJ1dCB0aGVzZSBhcmUgbm90IHVzZWQgYXQgYWxsIHdoZW4gbGlu a2luZyBpbnN0YWxsYWJsZSBsaWJyYXJpZXMKKyMgbGlrZSBsaWJ3ZWJraXRndGsgYW5kIGxpYndl YmtpdDJndGssIHNvIGFwcGVuZGluZyB0aGUgbGlua2VyIGZsYWcgdG8gdGhlIExERkxBR1MgdmFy aWFibGUgaXMgZG9uZSBpbnN0ZWFkLgorTERGTEFHUyArPSAtV2wsLS1uby1kZW1hbmdsZQorCiBF WFRSQV9ESVNUICs9IFwKIAkkKHNyY2RpcikvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRl ciBcCiAJJChzcmNkaXIpL1NvdXJjZS9XZWJLaXQvTElDRU5TRQo=