115731 2013-05-07 09:28:17 -0700 Use OwnPtr instead of deleteAllValues for requests in PluginView 2013-05-07 19:40:23 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 73757 1 darin darin commit-queue oldest_to_newest 885780 0 darin 2013-05-07 09:28:17 -0700 Use OwnPtr instead of deleteAllValues for requests in PluginView 885784 1 200918 darin 2013-05-07 09:32:08 -0700 Created attachment 200918 Patch 886110 2 200918 commit-queue 2013-05-07 19:40:21 -0700 Comment on attachment 200918 Patch Clearing flags on attachment: 200918 Committed r149709: <http://trac.webkit.org/changeset/149709> 886111 3 commit-queue 2013-05-07 19:40:23 -0700 All reviewed patches have been landed. Closing bug. 200918 2013-05-07 09:32:08 -0700 2013-05-07 19:40:21 -0700 Patch bug-115731-20130507093114.patch text/plain 4079 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRhMzBjMDRhMDNjM2Zj YjhiZWEwMzE4ZTAwYTk0YWZjMzVkNGJiNi4uOWNmMTE3OTE1Y2E4NGIzZDVhOGUxYjBiOTM2N2Uw MjA4OGFhZGYxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTA3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgT3duUHRyIGluc3RlYWQg b2YgZGVsZXRlQWxsVmFsdWVzIGZvciByZXF1ZXN0cyBpbiBQbHVnaW5WaWV3CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU3MzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojp+UGx1Z2luVmlldyk6IFJlbW92 ZWQgdGhlIGNhbGwgdG8gZGVsZXRlQWxsVmFsdWVzLgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu Vmlldzo6cmVxdWVzdFRpbWVyRmlyZWQpOiBVc2UgcmVsZWFzZSB0byByZW1vdmUgYW4gT3duUHRy CisgICAgICAgIGZyb20gbV9yZXF1ZXN0cyByYXRoZXIgdGhhbiBhbiBleHBsaWNpdCBkZWxldGUu IEFsc28gdXNlICFpc0VtcHR5IGluc3RlYWQKKyAgICAgICAgb2Ygc2l6ZSA+IDAuCisgICAgICAg IChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzY2hlZHVsZVJlcXVlc3QpOiBDaGFuZ2VkIGFyZ3VtZW50 IHR5cGUgdG8gUGFzc093blB0ci4KKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OmxvYWQp OiBVc2UgYWRvcHRQdHIgdG8gY2FsbCBzY2hlZHVsZVJlcXVlc3QuCisKKyAgICAgICAgKiBwbHVn aW5zL1BsdWdpblZpZXcuaDogQ2hhbmdlZCBhcmd1bWVudCB0eXBlIG9mIHNjaGVkdWxlUmVxdWVz dCB0bworICAgICAgICBQYXNzT3duUHRyLCBhbmQgbV9yZXF1ZXN0cyB0byBhIFZlY3RvcjxPd25Q dHI+LgorCiAyMDEzLTA1LTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3ZlIEFsd2F5c0lubGluZS5oIGZyb20gV1RGCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRleCAwMTEyYWU4MGY0NDc3YzE5ZDViYTQ4YTdiM2Q1YjFi Mzk5NmQ1YzJiLi45MmE4MzkwNDQzNTVkNzNiODljODJjZGNjZjFlNjcyZmUwMTdjMDRmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTMwMyw4ICszMDMsNiBAQCBQbHVn aW5WaWV3Ojp+UGx1Z2luVmlldygpCiAKICAgICBzdG9wKCk7CiAKLSAgICBkZWxldGVBbGxWYWx1 ZXMobV9yZXF1ZXN0cyk7Ci0KICAgICBmcmVlU3RyaW5nQXJyYXkobV9wYXJhbU5hbWVzLCBtX3Bh cmFtQ291bnQpOwogICAgIGZyZWVTdHJpbmdBcnJheShtX3BhcmFtVmFsdWVzLCBtX3BhcmFtQ291 bnQpOwogCkBAIC00ODYsMjIgKzQ4NCwyMSBAQCB2b2lkIFBsdWdpblZpZXc6OnBlcmZvcm1SZXF1 ZXN0KFBsdWdpblJlcXVlc3QqIHJlcXVlc3QpCiB2b2lkIFBsdWdpblZpZXc6OnJlcXVlc3RUaW1l ckZpcmVkKFRpbWVyPFBsdWdpblZpZXc+KiB0aW1lcikKIHsKICAgICBBU1NFUlRfVU5VU0VEKHRp bWVyLCB0aW1lciA9PSAmbV9yZXF1ZXN0VGltZXIpOwotICAgIEFTU0VSVChtX3JlcXVlc3RzLnNp emUoKSA+IDApOworICAgIEFTU0VSVCghbV9yZXF1ZXN0cy5pc0VtcHR5KCkpOwogICAgIEFTU0VS VCghbV9pc0phdmFTY3JpcHRQYXVzZWQpOwogCi0gICAgUGx1Z2luUmVxdWVzdCogcmVxdWVzdCA9 IG1fcmVxdWVzdHNbMF07CisgICAgT3duUHRyPFBsdWdpblJlcXVlc3Q+IHJlcXVlc3QgPSBtX3Jl cXVlc3RzWzBdLnJlbGVhc2UoKTsKICAgICBtX3JlcXVlc3RzLnJlbW92ZSgwKTsKICAgICAKICAg ICAvLyBTY2hlZHVsZSBhIG5ldyByZXF1ZXN0IGJlZm9yZSBjYWxsaW5nIHBlcmZvcm1SZXF1ZXN0 IHNpbmNlIHRoZSBjYWxsIHRvCiAgICAgLy8gcGVyZm9ybVJlcXVlc3QgY2FuIGNhdXNlIHRoZSBw bHVnaW4gdmlldyB0byBiZSBkZWxldGVkLgotICAgIGlmIChtX3JlcXVlc3RzLnNpemUoKSA+IDAp CisgICAgaWYgKCFtX3JlcXVlc3RzLmlzRW1wdHkoKSkKICAgICAgICAgbV9yZXF1ZXN0VGltZXIu c3RhcnRPbmVTaG90KDApOwogCi0gICAgcGVyZm9ybVJlcXVlc3QocmVxdWVzdCk7Ci0gICAgZGVs ZXRlIHJlcXVlc3Q7CisgICAgcGVyZm9ybVJlcXVlc3QocmVxdWVzdC5nZXQoKSk7CiB9CiAKLXZv aWQgUGx1Z2luVmlldzo6c2NoZWR1bGVSZXF1ZXN0KFBsdWdpblJlcXVlc3QqIHJlcXVlc3QpCit2 b2lkIFBsdWdpblZpZXc6OnNjaGVkdWxlUmVxdWVzdChQYXNzT3duUHRyPFBsdWdpblJlcXVlc3Q+ IHJlcXVlc3QpCiB7CiAgICAgbV9yZXF1ZXN0cy5hcHBlbmQocmVxdWVzdCk7CiAKQEAgLTUzNyw4 ICs1MzQsNyBAQCBOUEVycm9yIFBsdWdpblZpZXc6OmxvYWQoY29uc3QgRnJhbWVMb2FkUmVxdWVz dCYgZnJhbWVMb2FkUmVxdWVzdCwgYm9vbCBzZW5kTm90aQogICAgIH0gZWxzZSBpZiAoIW1fcGFy ZW50RnJhbWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCktPmNhbkRpc3BsYXkodXJsKSkK ICAgICAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CiAKLSAgICBQbHVnaW5SZXF1ZXN0 KiByZXF1ZXN0ID0gbmV3IFBsdWdpblJlcXVlc3QoZnJhbWVMb2FkUmVxdWVzdCwgc2VuZE5vdGlm aWNhdGlvbiwgbm90aWZ5RGF0YSwgYXJlUG9wdXBzQWxsb3dlZCgpKTsKLSAgICBzY2hlZHVsZVJl cXVlc3QocmVxdWVzdCk7CisgICAgc2NoZWR1bGVSZXF1ZXN0KGFkb3B0UHRyKG5ldyBQbHVnaW5S ZXF1ZXN0KGZyYW1lTG9hZFJlcXVlc3QsIHNlbmROb3RpZmljYXRpb24sIG5vdGlmeURhdGEsIGFy ZVBvcHVwc0FsbG93ZWQoKSkpKTsKIAogICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oIGIvU291cmNlL1dl YkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKaW5kZXggNWJmNTNhY2YzZGYyZTE1MmFlNjE0ZTc2 NzkyMzIwNmIzZjU1Yjk4Zi4uYmEzY2M3MWI2YzRlMDMyNmNiNWNmN2JlM2ZiNzU4NjdiMzRiM2M2 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKQEAgLTMwOCw3ICszMDgsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFZlY3RvcjxJbnRSZWN0PiBtX2ludmFsaWRSZWN0 czsKIAogICAgICAgICB2b2lkIHBlcmZvcm1SZXF1ZXN0KFBsdWdpblJlcXVlc3QqKTsKLSAgICAg ICAgdm9pZCBzY2hlZHVsZVJlcXVlc3QoUGx1Z2luUmVxdWVzdCopOworICAgICAgICB2b2lkIHNj aGVkdWxlUmVxdWVzdChQYXNzT3duUHRyPFBsdWdpblJlcXVlc3Q+KTsKICAgICAgICAgdm9pZCBy ZXF1ZXN0VGltZXJGaXJlZChUaW1lcjxQbHVnaW5WaWV3PiopOwogICAgICAgICB2b2lkIGludmFs aWRhdGVUaW1lckZpcmVkKFRpbWVyPFBsdWdpblZpZXc+Kik7CiAgICAgICAgIFRpbWVyPFBsdWdp blZpZXc+IG1fcmVxdWVzdFRpbWVyOwpAQCAtMzY5LDcgKzM2OSw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgVmVjdG9yPGJvb2wsIDQ+IG1fcG9wdXBTdGF0ZVN0YWNrOwogCiAgICAg ICAgIEhhc2hTZXQ8UmVmUHRyPFBsdWdpblN0cmVhbT4gPiBtX3N0cmVhbXM7Ci0gICAgICAgIFZl Y3RvcjxQbHVnaW5SZXF1ZXN0Kj4gbV9yZXF1ZXN0czsKKyAgICAgICAgVmVjdG9yPE93blB0cjxQ bHVnaW5SZXF1ZXN0PiA+IG1fcmVxdWVzdHM7CiAKICAgICAgICAgYm9vbCBtX2lzV2luZG93ZWQ7 CiAgICAgICAgIGJvb2wgbV9pc1RyYW5zcGFyZW50Owo=