115711 2013-05-06 22:12:54 -0700 REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal 2013-05-07 11:29:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa andersca andersca kling oldest_to_newest 885602 0 rniwa 2013-05-06 22:12:54 -0700 Comment #5 From Ryosuke Niwa 2013-05-06 21:55:31 PST (-) [reply] It appears that this patch broke WK2 bots: http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29?numbuilds=50 e.g. 16:33:53.229 46880 worker/1 accessibility/accessibility-node-memory-management.html crashed, (stderr lines): 16:33:53.229 46880 ASSERTION FAILED: !m_localStorageDirectory 16:33:53.229 46880 /Volumes/Data/slave/mountainlion-debug/build/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp(65) : void WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal(const WTF::String &) 16:33:53.229 46880 1 0x10b985093 WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal(WTF::String const&) 16:33:53.229 46880 2 0x10b98639a WTF::FunctionWrapper<void (WebKit::LocalStorageDatabaseTracker::*)(WTF::String const&)>::operator()(WebKit::LocalStorageDatabaseTracker*, WTF::String const&) 16:33:53.229 46880 3 0x10b98630c WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (WebKit::LocalStorageDatabaseTracker::*)(WTF::String const&)>, void (WebKit::LocalStorageDatabaseTracker*, WTF::String)>::operator()() 16:33:53.229 46880 4 0x10b6e3939 WTF::Function<void ()>::operator()() const 16:33:53.229 46880 5 0x10bb18be1 __dispatch_block_invoke_0 16:33:53.229 46880 6 0x7fff8c62bf01 _dispatch_call_block_and_release 16:33:53.229 46880 7 0x7fff8c6280b6 _dispatch_client_callout 16:33:53.229 46880 8 0x7fff8c62947f _dispatch_queue_drain 16:33:53.229 46880 9 0x7fff8c6292f1 _dispatch_queue_invoke 16:33:53.229 46880 10 0x7fff8c6291c3 _dispatch_worker_thread2 16:33:53.229 46880 11 0x7fff8d7f2d0b _pthread_wqthread 16:33:53.229 46880 12 0x7fff8d7dd1d1 start_wqthread I can reproduce this crash locally. 885607 1 rniwa 2013-05-06 22:20:34 -0700 Committed r149662: <http://trac.webkit.org/changeset/149662> 885854 2 200940 andersca 2013-05-07 11:19:45 -0700 Created attachment 200940 Patch 885867 3 200940 kling 2013-05-07 11:27:13 -0700 Comment on attachment 200940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200940&action=review Great. r=me > Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:64 > void LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal(const String& localStorageDirectory) > { Would it make sense to return early if m_localStorageDirectory == localStorageDirectory? 885871 4 andersca 2013-05-07 11:29:30 -0700 Committed r149683: <http://trac.webkit.org/changeset/149683> 200940 2013-05-07 11:19:45 -0700 2013-05-07 11:27:13 -0700 Patch bug-115711-20130507111852.patch text/plain 3193 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmYzMGI4M2ExOTVhN2U4 NzNjZWRlNzE0NzE2ODkwMjRlMDdjZWZlYS4uMWM2MGI4NDQ0MTg3NTAzYjdjZWZkNjk3MjBkMzUx MzAzMDYwZmYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTA3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTQ5NjQ3KTogQXNzZXJ0aW9uIGZhaWx1cmUgaW4gTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2Vy OjpzZXRMb2NhbFN0b3JhZ2VEaXJlY3RvcnlJbnRlcm5hbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3J0IFNRTGl0ZURhdGFiYXNlOjpjbG9zZS4K KworICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorCiAyMDEzLTA1LTA2ICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBhbiAnaXNSZWFkT25seScgbWVtYmVy IHRvIElETCBwYXJzZSB0cmVlIHN0cnVjdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDczZTBlMGU4ZWFlNmJi YjRhNTA2MmViY2Y0YmVkNDBlNjkzZjU0Y2MuLmFhOWZmZWQ5YzQ5MzcyZDk2ZDljZTMyMDgyMmU1 NmE1NmMyZTM0MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMy0wNS0wNyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04o cjE0OTY0Nyk6IEFzc2VydGlvbiBmYWlsdXJlIGluIExvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tl cjo6c2V0TG9jYWxTdG9yYWdlRGlyZWN0b3J5SW50ZXJuYWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTcxMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSBzZXR0aW5nIHRoZSBsb2NhbCBzdG9y YWdlIGRpcmVjdG9yeSBtb3JlIHRoYW4gb25jZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9TdG9y YWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Okxv Y2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlcjo6c2V0TG9jYWxTdG9yYWdlRGlyZWN0b3J5SW50ZXJu YWwpOgorICAgICAgICBDbG9zZSB0aGUgZGF0YWJhc2UgKGlmIG5lY2Vzc2FyeSkgYW5kIGNsZWFy IHRoZSBvcmlnaW5zIG1hcCBiZWZvcmUgaW1wb3J0aW5nIHRoZSBvcmlnaW4gaWRlbnRpZmllcnMu CisKKzIwMTMtMDUtMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwog ICAgICAgICBFYWNoIGxvY2FsIHN0b3JhZ2UgZGF0YWJhc2Ugc2hvdWxkIGtub3cgaXRzIG9yaWdp bgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzM3 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXggNDgwZGJjZWZmYjg4MzAyZjRhZTRmZjJkNjNiM2Q4 ODRjZmQ0Njk3Ny4uZDE2YTc4ZTQ0ZGM5MGU0YWY5Njg2NzZkOTQ1ZTBiODRiZmYzMTFmOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KQEAgLTM1MCw2ICszNTAsNyBAQCBfX1pON1dlYkNvcmUxNFJlc291 cmNlTG9hZGVyNmNhbmNlbEV2CiBfX1pON1dlYkNvcmUxNFNRTGl0ZURhdGFiYXNlMTF0YWJsZUV4 aXN0c0VSS04zV1RGNlN0cmluZ0UKIF9fWk43V2ViQ29yZTE0U1FMaXRlRGF0YWJhc2UxNGV4ZWN1 dGVDb21tYW5kRVJLTjNXVEY2U3RyaW5nRQogX19aTjdXZWJDb3JlMTRTUUxpdGVEYXRhYmFzZTRv cGVuRVJLTjNXVEY2U3RyaW5nRWIKK19fWk43V2ViQ29yZTE0U1FMaXRlRGF0YWJhc2U1Y2xvc2VF dgogX19aTjdXZWJDb3JlMTRTUUxpdGVEYXRhYmFzZUMxRXYKIF9fWk43V2ViQ29yZTE0U1FMaXRl RGF0YWJhc2VEMUV2CiBfX1pON1dlYkNvcmUxNFNjaGVtZVJlZ2lzdHJ5MjRyZWdpc3RlclVSTFNj aGVtZUFzTG9jYWxFUktOM1dURjZTdHJpbmdFCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNw cAppbmRleCA5MmMxMjdlZGViOWZkMzAwYzc2Njg1YjBmNzQ5MzBjNDJkYzkxN2YyLi40MDMyMTA2 YjRmYTFmOGExNTZlMWZlODhlNzc1OWZhNmM2MDk5M2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNl VHJhY2tlci5jcHAKQEAgLTYyLDcgKzYyLDExIEBAIFN0cmluZyBMb2NhbFN0b3JhZ2VEYXRhYmFz ZVRyYWNrZXI6OmRhdGFiYXNlRmlsZW5hbWUoU2VjdXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpCiAK IHZvaWQgTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOjpzZXRMb2NhbFN0b3JhZ2VEaXJlY3Rv cnlJbnRlcm5hbChjb25zdCBTdHJpbmcmIGxvY2FsU3RvcmFnZURpcmVjdG9yeSkKIHsKKyAgICBp ZiAobV9kYXRhYmFzZS5pc09wZW4oKSkKKyAgICAgICAgbV9kYXRhYmFzZS5jbG9zZSgpOworCiAg ICAgbV9sb2NhbFN0b3JhZ2VEaXJlY3RvcnkgPSBsb2NhbFN0b3JhZ2VEaXJlY3Rvcnk7CisgICAg bV9vcmlnaW5zLmNsZWFyKCk7CiAKICAgICBtX3F1ZXVlLT5kaXNwYXRjaChiaW5kKCZMb2NhbFN0 b3JhZ2VEYXRhYmFzZVRyYWNrZXI6OmltcG9ydE9yaWdpbklkZW50aWZpZXJzLCB0aGlzKSk7CiB9 Cg==