115709 2013-05-06 21:22:41 -0700 Invalid block doesn't make declaration invalid 2013-05-28 07:31:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 113401 116679 1 rniwa svillar commit-queue csaavedra darin dino esprehn+autocc glenn kling koivisto macpherson menard pfeldman svillar syoichi thorton tkent oldest_to_newest 885589 0 rniwa 2013-05-06 21:22:41 -0700 We should probably merge https://chromium.googlesource.com/chromium/blink/+/aad5495be789ff7e6791440465c8dc391ea5dfc3 894040 1 202986 svillar 2013-05-27 08:23:56 -0700 Created attachment 202986 Patch Not marking it for review as it depends on 113401 which is pending to be reviewed 894240 2 202986 svillar 2013-05-28 00:22:43 -0700 Comment on attachment 202986 Patch Setting the r? now that 113401 landed, it should make EWS happy. 894305 3 202986 kling 2013-05-28 04:43:06 -0700 Comment on attachment 202986 Patch Sweet! 894354 4 202986 svillar 2013-05-28 07:31:02 -0700 Comment on attachment 202986 Patch Clearing flags on attachment: 202986 Committed r150803: <http://trac.webkit.org/changeset/150803> 894355 5 svillar 2013-05-28 07:31:10 -0700 All reviewed patches have been landed. Closing bug. 202986 2013-05-27 08:23:56 -0700 2013-05-28 07:31:02 -0700 Patch bug-115709-20130527172236.patch text/plain 6688 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwNzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ0MTg5NWE2ZjE4Y2Jj NzExZWVkNmMxYzExNzJjZjJjZDdiODM5OS4uYjMwYmM4ODQzNmY2M2E1NWNlZTIwMGNkNTk2MjVm ZTI2YmVmODZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTA1LTI3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCisgICAgICAgIEludmFsaWQg YmxvY2sgZG9lc24ndCBtYWtlIGRlY2xhcmF0aW9uIGludmFsaWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTcwOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyb20gQmxpbmsgcjE0OTQ0NiBieSA8c2Vy eWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZGVkIGEgbmV3IHJ1bGUgImRlY2xhcmF0aW9u X3JlY292ZXJ5OiIgd2hpY2ggY292ZXJzIGFueSBraW5kIG9mCisgICAgICAgICJpbnZhbGlkX2Js b2NrX2xpc3QgbWF5YmVfc3BhY2UiIHNlcXVlbmNlLiBCeSBhcHBlbmRpbmcgdGhpcyBuZXcKKyAg ICAgICAgcnVsZSB0byBldmVyeSBydWxlIHJlZHVjdGFibGUgdG8gImRlY2xhcmF0aW9uOiIgd2Ug Y2FuIHJlbW92ZSBzb21lCisgICAgICAgIHJlZHVuZGFudCBydWxlcyBhbmQgaW1wcm92ZSBlcnJv ciByZWNvdmVyeSBvZiBzb21lIG90aGVycyB0aGF0CisgICAgICAgIHdlcmUgb25seSBhY2NlcHRp bmcgZXhhY3RseSBvbmUgZXJyb3IuCisKKyAgICAgICAgT25lIG9mIHRoZSBydWxlcyBiZWluZyBy ZW1vdmVkIHdhcyBwcmV2ZW50aW5nIGludmFsaWQgYmxvY2tzIGluIGEKKyAgICAgICAgZGVjbGFy YXRpb24gdG8gaW52YWxpZGF0ZSB0aGUgd2hvbGUgZGVjbGFyYXRpb24uIFRoZSBydWxlIHdhcwor ICAgICAgICByZXBvcnRpbmcgdGhlIHN5bnRheCBlcnJvciBidXQgYXQgdGhlIHNhbWUgdGltZSBh Y2NlcHRpbmcgdGhlCisgICAgICAgIGludmFsaWQgYmxvY2sgYXMgcGFydCBvZiBhIHZhbGlkIGRl Y2xhcmF0aW9uLgorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIueS5pbjoKKworMjAxMy0wNS0y NyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBFbmFibGUgQ1NTIGxvZ2dpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzQwMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTR3JhbW1hci55LmluIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIu eS5pbgppbmRleCAzN2IzZjIzMzIxMjNlOTg0ZWIxM2I0NGFlNzJjOWIwYTVmNTA5YTIyLi4wZjA3 OTAxODQ4NGMyMzMyOGJjZTVjMzI5ZGYxODU2YTUzZGZkMGMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NH cmFtbWFyLnkuaW4KQEAgLTg4LDkgKzg4LDkgQEAgc3RhdGljIGlubGluZSBib29sIGlzQ1NTVG9r ZW5BU3RyaW5nKGludCB5eXR5cGUpCiAlfQogCiAjaWYgRU5BQkxFX1NIQURPV19ET00KLSVleHBl Y3QgNjgKKyVleHBlY3QgNjUKICNlbHNlCi0lZXhwZWN0IDY3CislZXhwZWN0IDY0CiAjZW5kaWYK IAogJW5vbmFzc29jIExPV0VTVF9QUkVDCkBAIC0zMzYsNyArMzM2LDYgQEAgc3RhdGljIGlubGlu ZSBib29sIGlzQ1NTVG9rZW5BU3RyaW5nKGludCB5eXR5cGUpCiAldHlwZSA8c3RyaW5nPiBlbGVt ZW50X25hbWUKICV0eXBlIDxzdHJpbmc+IGF0dHJfbmFtZQogCi0ldHlwZSA8bG9jYXRpb24+IGVy cm9ycwogJXR5cGUgPGxvY2F0aW9uPiBlcnJvcl9sb2NhdGlvbgogCiAlJQpAQCAtMTU0NSwxNCAr MTU0NCw2IEBAIGRlY2xfbGlzdDoKICAgICAgICAgcGFyc2VyLT5tYXJrUHJvcGVydHlTdGFydCgp OwogICAgICAgICAkJCA9ICQxOwogICAgIH0KLSAgICB8IGRlY2xhcmF0aW9uIGVycm9yX2xvY2F0 aW9uIGludmFsaWRfYmxvY2tfbGlzdCBtYXliZV9zcGFjZSB7Ci0gICAgICAgIHBhcnNlci0+c3lu dGF4RXJyb3IoJDIpOwotICAgICAgICAkJCA9IGZhbHNlOwotICAgIH0KLSAgICB8IGRlY2xhcmF0 aW9uIGVycm9yX2xvY2F0aW9uIGludmFsaWRfYmxvY2tfbGlzdCAnOycgbWF5YmVfc3BhY2Ugewot ICAgICAgICBwYXJzZXItPnN5bnRheEVycm9yKCQyKTsKLSAgICAgICAgJCQgPSBmYWxzZTsKLSAg ICB9CiAgICAgfCBkZWNsX2xpc3RfcmVjb3ZlcnkgJzsnIG1heWJlX3NwYWNlIHsKICAgICAgICAg cGFyc2VyLT5tYXJrUHJvcGVydHlTdGFydCgpOwogICAgICAgICAkJCA9IGZhbHNlOwpAQCAtMTYw NCw1MSArMTU5NSwzNCBAQCBkZWNsYXJhdGlvbjoKICAgICAgICAgcGFyc2VyLT5tYXJrUHJvcGVy dHlFbmQoJDUsIGlzUHJvcGVydHlQYXJzZWQpOwogICAgIH0KICAgICB8Ci0gICAgcHJvcGVydHkg ZXJyb3JzIHsKLSAgICAgICAgcGFyc2VyLT5zeW50YXhFcnJvcigkMik7CisgICAgcHJvcGVydHkg ZGVjbGFyYXRpb25fcmVjb3ZlcnkgewogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KICAgICB8 Ci0gICAgcHJvcGVydHkgJzonIG1heWJlX3NwYWNlIGVycm9ycyBleHByIHByaW8gewotICAgICAg ICAvKiBUaGUgZGVmYXVsdCBtb3ZhYmxlIHR5cGUgdGVtcGxhdGUgaGFzIGxldHRlci1zcGFjaW5n OiAubm9uZTsgIEhhbmRsZSB0aGlzIGJ5IGxvb2tpbmcgZm9yCi0gICAgICAgIGVycm9yIHRva2Vu cyBhdCB0aGUgc3RhcnQgb2YgYW4gZXhwciwgcmVjb3ZlciB0aGUgZXhwciBhbmQgdGhlbiB0cmVh dCBhcyBhbiBlcnJvciwgY2xlYW5pbmcKLSAgICAgICAgdXAgYW5kIGRlbGV0aW5nIHRoZSBzaGlm dGVkIGV4cHIuICAqLwotICAgICAgICBwYXJzZXItPnN5bnRheEVycm9yKCQ0KTsKLSAgICAgICAg cGFyc2VyLT5tYXJrUHJvcGVydHlFbmQoZmFsc2UsIGZhbHNlKTsKLSAgICAgICAgJCQgPSBmYWxz ZTsKLSAgICB9Ci0gICAgfAotICAgIHByb3BlcnR5ICc6JyBtYXliZV9zcGFjZSBleHByIHByaW8g ZXJyb3IgeworICAgIHByb3BlcnR5ICc6JyBtYXliZV9zcGFjZSBleHByIHByaW8gZGVjbGFyYXRp b25fcmVjb3ZlcnkgewogICAgICAgICAvKiBXaGVuIHdlIGVuY291bnRlciBzb21ldGhpbmcgbGlr ZSBwIHtjb2xvcjogcmVkICFpbXBvcnRhbnQgZmFpbDt9IHdlIHNob3VsZCBkcm9wIHRoZSBkZWNs YXJhdGlvbiAqLwogICAgICAgICBwYXJzZXItPm1hcmtQcm9wZXJ0eUVuZChmYWxzZSwgZmFsc2Up OwogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KICAgICB8Ci0gICAgSU1QT1JUQU5UX1NZTSBt YXliZV9zcGFjZSBlcnJvcl9sb2NhdGlvbiB7CisgICAgSU1QT1JUQU5UX1NZTSBtYXliZV9zcGFj ZSBkZWNsYXJhdGlvbl9yZWNvdmVyeSB7CiAgICAgICAgIC8qIEhhbmRsZSB0aGlzIGNhc2U6IGRp diB7IHRleHQtYWxpZ246IGNlbnRlcjsgIWltcG9ydGFudCB9IEp1c3QgcmVkdWNlIGF3YXkgdGhl IHN0cmF5ICFpbXBvcnRhbnQuICovCi0gICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDMpOwog ICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KICAgICB8Ci0gICAgcHJvcGVydHkgJzonIG1heWJl X3NwYWNlIGVycm9yX2xvY2F0aW9uIHsKLSAgICAgICAgLyogZGl2IHsgZm9udC1mYW1pbHk6IH0g SnVzdCByZWR1Y2UgYXdheSB0aGlzIHByb3BlcnR5IHdpdGggbm8gdmFsdWUuICovCi0gICAgICAg IHBhcnNlci0+c3ludGF4RXJyb3IoJDQpOwotICAgICAgICBwYXJzZXItPm1hcmtQcm9wZXJ0eUVu ZChmYWxzZSwgZmFsc2UpOwotICAgICAgICAkJCA9IGZhbHNlOwotICAgIH0KLSAgICB8Ci0gICAg cHJvcGVydHkgJzonIG1heWJlX3NwYWNlIGVycm9ycyB7CisgICAgcHJvcGVydHkgJzonIG1heWJl X3NwYWNlIGRlY2xhcmF0aW9uX3JlY292ZXJ5IHsKICAgICAgICAgLyogaWYgd2UgY29tZSBhY3Jv c3MgcnVsZXMgd2l0aCBpbnZhbGlkIHZhbHVlcyBsaWtlIHRoaXMgY2FzZTogcCB7IHdlaWdodDog KjsgfSwganVzdCBkaXNjYXJkIHRoZSBydWxlICovCi0gICAgICAgIHBhcnNlci0+c3ludGF4RXJy b3IoJDQpOwogICAgICAgICBwYXJzZXItPm1hcmtQcm9wZXJ0eUVuZChmYWxzZSwgZmFsc2UpOwog ICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KLSAgICB8Ci0gICAgcHJvcGVydHkgZXJyb3JfbG9j YXRpb24gaW52YWxpZF9ibG9jayB7Ci0gICAgICAgIC8qIGlmIHdlIGNvbWUgYWNyb3NzOiBkaXYg eyBjb2xvcns7Y29sb3I6bWFyb29ufSB9LCBpZ25vcmUgZXZlcnl0aGluZyB3aXRoaW4gY3VybHkg YnJhY2tldHMgKi8KKyAgOworCitkZWNsYXJhdGlvbl9yZWNvdmVyeToKKyAgICBlcnJvciBlcnJv cl9sb2NhdGlvbiB7CiAgICAgICAgIHBhcnNlci0+c3ludGF4RXJyb3IoJDIpOwotICAgICAgICAk JCA9IGZhbHNlOwogICAgIH0KKyAgICB8IGRlY2xhcmF0aW9uX3JlY292ZXJ5IGludmFsaWRfYmxv Y2sKKyAgICB8IGRlY2xhcmF0aW9uX3JlY292ZXJ5IGVycm9yCiAgIDsKIAogcHJvcGVydHk6CkBA IC0yMDAxLDEyICsxOTc1LDYgQEAgaW52YWxpZF9ibG9ja19saXN0OgogICB8IGludmFsaWRfYmxv Y2tfbGlzdCBlcnJvciBpbnZhbGlkX2Jsb2NrCiA7CiAKLWVycm9yczoKLSAgICBlcnJvciBlcnJv cl9sb2NhdGlvbiB7Ci0gICAgICAgICQkID0gJDI7Ci0gICAgfQotICAgIDsKLQogZXJyb3JfbG9j YXRpb246IHsKICAgICAgICAgJCQgPSBwYXJzZXItPmN1cnJlbnRMb2NhdGlvbigpOwogICAgIH0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYjA1ODFkMTU0ZTdlZDkyNmM1ODgyNDBhOTQ3MmExNWVjZWE0ZDcxLi5iOTMzMzhh ODMyZDk5Yjg3MzNhNzRkMmU0NDYwMmM1NWE3NTVlNDQyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTMtMDUtMjcgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAK KyAgICAgICAgSW52YWxpZCBibG9jayBkb2Vzbid0IG1ha2UgZGVjbGFyYXRpb24gaW52YWxpZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NzA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJvbSBCbGlu ayByMTQ5NDQ2IGJ5IDxzZXJ5YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgKiBmYXN0L2Nzcy9w YXJzaW5nLWVycm9yLXJlY292ZXJ5Lmh0bWw6IEFkZGVkIDIgbmV3IHRlc3QgY2FzZXMuCisKKzIw MTMtMDUtMjcgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKICAg ICAgICAgV2ViIEluc3BlY3RvcjogRW5hYmxlIENTUyBsb2dnaW5nCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM0MDEKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2luZy1lcnJvci1yZWNvdmVyeS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9jc3MvcGFyc2luZy1lcnJvci1yZWNvdmVyeS5odG1sCmluZGV4IDkwNTBkYTljMDZi ZmMzMzMwNGRhMDFhYzExNWVmYzQ3NGI2YTY5Y2QuLjlhYmY5MmNkYzJjNzUyNDRiYjBjMGYwYjA5 OTkwNjQxMWNhMmJlOTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNpbmct ZXJyb3ItcmVjb3ZlcnkuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzaW5nLWVy cm9yLXJlY292ZXJ5Lmh0bWwKQEAgLTQ4LDYgKzQ4LDE4IEBACiAgICAgICAgICAgICBkaXNwbGF5 Om5vbmU7CiAgICAgICAgIH0KIAorICAgICAgICAjdGVzdDYgeworICAgICAgICAgICAgZGlzcGxh eTogbm9uZSAhaW1wb3J0YW50OworICAgICAgICAgICAgZGlzcGxheTogYmxvY2sgIWltcG9ydGFu dCB7aW52YWxpZF9ibG9ja307CisgICAgICAgIH0KKworICAgICAgICAjdGVzdDcgeworICAgICAg ICAgICAgZGlzcGxheTogbm9uZSAhaW1wb3J0YW50OworICAgICAgICB9CisgICAgICAgICN0ZXN0 NyB7CisgICAgICAgICAgICBkaXNwbGF5OiBibG9jayAhaW1wb3J0YW50IHtpbnZhbGlkX2Jsb2Nr fQorICAgICAgICB9CisKICAgICAgICAgLyogU3VjY2Vzc2Z1bGx5IHBhcnNlZCAqLwogICAgICAg ICAjbGFzdCB7CiAgICAgICAgICAgICBkaXNwbGF5OmJsb2NrOwpAQCAtNjAsNiArNzIsOCBAQAog ICA8ZGl2IGNsYXNzPSJ0b19iZV9oaWRkZW4iIGlkPSJ0ZXN0MyI+RkFJTDogVGVzdCAzPC9kaXY+ CiAgIDxkaXYgY2xhc3M9InRvX2JlX2hpZGRlbiIgaWQ9InRlc3Q0Ij5GQUlMOiBUZXN0IDQ8L2Rp dj4KICAgPGRpdiBjbGFzcz0idG9fYmVfaGlkZGVuIiBpZD0idGVzdDUiPkZBSUw6IFRlc3QgNTwv ZGl2PgorICA8ZGl2IGNsYXNzPSJ0b19iZV9oaWRkZW4iIGlkPSJ0ZXN0NiI+RkFJTDogVGVzdCA2 PC9kaXY+CisgIDxkaXYgY2xhc3M9InRvX2JlX2hpZGRlbiIgaWQ9InRlc3Q3Ij5GQUlMOiBUZXN0 IDc8L2Rpdj4KICAgPGRpdiBjbGFzcz0idG9fYmVfc2hvd24iIGlkPSJsYXN0Ij5QQVNTPC9kaXY+ CiA8L2JvZHk+CiA8L2h0bWw+Cg==