115664 2013-05-06 11:25:28 -0700 Handle removeItem and clear in LocalStorageDatabase 2013-05-06 11:37:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 885137 0 andersca 2013-05-06 11:25:28 -0700 Handle removeItem and clear in LocalStorageDatabase 885139 1 200725 andersca 2013-05-06 11:26:50 -0700 Created attachment 200725 Patch 885143 2 200725 darin 2013-05-06 11:32:09 -0700 Comment on attachment 200725 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200725&action=review > Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.h:80 > + bool m_shouldClearItems; Need to initialize this to false in the constructor! 885150 3 andersca 2013-05-06 11:37:58 -0700 Committed r149618: <http://trac.webkit.org/changeset/149618> 200725 2013-05-06 11:26:50 -0700 2013-05-06 11:32:09 -0700 Patch bug-115664-20130506112558.patch text/plain 4784 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWZiY2EwYTQwZTUxMTgz MmIxMzc3N2IwMzRkYmZjZjcxYTNjMTVmNC4uNjZiNTRjMTk3N2Q2ZDFkNWQ1MTFkZjE4YzBmYThj YTMwNjMzMWQxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEzLTA1LTA2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgSGFuZGxlIHJlbW92 ZUl0ZW0gYW5kIGNsZWFyIGluIExvY2FsU3RvcmFnZURhdGFiYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU2NjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9TdG9yYWdlL0xvY2Fs U3RvcmFnZURhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdlRGF0YWJh c2U6OnJlbW92ZUl0ZW0pOgorICAgICAgICBDYWxsIGl0ZW1EaWRDaGFuZ2Ugd2l0aCBhIG51bGwg dmFsdWUsIGluZGljYXRpbmcgdGhhdCB3ZSB3YW50IHRvIHJlbW92ZSB0aGlzIGl0ZW0uCisKKyAg ICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdlRGF0YWJhc2U6OmNsZWFyKToKKyAgICAgICAgQ2xl YXIgaXRlbXMsIHNldCBtX3Nob3VsZENsZWFySXRlbXMgYW5kIHNjaGVkdWxlIGEgZGF0YWJhc2Ug dXBkYXRlLgorCisgICAgICAgIChXZWJLaXQ6OkxvY2FsU3RvcmFnZURhdGFiYXNlOjp1cGRhdGVE YXRhYmFzZSk6CisgICAgICAgIElmIG1fc2hvdWxkQ2xlYXJJdGVtcyBpcyB0cnVlLCBjbGVhciBh bGwgaXRlbXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5j cHA6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYTo6cmVtb3Zl SXRlbSk6CisgICAgICAgIENhbGwgdGhyb3VnaCB0byB0aGUgbG9jYWwgc3RvcmFnZSBkYXRhYmFz ZS4KKworICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6U3RvcmFnZUFyZWE6OmNsZWFy KToKKyAgICAgICAgRGl0dG8uCisKKzIwMTMtMDUtMDYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBXcml0ZSBzdG9yYWdlIGNoYW5nZXMgdG8gZGlzawog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjYwCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFn ZURhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3Rv cmFnZURhdGFiYXNlLmNwcAppbmRleCBmZjlmYTQ5YTAzM2RkYzY5NzYyMmRkNDMyOGZhMjIwZmE3 NjFjZTk4Li4yYTQ2NDQwZWRmODIwMjIyZjk4NDhlZGI4MTQwZjU1MDMyY2ViMTgzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdl RGF0YWJhc2UuY3BwCkBAIC0xODksNiArMTg5LDE5IEBAIHZvaWQgTG9jYWxTdG9yYWdlRGF0YWJh c2U6OnNldEl0ZW0oY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFsdWUpCiAgICAg aXRlbURpZENoYW5nZShrZXksIHZhbHVlKTsKIH0KIAordm9pZCBMb2NhbFN0b3JhZ2VEYXRhYmFz ZTo6cmVtb3ZlSXRlbShjb25zdCBTdHJpbmcmIGtleSkKK3sKKyAgICBpdGVtRGlkQ2hhbmdlKGtl eSwgU3RyaW5nKCkpOworfQorCit2b2lkIExvY2FsU3RvcmFnZURhdGFiYXNlOjpjbGVhcigpCit7 CisgICAgbV9jaGFuZ2VkSXRlbXMuY2xlYXIoKTsKKyAgICBtX3Nob3VsZENsZWFySXRlbXMgPSB0 cnVlOworCisgICAgc2NoZWR1bGVEYXRhYmFzZVVwZGF0ZSgpOworfQorCiB2b2lkIExvY2FsU3Rv cmFnZURhdGFiYXNlOjppdGVtRGlkQ2hhbmdlKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJp bmcmIHZhbHVlKQogewogICAgIG1fY2hhbmdlZEl0ZW1zLnNldChrZXksIHZhbHVlKTsKQEAgLTIx MCw3ICsyMjMsMjEgQEAgdm9pZCBMb2NhbFN0b3JhZ2VEYXRhYmFzZTo6dXBkYXRlRGF0YWJhc2Uo KQogCiAgICAgbV9kaWRTY2hlZHVsZURhdGFiYXNlVXBkYXRlID0gZmFsc2U7CiAKLSAgICAvLyBG SVhNRTogSGFuZGxlIGNsZWFyaW5nLgorICAgIGlmIChtX3Nob3VsZENsZWFySXRlbXMpIHsKKyAg ICAgICAgbV9zaG91bGRDbGVhckl0ZW1zID0gZmFsc2U7CisKKyAgICAgICAgU1FMaXRlU3RhdGVt ZW50IGNsZWFyU3RhdGVtZW50KG1fZGF0YWJhc2UsICJERUxFVEUgRlJPTSBJdGVtVGFibGUiKTsK KyAgICAgICAgaWYgKGNsZWFyU3RhdGVtZW50LnByZXBhcmUoKSAhPSBTUUxSZXN1bHRPaykgewor ICAgICAgICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gcHJlcGFyZSBjbGVhciBzdGF0ZW1lbnQg LSBjYW5ub3Qgd3JpdGUgdG8gbG9jYWwgc3RvcmFnZSBkYXRhYmFzZSIpOworICAgICAgICAgICAg cmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgaW50IHJlc3VsdCA9IGNsZWFyU3RhdGVtZW50 LnN0ZXAoKTsKKyAgICAgICAgaWYgKHJlc3VsdCAhPSBTUUxSZXN1bHREb25lKSB7CisgICAgICAg ICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byBjbGVhciBhbGwgaXRlbXMgaW4gdGhlIGxvY2FsIHN0 b3JhZ2UgZGF0YWJhc2UgLSAlaSIsIHJlc3VsdCk7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKyAgICB9CiAKICAgICBIYXNoTWFwPFN0cmluZywgU3RyaW5nPiBjaGFuZ2VkSXRlbXM7 CiAgICAgaWYgKG1fY2hhbmdlZEl0ZW1zLnNpemUoKSA+IG1heGltdW1JdGVtc1RvVXBkYXRlKSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3Jh Z2VEYXRhYmFzZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9y YWdlRGF0YWJhc2UuaAppbmRleCA3ZjNlMjljOWQ5MDE2MjM0MzMwNjk1MjkxOTRjN2IyMTU1NTc5 NWNhLi4zZDc4MDJkOTk2MzAyMjZhNjdlNWUyMzI5NDZkM2ZmZWQ0ODIyMjMzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFi YXNlLmgKQEAgLTQ5LDYgKzQ5LDggQEAgcHVibGljOgogICAgIHZvaWQgaW1wb3J0SXRlbXMoV2Vi Q29yZTo6U3RvcmFnZU1hcCYpOwogCiAgICAgdm9pZCBzZXRJdGVtKGNvbnN0IFN0cmluZyYga2V5 LCBjb25zdCBTdHJpbmcmIHZhbHVlKTsKKyAgICB2b2lkIHJlbW92ZUl0ZW0oY29uc3QgU3RyaW5n JiBrZXkpOworICAgIHZvaWQgY2xlYXIoKTsKIAogcHJpdmF0ZToKICAgICBMb2NhbFN0b3JhZ2VE YXRhYmFzZShjb25zdCBTdHJpbmcmIGRhdGFiYXNlRmlsZW5hbWUsIFBhc3NSZWZQdHI8V29ya1F1 ZXVlPik7CkBAIC03NSw2ICs3Nyw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2RpZEltcG9ydEl0 ZW1zOwogCiAgICAgYm9vbCBtX2RpZFNjaGVkdWxlRGF0YWJhc2VVcGRhdGU7CisgICAgYm9vbCBt X3Nob3VsZENsZWFySXRlbXM7CiAgICAgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4gbV9jaGFuZ2Vk SXRlbXM7CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFn ZS9TdG9yYWdlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9T dG9yYWdlTWFuYWdlci5jcHAKaW5kZXggY2FhMmFkYWFmNTBiZGNjM2UyNDE1OTI3YjVlM2MzMGY5 MGU3YTMwNy4uMzhiOGFkZThhNjBlNWM2NGNlODgzODQ3ODRhNzNhMjliMzBjNzdlOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNw cApAQCAtMTc0LDYgKzE3NCw5IEBAIHZvaWQgU3RvcmFnZU1hbmFnZXI6OlN0b3JhZ2VBcmVhOjpy ZW1vdmVJdGVtKENvcmVJUEM6OkNvbm5lY3Rpb24qIHNvdXJjZUNvbm5lY3RpCiAgICAgaWYgKG9s ZFZhbHVlLmlzTnVsbCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAobV9sb2NhbFN0b3Jh Z2VEYXRhYmFzZSkKKyAgICAgICAgbV9sb2NhbFN0b3JhZ2VEYXRhYmFzZS0+cmVtb3ZlSXRlbShr ZXkpOworCiAgICAgZGlzcGF0Y2hFdmVudHMoc291cmNlQ29ubmVjdGlvbiwgc291cmNlU3RvcmFn ZUFyZWFJRCwga2V5LCBvbGRWYWx1ZSwgU3RyaW5nKCksIHVybFN0cmluZyk7CiB9CiAKQEAgLTE4 Niw2ICsxODksOSBAQCB2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYTo6Y2xlYXIoQ29y ZUlQQzo6Q29ubmVjdGlvbiogc291cmNlQ29ubmVjdGlvbiwgdQogCiAgICAgbV9zdG9yYWdlTWFw ID0gU3RvcmFnZU1hcDo6Y3JlYXRlKG1fcXVvdGFJbkJ5dGVzKTsKIAorICAgIGlmIChtX2xvY2Fs U3RvcmFnZURhdGFiYXNlKQorICAgICAgICBtX2xvY2FsU3RvcmFnZURhdGFiYXNlLT5jbGVhcigp OworCiAgICAgZGlzcGF0Y2hFdmVudHMoc291cmNlQ29ubmVjdGlvbiwgc291cmNlU3RvcmFnZUFy ZWFJRCwgU3RyaW5nKCksIFN0cmluZygpLCBTdHJpbmcoKSwgdXJsU3RyaW5nKTsKIH0KIAo=