115653 2013-05-06 09:40:15 -0700 Use OwnPtr instead of deleteAllValues in SVGAttributeToPropertyMap 2013-05-07 09:14:42 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 73757 1 darin darin cmarcelo commit-queue d-r fmalita pdr schenney zimmermann oldest_to_newest 885065 0 darin 2013-05-06 09:40:15 -0700 Use OwnPtr instead of deleteAllValues in SVGAttributeToPropertyMap 885074 1 200711 darin 2013-05-06 09:46:05 -0700 Created attachment 200711 Patch 885262 2 200711 kling 2013-05-06 12:46:38 -0700 Comment on attachment 200711 Patch r=me, nice touch with the added comments. 885277 3 200711 commit-queue 2013-05-06 13:14:30 -0700 Comment on attachment 200711 Patch Clearing flags on attachment: 200711 Committed r149632: <http://trac.webkit.org/changeset/149632> 885278 4 commit-queue 2013-05-06 13:14:33 -0700 All reviewed patches have been landed. Closing bug. 885763 5 darin 2013-05-07 09:14:42 -0700 *** Bug 75734 has been marked as a duplicate of this bug. *** 200711 2013-05-06 09:46:05 -0700 2013-05-06 13:14:30 -0700 Patch bug-115653-20130506094512.patch text/plain 6175 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZhODE5MjU5YjMwMzIy YmE1Njk2N2JjNjEwMWIwNDRlOWExY2NlZi4uMDY2NjgzNGNiOThjZGExM2U0YWFhMDZiOGE5NGE2 NTkxNWViYTU0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA1LTA2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgT3duUHRyIGluc3RlYWQg b2YgZGVsZXRlQWxsVmFsdWVzIGluIFNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTY1MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsc28gbWFkZSBhIGZldyBz dHlsZSBmaXhlcyB0byB0aGUgY29kZSBhdCB0aGUgc2FtZSB0aW1lLgorCisgICAgICAgICogc3Zn L3Byb3BlcnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwOjphZGRQcm9wZXJ0aWVzKTogQ2hhbmdlZCBh cmd1bWVudCB0bworICAgICAgICBjb25zdCBiZWNhdXNlIHRoZXJlIHdhcyBubyByZWFzb24gZm9y IGl0IHRvIGJlIG5vbi1jb25zdC4gQWRkZWQgY2FsbHMgdG8KKyAgICAgICAgZ2V0KCkgc2luY2Ug dGhlIGl0ZW1zIGluIHRoZSBtYXAgYXJlIG5vdyBPd25QdHIuIEFkZGVkIGEgY291cGxlIEZJWE1F cworICAgICAgICBhYm91dCBwZXJmb3JtYW5jZSBtaXN0YWtlcy4KKyAgICAgICAgKFdlYkNvcmU6 OlNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXA6OmFkZFByb3BlcnR5KTogQWRkZWQgYSBGSVhNRSBh Ym91dAorICAgICAgICBhIHNtYWxsIHBlcmZvcm1hbmNlIG1pc3Rha2UsIGFuZCB1cGRhdGVkIHRv IHVzZSBPd25QdHIgaW5zdGVhZCBvZiByYXcKKyAgICAgICAgcG9pbnRlcnMuCisgICAgICAgIChX ZWJDb3JlOjpTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwOjpzeW5jaHJvbml6ZVByb3BlcnRpZXMp OiBBZGRlZCBhIGNhbGwKKyAgICAgICAgdG8gZ2V0KCkuCisKKyAgICAgICAgKiBzdmcvcHJvcGVy dGllcy9TVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwLmg6IFJlbW92ZWQgbm93LXVubmVlZGVkCisg ICAgICAgIGNvbnN0cnVjdG9yIGFuZCBkZXN0cnVjdG9yIGRlZmluaXRpb25zLiBDaGFuZ2VkIHRo ZSB0eXBlIGZvciB0aGUKKyAgICAgICAgYWRkUHJvcGVydGllcyB0byBiZSBjb25zdCYuIEFkZGVk IGEgY29tbWVudCBhYm91dCBpbmNvcnJlY3QgZnVuY3Rpb24KKyAgICAgICAgbmFtaW5nLiBDaGFu Z2VkIHRoZSB0eXBlIG9mIHRoZSBtYXAgZGF0YSBtZW1iZXIgdG8gdXNlIE93blB0ci4KKwogMjAx My0wNS0wNiAgVsOtY3RvciBNYW51ZWwgSsOhcXVleiBMZWFsICA8dmphcXVlekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFt0ZXhtYXBdIGRyYXcgY29udGVudCBpZiBncmFwaGljcyBsYXllciBkaXNw bGF5cyBhIHZpZGVvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9T VkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0 aWVzL1NWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAuY3BwCmluZGV4IGNjNDZjY2ZhMDgxZmZjODgz MDliN2VmMjJkNjNmMGYzNGVmZDgxN2MuLjQ3ZTU0MjY2YzA2NTBhOWRiMmYxNDE4NzIxZjc0ODgy OGNjYzkwZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0F0 dHJpYnV0ZVRvUHJvcGVydHlNYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0 aWVzL1NWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAuY3BwCkBAIC0yNywxNSArMjcsMTkgQEAKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIFNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXA6OmFk ZFByb3BlcnRpZXMoU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcCYgbWFwKQordm9pZCBTVkdBdHRy aWJ1dGVUb1Byb3BlcnR5TWFwOjphZGRQcm9wZXJ0aWVzKGNvbnN0IFNWR0F0dHJpYnV0ZVRvUHJv cGVydHlNYXAmIG1hcCkKIHsKLSAgICBBdHRyaWJ1dGVUb1Byb3BlcnRpZXNNYXA6Oml0ZXJhdG9y IGVuZCA9IG1hcC5tX21hcC5lbmQoKTsKLSAgICBmb3IgKEF0dHJpYnV0ZVRvUHJvcGVydGllc01h cDo6aXRlcmF0b3IgaXQgPSBtYXAubV9tYXAuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0g ICAgICAgIFByb3BlcnRpZXNWZWN0b3IqIHZlY3RvciA9IGl0LT52YWx1ZTsKKyAgICBBdHRyaWJ1 dGVUb1Byb3BlcnRpZXNNYXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1hcC5tX21hcC5lbmQoKTsK KyAgICBmb3IgKEF0dHJpYnV0ZVRvUHJvcGVydGllc01hcDo6Y29uc3RfaXRlcmF0b3IgaXQgPSBt YXAubV9tYXAuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgIGNvbnN0IFByb3Bl cnRpZXNWZWN0b3IqIHZlY3RvciA9IGl0LT52YWx1ZS5nZXQoKTsKICAgICAgICAgQVNTRVJUKHZl Y3Rvcik7CiAKLSAgICAgICAgUHJvcGVydGllc1ZlY3Rvcjo6aXRlcmF0b3IgdmVjdG9yRW5kID0g dmVjdG9yLT5lbmQoKTsKLSAgICAgICAgZm9yIChQcm9wZXJ0aWVzVmVjdG9yOjppdGVyYXRvciB2 ZWN0b3JJdCA9IHZlY3Rvci0+YmVnaW4oKTsgdmVjdG9ySXQgIT0gdmVjdG9yRW5kOyArK3ZlY3Rv ckl0KQorICAgICAgICAvLyBGSVhNRTogVGhpcyBsb29rcyB1cCB0aGUgYXR0cmlidXRlIG5hbWUg aW4gdGhlIGhhc2ggdGFibGUgZm9yIGVhY2ggcHJvcGVydHksIGV2ZW4gdGhvdWdoIGFsbCB0aGUK KyAgICAgICAgLy8gcHJvcGVydGllcyBpbiBhIHNpbmdsZSB2ZWN0b3IgYXJlIGd1YXJhbnRlZWQg dG8gaGF2ZSB0aGUgc2FtZSBhdHRyaWJ1dGUgbmFtZS4KKyAgICAgICAgLy8gRklYTUU6IFRoaXMg Z3Jvd3MgdGhlIHZlY3RvciBvbmUgaXRlbSBhdCBhIHRpbWUsIGV2ZW4gdGhvdWdoIHdlIGtub3cg dXAgZnJvbnQgZXhhY3RseSBob3cgbWFueQorICAgICAgICAvLyBlbGVtZW50cyB3ZSBhcmUgYWRk aW5nIHRvIHRoZSB2ZWN0b3IuCisgICAgICAgIFByb3BlcnRpZXNWZWN0b3I6OmNvbnN0X2l0ZXJh dG9yIHZlY3RvckVuZCA9IHZlY3Rvci0+ZW5kKCk7CisgICAgICAgIGZvciAoUHJvcGVydGllc1Zl Y3Rvcjo6Y29uc3RfaXRlcmF0b3IgdmVjdG9ySXQgPSB2ZWN0b3ItPmJlZ2luKCk7IHZlY3Rvckl0 ICE9IHZlY3RvckVuZDsgKyt2ZWN0b3JJdCkKICAgICAgICAgICAgIGFkZFByb3BlcnR5KCp2ZWN0 b3JJdCk7CiAgICAgfQogfQpAQCAtNDgsOSArNTIsMTAgQEAgdm9pZCBTVkdBdHRyaWJ1dGVUb1By b3BlcnR5TWFwOjphZGRQcm9wZXJ0eShjb25zdCBTVkdQcm9wZXJ0eUluZm8qIGluZm8pCiAgICAg ICAgIHZlY3Rvci0+YXBwZW5kKGluZm8pOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIFBy b3BlcnRpZXNWZWN0b3IqIHZlY3RvciA9IG5ldyBQcm9wZXJ0aWVzVmVjdG9yOworICAgIC8vIEZJ WE1FOiBUaGlzIGRvZXMgYSBzZWNvbmQgaGFzaCB0YWJsZSBsb29rdXAsIGJ1dCB3aXRoIEhhc2hN YXA6OmFkZCB3ZSBjb3VsZCBpbnN0ZWFkIGRvIG9ubHkgb25lLgorICAgIE93blB0cjxQcm9wZXJ0 aWVzVmVjdG9yPiB2ZWN0b3IgPSBhZG9wdFB0cihuZXcgUHJvcGVydGllc1ZlY3Rvcik7CiAgICAg dmVjdG9yLT5hcHBlbmQoaW5mbyk7Ci0gICAgbV9tYXAuc2V0KGluZm8tPmF0dHJpYnV0ZU5hbWUs IHZlY3Rvcik7CisgICAgbV9tYXAuc2V0KGluZm8tPmF0dHJpYnV0ZU5hbWUsIHZlY3Rvci5yZWxl YXNlKCkpOwogfQogCiB2b2lkIFNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXA6OmFuaW1hdGVkUHJv cGVydGllc0ZvckF0dHJpYnV0ZShTVkdFbGVtZW50KiBvd25lclR5cGUsIGNvbnN0IFF1YWxpZmll ZE5hbWUmIGF0dHJpYnV0ZU5hbWUsIFZlY3RvcjxSZWZQdHI8U1ZHQW5pbWF0ZWRQcm9wZXJ0eT4g PiYgcHJvcGVydGllcykKQEAgLTgxLDcgKzg2LDcgQEAgdm9pZCBTVkdBdHRyaWJ1dGVUb1Byb3Bl cnR5TWFwOjpzeW5jaHJvbml6ZVByb3BlcnRpZXMoU1ZHRWxlbWVudCogY29udGV4dEVsZW1lbnQK ICAgICBBU1NFUlQoY29udGV4dEVsZW1lbnQpOwogICAgIEF0dHJpYnV0ZVRvUHJvcGVydGllc01h cDo6aXRlcmF0b3IgZW5kID0gbV9tYXAuZW5kKCk7CiAgICAgZm9yIChBdHRyaWJ1dGVUb1Byb3Bl cnRpZXNNYXA6Oml0ZXJhdG9yIGl0ID0gbV9tYXAuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7 Ci0gICAgICAgIFByb3BlcnRpZXNWZWN0b3IqIHZlY3RvciA9IGl0LT52YWx1ZTsKKyAgICAgICAg UHJvcGVydGllc1ZlY3RvciogdmVjdG9yID0gaXQtPnZhbHVlLmdldCgpOwogICAgICAgICBBU1NF UlQodmVjdG9yKTsKIAogICAgICAgICBQcm9wZXJ0aWVzVmVjdG9yOjppdGVyYXRvciB2ZWN0b3JF bmQgPSB2ZWN0b3ItPmVuZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL3Byb3Bl cnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL3By b3BlcnRpZXMvU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcC5oCmluZGV4IDMyMDNjNGRiODI4NTE4 MzViZDNlNjJkZThhZGM1MTFhZjVmNmQ1ODkuLjE2YWI5ZDA5OTg3NjM3YWQ5NzM5Zjk0MmExMzU5 OTQxMjc5Y2Y2ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NW R0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVy dGllcy9TVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwLmgKQEAgLTMxLDE0ICszMSwxMyBAQCBjbGFz cyBTVkdFbGVtZW50OwogCiBjbGFzcyBTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwIHsKIHB1Ymxp YzoKLSAgICBTVkdBdHRyaWJ1dGVUb1Byb3BlcnR5TWFwKCkgeyB9Ci0gICAgflNWR0F0dHJpYnV0 ZVRvUHJvcGVydHlNYXAoKSB7IGRlbGV0ZUFsbFZhbHVlcyhtX21hcCk7IH0KLQogICAgIGJvb2wg aXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuIG1fbWFwLmlzRW1wdHkoKTsgfQogCi0gICAgdm9pZCBh ZGRQcm9wZXJ0aWVzKFNWR0F0dHJpYnV0ZVRvUHJvcGVydHlNYXAmKTsKKyAgICB2b2lkIGFkZFBy b3BlcnRpZXMoY29uc3QgU1ZHQXR0cmlidXRlVG9Qcm9wZXJ0eU1hcCYpOwogICAgIHZvaWQgYWRk UHJvcGVydHkoY29uc3QgU1ZHUHJvcGVydHlJbmZvKik7CiAKKyAgICAvLyBGSVhNRTogVG8gbWF0 Y2ggV2ViS2l0IGNvZGluZyBzdHlsZSBlaXRoZXIgdGhlc2UgZnVuY3Rpb25zIHNob3VsZCBoYXZl IHJldHVybiB2YWx1ZXMgaW5zdGVhZCBvZiBvdXQgcGFyYW1ldGVycywKKyAgICAvLyBvciB0aGUg d29yZCAiZ2V0IiBzaG91bGQgYmUgYWRkZWQgYXMgYSBwcmVmaXggdG8gdGhlaXIgbmFtZXMuCiAg ICAgdm9pZCBhbmltYXRlZFByb3BlcnRpZXNGb3JBdHRyaWJ1dGUoU1ZHRWxlbWVudCogY29udGV4 dEVsZW1lbnQsIGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHJpYnV0ZU5hbWUsIFZlY3RvcjxSZWZQ dHI8U1ZHQW5pbWF0ZWRQcm9wZXJ0eT4gPiYpOwogICAgIHZvaWQgYW5pbWF0ZWRQcm9wZXJ0eVR5 cGVGb3JBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgYXR0cmlidXRlTmFtZSwgVmVjdG9y PEFuaW1hdGVkUHJvcGVydHlUeXBlPiYpOwogCkBAIC01MCw3ICs0OSw3IEBAIHByaXZhdGU6CiAg ICAgUGFzc1JlZlB0cjxTVkdBbmltYXRlZFByb3BlcnR5PiBhbmltYXRlZFByb3BlcnR5KFNWR0Vs ZW1lbnQqIGNvbnRleHRFbGVtZW50LCBjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyaWJ1dGVOYW1l LCBjb25zdCBTVkdQcm9wZXJ0eUluZm8qKTsKIAogICAgIHR5cGVkZWYgVmVjdG9yPGNvbnN0IFNW R1Byb3BlcnR5SW5mbyo+IFByb3BlcnRpZXNWZWN0b3I7Ci0gICAgdHlwZWRlZiBIYXNoTWFwPFF1 YWxpZmllZE5hbWUsIFByb3BlcnRpZXNWZWN0b3IqPiBBdHRyaWJ1dGVUb1Byb3BlcnRpZXNNYXA7 CisgICAgdHlwZWRlZiBIYXNoTWFwPFF1YWxpZmllZE5hbWUsIE93blB0cjxQcm9wZXJ0aWVzVmVj dG9yPiA+IEF0dHJpYnV0ZVRvUHJvcGVydGllc01hcDsKICAgICBBdHRyaWJ1dGVUb1Byb3BlcnRp ZXNNYXAgbV9tYXA7CiB9OwogCg==