115649 2013-05-06 08:49:19 -0700 [CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled 2013-05-07 15:53:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115292 1 giles_joplin webkit-unassigned commit-queue oldest_to_newest 885034 0 giles_joplin 2013-05-06 08:49:19 -0700 The following test started failing when subpixel layout was disabled for the OSX port (see http://trac.webkit.org/changeset/149224). fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html 885928 1 200961 giles_joplin 2013-05-07 12:44:56 -0700 Created attachment 200961 Patch Another correction of a padded shape test that failed when subpixel layout was disabled. This test puts a cross pattern made of five Ahem characters on three lines, within a padded diamond polygon. The left edges of each line depend on the intersection of the padded polygon's edges with the top of each line, which makes predicting the exact values unreliable. So we just verify that the left edges of each line are within a pixel of the ideal value. This change is very similar to the one made for https://bugs.webkit.org/show_bug.cgi?id=115490. 886022 2 200961 commit-queue 2013-05-07 15:53:28 -0700 Comment on attachment 200961 Patch Clearing flags on attachment: 200961 Committed r149699: <http://trac.webkit.org/changeset/149699> 886023 3 commit-queue 2013-05-07 15:53:29 -0700 All reviewed patches have been landed. Closing bug. 200961 2013-05-07 12:44:56 -0700 2013-05-07 15:53:27 -0700 Patch tmp.patch text/plain 6069 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMWYzMjFlLi5kNjgxYzA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTMtMDUt MDYgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBFeGNs dXNpb25zXSBzaGFwZS1pbnNpZGUsIHNoYXBlLXBhZGRpbmcsIHBvbHlnb24gdGVzdCBmYWlsaW5n IHdoZW4gc3VicGl4ZWwgbGF5b3V0IGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbm90aGVyIGNvcnJlY3Rpb24gb2YgYSBwYWRkZWQg c2hhcGUgdGVzdCB0aGF0IGZhaWxlZCB3aGVuIHN1YnBpeGVsIGxheW91dCB3YXMgZGlzYWJsZWQu CisgICAgICAgIFRoaXMgdGVzdCBwdXRzIGEgY3Jvc3MgcGF0dGVybiBtYWRlIG9mIGZpdmUgQWhl bSBjaGFyYWN0ZXJzIG9uIHRocmVlIGxpbmVzLCB3aXRoaW4gYSBwYWRkZWQKKyAgICAgICAgZGlh bW9uZCBwb2x5Z29uLiBUaGUgbGVmdCBlZGdlcyBvZiBlYWNoIGxpbmUgZGVwZW5kIG9uIHRoZSBp bnRlcnNlY3Rpb24gb2YgdGhlIHBhZGRlZCBwb2x5Z29uJ3MKKyAgICAgICAgZWRnZXMgd2l0aCB0 aGUgdG9wIG9mIGVhY2ggbGluZSwgd2hpY2ggbWFrZXMgcHJlZGljdGluZyB0aGUgZXhhY3QgdmFs dWVzIHVucmVsaWFibGUuIFNvIHdlCisgICAgICAgIGp1c3QgdmVyaWZ5IHRoYXQgdGhlIGxlZnQg ZWRnZXMgb2YgZWFjaCBsaW5lIGFyZSB3aXRoaW4gYSBwaXhlbCBvZiB0aGUgaWRlYWwgdmFsdWUu IFRoaXMKKyAgICAgICAgY2hhbmdlIGlzIHZlcnkgc2ltaWxhciB0byB0aGUgb25lIG1hZGUgZm9y IGJ1ZyAxMTU0OTAuCisKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3No YXBlLWluc2lkZS1wb2x5Z29uLXBhZGRpbmctMDAyLWV4cGVjdGVkLmh0bWw6IFJlbW92ZWQuCisg ICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdv bi1wYWRkaW5nLTAwMi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXhjbHVz aW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHlnb24tcGFkZGluZy0wMDIuaHRtbDoK KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMy0wNS0wNyAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBDb21iaW5lIGh0 bWwgYW5kIGpzIHBhcnRzIGZhc3QvdXJsIHNjcmlwdC10ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1w YWRkaW5nLTAwMi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3No YXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1wYWRkaW5nLTAwMi1leHBlY3RlZC5odG1s CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBmYjI4ODBiLi4wMDAwMDAwCi0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHln b24tcGFkZGluZy0wMDItZXhwZWN0ZWQuaHRtbAorKysgL2Rldi9udWxsCkBAIC0xLDM3ICswLDAg QEAKLTwhRE9DVFlQRSBodG1sPgotPGh0bWw+Ci08aGVhZD4KLTxzdHlsZT4KLSAgICAjc2hhcGUt aW5zaWRlIHsKLSAgICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwotICAgIH0KLQotICAgICNzaGFw ZS1vdXRsaW5lIHsKLSAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwotICAgICAgICB0b3A6IDBw eDsKLSAgICAgICAgbGVmdDogMHB4OwotICAgICAgICB3aWR0aDogNTAwcHg7Ci0gICAgICAgIGhl aWdodDogNTAwcHg7Ci0gICAgfQotCi0gICAgI3NoYXBlLWNvbnRlbnQgewotICAgICAgICBwb3Np dGlvbjogYWJzb2x1dGU7Ci0gICAgICAgIHRvcDogMTUwcHg7Ci0gICAgICAgIGxlZnQ6IDE1MHB4 OwotICAgICAgICB3aWR0aDogMzUwcHg7Ci0gICAgICAgIGhlaWdodDogMzUwcHg7Ci0gICAgICAg IGZvbnQ6IDEwMHB4LzEgQWhlbSwgc2Fucy1zZXJpZjsKLSAgICAgICAgY29sb3I6IGdyZWVuOwot ICAgIH0KLTwvc3R5bGU+Ci08L2hlYWQ+Ci08Ym9keT4KLSAgICA8cD5UaGUgYmx1ZSBkaWFtb25k IG91dGxpbmUgc2hvdWxkIGJlIGZpbGxlZCBieSBjcm9zcyBtYWRlIG9mIDUgZ3JlZW4gc3F1YXJl cy48L3A+Ci0gICAgPGRpdiBpZD0ic2hhcGUtaW5zaWRlIj4KLSAgICAgICAgPGRpdiBpZD0ic2hh cGUtY29udGVudCI+Jm5ic3A7WDxici8+WFhYPGJyLz4mbmJzcDtYPC9kaXY+Ci0gICAgICAgIDxz dmcgaWQ9InNoYXBlLW91dGxpbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+ Ci0gICAgICAgICAgICA8cG9seWdvbiBwb2ludHM9IjMwMCwxMDAgNTAwLDMwMCAzMDAsNTAwIDEw MCwzMDAiIHN0cm9rZT0iYmx1ZSIgZmlsbD0ibm9uZSIvPgotICAgICAgICA8L3N2Zz4KLSAgICA8 L2Rpdj4KLTwvYm9keT4KLTwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhj bHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHlnb24tcGFkZGluZy0wMDItZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFw ZS1pbnNpZGUtcG9seWdvbi1wYWRkaW5nLTAwMi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uZDYwYzI0YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHlnb24tcGFk ZGluZy0wMDItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1RoZSBibHVlIGRpYW1vbmQg b3V0bGluZSBzaG91bGQgYmUgZmlsbGVkIGJ5IGNyb3NzIG1hZGUgb2YgNSBncmVlbiBzcXVhcmVz LgorCitYIFhYWCBYCitQQVNTIHNoYXBlSW5zaWRlUmVjdCgnYScpLnRvcCBpcyAxNTAKK1BBU1Mg c2hhcGVJbnNpZGVSZWN0KCdhJykud2lkdGggaXMgMTAwCitQQVNTIHNoYXBlSW5zaWRlUmVjdCgn YicpLnRvcCBpcyAyNTAKK1BBU1Mgc2hhcGVJbnNpZGVSZWN0KCdiJykud2lkdGggaXMgMzAwCitQ QVNTIHNoYXBlSW5zaWRlUmVjdCgnYycpLnRvcCBpcyAzNTAKK1BBU1Mgc2hhcGVJbnNpZGVSZWN0 KCdjJykud2lkdGggaXMgMTAwCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVz aW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHlnb24tcGFkZGluZy0wMDIuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBv bHlnb24tcGFkZGluZy0wMDIuaHRtbAppbmRleCBjZjlmOGI1Li45YjRkNDEwIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1w b2x5Z29uLXBhZGRpbmctMDAyLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25z L3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcG9seWdvbi1wYWRkaW5nLTAwMi5odG1sCkBAIC0x LDYgKzEsNyBAQAogPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0Pgog ICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQogICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRp bmdzLnNldENTU0V4Y2x1c2lvbnNFbmFibGVkKHRydWUpOwpAQCAtMzcsNyArMzgsMzAgQEAgb2Zm c2V0cyAyMC4KICAgICAgICAgPHN2ZyBpZD0ic2hhcGUtb3V0bGluZSIgeG1sbnM9Imh0dHA6Ly93 d3cudzMub3JnLzIwMDAvc3ZnIj4KICAgICAgICAgICAgIDxwb2x5Z29uIHBvaW50cz0iMzAwLDEw MCA1MDAsMzAwIDMwMCw1MDAgMTAwLDMwMCIgc3Ryb2tlPSJibHVlIiBmaWxsPSJub25lIi8+CiAg ICAgICAgIDwvc3ZnPgotICAgIFggWFhYIFgKKyAgICA8c3BhbiBpZD0iYSI+WDwvc3Bhbj4gPHNw YW4gaWQ9ImIiPlhYWDwvc3Bhbj4gPHNwYW4gaWQ9ImMiPlg8L3NwYW4+CiAgICAgPC9kaXY+Cisg ICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8L2JvZHk+Cis8c2NyaXB0PgorICBmdW5jdGlv biBzaGFwZUluc2lkZVJlY3QoZWxlbWVudElkKSAKKyAgeworICAgICAgdmFyIHMgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgic2hhcGUtaW5zaWRlIikuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7 CisgICAgICB2YXIgciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGVsZW1lbnRJZCkuZ2V0Qm91 bmRpbmdDbGllbnRSZWN0KCk7CisgICAgICByZXR1cm4ge2xlZnQ6IHIubGVmdCAtIHMubGVmdCwg dG9wOiByLnRvcCAtIHMudG9wLCB3aWR0aDogci53aWR0aCwgaGVpZ2h0OiByLmhlaWdodH07Cisg IH0KKworICB2YXIgcXVpZXQgPSB0cnVlOyAvLyBQQVNTIG91dHB1dCBkZXBlbmRzIG9uIGlmIHN1 YnBpeGVsIGxheW91dCBoYXMgYmVlbiBlbmFibGVkCisKKyAgc2hvdWxkQmUoInNoYXBlSW5zaWRl UmVjdCgnYScpLnRvcCIsICIxNTAiKTsKKyAgc2hvdWxkQmVDbG9zZVRvKCJzaGFwZUluc2lkZVJl Y3QoJ2EnKS5sZWZ0IiwgMjUwLCAxLCBxdWlldCk7CisgIHNob3VsZEJlKCJzaGFwZUluc2lkZVJl Y3QoJ2EnKS53aWR0aCIsICIxMDAiKTsKKworICBzaG91bGRCZSgic2hhcGVJbnNpZGVSZWN0KCdi JykudG9wIiwgIjI1MCIpOworICBzaG91bGRCZUNsb3NlVG8oInNoYXBlSW5zaWRlUmVjdCgnYicp LmxlZnQiLCAxNTAsIDEsIHF1aWV0KQorICBzaG91bGRCZSgic2hhcGVJbnNpZGVSZWN0KCdiJyku d2lkdGgiLCAiMzAwIik7CisKKyAgc2hvdWxkQmUoInNoYXBlSW5zaWRlUmVjdCgnYycpLnRvcCIs ICIzNTAiKTsgCisgIHNob3VsZEJlQ2xvc2VUbygic2hhcGVJbnNpZGVSZWN0KCdjJykubGVmdCIs IDI1MCwgMSwgcXVpZXQpOworICBzaG91bGRCZSgic2hhcGVJbnNpZGVSZWN0KCdjJykud2lkdGgi LCAiMTAwIik7IAorPC9zY3JpcHQ+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCmluZGV4IDQyNzJiNmUuLjFjNGU5ZGIgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNTEzLDcgKzE1MTMsNiBAQCB3ZWJraXQu b3JnL2IvMTE1MjkyIGZhc3QvYmxvY2svZmxvYXQvb3ZlcmhhbmdpbmctdGFsbC1ibG9jay5odG1s CiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3QvZXZlbnRzL2NsaWVudFhZLWluLXpvb20tYW5kLXNj cm9sbC5odG1sCiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9t b3VzZS1ldmVudC1jb25zdHJ1Y3Rvci5odG1sCiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3QvZXZl bnRzL2NvbnN0cnVjdG9ycy93aGVlbC1ldmVudC1jb25zdHJ1Y3Rvci5odG1sCi13ZWJraXQub3Jn L2IvMTE1MjkyIGZhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXBvbHln b24tcGFkZGluZy0wMDIuaHRtbAogd2Via2l0Lm9yZy9iLzExNTI5MiBmYXN0L2V4Y2x1c2lvbnMv c2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtbm9uLXplcm8teS5odG1s CiB3ZWJraXQub3JnL2IvMTE1MjkyIGZhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRlLWZsb2F0 cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1zaW1wbGUtY2lyY2xlLmh0bWwKIHdlYmtpdC5vcmcvYi8x MTUyOTIgZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUt ZmxvYXRzLXNpbXBsZS1lbGxpcHNlLmh0bWwK