115648 2013-05-06 08:42:43 -0700 Build with GCC 4.8 fails because of -Wmaybe-uninitialized 2013-05-06 11:48:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi mhahnenberg msaboff ossy oldest_to_newest 885029 0 abecsi 2013-05-06 08:42:43 -0700 Build with GCC 4.8 fails because of -Wmaybe-uninitialized 885032 1 200703 abecsi 2013-05-06 08:43:19 -0700 Created attachment 200703 Patch 885040 2 200703 mhahnenberg 2013-05-06 09:04:42 -0700 Comment on attachment 200703 Patch Hmm, maybe there's a way to make it so OptionRange has a trivial constructor and then we can manually initialize the fields with an init method? I'm leery of disabling warnings. 885122 3 msaboff 2013-05-06 10:59:22 -0700 I had a trivial constructor but got these messages from clang: /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:166:25: error: call to deleted constructor of 'Options::Entry [57]' Options::Entry Options::s_options[Options::numberOfOptions]; ^ In file included from /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:27: /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.h:222:12: note: function has been explicitly marked deleted here struct Entry { ^ 1 error generated. Here is the constructor: OptionRange() : m_state(Uninitialized) , m_rangeString(0) , m_lowLimit(0) , m_highLimit(0) { } What line is it complaining may be uninitialized? 885156 4 200731 abecsi 2013-05-06 11:44:24 -0700 Created attachment 200731 Patch 885157 5 abecsi 2013-05-06 11:44:43 -0700 (In reply to comment #3) > I had a trivial constructor but got these messages from clang: > > /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:166:25: error: call to deleted constructor of 'Options::Entry [57]' > Options::Entry Options::s_options[Options::numberOfOptions]; > ^ > In file included from /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.cpp:27: > /Volumes/Data/src/webkit.work/Source/JavaScriptCore/runtime/Options.h:222:12: note: function has been explicitly marked deleted here > struct Entry { > ^ > 1 error generated. > > Here is the constructor: > OptionRange() > : m_state(Uninitialized) > , m_rangeString(0) > , m_lowLimit(0) > , m_highLimit(0) > { > } The problem with this is that a constructor with an initializer-list is not trivial any more and hence can not be placed into a union,which can only hold POD. With "trivial constructor" I actually meant "default constructor with no initializer list and empty body" (equivalent with an implicitly-declared constructor generated by the compiler). GCC has an informative error message with the above constructor: error: member 'JSC::OptionRange JSC::Options::Entry::<anonymous union>::optionRangeVal' with constructor not allowed in union note: unrestricted unions only available with -std=c++11 or -std=gnu++11 > > What line is it complaining may be uninitialized? /home/abecsi/devel/git/webkit-git-svn/Source/JavaScriptCore/runtime/Options.cpp:120:17: error: 'value.JSC::OptionRange::m_state' may be used uninitialized in this function [-Werror=maybe-uninitialized] This is actually valid, since in Options::setOption the values are not initialized, hence the new patch. 885160 6 200731 abecsi 2013-05-06 11:48:23 -0700 Comment on attachment 200731 Patch Clearing flags on attachment: 200731 Committed r149622: <http://trac.webkit.org/changeset/149622> 885161 7 abecsi 2013-05-06 11:48:28 -0700 All reviewed patches have been landed. Closing bug. 200703 2013-05-06 08:43:19 -0700 2013-05-06 11:44:19 -0700 Patch bug-115648-20130506173910.patch text/plain 1938 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZDViZGYxMDRiNGI3ZTRhNGRlMGY5ZTBhZjE0YzM2MTBjNGZmZDhlLi4xZjhlYTA5ODM0YTM1NWUx NGI3MGU5NzliYjBmYTAxMDE0ZDFlYjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMy0wNS0wNiAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQGRpZ2lh LmNvbT4KKworICAgICAgICBCdWlsZCB3aXRoIEdDQyA0LjggZmFpbHMgYmVjYXVzZSBvZiAtV21h eWJlLXVuaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE0OTU1MiBPcHRp b25SYW5nZSBoYXMgYmVlbiBhZGRlZAorICAgICAgICB3aGljaCBpcyBzdG9yZWQgaW4gYSB1bmlv biBpbiBPcHRpb25zLCB0aHVzIGl0IGNhbiBvbmx5IGhhdmUgYSB0cml2aWFsCisgICAgICAgIGNv bnN0cnVjdG9yLiBUaGlzIGluIHR1cm4gcmVzdWx0cyBpbiBtYXliZS11bmluaXRpYWxpemVkIHdh cm5pbmdzICB3aXRoCisgICAgICAgIEdDQyA0LjggZm9yIG1lbWJlcnMgb2YgT3B0aW9uUmFuZ2Us IHRoZXJlZm9yIHRoZSBidWlsZCBmYWlscyBiZWNhdXNlIG9mCisgICAgICAgIC1XZXJyb3IuCisg ICAgICAgIFNpbmNlIGl0IGlzIG5vdCByZWFsbHkgdXNlZnVsLCBzdXBwcmVzcyBHQ0MgNC44J3Mg bWF5YmUtdW5pbml0aWFsaXplZAorICAgICAgICB3YXJuaW5ncyBvbiB0aGlzIHNvdXJjZSBmaWxl IHRvIGZpeCB0aGUgYnVpbGQuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuY3BwOgorCiAy MDEzLTA1LTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAg IFRoZXJlIHNob3VsZCBiZSBhIHJ1bnRpbWUgb3B0aW9uIHRvIGNvbnN0cmFpbiB3aGF0IGZ1bmN0 aW9ucyBnZXQgREZHIGNvbXBpbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcHRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlv bnMuY3BwCmluZGV4IDBiNjA2YjI0YTE4NWQ0N2NjYzc1YjdkZWE4OWYxYTM4ZjAzYWRkNGUuLjE1 NjNhM2ZjYTNhMmQ2NTcxNjc0NDY4MWNkMGI1YzM3ODg1Y2U3ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCkBAIC00Miw2ICs0MiwxMSBAQAogI2luY2x1ZGUg PHN5cy9zeXNjdGwuaD4KICNlbmRpZgogCisjaWYgQ09NUElMRVIoR0NDKSAmJiBHQ0NfVkVSU0lP Tl9BVF9MRUFTVCg0LCA4LCAwKQorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21h IEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWF5YmUtdW5pbml0aWFsaXplZCIKKyNlbmRpZgor CiBuYW1lc3BhY2UgSlNDIHsKIAogc3RhdGljIGJvb2wgcGFyc2UoY29uc3QgY2hhciogc3RyaW5n LCBib29sJiB2YWx1ZSkKQEAgLTI5NCwzICsyOTksNiBAQCB2b2lkIE9wdGlvbnM6OmR1bXBPcHRp b24oT3B0aW9uSUQgaWQsIEZJTEUqIHN0cmVhbSwgY29uc3QgY2hhciogaGVhZGVyLCBjb25zdCBj aAogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAorI2lmIENPTVBJTEVSKEdDQykgJiYgR0NDX1ZFUlNJ T05fQVRfTEVBU1QoNCwgOCwgMCkKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcG9wCisjZW5kaWYK 200731 2013-05-06 11:44:24 -0700 2013-05-06 11:48:23 -0700 Patch bug-115648-20130506204015.patch text/plain 1580 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh N2NlZDZjN2MwNTMwOTFmM2ViMDk3MGEzMGExZTM4ZjQ4ODViNzc0Li40NTM4N2Y0NzE1NGU0YTVi YjZlZWU1MjEyZTY4OTVkZGNkZDE0NjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNS0wNiAgQW5kcmFzIEJlY3NpICA8YW5kcmFzLmJlY3NpQGRpZ2lh LmNvbT4KKworICAgICAgICBCdWlsZCB3aXRoIEdDQyA0LjggZmFpbHMgYmVjYXVzZSBvZiAtV21h eWJlLXVuaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluaXRpYWxpemUgdmFsdWVzIGluIE9wdGlvbnM6OnNldE9wdGlvbiBzaW5jZSBm cm9tCisgICAgICAgIHRoZXJlIHdlIGVuZCB1cCBjYWxsaW5nIE9wdGlvblJhbmdlOjppbml0IHdp dGgKKyAgICAgICAgdW5pbml0aWFsaXplZCBtZW1iZXJzLgorCisgICAgICAgICogcnVudGltZS9P cHRpb25zLmNwcDoKKwogMjAxMy0wNS0wNiAgR2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQHdlYmtp dC5vcmc+CiAKICAgICAgICAgSlNDIEFSTSB0cmFkaXRpb25hbCBmYWlsaW5nIG9uIE9jdGFuZSBO YXZpZXJTdG9rZXMgdGVzdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNw cAppbmRleCAwYjYwNmIyNGExODVkNDdjY2M3NWI3ZGVhODlmMWEzOGYwM2FkZDRlLi5jM2ZmNDlh YWRjZGNmMDg4YTljN2ZkOTc4NDdhMTUwMmVmNjkwNTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PcHRpb25zLmNwcApAQCAtMjQ1LDYgKzI0NSw3IEBAIGJvb2wgT3B0aW9uczo6 c2V0T3B0aW9uKGNvbnN0IGNoYXIqIGFyZykKICNkZWZpbmUgRk9SX0VBQ0hfT1BUSU9OKHR5cGVf LCBuYW1lXywgZGVmYXVsdFZhbHVlXykgICAgXAogICAgIGlmICghc3RybmNtcChhcmcsICNuYW1l XywgZXF1YWxTdHIgLSBhcmcpKSB7ICAgICAgICBcCiAgICAgICAgIHR5cGVfIHZhbHVlOyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICAgICAgdmFsdWUgPSAwOyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICBib29sIHN1Y2Nlc3Mg PSBwYXJzZSh2YWx1ZVN0ciwgdmFsdWUpOyAgICAgICAgICBcCiAgICAgICAgIGlmIChzdWNjZXNz KSB7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAgICAgIG5hbWVf KCkgPSB2YWx1ZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo=