<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>115624</bug_id>
          
          <creation_ts>2013-05-06 00:41:06 -0700</creation_ts>
          <short_desc>[GTK] Initialize WebKitWebPlugin path to prevent double-free</short_desc>
          <delta_ts>2013-05-07 00:41:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Tomas Popela">tpopela</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>884853</commentid>
    <comment_count>0</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2013-05-06 00:41:06 -0700</bug_when>
    <thetext>Initialize WebKitWebPlugin path in webkitwebplugin.cpp to prevent double-free on OpenBSD: https://bugzilla.gnome.org/show_bug.cgi?id=684245#c20</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>884854</commentid>
    <comment_count>1</comment_count>
      <attachid>200639</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2013-05-06 00:49:02 -0700</bug_when>
    <thetext>Created attachment 200639
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>884857</commentid>
    <comment_count>2</comment_count>
      <attachid>200639</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-05-06 00:58:10 -0700</bug_when>
    <thetext>Comment on attachment 200639
Proposed patch

Oh!, this happens because webkitwebplugin is doing new WebKitWebPluginPrivate(). I think a better fix would be to use GOwnPtr&lt;char&gt; for the path. GOwnPtr initializes the internal pointer on construction and you can remove all the g_free.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>884920</commentid>
    <comment_count>3</comment_count>
      <attachid>200664</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2013-05-06 06:30:51 -0700</bug_when>
    <thetext>Created attachment 200664
Proposed patch v2

WebKitWebPlugin path and also error variable in webkit_web_plugin_get_path are now using GOwnPtr</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>884921</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-06 06:33:09 -0700</bug_when>
    <thetext>Attachment 200664 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit/gtk/ChangeLog&apos;, u&apos;Source/WebKit/gtk/webkit/webkitwebplugin.cpp&apos;, u&apos;Source/WebKit/gtk/webkit/webkitwebpluginprivate.h&apos;]&quot; exit_code: 1
Source/WebKit/gtk/webkit/webkitwebpluginprivate.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>884959</commentid>
    <comment_count>5</comment_count>
      <attachid>200664</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-05-06 08:17:17 -0700</bug_when>
    <thetext>Comment on attachment 200664
Proposed patch v2

Looks good to me, but please fix the style error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>885626</commentid>
    <comment_count>6</comment_count>
      <attachid>200877</attachid>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2013-05-07 00:04:10 -0700</bug_when>
    <thetext>Created attachment 200877
Proposed patch v3

Fixes style error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>885636</commentid>
    <comment_count>7</comment_count>
      <attachid>200877</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-07 00:41:26 -0700</bug_when>
    <thetext>Comment on attachment 200877
Proposed patch v3

Clearing flags on attachment: 200877

Committed r149666: &lt;http://trac.webkit.org/changeset/149666&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>885637</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-05-07 00:41:28 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>200639</attachid>
            <date>2013-05-06 00:49:02 -0700</date>
            <delta_ts>2013-05-06 06:30:51 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>115624.patch</filename>
            <type>text/plain</type>
            <size>1665</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">RnJvbSBiYzFlNjQ4YTNhYmQ4YTRhYWRiY2Y5OWYxMjZiMGE2MzE1MDUyNjRlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0
ZTogTW9uLCA2IE1heSAyMDEzIDA5OjQzOjExICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMy0w
NS0wNiAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgoKICAgICAgICBbR1RLXSBJ
bml0aWFsaXplIFdlYktpdFdlYlBsdWdpbiBwYXRoIHRvIHByZXZlbnQgZG91YmxlLWZyZWUKICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CgogICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3
ZWJwbHVnaW4uY3BwOgogICAgICAgICh3ZWJraXRfd2ViX3BsdWdpbl9pbml0KToKLS0tCiBTb3Vy
Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysK
IFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW4uY3BwIHwgIDEgKwogMiBm
aWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDI0ZTc4
OTYuLmZlYWEzMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wNS0w
NiAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisgICAgICAgIFtHVEtdIElu
aXRpYWxpemUgV2ViS2l0V2ViUGx1Z2luIHBhdGggdG8gcHJldmVudCBkb3VibGUtZnJlZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJraXQvd2Vi
a2l0d2VicGx1Z2luLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfcGx1Z2luX2luaXQpOgorCiAy
MDEzLTA1LTAyICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAg
ICBTZWdtZW50YXRpb24gRmF1bHQgd2l0aCBSb21hbmlhbiBsb2NhbGUuIEV2b2x1dGlvbiBub3Qg
c3RhcnRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi
cGx1Z2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW4uY3Bw
CmluZGV4IDM3OGU4ODQuLjY5Y2E3N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl
YmtpdC93ZWJraXR3ZWJwbHVnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93
ZWJraXR3ZWJwbHVnaW4uY3BwCkBAIC0xMjIsNiArMTIyLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0
X3dlYl9wbHVnaW5faW5pdChXZWJLaXRXZWJQbHVnaW4gKnBsdWdpbikKIHsKICAgICBwbHVnaW4t
PnByaXYgPSBuZXcgV2ViS2l0V2ViUGx1Z2luUHJpdmF0ZSgpOwogICAgIHBsdWdpbi0+cHJpdi0+
bWltZVR5cGVzID0gMDsKKyAgICBwbHVnaW4tPnByaXYtPnBhdGggPSAwOwogfQogCiBuYW1lc3Bh
Y2UgV2ViS2l0IHsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>200664</attachid>
            <date>2013-05-06 06:30:51 -0700</date>
            <delta_ts>2013-05-07 00:04:10 -0700</delta_ts>
            <desc>Proposed patch v2</desc>
            <filename>115624v2.patch</filename>
            <type>text/plain</type>
            <size>3976</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">RnJvbSBmOTg0N2ZjMmE4MDVjMmNmOWJkOTJlZjhmOWI1M2ZiOTE2M2EyZmQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0
ZTogTW9uLCA2IE1heSAyMDEzIDE1OjI2OjA5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMy0w
NS0wNiAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgoKICAgICAgICBbR1RLXSBJ
bml0aWFsaXplIFdlYktpdFdlYlBsdWdpbiBwYXRoIHRvIHByZXZlbnQgZG91YmxlLWZyZWUKICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CgogICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBVc2UgR093blB0ciBmb3Ig
V2ViS2l0V2ViUGx1Z2luIHBhdGggdG8gcHJldmVudCBkb3VibGUtZnJlZQogICAgICAgIHNpdHVh
dGlvbnMuIEFsc28gdXNlIEdPd25QdHIgZm9yIEdFcnJvciBpbiB3ZWJraXRfd2ViX3BsdWdpbl9n
ZXRfcGF0aC4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcDoKICAgICAgICAo
d2Via2l0X3dlYl9wbHVnaW5fZmluYWxpemUpOgogICAgICAgICh3ZWJraXRfd2ViX3BsdWdpbl9n
ZXRfcGF0aCk6CiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2VicGx1Z2lucHJpdmF0ZS5oOgotLS0K
IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAxNSAr
KysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW4u
Y3BwICAgICAgfCAxNSArKysrKy0tLS0tLS0tLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93
ZWJraXR3ZWJwbHVnaW5wcml2YXRlLmggfCAgMyArKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5z
ZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9n
dGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDI0ZTc4OTYu
LjE0ZTUwODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9T
b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wNS0wNiAg
VG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisgICAgICAgIFtHVEtdIEluaXRp
YWxpemUgV2ViS2l0V2ViUGx1Z2luIHBhdGggdG8gcHJldmVudCBkb3VibGUtZnJlZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEdPd25QdHIgZm9y
IFdlYktpdFdlYlBsdWdpbiBwYXRoIHRvIHByZXZlbnQgZG91YmxlLWZyZWUKKyAgICAgICAgc2l0
dWF0aW9ucy4gQWxzbyB1c2UgR093blB0ciBmb3IgR0Vycm9yIGluIHdlYmtpdF93ZWJfcGx1Z2lu
X2dldF9wYXRoLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5jcHA6CisgICAg
ICAgICh3ZWJraXRfd2ViX3BsdWdpbl9maW5hbGl6ZSk6CisgICAgICAgICh3ZWJraXRfd2ViX3Bs
dWdpbl9nZXRfcGF0aCk6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbnByaXZhdGUu
aDoKKwogMjAxMy0wNS0wMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgU2VnbWVudGF0aW9uIEZhdWx0IHdpdGggUm9tYW5pYW4gbG9jYWxlLiBFdm9sdXRp
b24gbm90IHN0YXJ0aW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl
YmtpdHdlYnBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1
Z2luLmNwcAppbmRleCAzNzhlODg0Li43M2I0MmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93
ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcApAQCAtNjMsOCArNjMsNiBAQCBzdGF0aWMgdm9pZCB3
ZWJraXRfd2ViX3BsdWdpbl9maW5hbGl6ZShHT2JqZWN0KiBvYmplY3QpCiAgICAgV2ViS2l0V2Vi
UGx1Z2luKiBwbHVnaW4gPSBXRUJLSVRfV0VCX1BMVUdJTihvYmplY3QpOwogICAgIFdlYktpdFdl
YlBsdWdpblByaXZhdGUqIHByaXYgPSBwbHVnaW4tPnByaXY7CiAKLSAgICBnX2ZyZWUocHJpdi0+
cGF0aCk7Ci0KICAgICBnX3NsaXN0X2ZvcmVhY2gocHJpdi0+bWltZVR5cGVzLCAoR0Z1bmMpZnJl
ZU1JTUVUeXBlLCAwKTsKICAgICBnX3NsaXN0X2ZyZWUocHJpdi0+bWltZVR5cGVzKTsKIApAQCAt
MTkxLDIzICsxODksMjAgQEAgY29uc3QgY2hhciogd2Via2l0X3dlYl9wbHVnaW5fZ2V0X3BhdGgo
V2ViS2l0V2ViUGx1Z2luKiBwbHVnaW4pCiAgICAgV2ViS2l0V2ViUGx1Z2luUHJpdmF0ZSogcHJp
diA9IHBsdWdpbi0+cHJpdjsKIAogICAgIGlmIChwcml2LT5wYXRoKQotICAgICAgICByZXR1cm4g
cHJpdi0+cGF0aDsKKyAgICAgICAgcmV0dXJuIHByaXYtPnBhdGguZ2V0KCk7CiAKLSAgICBHRXJy
b3IqIGVycm9yID0gMDsKLSAgICBwcml2LT5wYXRoID0gZ19maWxlbmFtZV9mcm9tX3V0ZjgocHJp
di0+Y29yZVBsdWdpbi0+cGF0aCgpLnV0ZjgoKS5kYXRhKCksIC0xLCAwLCAwLCAmZXJyb3IpOwor
ICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKKyAgICBwcml2LT5wYXRoLnNldChnX2ZpbGVuYW1l
X2Zyb21fdXRmOChwcml2LT5jb3JlUGx1Z2luLT5wYXRoKCkudXRmOCgpLmRhdGEoKSwgLTEsIDAs
IDAsICZlcnJvci5vdXRQdHIoKSkpOwogCiAgICAgaWYgKCFlcnJvcikKLSAgICAgICAgcmV0dXJu
IHByaXYtPnBhdGg7CisgICAgICAgIHJldHVybiBwcml2LT5wYXRoLmdldCgpOwogCiAgICAgLy8g
SW4gdGhlIHVubGlrZWx5IGNhc2UgdGhlIGNvbnZlcnRpb24gZmFpbHMsIHJlcG9ydCB0aGUgZXJy
b3IgYW5kIG1ha2Ugc3VyZSB3ZSBmcmVlCiAgICAgLy8gYW55IHBhcnRpYWwgY29udmVydGlvbiB0
aGF0IGVuZGVkIHVwIGluIHRoZSB2YXJpYWJsZS4KLSAgICBnX2ZyZWUocHJpdi0+cGF0aCk7Ci0g
ICAgcHJpdi0+cGF0aCA9IDA7CisgICAgcHJpdi0+cGF0aC5jbGVhcigpOwogCiAgICAgZ193YXJu
aW5nKCJGYWlsZWQgdG8gY29udmVydCAnJXMnIHRvIHN5c3RlbSBmaWxlbmFtZSBlbmNvZGluZzog
JXMiLCBwcml2LT5jb3JlUGx1Z2luLT5wYXRoKCkudXRmOCgpLmRhdGEoKSwgZXJyb3ItPm1lc3Nh
Z2UpOwogCi0gICAgZ19jbGVhcl9lcnJvcigmZXJyb3IpOwotCiAgICAgcmV0dXJuIDA7CiB9CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5wcml2
YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2lucHJpdmF0ZS5o
CmluZGV4IDhhMWJhMWIuLmNlNzRkNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl
YmtpdC93ZWJraXR3ZWJwbHVnaW5wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Vi
a2l0L3dlYmtpdHdlYnBsdWdpbnByaXZhdGUuaApAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1ZGUg
IndlYmtpdHdlYnBsdWdpbi5oIgogI2luY2x1ZGUgPGdsaWItb2JqZWN0Lmg+CiAjaW5jbHVkZSA8
d3RmL3RleHQvQ1N0cmluZy5oPgorI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dPd25QdHIuaD4KIAog
bmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgUGx1Z2luUGFja2FnZTsKQEAgLTM4LDcgKzM5LDcg
QEAgc3RydWN0IF9XZWJLaXRXZWJQbHVnaW5Qcml2YXRlIHsKICAgICBSZWZQdHI8V2ViQ29yZTo6
UGx1Z2luUGFja2FnZT4gY29yZVBsdWdpbjsKICAgICBDU3RyaW5nIG5hbWU7CiAgICAgQ1N0cmlu
ZyBkZXNjcmlwdGlvbjsKLSAgICBjaGFyKiBwYXRoOworICAgIEdPd25QdHI8Y2hhcj4gcGF0aDsK
ICAgICBHU0xpc3QqIG1pbWVUeXBlczsKIH07CiAKLS0gCjEuOC4xLjQKCg==
</data>
<flag name="review"
          id="222038"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
    <flag name="commit-queue"
          id="222039"
          type_id="3"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>200877</attachid>
            <date>2013-05-07 00:04:10 -0700</date>
            <delta_ts>2013-05-07 00:41:26 -0700</delta_ts>
            <desc>Proposed patch v3</desc>
            <filename>115624v3.patch</filename>
            <type>text/plain</type>
            <size>3956</size>
            <attacher name="Tomas Popela">tpopela</attacher>
            
              <data encoding="base64">RnJvbSA0ZDVmOGZlNjBiMmVlYjczMmE4MTNhZjRlMjZhYWJhODY4MTNjMzZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0
ZTogTW9uLCA2IE1heSAyMDEzIDE1OjI2OjA5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMy0w
NS0wNiAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgoKICAgICAgICBbR1RLXSBJ
bml0aWFsaXplIFdlYktpdFdlYlBsdWdpbiBwYXRoIHRvIHByZXZlbnQgZG91YmxlLWZyZWUKICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CgogICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBVc2UgR093blB0ciBmb3Ig
V2ViS2l0V2ViUGx1Z2luIHBhdGggdG8gcHJldmVudCBkb3VibGUtZnJlZQogICAgICAgIHNpdHVh
dGlvbnMuIEFsc28gdXNlIEdPd25QdHIgZm9yIEdFcnJvciBpbiB3ZWJraXRfd2ViX3BsdWdpbl9n
ZXRfcGF0aC4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcDoKICAgICAgICAo
d2Via2l0X3dlYl9wbHVnaW5fZmluYWxpemUpOgogICAgICAgICh3ZWJraXRfd2ViX3BsdWdpbl9n
ZXRfcGF0aCk6CiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2VicGx1Z2lucHJpdmF0ZS5oOgotLS0K
IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAxNSAr
KysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW4u
Y3BwICAgICAgfCAxNSArKysrKy0tLS0tLS0tLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93
ZWJraXR3ZWJwbHVnaW5wcml2YXRlLmggfCAgMyArKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5z
ZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9n
dGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDI0ZTc4OTYu
LjE0ZTUwODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9T
b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wNS0wNiAg
VG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisgICAgICAgIFtHVEtdIEluaXRp
YWxpemUgV2ViS2l0V2ViUGx1Z2luIHBhdGggdG8gcHJldmVudCBkb3VibGUtZnJlZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NjI0CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEdPd25QdHIgZm9y
IFdlYktpdFdlYlBsdWdpbiBwYXRoIHRvIHByZXZlbnQgZG91YmxlLWZyZWUKKyAgICAgICAgc2l0
dWF0aW9ucy4gQWxzbyB1c2UgR093blB0ciBmb3IgR0Vycm9yIGluIHdlYmtpdF93ZWJfcGx1Z2lu
X2dldF9wYXRoLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5jcHA6CisgICAg
ICAgICh3ZWJraXRfd2ViX3BsdWdpbl9maW5hbGl6ZSk6CisgICAgICAgICh3ZWJraXRfd2ViX3Bs
dWdpbl9nZXRfcGF0aCk6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbnByaXZhdGUu
aDoKKwogMjAxMy0wNS0wMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgU2VnbWVudGF0aW9uIEZhdWx0IHdpdGggUm9tYW5pYW4gbG9jYWxlLiBFdm9sdXRp
b24gbm90IHN0YXJ0aW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl
YmtpdHdlYnBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1
Z2luLmNwcAppbmRleCAzNzhlODg0Li43M2I0MmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93
ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcApAQCAtNjMsOCArNjMsNiBAQCBzdGF0aWMgdm9pZCB3
ZWJraXRfd2ViX3BsdWdpbl9maW5hbGl6ZShHT2JqZWN0KiBvYmplY3QpCiAgICAgV2ViS2l0V2Vi
UGx1Z2luKiBwbHVnaW4gPSBXRUJLSVRfV0VCX1BMVUdJTihvYmplY3QpOwogICAgIFdlYktpdFdl
YlBsdWdpblByaXZhdGUqIHByaXYgPSBwbHVnaW4tPnByaXY7CiAKLSAgICBnX2ZyZWUocHJpdi0+
cGF0aCk7Ci0KICAgICBnX3NsaXN0X2ZvcmVhY2gocHJpdi0+bWltZVR5cGVzLCAoR0Z1bmMpZnJl
ZU1JTUVUeXBlLCAwKTsKICAgICBnX3NsaXN0X2ZyZWUocHJpdi0+bWltZVR5cGVzKTsKIApAQCAt
MTkxLDIzICsxODksMjAgQEAgY29uc3QgY2hhciogd2Via2l0X3dlYl9wbHVnaW5fZ2V0X3BhdGgo
V2ViS2l0V2ViUGx1Z2luKiBwbHVnaW4pCiAgICAgV2ViS2l0V2ViUGx1Z2luUHJpdmF0ZSogcHJp
diA9IHBsdWdpbi0+cHJpdjsKIAogICAgIGlmIChwcml2LT5wYXRoKQotICAgICAgICByZXR1cm4g
cHJpdi0+cGF0aDsKKyAgICAgICAgcmV0dXJuIHByaXYtPnBhdGguZ2V0KCk7CiAKLSAgICBHRXJy
b3IqIGVycm9yID0gMDsKLSAgICBwcml2LT5wYXRoID0gZ19maWxlbmFtZV9mcm9tX3V0ZjgocHJp
di0+Y29yZVBsdWdpbi0+cGF0aCgpLnV0ZjgoKS5kYXRhKCksIC0xLCAwLCAwLCAmZXJyb3IpOwor
ICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKKyAgICBwcml2LT5wYXRoLnNldChnX2ZpbGVuYW1l
X2Zyb21fdXRmOChwcml2LT5jb3JlUGx1Z2luLT5wYXRoKCkudXRmOCgpLmRhdGEoKSwgLTEsIDAs
IDAsICZlcnJvci5vdXRQdHIoKSkpOwogCiAgICAgaWYgKCFlcnJvcikKLSAgICAgICAgcmV0dXJu
IHByaXYtPnBhdGg7CisgICAgICAgIHJldHVybiBwcml2LT5wYXRoLmdldCgpOwogCiAgICAgLy8g
SW4gdGhlIHVubGlrZWx5IGNhc2UgdGhlIGNvbnZlcnRpb24gZmFpbHMsIHJlcG9ydCB0aGUgZXJy
b3IgYW5kIG1ha2Ugc3VyZSB3ZSBmcmVlCiAgICAgLy8gYW55IHBhcnRpYWwgY29udmVydGlvbiB0
aGF0IGVuZGVkIHVwIGluIHRoZSB2YXJpYWJsZS4KLSAgICBnX2ZyZWUocHJpdi0+cGF0aCk7Ci0g
ICAgcHJpdi0+cGF0aCA9IDA7CisgICAgcHJpdi0+cGF0aC5jbGVhcigpOwogCiAgICAgZ193YXJu
aW5nKCJGYWlsZWQgdG8gY29udmVydCAnJXMnIHRvIHN5c3RlbSBmaWxlbmFtZSBlbmNvZGluZzog
JXMiLCBwcml2LT5jb3JlUGx1Z2luLT5wYXRoKCkudXRmOCgpLmRhdGEoKSwgZXJyb3ItPm1lc3Nh
Z2UpOwogCi0gICAgZ19jbGVhcl9lcnJvcigmZXJyb3IpOwotCiAgICAgcmV0dXJuIDA7CiB9CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5wcml2
YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2lucHJpdmF0ZS5o
CmluZGV4IDhhMWJhMWIuLjUwN2Y3MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl
YmtpdC93ZWJraXR3ZWJwbHVnaW5wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Vi
a2l0L3dlYmtpdHdlYnBsdWdpbnByaXZhdGUuaApAQCAtMjEsNiArMjEsNyBAQAogCiAjaW5jbHVk
ZSAid2Via2l0d2VicGx1Z2luLmgiCiAjaW5jbHVkZSA8Z2xpYi1vYmplY3QuaD4KKyNpbmNsdWRl
IDx3dGYvZ29iamVjdC9HT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgog
CiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zOCw3ICszOSw3IEBAIHN0cnVjdCBfV2ViS2l0V2Vi
UGx1Z2luUHJpdmF0ZSB7CiAgICAgUmVmUHRyPFdlYkNvcmU6OlBsdWdpblBhY2thZ2U+IGNvcmVQ
bHVnaW47CiAgICAgQ1N0cmluZyBuYW1lOwogICAgIENTdHJpbmcgZGVzY3JpcHRpb247Ci0gICAg
Y2hhciogcGF0aDsKKyAgICBHT3duUHRyPGNoYXI+IHBhdGg7CiAgICAgR1NMaXN0KiBtaW1lVHlw
ZXM7CiB9OwogCi0tIAoxLjguMS40Cgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>