115587 2013-05-04 08:14:47 -0700 No need to declare JSC::LLInt::Data as friend class of WTF::StringImpl 2013-05-04 13:52:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 1 xan.lopez webkit-unassigned benjamin cmarcelo commit-queue ggaren kling xan.lopez oldest_to_newest 884526 0 xan.lopez 2013-05-04 08:14:47 -0700 I suppose LLInt::Data used some private method/data from StringImpl in the past, but that's not the case anymore. So remove the (bogus) layering violation. 884527 1 200528 xan.lopez 2013-05-04 08:18:16 -0700 Created attachment 200528 stringimplllintdata.diff 884556 2 commit-queue 2013-05-04 12:34:24 -0700 The commit-queue encountered the following flaky tests while processing attachment 200528: fast/frames/crash-remove-iframe-during-object-beforeload.html bug 115322 (author: zalan@apple.com) The commit-queue is continuing to process your patch. 884557 3 200528 commit-queue 2013-05-04 12:35:45 -0700 Comment on attachment 200528 stringimplllintdata.diff Clearing flags on attachment: 200528 Committed r149563: <http://trac.webkit.org/changeset/149563> 884558 4 commit-queue 2013-05-04 12:35:47 -0700 All reviewed patches have been landed. Closing bug. 884570 5 kling 2013-05-04 13:28:39 -0700 Reverted r149563 for reason: Broke LLInt build. Committed r149568: <http://trac.webkit.org/changeset/149568> 884573 6 xan.lopez 2013-05-04 13:48:57 -0700 (In reply to comment #5) > Reverted r149563 for reason: > > Broke LLInt build. > > Committed r149568: <http://trac.webkit.org/changeset/149568> Right, there was an ASSERT accessing a private flag, missed that (like EWS). We can change it to use the public getter, will upload a new patch later when I can verify with a debug build. 884575 7 ggaren 2013-05-04 13:52:10 -0700 Can someone svn blame to find out when this interface was added, and when its use was removed? If the use was truly removed, we can remove the ASSERT. Otherwise, we probably can't remove the interface. 200528 2013-05-04 08:18:16 -0700 2013-05-04 12:35:45 -0700 stringimplllintdata.diff stringimplllintdata.diff text/plain 2177 xan.lopez RnJvbSBkYmY3MGM2NWVkZTZlN2U5MzgyYjdjZTllZmI5YmFhNjE0NTAwY2E2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBTYXQs IDQgTWF5IDIwMTMgMDg6MTU6NTIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBObyBuZWVkIHRvIGRl Y2xhcmUgSlNDOjpMTEludDo6RGF0YSBhcyBmcmllbmQgY2xhc3Mgb2YKIFdURjo6U3RyaW5nSW1w bCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTg3CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCk5vIG5lZWQgdG8gZGVjbGFyZSBMTEludDo6RGF0YSBhcyBm cmllbmQgY2xhc3Mgb2YgV1RGOjpTdHJpbmdJbXBsLAppdCBkb2VzIG5vdCB1c2UgYW55IHByaXZh dGUgbWV0aG9kL2RhdGEgbWVtYmVyIG9mIHRoZSBsYXR0ZXIuCgoqIHd0Zi90ZXh0L1N0cmluZ0lt cGwuaDoKKFN0cmluZ0ltcGwpOgotLS0KIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgICAgICAg IHwgMTMgKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmggfCAg MiAtLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggODIxNzE1YS4uODIyNjA0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wNS0wNCAg WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgTm8gbmVlZCB0byBkZWNs YXJlIEpTQzo6TExJbnQ6OkRhdGEgYXMgZnJpZW5kIGNsYXNzIG9mIFdURjo6U3RyaW5nSW1wbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTg3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmVlZCB0 byBkZWNsYXJlIExMSW50OjpEYXRhIGFzIGZyaWVuZCBjbGFzcyBvZiBXVEY6OlN0cmluZ0ltcGws CisgICAgICAgIGl0IGRvZXMgbm90IHVzZSBhbnkgcHJpdmF0ZSBtZXRob2QvZGF0YSBtZW1iZXIg b2YgdGhlIGxhdHRlci4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAg ICAgKFN0cmluZ0ltcGwpOgorCiAyMDEzLTA1LTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIFRocmVhZEZ1bmN0aW9uSW52b2NhdGlvbiBmYXN0 IGFsbG9jYXRlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5o IGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggYWM0NzA0ZC4uYWVkZjNk MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIvU291 cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKQEAgLTUxLDcgKzUxLDYgQEAgdHlwZWRlZiBj b25zdCBzdHJ1Y3QgX19DRlN0cmluZyAqIENGU3RyaW5nUmVmOwogLy8gTGFuZGluZyB0aGUgZmls ZSBtb3ZlcyBpbiBvbmUgcGF0Y2gsIHdpbGwgZm9sbG93IG9uIHdpdGggcGF0Y2hlcyB0byBjaGFu Z2UgdGhlIG5hbWVzcGFjZXMuCiBuYW1lc3BhY2UgSlNDIHsKIHN0cnVjdCBJZGVudGlmaWVyQVND SUlTdHJpbmdUcmFuc2xhdG9yOwotbmFtZXNwYWNlIExMSW50IHsgY2xhc3MgRGF0YTsgfQogY2xh c3MgTExJbnRPZmZzZXRzRXh0cmFjdG9yOwogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0cnVjdCBJ ZGVudGlmaWVyQ2hhckJ1ZmZlclRyYW5zbGF0b3I7CiBzdHJ1Y3QgSWRlbnRpZmllckxDaGFyRnJv bVVDaGFyVHJhbnNsYXRvcjsKQEAgLTE0NCw3ICsxNDMsNiBAQCBjbGFzcyBTdHJpbmdJbXBsIHsK ICAgICBmcmllbmQgc3RydWN0IFdURjo6U3Vic3RyaW5nVHJhbnNsYXRvcjsKICAgICBmcmllbmQg c3RydWN0IFdURjo6VUNoYXJCdWZmZXJUcmFuc2xhdG9yOwogICAgIGZyaWVuZCBjbGFzcyBBdG9t aWNTdHJpbmdJbXBsOwotICAgIGZyaWVuZCBjbGFzcyBKU0M6OkxMSW50OjpEYXRhOwogICAgIGZy aWVuZCBjbGFzcyBKU0M6OkxMSW50T2Zmc2V0c0V4dHJhY3RvcjsKICAgICAKIHByaXZhdGU6Ci0t IAoxLjguMS40Cgo=