115575 2013-05-03 14:03:15 -0700 [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category 2013-05-03 16:11:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris commit-queue eric.carlson glenn gustavo jer.noble menard mrobinson philn pnormand oldest_to_newest 884326 0 calvaris 2013-05-03 14:03:15 -0700 [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category 884328 1 200468 calvaris 2013-05-03 14:06:23 -0700 Created attachment 200468 Patch Fixes the cadebug category for MediaPlayerPrivatteGStreamerBase. 884407 2 200468 pnormand 2013-05-03 15:20:43 -0700 Comment on attachment 200468 Patch Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern. 884408 3 pnormand 2013-05-03 15:21:30 -0700 If that's possible of course :) 884416 4 calvaris 2013-05-03 15:44:14 -0700 (In reply to comment #2) > (From update of attachment 200468 [details]) > Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern. The problem of that is the types, and exporting more things like this debug thing is not a very good idea. Base.h file is used in other places. We could create another common .h that we would include in both cpp file, but I think that's overkilling. 884417 5 200468 pnormand 2013-05-03 15:44:36 -0700 Comment on attachment 200468 Patch Oh sorry I misread the patch in the first place. This actually looks good to me :) 884431 6 200468 commit-queue 2013-05-03 16:11:12 -0700 Comment on attachment 200468 Patch Clearing flags on attachment: 200468 Committed r149543: <http://trac.webkit.org/changeset/149543> 884433 7 commit-queue 2013-05-03 16:11:15 -0700 All reviewed patches have been landed. Closing bug. 200468 2013-05-03 14:06:23 -0700 2013-05-03 16:11:12 -0700 Patch bug-115575-20130503230532.patch text/plain 2338 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg0NGI3Yjc0NzI5MWI0 MDcyMTliODcwYjk5OGM5NTc5YjUyYWMxYy4uNjE4M2FjZjI0NDc4MjQwMDc2MjkxZjJlZjk4ODgy MDUxMmM5ZDJjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA1LTAzICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gR1N0cmVhbWVyIGxvZyBjcmFzaGVzIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2UgYmVjYXVzZSBvZiB1bmluaXRpYWxpemVkIGNhdGVnb3J5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU1NzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIFVzaW5nIGV4dGVybiBkZWJ1ZyBjYXRlZ29yeS4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyQmFzZS5jcHA6CisgICAgICAgIERlY2xhcmluZyBkZWJ1ZyBjYXRlZ29yeSBhcyBub3Qg c3RhdGljLgorCiAyMDEzLTA1LTAzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5z ZW5AZGlnaWEuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gY2FsbGluZyBRV2ViRnJhbWU6OmV2 YWx1YXRlSmF2YVNjcmlwdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcAppbmRleCA3MDc2YWU2YjhkOTYwNzE2ZTMzOWY4ZGQzNjZiN2MyNmQ0OTUzZDRm Li5jYWYzYjc4NDI1MzU1YWIzMTQ2NWQxNGYxYmU3MjhlNDRiZjc0ZTE5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNzYsNyArNzYsNyBA QCBzdGF0aWMgY29uc3QgY2hhciogZ1BsYXliaW5OYW1lID0gInBsYXliaW4yIjsKIHN0YXRpYyBj b25zdCBnaW50NjQgZ1BlcmNlbnRNYXggPSAxMDA7CiAjZW5kaWYKIAotR1NUX0RFQlVHX0NBVEVH T1JZX1NUQVRJQyh3ZWJraXRfbWVkaWFfcGxheWVyX2RlYnVnKTsKK0dTVF9ERUJVR19DQVRFR09S WV9FWFRFUk4od2Via2l0X21lZGlhX3BsYXllcl9kZWJ1Zyk7CiAjZGVmaW5lIEdTVF9DQVRfREVG QVVMVCB3ZWJraXRfbWVkaWFfcGxheWVyX2RlYnVnCiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAK aW5kZXggMGNjMjgxMGNhNDU2NjIxYTFjMzczZjEyYTYxYTNkMTdmOTAwMDdjMi4uY2RhYTFkYjYx OWNlNTdhZmJhNTY0YzIwOTZmMWNjMDQ1MGU2MGI3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAtNTEsNyArNTEsNyBAQAog I2luY2x1ZGUgPGdzdC9pbnRlcmZhY2VzL3N0cmVhbXZvbHVtZS5oPgogI2VuZGlmCiAKLUdTVF9E RUJVR19DQVRFR09SWV9TVEFUSUMod2Via2l0X21lZGlhX3BsYXllcl9kZWJ1Zyk7CitHU1RfREVC VUdfQ0FURUdPUlkod2Via2l0X21lZGlhX3BsYXllcl9kZWJ1Zyk7CiAjZGVmaW5lIEdTVF9DQVRf REVGQVVMVCB3ZWJraXRfbWVkaWFfcGxheWVyX2RlYnVnCiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7 Cg==