115574 2013-05-03 13:55:39 -0700 Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null 2013-05-04 11:46:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin andersca bdakin benjamin sam oldest_to_newest 884319 0 bdakin 2013-05-03 13:55:39 -0700 The new WKBundlePageSetHeaderBanner does not correctly handle the null banner case. Patch forthcoming. <rdar://problem/13798364> 884324 1 200466 bdakin 2013-05-03 13:57:51 -0700 Created attachment 200466 Patch 884424 2 200466 benjamin 2013-05-03 15:58:15 -0700 Comment on attachment 200466 Patch No API tests? 884547 3 bdakin 2013-05-04 11:44:09 -0700 (In reply to comment #2) > (From update of attachment 200466 [details]) > No API tests? You're right; Sam and I should add API tests for this feature. Up until when Sam added the hit testing stuff to the API (which led to this crash), most of the interesting work was happening down in WebCore and we have been testing it with Internals.setHeaderHeight and Internals.setFooterHeight. 884548 4 bdakin 2013-05-04 11:46:05 -0700 http://trac.webkit.org/changeset/149561 200466 2013-05-03 13:57:51 -0700 2013-05-03 19:01:45 -0700 Patch for-review.txt text/plain 2032 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTUzNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA1LTAzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTc0CisgICAgICAgIENyYXNoIHVzaW5nIG5ldyBXS0J1bmRs ZVBhZ2VTZXRIZWFkZXJCYW5uZXIoKSBBUEkgdG8gc2V0IGEgYmFubmVyIHRvIG51bGwKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBjYWxsIGFk ZFRvUGFnZSgpIG9uIGEgbnVsbCBiYW5uZXIuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZXRIZWFkZXJQYWdlQmFu bmVyKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2V0Rm9vdGVyUGFnZUJhbm5lcik6CisK IDIwMTMtMDUtMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUERGUGx1Z2luOiBDaGFuZ2VzIGJlaW5nIG1hZGUgdG8gYWN0aXZlIGFubm90YXRpb24g YXJlbid0IHNhdmVkIHdoZW4gdGhlIFBERiBpcyBleHBvcnRlZApJbmRleDogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTQ5NTIzKQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNDEwLDEzICsxNDEwLDEzIEBAIHZvaWQgV2ViUGFnZTo6dW5pbnN0YWxsUGFn ZU92ZXJsYXkoUGFnZU8KIAogdm9pZCBXZWJQYWdlOjpzZXRIZWFkZXJQYWdlQmFubmVyKFBhc3NS ZWZQdHI8UGFnZUJhbm5lcj4gcGFnZUJhbm5lcikKIHsKLSAgICBpZiAobV9oZWFkZXJCYW5uZXIp IHsKKyAgICBpZiAobV9oZWFkZXJCYW5uZXIpCiAgICAgICAgIG1faGVhZGVyQmFubmVyLT5kZXRh Y2hGcm9tUGFnZSgpOwotICAgICAgICBtX2hlYWRlckJhbm5lciA9IDA7Ci0gICAgfQogCiAgICAg bV9oZWFkZXJCYW5uZXIgPSBwYWdlQmFubmVyOwotICAgIG1faGVhZGVyQmFubmVyLT5hZGRUb1Bh Z2UoUGFnZUJhbm5lcjo6SGVhZGVyLCB0aGlzKTsKKworICAgIGlmIChtX2hlYWRlckJhbm5lcikK KyAgICAgICAgbV9oZWFkZXJCYW5uZXItPmFkZFRvUGFnZShQYWdlQmFubmVyOjpIZWFkZXIsIHRo aXMpOwogfQogCiBQYWdlQmFubmVyKiBXZWJQYWdlOjpoZWFkZXJQYWdlQmFubmVyKCkKQEAgLTE0 MjYsMTMgKzE0MjYsMTMgQEAgUGFnZUJhbm5lciogV2ViUGFnZTo6aGVhZGVyUGFnZUJhbm5lcigp CiAKIHZvaWQgV2ViUGFnZTo6c2V0Rm9vdGVyUGFnZUJhbm5lcihQYXNzUmVmUHRyPFBhZ2VCYW5u ZXI+IHBhZ2VCYW5uZXIpCiB7Ci0gICAgaWYgKG1fZm9vdGVyQmFubmVyKSB7CisgICAgaWYgKG1f Zm9vdGVyQmFubmVyKQogICAgICAgICBtX2Zvb3RlckJhbm5lci0+ZGV0YWNoRnJvbVBhZ2UoKTsK LSAgICAgICAgbV9mb290ZXJCYW5uZXIgPSAwOwotICAgIH0KIAogICAgIG1fZm9vdGVyQmFubmVy ID0gcGFnZUJhbm5lcjsKLSAgICBtX2Zvb3RlckJhbm5lci0+YWRkVG9QYWdlKFBhZ2VCYW5uZXI6 OkZvb3RlciwgdGhpcyk7CisKKyAgICBpZiAobV9mb290ZXJCYW5uZXIpCisgICAgICAgIG1fZm9v dGVyQmFubmVyLT5hZGRUb1BhZ2UoUGFnZUJhbm5lcjo6Rm9vdGVyLCB0aGlzKTsKIH0KIAogUGFn ZUJhbm5lciogV2ViUGFnZTo6Zm9vdGVyUGFnZUJhbm5lcigpCg==