115559 2013-05-03 11:32:00 -0700 REGRESSION (r145042): Downloading a file sometimes results in could not create a sandbox extension Console message and file stays as a .download file 2013-05-03 13:29:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap ap andersca oldest_to_newest 884242 0 ap 2013-05-03 11:32:00 -0700 This is a bug that existed before it was uncovered by r145042. fileSystemRepresentation returns a CString that has a buffer that's longer than its length, and then resolveSymlinksInPath treats it as if buffer size was the length. <rdar://problem/13785101> 884244 1 ap 2013-05-03 11:34:58 -0700 This is much like bug 55412. I'd like to see if these CString issues can be fixed for good... 884296 2 200463 ap 2013-05-03 12:41:33 -0700 Created attachment 200463 proposed fix 884309 3 ap 2013-05-03 13:29:11 -0700 Committed <http://trac.webkit.org/r149531>. 200463 2013-05-03 12:41:33 -0700 2013-05-03 13:26:17 -0700 proposed fix DownloadSandboxExtension.txt text/plain 2160 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTUyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA1LTAzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNDUw NDIpOiBEb3dubG9hZGluZyBhIGZpbGUgc29tZXRpbWVzIHJlc3VsdHMgaW4gY291bGQgbm90IGNy ZWF0ZQorICAgICAgICBhIHNhbmRib3ggZXh0ZW5zaW9uIENvbnNvbGUgbWVzc2FnZSBhbmQgZmls ZSBzdGF5cyBhcyBhIC5kb3dubG9hZCBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU1NTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzNzg1 MTAxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENT dHJpbmcgaXMgZXZpbCwgaXQgaGFzIHR3byBsZW5ndGhzIHdoaWNoIGNhbiBiZSBkaWZmZXJlbnQg LSBzcGVjaWZpY2FsbHksIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbigpCisgICAgICAgIGNyZWF0 ZXMgYSBzdHJpbmcgd2l0aCBtYXhpbXVtIHBvc3NpYmxlIGJ1ZmZlciBzaXplLiBUaGlzIHdhcyBj b25mdXNpbmcgcmVzb2x2ZVN5bWxpbmtzSW5QYXRoKCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j Zi9GaWxlU3lzdGVtQ0YuY3BwOiAoV2ViQ29yZTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKToK KyAgICAgICAgQ2hhbmdlIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbiB0byBiZSBsZXNzIHN1cnBy aXNpbmcuIFJlYWxseSwgd2Ugc2hvdWxkIHJpcCBhcGFydAorICAgICAgICBDU3RyaW5nIGFuZCB1 cGRhdGUgY2FsbGVycyB0byB1c2UgYmV0dGVyIGRlZmluZWQgc2VtYW50aWNzLCBidXQgdGhpcyBp cyB0aGUgb25lIGZ1bmN0aW9uCisgICAgICAgIHRoYXQgcmVwZWF0ZWRseSBjYXVzZXMgcHJvYmxl bXMgaW4gcHJhY3RpY2UuCisKIDIwMTMtMDUtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFVzZSBOb3ROdWxsIHRhZyBmb3IgcGxhY2VtZW50IG5ldyBpbiBX ZWJDb3JlLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvRmlsZVN5c3RlbUNGLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9GaWxlU3lzdGVtQ0Yu Y3BwCShyZXZpc2lvbiAxNDk1MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9GaWxl U3lzdGVtQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCwxNSArNDQsMTQgQEAgQ1N0cmluZyBm aWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29uc3QgUwogCiAgICAgQ0ZJbmRleCBzaXplID0gQ0ZT dHJpbmdHZXRNYXhpbXVtU2l6ZU9mRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGNmU3RyaW5nLmdl dCgpKTsKIAotICAgIGNoYXIqIGJ1ZmZlcjsKLSAgICBDU3RyaW5nIHN0cmluZyA9IENTdHJpbmc6 Om5ld1VuaW5pdGlhbGl6ZWQoc2l6ZSwgYnVmZmVyKTsKKyAgICBWZWN0b3I8Y2hhcj4gYnVmZmVy KHNpemUpOwogCi0gICAgaWYgKCFDRlN0cmluZ0dldEZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihj ZlN0cmluZy5nZXQoKSwgYnVmZmVyLCBzaXplKSkgeworICAgIGlmICghQ0ZTdHJpbmdHZXRGaWxl U3lzdGVtUmVwcmVzZW50YXRpb24oY2ZTdHJpbmcuZ2V0KCksIGJ1ZmZlci5kYXRhKCksIGJ1ZmZl ci5zaXplKCkpKSB7CiAgICAgICAgIExPR19FUlJPUigiRmFpbGVkIHRvIGdldCBmaWxlc3lzdGVt IHJlcHJlc2VudGF0aW9uIHRvIGNyZWF0ZSBDU3RyaW5nIGZyb20gY2ZTdHJpbmciKTsKICAgICAg ICAgcmV0dXJuIENTdHJpbmcoKTsKICAgICB9CiAKLSAgICByZXR1cm4gc3RyaW5nOworICAgIHJl dHVybiBDU3RyaW5nKGJ1ZmZlci5kYXRhKCksIHN0cmxlbihidWZmZXIuZGF0YSgpKSk7CiB9CiAK IFJldGFpblB0cjxDRlVSTFJlZj4gcGF0aEFzVVJMKGNvbnN0IFN0cmluZyYgcGF0aCkK