115551 2013-05-03 09:33:58 -0700 [Qt] Build with --video-track fails because String(AtomicString) is ambiguous 2013-05-03 16:43:54 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED PlatformOnly, Qt P2 Normal --- 0 b.long webkit-unassigned b.long commit-queue eric.carlson esprehn+autocc glenn jer.noble pnormand oldest_to_newest 884172 0 b.long 2013-05-03 09:33:58 -0700 [Qt] Build with --video-track fails because String(AtomicString) is ambiguous 884173 1 200419 b.long 2013-05-03 09:35:33 -0700 Created attachment 200419 Fix QtWebKitBuild with --video-track 884174 2 b.long 2013-05-03 09:37:37 -0700 I'm using qt5-tools (https://github.com/ossy-szeged/qt5-tools) to build Qt5, which may be out of date (2 months since last commit), but this error only shows up if I build with --video-track. Full error message: /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp: In member function 'void WebCore::HTMLMediaElement::configureTextTrackGroup(const WebCore::HTMLMediaElement::TrackGroup&)': /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: note: candidates are: /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&) /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&) /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: note: candidates are: /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&) /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&) 884258 3 pnormand 2013-05-03 11:46:15 -0700 Why is this not working only in Qt? A change to cross-port code to satisfy a single port is suspect to me. 884294 4 b.long 2013-05-03 12:33:15 -0700 I'm trying to build against a different version of Qt to see if this is just a weird issue with the versions not matching up. 884403 5 b.long 2013-05-03 15:08:37 -0700 I get this when building against Qt5 master also, so it seems to be a real problem. It seems like making String(AtomicString) not ambiguous would be nice, but I'm not sure if there's a reasonable way to do that. 884434 6 200419 benjamin 2013-05-03 16:20:29 -0700 Comment on attachment 200419 Fix QtWebKitBuild with --video-track Not sure why would that constructor would be ambiguous, but the patch looks fine. 884438 7 200419 commit-queue 2013-05-03 16:43:51 -0700 Comment on attachment 200419 Fix QtWebKitBuild with --video-track Clearing flags on attachment: 200419 Committed r149544: <http://trac.webkit.org/changeset/149544> 884439 8 commit-queue 2013-05-03 16:43:54 -0700 All reviewed patches have been landed. Closing bug. 200419 2013-05-03 09:35:33 -0700 2013-05-03 16:43:51 -0700 Fix QtWebKitBuild with --video-track bug-115551-20130503103444.patch text/plain 1841 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg0NGI3Yjc0NzI5MWI0 MDcyMTliODcwYjk5OGM5NTc5YjUyYWMxYy4uNzVkNWJhZTY2MGZlYWMyMmVkMjMyMjgwYWRjYjI0 ZDNjYjFkNmM0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTAzICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbUXRdIEJ1aWxkIHdp dGggLS12aWRlby10cmFjayBmYWlscyBiZWNhdXNlIFN0cmluZyhBdG9taWNTdHJpbmcpIGlzIGFt YmlndW91cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6Y29uZmlndXJlVGV4dFRyYWNrR3JvdXApOgorICAgICAgICBDaGFuZ2UgU3RyaW5n KHRleHRUcmFjay0+a2luZCgpKSB0byB0ZXh0VHJhY2stPmtpbmQoKS5zdHJpbmcoKSwgYW5kIHNh bWUgdGhpbmcgd2l0aCBsYW5ndWFnZS4KKwogMjAxMy0wNS0wMyAgQWxsYW4gU2FuZGZlbGQgSmVu c2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAogICAgICAgICBDcmFzaCB3aGVuIGNhbGxp bmcgUVdlYkZyYW1lOjpldmFsdWF0ZUphdmFTY3JpcHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwCmluZGV4IDRlYzFkMGJiNzZkMWM2MzE1YjBlZDQyNzZmOWQ1MWQ1NGEx ZjU5ODMuLjg0Y2NiMjg3ZTJkNmE5MTgwYTUzMGUwZmUxMjk3YmQxMjY4M2UzMWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMzIwNyw3ICszMjA3LDcgQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tHcm91cChjb25zdCBUcmFj a0dyb3VwJiBncm91cCkKICAgICAgICAgICAgIGN1cnJlbnRseUVuYWJsZWRUcmFja3MuYXBwZW5k KHRleHRUcmFjayk7CiAKICAgICAgICAgaW50IHRyYWNrU2NvcmUgPSBjYXB0aW9uUHJlZmVyZW5j ZXMgPyBjYXB0aW9uUHJlZmVyZW5jZXMtPnRleHRUcmFja1NlbGVjdGlvblNjb3JlKHRleHRUcmFj ay5nZXQoKSwgdGhpcykgOiAwOwotICAgICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50 Ojpjb25maWd1cmVUZXh0VHJhY2tHcm91cCAtICAnJXMnIHRyYWNrIHdpdGggbGFuZ3VhZ2UgJyVz JyBoYXMgc2NvcmUgJWkiLCBTdHJpbmcodGV4dFRyYWNrLT5raW5kKCkpLnV0ZjgoKS5kYXRhKCks IFN0cmluZyh0ZXh0VHJhY2stPmxhbmd1YWdlKCkpLnV0ZjgoKS5kYXRhKCksIHRyYWNrU2NvcmUp OworICAgICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojpjb25maWd1cmVUZXh0VHJh Y2tHcm91cCAtICAnJXMnIHRyYWNrIHdpdGggbGFuZ3VhZ2UgJyVzJyBoYXMgc2NvcmUgJWkiLCB0 ZXh0VHJhY2stPmtpbmQoKS5zdHJpbmcoKS51dGY4KCkuZGF0YSgpLCB0ZXh0VHJhY2stPmxhbmd1 YWdlKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgdHJhY2tTY29yZSk7CiAKICAgICAgICAgaWYg KHRyYWNrU2NvcmUpIHsKIAo=