115546 2013-05-03 05:13:47 -0700 Remove some "what" comments from FindController 2013-05-03 13:58:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca oldest_to_newest 884144 0 thorton 2013-05-03 05:13:47 -0700 I don't even. 884145 1 200411 thorton 2013-05-03 05:16:25 -0700 Created attachment 200411 remove comments 884187 2 200411 kling 2013-05-03 09:54:41 -0700 Comment on attachment 200411 remove comments Huh. 884325 3 thorton 2013-05-03 13:58:05 -0700 http://trac.webkit.org/changeset/149534 200411 2013-05-03 05:16:25 -0700 2013-05-03 09:54:40 -0700 remove comments findcontroller.diff text/plain 4015 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOWQ0YjMzLi5mNGZlMTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDUtMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIHNvbWUgIndoYXQiIGNvbW1lbnRzIGZyb20gRmluZENvbnRyb2xsZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTU0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RmluZENv bnRyb2xsZXI6OmNvdW50U3RyaW5nTWF0Y2hlcyk6CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250 cm9sbGVyOjp1cGRhdGVGaW5kVUlBZnRlclBhZ2VTY3JvbGwpOgorICAgICAgICAoV2ViS2l0OjpG aW5kQ29udHJvbGxlcjo6d2lsbE1vdmVUb1dlYlBhZ2UpOgorICAgICAgICAoV2ViS2l0OjpGaW5k Q29udHJvbGxlcjo6bW91c2VFdmVudCk6CisgICAgICAgIFJlbW92ZSBvciByZXdvcmQgc29tZSBj b21tZW50cy4KKwogMjAxMy0wNS0wMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgW1dLMl1bQ3VzdG9tUHJvdG9jb2xzXSBOU1VSTFByb3RvY29sQ2xpZW50IG1ldGhv ZHMgc2hvdWxkIGJlIGRpc3BhdGNoZWQgb24gTlNVUkxDb25uZWN0aW9uJ3MgcmVzb3VyY2UgbG9h ZGVyIHJ1biBsb29wCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvRmluZENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0ZpbmRDb250cm9sbGVyLmNwcAppbmRleCA1Y2IyNmU4Li4yNzlmNmFiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKQEAg LTkxLDcgKzkxLDYgQEAgdm9pZCBGaW5kQ29udHJvbGxlcjo6Y291bnRTdHJpbmdNYXRjaGVzKGNv bnN0IFN0cmluZyYgc3RyaW5nLCBGaW5kT3B0aW9ucyBvcHRpb24KICAgICAgICAgbV93ZWJQYWdl LT5jb3JlUGFnZSgpLT51bm1hcmtBbGxUZXh0TWF0Y2hlcygpOwogICAgIH0KIAotICAgIC8vIENo ZWNrIGlmIHdlIGhhdmUgbW9yZSBtYXRjaGVzIHRoYW4gYWxsb3dlZC4KICAgICBpZiAobWF0Y2hD b3VudCA+IG1heE1hdGNoQ291bnQpCiAgICAgICAgIG1hdGNoQ291bnQgPSBzdGF0aWNfY2FzdDx1 bnNpZ25lZD4oa1dLTW9yZVRoYW5NYXhpbXVtTWF0Y2hDb3VudCk7CiAgICAgCkBAIC0xMjAsNyAr MTE5LDYgQEAgdm9pZCBGaW5kQ29udHJvbGxlcjo6dXBkYXRlRmluZFVJQWZ0ZXJQYWdlU2Nyb2xs KGJvb2wgZm91bmQsIGNvbnN0IFN0cmluZyYgc3RyaW4KICAgICAgICAgaWYgKCFwbHVnaW5WaWV3 KQogICAgICAgICAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT51bm1hcmtBbGxUZXh0TWF0Y2hl cygpOwogCi0gICAgICAgIC8vIENsZWFyIHRoZSBzZWxlY3Rpb24uCiAgICAgICAgIGlmIChzZWxl Y3RlZEZyYW1lKQogICAgICAgICAgICAgc2VsZWN0ZWRGcmFtZS0+c2VsZWN0aW9uKCktPmNsZWFy KCk7CiAKQEAgLTE0NSw3ICsxNDMsNyBAQCB2b2lkIEZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5k VUlBZnRlclBhZ2VTY3JvbGwoYm9vbCBmb3VuZCwgY29uc3QgU3RyaW5nJiBzdHJpbgogICAgICAg ICAgICAgICAgIG1hdGNoQ291bnQgPSBtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPm1hcmtBbGxNYXRj aGVzRm9yVGV4dChzdHJpbmcsIGNvcmUob3B0aW9ucyksIHNob3VsZFNob3dIaWdobGlnaHQsIG1h eE1hdGNoQ291bnQgKyAxKTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgLy8gQ2hlY2sg aWYgd2UgaGF2ZSBtb3JlIG1hdGNoZXMgdGhhbiBhbGxvd2VkLgorICAgICAgICAgICAgLy8gSWYg d2UgaGF2ZSBhIGxhcmdlIG51bWJlciBvZiBtYXRjaGVzLCB3ZSBkb24ndCB3YW50IHRvIHRha2Ug dGhlIHRpbWUgdG8gcGFpbnQgdGhlIG92ZXJsYXkuCiAgICAgICAgICAgICBpZiAobWF0Y2hDb3Vu dCA+IG1heE1hdGNoQ291bnQpIHsKICAgICAgICAgICAgICAgICBzaG91bGRTaG93T3ZlcmxheSA9 IGZhbHNlOwogICAgICAgICAgICAgICAgIG1hdGNoQ291bnQgPSBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4oa1dLTW9yZVRoYW5NYXhpbXVtTWF0Y2hDb3VudCk7CkBAIC0xNTQsMTcgKzE1MiwxMyBAQCB2 b2lkIEZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5kVUlBZnRlclBhZ2VTY3JvbGwoYm9vbCBmb3Vu ZCwgY29uc3QgU3RyaW5nJiBzdHJpbgogCiAgICAgICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdl czo6V2ViUGFnZVByb3h5OjpEaWRGaW5kU3RyaW5nKHN0cmluZywgbWF0Y2hDb3VudCkpOwogCi0g ICAgICAgIGlmICghKG9wdGlvbnMgJiBGaW5kT3B0aW9uc1Nob3dGaW5kSW5kaWNhdG9yKSB8fCAh dXBkYXRlRmluZEluZGljYXRvcihzZWxlY3RlZEZyYW1lLCBzaG91bGRTaG93T3ZlcmxheSkpIHsK LSAgICAgICAgICAgIC8vIEVpdGhlciB3ZSBzaG91bGRuJ3Qgc2hvdyB0aGUgZmluZCBpbmRpY2F0 b3IsIG9yIHdlIGNvdWxkbid0IHVwZGF0ZSBpdC4KKyAgICAgICAgaWYgKCEob3B0aW9ucyAmIEZp bmRPcHRpb25zU2hvd0ZpbmRJbmRpY2F0b3IpIHx8ICF1cGRhdGVGaW5kSW5kaWNhdG9yKHNlbGVj dGVkRnJhbWUsIHNob3VsZFNob3dPdmVybGF5KSkKICAgICAgICAgICAgIGhpZGVGaW5kSW5kaWNh dG9yKCk7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoIXNob3VsZFNob3dPdmVybGF5KSB7 Ci0gICAgICAgIGlmIChtX2ZpbmRQYWdlT3ZlcmxheSkgewotICAgICAgICAgICAgLy8gR2V0IHJp ZCBvZiB0aGUgb3ZlcmxheS4KKyAgICAgICAgaWYgKG1fZmluZFBhZ2VPdmVybGF5KQogICAgICAg ICAgICAgbV93ZWJQYWdlLT51bmluc3RhbGxQYWdlT3ZlcmxheShtX2ZpbmRQYWdlT3ZlcmxheSwg dHJ1ZSk7Ci0gICAgICAgIH0gICAgICAgIAogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmICghbV9m aW5kUGFnZU92ZXJsYXkpIHsKICAgICAgICAgICAgIFJlZlB0cjxQYWdlT3ZlcmxheT4gZmluZFBh Z2VPdmVybGF5ID0gUGFnZU92ZXJsYXk6OmNyZWF0ZSh0aGlzKTsKQEAgLTM4NCw3ICszNzgsNiBA QCB2b2lkIEZpbmRDb250cm9sbGVyOjp3aWxsTW92ZVRvV2ViUGFnZShQYWdlT3ZlcmxheSosIFdl YlBhZ2UqIHdlYlBhZ2UpCiAgICAgaWYgKHdlYlBhZ2UpCiAgICAgICAgIHJldHVybjsKIAotICAg IC8vIFRoZSBwYWdlIG92ZXJsYXkgaXMgbW92aW5nIGF3YXkgZnJvbSB0aGUgd2ViIHBhZ2UsIHJl c2V0IGl0LgogICAgIEFTU0VSVChtX2ZpbmRQYWdlT3ZlcmxheSk7CiAgICAgbV9maW5kUGFnZU92 ZXJsYXkgPSAwOwogfQpAQCAtNDYxLDExICs0NTQsOCBAQCB2b2lkIEZpbmRDb250cm9sbGVyOjpk cmF3UmVjdChQYWdlT3ZlcmxheSogcGFnZU92ZXJsYXksIEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhp YwogCiBib29sIEZpbmRDb250cm9sbGVyOjptb3VzZUV2ZW50KFBhZ2VPdmVybGF5KiwgY29uc3Qg V2ViTW91c2VFdmVudCYgbW91c2VFdmVudCkKIHsKLSAgICAvLyBJZiB3ZSBnZXQgYSBtb3VzZSBk b3duIGV2ZW50IGluc2lkZSB0aGUgcGFnZSBvdmVybGF5IHdlIHNob3VsZCBoaWRlIHRoZSBmaW5k IFVJLgotICAgIGlmIChtb3VzZUV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6TW91c2VEb3duKSB7 Ci0gICAgICAgIC8vIERpc21pc3MgdGhlIG92ZXJsYXkuCisgICAgaWYgKG1vdXNlRXZlbnQudHlw ZSgpID09IFdlYkV2ZW50OjpNb3VzZURvd24pCiAgICAgICAgIGhpZGVGaW5kVUkoKTsKLSAgICB9 CiAKICAgICByZXR1cm4gZmFsc2U7CiB9Cg==