115544 2013-05-03 04:31:08 -0700 PDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported 2013-05-03 13:56:43 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap simon.fraser webkit-bug-importer oldest_to_newest 884132 0 thorton 2013-05-03 04:31:08 -0700 Steps to Reproduce: 1. Start editing a field in a PDFPlugin. Type some stuff, don't commit it. 2. Hit Cmd-S. Save the file. Expected: A file with the stuff you typed in the field. Actual: The field is blank. Notes: We need to commit before we return liveData(), before we decide whether the PDF form data has been mutated or not. 884133 1 webkit-bug-importer 2013-05-03 04:32:25 -0700 <rdar://problem/13801789> 884134 2 200407 thorton 2013-05-03 04:35:55 -0700 Created attachment 200407 patch 884322 3 thorton 2013-05-03 13:56:43 -0700 http://trac.webkit.org/changeset/149536 200407 2013-05-03 04:35:55 -0700 2013-05-03 08:31:25 -0700 patch livedata-commit.diff text/plain 2851 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOWQ0YjMzLi5kZTE5ZDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUERGUGx1Z2luOiBDaGFuZ2VzIGJlaW5nIG1hZGUgdG8gYWN0aXZlIGFubm90YXRp b24gYXJlbid0IHNhdmVkIHdoZW4gdGhlIFBERiBpcyBleHBvcnRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTQ0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xMzgwMTc4OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb21taXQgY2hhbmdlcyB0byB0aGUgYWN0aXZlIGFubm90YXRpb24gKGlmIHRo ZXJlIGlzIG9uZSkgYmVmb3JlCisgICAgICAgIHJldHVybmluZyB0aGUgbGl2ZSBQREYgZGF0YSwg c28gdGhhdCBzYWlkIGNoYW5nZXMgYXJlIHJlcHJlc2VudGVkCisgICAgICAgIGluIHRoZSBleHBv cnRlZCBvciBwcmludGVkIG91dHB1dC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9Q REYvUERGUGx1Z2luLmg6IE92ZXJyaWRlIGxpdmVEYXRhLgorICAgICAgICAqIFdlYlByb2Nlc3Mv UGx1Z2lucy9QREYvUERGUGx1Z2luLm1tOgorICAgICAgICAoV2ViS2l0OjpQREZQbHVnaW46Omxp dmVEYXRhKTogQ29tbWl0IHRoZSBhY3RpdmUgYW5ub3RhdGlvbiBpZiB0aGVyZSBpcyBvbmUuCisg ICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQREZQbHVnaW4uaDoKKyAgICAg ICAgKFNpbXBsZVBERlBsdWdpbik6IE1ha2UgbGl2ZURhdGEgdmlydHVhbC4KKwogMjAxMy0wNS0w MiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl1bQ3VzdG9t UHJvdG9jb2xzXSBOU1VSTFByb3RvY29sQ2xpZW50IG1ldGhvZHMgc2hvdWxkIGJlIGRpc3BhdGNo ZWQgb24gTlNVUkxDb25uZWN0aW9uJ3MgcmVzb3VyY2UgbG9hZGVyIHJ1biBsb29wCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaAppbmRleCA3 MWI3OGRjLi4xZDU1NjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERlBsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9QREYvUERGUGx1Z2luLmgKQEAgLTE0Miw2ICsxNDIsOCBAQCBwcml2YXRlOgogCiAgICAg V2ViQ29yZTo6SW50UG9pbnQgY29udmVydEZyb21QREZWaWV3VG9Sb290Vmlldyhjb25zdCBXZWJD b3JlOjpJbnRQb2ludCYpIGNvbnN0OwogCisgICAgdmlydHVhbCBOU0RhdGEgKmxpdmVEYXRhKCkg Y29uc3QgT1ZFUlJJREU7CisKICAgICBlbnVtIFVwZGF0ZUN1cnNvck1vZGUgewogICAgICAgICBV cGRhdGVJZk5lZWRlZCwKICAgICAgICAgRm9yY2VVcGRhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXggZDlhY2NhNC4uNjMz NDFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0KQEAgLTEwOTksNiArMTA5OSwxNCBAQCBib29sIFBERlBsdWdpbjo6aGFuZGxl V2hlZWxFdmVudChjb25zdCBXZWJXaGVlbEV2ZW50JiBldmVudCkKICAgICByZXR1cm4gU2ltcGxl UERGUGx1Z2luOjpoYW5kbGVXaGVlbEV2ZW50KGV2ZW50KTsKIH0KIAorTlNEYXRhICpQREZQbHVn aW46OmxpdmVEYXRhKCkgY29uc3QKK3sKKyAgICBpZiAobV9hY3RpdmVBbm5vdGF0aW9uKQorICAg ICAgICBtX2FjdGl2ZUFubm90YXRpb24tPmNvbW1pdCgpOworCisgICAgcmV0dXJuIFNpbXBsZVBE RlBsdWdpbjo6bGl2ZURhdGEoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKICNlbmRp ZiAvLyBFTkFCTEUoUERGS0lUX1BMVUdJTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QREYvU2ltcGxlUERGUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvUERGL1NpbXBsZVBERlBsdWdpbi5oCmluZGV4IDJhMmYxMTIuLjA4 ZGE3NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYv U2ltcGxlUERGUGx1Z2luLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BERi9TaW1wbGVQREZQbHVnaW4uaApAQCAtNzMsNyArNzMsNyBAQCBwcm90ZWN0ZWQ6CiAKICAg ICBjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZEZpbGVuYW1lKCkgeyByZXR1cm4gbV9zdWdnZXN0ZWRG aWxlbmFtZTsgfQogICAgIAotICAgIE5TRGF0YSAqbGl2ZURhdGEoKSBjb25zdDsKKyAgICB2aXJ0 dWFsIE5TRGF0YSAqbGl2ZURhdGEoKSBjb25zdDsKICAgICBOU0RhdGEgKnJhd0RhdGEoKSBjb25z dCB7IHJldHVybiAoTlNEYXRhICopbV9kYXRhLmdldCgpOyB9CiAKICAgICBib29sIHBkZkRvY3Vt ZW50V2FzTXV0YXRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcGRmRG9jdW1lbnRXYXNNdXRhdGVkOyB9 Cg==