115534 2013-05-02 16:27:57 -0700 [CSSRegions] Improve hit testing for empty regions 2013-05-14 10:55:06 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea mihnea allan.jensen commit-queue esprehn+autocc glenn hyatt WebkitBugTracker oldest_to_newest 884008 0 mihnea 2013-05-02 16:27:57 -0700 WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107752 provided a way to fix incorrect selection of content in HTML document when clicking inside an empty region. I want to address the follow up comment from David Hyatt and improve the hit testing code. 884014 1 200369 mihnea 2013-05-02 16:37:33 -0700 Created attachment 200369 Patch 887540 2 200369 hyatt 2013-05-10 13:26:38 -0700 Comment on attachment 200369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200369&action=review > Source/WebCore/rendering/RenderObject.cpp:2624 > - if (hitTestFilter != HitTestDescendants && !inside) > + if (hitTestFilter != HitTestDescendants && !inside && !isRenderFlowThread()) I wonder if it would be cleaner to subclass nodeAtPoint for RenderFlowThread and have it return false always if HitTestBlockBackground is the flag? 887750 3 201449 mihnea 2013-05-10 23:18:32 -0700 Created attachment 201449 Patch 2 Use David's suggestion as the hittesting code is better contained in RFT class. 888844 4 201449 hyatt 2013-05-14 08:10:29 -0700 Comment on attachment 201449 Patch 2 r=me 888871 5 201725 mihnea 2013-05-14 09:24:22 -0700 Created attachment 201725 Patch for landing 888927 6 201725 commit-queue 2013-05-14 10:55:03 -0700 Comment on attachment 201725 Patch for landing Clearing flags on attachment: 201725 Committed r150078: <http://trac.webkit.org/changeset/150078> 888928 7 commit-queue 2013-05-14 10:55:06 -0700 All reviewed patches have been landed. Closing bug. 200369 2013-05-02 16:37:33 -0700 2013-05-10 23:18:32 -0700 Patch 115534.patch text/plain 3247 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNjVlNTAwLi43ZmM1YzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDUtMDIgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIEltcHJvdmUgaGl0IHRlc3RpbmcgZm9yIGVtcHR5IHJlZ2lvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTUzNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgYmV0 dGVyIGZvbGxvdyB1cCBhZnRlciBXZWJLaXQgYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDc3NTIsCisgICAgICAgIHdlIGNhbiBpbXByb3ZlIHRoZSBjb2RlIGJ5 IG5vdCBkb2luZyBoaXQgdGVzdGluZyBvbiB0aGUgcmVuZGVyIGZsb3cgdGhyZWFkIG9iamVjdCB3 aGVuCisgICAgICAgIHdlIGFyZSB0cnlpbmcgdG8gaGl0IHRlc3QgdGhlIHJlbmRlciBmbG93IHRo cmVhZCBiYWNrZ3JvdW5kLiBJbiB0aGlzIGNhc2UsIHdlIHNob3VsZCBqdXN0IGJhaWwgb3V0Lgor ICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgcmVnaW9ucyB0ZXN0cy4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6OmhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9u KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck9iamVjdDo6aGl0VGVzdCk6CisKIDIwMTMtMDUtMDIgIEVyaWMgQ2FybHNvbiAg PGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2FwdGlvbiBtZW51IGRvZXMgbm90 IGluY2x1ZGUgaW4tYmFuZCBjYXB0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZsb3dUaHJlYWQuY3BwCmluZGV4IGI3YWJkMDEuLmY5MjE5MTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKQEAgLTMyNCwxNyArMzI0LDEx IEBAIGJvb2wgUmVuZGVyRmxvd1RocmVhZDo6aGl0VGVzdEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdp b24oUmVuZGVyUmVnaW9uKiByZWdpb24sIExhCiAKICAgICAvLyBBbHdheXMgaWdub3JlIGNsaXBw aW5nLCBzaW5jZSB0aGUgUmVuZGVyRmxvd1RocmVhZCBoYXMgbm90aGluZyB0byBkbyB3aXRoIHRo ZSBib3VuZHMgb2YgdGhlIEZyYW1lVmlldy4KICAgICBIaXRUZXN0UmVxdWVzdCBuZXdSZXF1ZXN0 KHJlcXVlc3QudHlwZSgpIHwgSGl0VGVzdFJlcXVlc3Q6Oklnbm9yZUNsaXBwaW5nIHwgSGl0VGVz dFJlcXVlc3Q6OkRpc2FsbG93U2hhZG93Q29udGVudCk7Ci0gICAgSGl0VGVzdFJlc3VsdCB0ZW1w UmVzdWx0KHJlc3VsdCk7CiAKICAgICAvLyBNYWtlIGEgbmV3IHRlbXBvcmFyeSBIaXRUZXN0TG9j YXRpb24gaW4gdGhlIG5ldyByZWdpb24uCiAgICAgSGl0VGVzdExvY2F0aW9uIG5ld0hpdFRlc3RM b2NhdGlvbihsb2NhdGlvbkluQ29udGFpbmVyLCAtcmVuZGVyRmxvd1RocmVhZE9mZnNldCwgcmVn aW9uKTsKIAotICAgIGJvb2wgaXNQb2ludEluc2lkZUZsb3dUaHJlYWQgPSBsYXllcigpLT5oaXRU ZXN0KG5ld1JlcXVlc3QsIG5ld0hpdFRlc3RMb2NhdGlvbiwgdGVtcFJlc3VsdCk7Ci0KLSAgICAv LyBXZSB3YW50IHRvIG1ha2Ugc3VyZSB3ZSBoaXQgYSBub2RlIGZyb20gdGhlIGNvbnRlbnQgaW5z aWRlIHRoZSBmbG93IHRocmVhZC4KLSAgICBpc1BvaW50SW5zaWRlRmxvd1RocmVhZCA9IGlzUG9p bnRJbnNpZGVGbG93VGhyZWFkICYmICF0ZW1wUmVzdWx0LmlubmVyTm9kZSgpLT5pc0RvY3VtZW50 Tm9kZSgpOwotICAgIGlmIChpc1BvaW50SW5zaWRlRmxvd1RocmVhZCkKLSAgICAgICAgcmVzdWx0 ID0gdGVtcFJlc3VsdDsKKyAgICBib29sIGlzUG9pbnRJbnNpZGVGbG93VGhyZWFkID0gbGF5ZXIo KS0+aGl0VGVzdChuZXdSZXF1ZXN0LCBuZXdIaXRUZXN0TG9jYXRpb24sIHJlc3VsdCk7CiAKICAg ICAvLyBGSVhNRTogU2hvdWxkIHdlIHNldCByZXN1bHQubV9sb2NhbFBvaW50IGJhY2sgdG8gdGhl IFJlbmRlclJlZ2lvbidzIGNvb3JkaW5hdGUgc3BhY2Ugb3IgbGVhdmUgaXQgaW4gdGhlIFJlbmRl ckZsb3dUaHJlYWQncyBjb29yZGluYXRlCiAgICAgLy8gc3BhY2U/IFJpZ2h0IG5vdyBpdCdzIHN0 YXlpbmcgaW4gdGhlIFJlbmRlckZsb3dUaHJlYWQncyBjb29yZGluYXRlIHNwYWNlLCB3aGljaCBt YXkgZW5kIHVwIGJlaW5nIG9rLiBXZSB3aWxsIGtub3cgbW9yZSB3aGVuIHdlIGdldCBhcm91bmQg dG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggMTdhMWJk OS4uODVjMDJiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAK QEAgLTI2MjEsNyArMjYyMSw3IEBAIGJvb2wgUmVuZGVyT2JqZWN0OjpoaXRUZXN0KGNvbnN0IEhp dFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsCiAgICAgfQogCiAg ICAgLy8gU2VlIGlmIHRoZSBtb3VzZSBpcyBpbnNpZGUgdXMgYnV0IG5vdCBhbnkgb2Ygb3VyIGRl c2NlbmRhbnRzCi0gICAgaWYgKGhpdFRlc3RGaWx0ZXIgIT0gSGl0VGVzdERlc2NlbmRhbnRzICYm ICFpbnNpZGUpCisgICAgaWYgKGhpdFRlc3RGaWx0ZXIgIT0gSGl0VGVzdERlc2NlbmRhbnRzICYm ICFpbnNpZGUgJiYgIWlzUmVuZGVyRmxvd1RocmVhZCgpKQogICAgICAgICBpbnNpZGUgPSBub2Rl QXRQb2ludChyZXF1ZXN0LCByZXN1bHQsIGxvY2F0aW9uSW5Db250YWluZXIsIGFjY3VtdWxhdGVk T2Zmc2V0LCBIaXRUZXN0QmxvY2tCYWNrZ3JvdW5kKTsKIAogICAgIHJldHVybiBpbnNpZGU7Cg== 201449 2013-05-10 23:18:32 -0700 2013-05-14 09:24:11 -0700 Patch 2 115534-2.patch text/plain 4600 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYThhY2MzLi4zNWFhNzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMTAgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIEltcHJvdmUgaGl0IHRlc3RpbmcgZm9yIGVtcHR5IHJlZ2lvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNTUzNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgYmV0 dGVyIGZvbGxvdyB1cCBhZnRlciBXZWJLaXQgYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDc3NTIsCisgICAgICAgIHdlIGNhbiBpbXByb3ZlIHRoZSBjb2RlIGJ5 IG5vdCBkb2luZyBoaXQgdGVzdGluZyBvbiB0aGUgcmVuZGVyIGZsb3cgdGhyZWFkIG9iamVjdCB3 aGVuCisgICAgICAgIHdlIGFyZSB0cnlpbmcgdG8gaGl0IHRlc3QgdGhlIHJlbmRlciBmbG93IHRo cmVhZCBiYWNrZ3JvdW5kLiBJbiB0aGlzIGNhc2UsIHdlIHNob3VsZCBqdXN0IGJhaWwgb3V0Lgor ICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgcmVnaW9ucyB0ZXN0cy4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6Om5vZGVBdFBvaW50KToKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1RocmVhZDo6aGl0VGVzdEZsb3dUaHJlYWRQ b3J0aW9uSW5SZWdpb24pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmg6 CisKIDIwMTMtMDUtMTAgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IGRldGVybWluZSB0aGUgcmVzb3VyY2UgdHlwZSBpbiBJbnNw ZWN0b3JSZXNvdXJjZUFnZW50Ojp3aWxsU2VuZFJlcXVlc3QuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKaW5kZXggYjdhYmQwMS4uYzZjMDY3YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcApAQCAtMzA4 LDYgKzMwOCwxMyBAQCB2b2lkIFJlbmRlckZsb3dUaHJlYWQ6OnBhaW50Rmxvd1RocmVhZFBvcnRp b25JblJlZ2lvbihQYWludEluZm8mIHBhaW50SW5mbywgUmVuZAogICAgIH0KIH0KIAorYm9vbCBS ZW5kZXJGbG93VGhyZWFkOjpub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVz dCwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBjb25zdCBIaXRUZXN0TG9jYXRpb24mIGxvY2F0aW9u SW5Db250YWluZXIsIGNvbnN0IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9mZnNldCwgSGl0VGVz dEFjdGlvbiBoaXRUZXN0QWN0aW9uKQoreworICAgIGlmIChoaXRUZXN0QWN0aW9uID09IEhpdFRl c3RCbG9ja0JhY2tncm91bmQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gUmVu ZGVyQmxvY2s6Om5vZGVBdFBvaW50KHJlcXVlc3QsIHJlc3VsdCwgbG9jYXRpb25JbkNvbnRhaW5l ciwgYWNjdW11bGF0ZWRPZmZzZXQsIGhpdFRlc3RBY3Rpb24pOworfQorCiBib29sIFJlbmRlckZs b3dUaHJlYWQ6OmhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKFJlbmRlclJlZ2lvbiog cmVnaW9uLCBMYXlvdXRSZWN0IGZsb3dUaHJlYWRQb3J0aW9uUmVjdCwgTGF5b3V0UmVjdCBmbG93 VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCwgY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3Qs IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSGl0VGVzdExvY2F0aW9uJiBsb2NhdGlvbklu Q29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQpIGNvbnN0CiB7 CiAgICAgTGF5b3V0UmVjdCByZWdpb25DbGlwcGluZ1JlY3QgPSBjb21wdXRlUmVnaW9uQ2xpcHBp bmdSZWN0KGFjY3VtdWxhdGVkT2Zmc2V0LCBmbG93VGhyZWFkUG9ydGlvblJlY3QsIGZsb3dUaHJl YWRQb3J0aW9uT3ZlcmZsb3dSZWN0KTsKQEAgLTMyNCwxNyArMzMxLDExIEBAIGJvb2wgUmVuZGVy Rmxvd1RocmVhZDo6aGl0VGVzdEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUmVuZGVyUmVnaW9u KiByZWdpb24sIExhCiAKICAgICAvLyBBbHdheXMgaWdub3JlIGNsaXBwaW5nLCBzaW5jZSB0aGUg UmVuZGVyRmxvd1RocmVhZCBoYXMgbm90aGluZyB0byBkbyB3aXRoIHRoZSBib3VuZHMgb2YgdGhl IEZyYW1lVmlldy4KICAgICBIaXRUZXN0UmVxdWVzdCBuZXdSZXF1ZXN0KHJlcXVlc3QudHlwZSgp IHwgSGl0VGVzdFJlcXVlc3Q6Oklnbm9yZUNsaXBwaW5nIHwgSGl0VGVzdFJlcXVlc3Q6OkRpc2Fs bG93U2hhZG93Q29udGVudCk7Ci0gICAgSGl0VGVzdFJlc3VsdCB0ZW1wUmVzdWx0KHJlc3VsdCk7 CiAKICAgICAvLyBNYWtlIGEgbmV3IHRlbXBvcmFyeSBIaXRUZXN0TG9jYXRpb24gaW4gdGhlIG5l dyByZWdpb24uCiAgICAgSGl0VGVzdExvY2F0aW9uIG5ld0hpdFRlc3RMb2NhdGlvbihsb2NhdGlv bkluQ29udGFpbmVyLCAtcmVuZGVyRmxvd1RocmVhZE9mZnNldCwgcmVnaW9uKTsKIAotICAgIGJv b2wgaXNQb2ludEluc2lkZUZsb3dUaHJlYWQgPSBsYXllcigpLT5oaXRUZXN0KG5ld1JlcXVlc3Qs IG5ld0hpdFRlc3RMb2NhdGlvbiwgdGVtcFJlc3VsdCk7Ci0KLSAgICAvLyBXZSB3YW50IHRvIG1h a2Ugc3VyZSB3ZSBoaXQgYSBub2RlIGZyb20gdGhlIGNvbnRlbnQgaW5zaWRlIHRoZSBmbG93IHRo cmVhZC4KLSAgICBpc1BvaW50SW5zaWRlRmxvd1RocmVhZCA9IGlzUG9pbnRJbnNpZGVGbG93VGhy ZWFkICYmICF0ZW1wUmVzdWx0LmlubmVyTm9kZSgpLT5pc0RvY3VtZW50Tm9kZSgpOwotICAgIGlm IChpc1BvaW50SW5zaWRlRmxvd1RocmVhZCkKLSAgICAgICAgcmVzdWx0ID0gdGVtcFJlc3VsdDsK KyAgICBib29sIGlzUG9pbnRJbnNpZGVGbG93VGhyZWFkID0gbGF5ZXIoKS0+aGl0VGVzdChuZXdS ZXF1ZXN0LCBuZXdIaXRUZXN0TG9jYXRpb24sIHJlc3VsdCk7CiAKICAgICAvLyBGSVhNRTogU2hv dWxkIHdlIHNldCByZXN1bHQubV9sb2NhbFBvaW50IGJhY2sgdG8gdGhlIFJlbmRlclJlZ2lvbidz IGNvb3JkaW5hdGUgc3BhY2Ugb3IgbGVhdmUgaXQgaW4gdGhlIFJlbmRlckZsb3dUaHJlYWQncyBj b29yZGluYXRlCiAgICAgLy8gc3BhY2U/IFJpZ2h0IG5vdyBpdCdzIHN0YXlpbmcgaW4gdGhlIFJl bmRlckZsb3dUaHJlYWQncyBjb29yZGluYXRlIHNwYWNlLCB3aGljaCBtYXkgZW5kIHVwIGJlaW5n IG9rLiBXZSB3aWxsIGtub3cgbW9yZSB3aGVuIHdlIGdldCBhcm91bmQgdG8KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oCmluZGV4IGY0MzdkZjQuLjk0ZTBiZTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaApAQCAtODAs NiArODAsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHBhaW50Rmxvd1RocmVhZFBvcnRpb25JblJl Z2lvbihQYWludEluZm8mLCBSZW5kZXJSZWdpb24qLCBMYXlvdXRSZWN0IGZsb3dUaHJlYWRQb3J0 aW9uUmVjdCwgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCwgY29uc3Qg TGF5b3V0UG9pbnQmKSBjb25zdDsKICAgICBib29sIGhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbklu UmVnaW9uKFJlbmRlclJlZ2lvbiosIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBM YXlvdXRSZWN0IGZsb3dUaHJlYWRQb3J0aW9uT3ZlcmZsb3dSZWN0LCBjb25zdCBIaXRUZXN0UmVx dWVzdCYsIEhpdFRlc3RSZXN1bHQmLCBjb25zdCBIaXRUZXN0TG9jYXRpb24mIGxvY2F0aW9uSW5D b250YWluZXIsIGNvbnN0IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9mZnNldCkgY29uc3Q7Cisg ICAgdmlydHVhbCBib29sIG5vZGVBdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVz dFJlc3VsdCYsIGNvbnN0IEhpdFRlc3RMb2NhdGlvbiYgbG9jYXRpb25JbkNvbnRhaW5lciwgY29u c3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0LCBIaXRUZXN0QWN0aW9uKSBPVkVSUklE RTsKIAogICAgIGJvb2wgaGFzUmVnaW9ucygpIGNvbnN0IHsgcmV0dXJuIG1fcmVnaW9uTGlzdC5z aXplKCk7IH0KICAgICAvLyBDaGVjayBpZiB0aGUgY29udGVudCBpcyBmbG93biBpbnRvIGF0IGxl YXN0IGEgcmVnaW9uIHdpdGggcmVnaW9uIHN0eWxpbmcgcnVsZXMuCg== 201725 2013-05-14 09:24:22 -0700 2013-05-14 10:55:03 -0700 Patch for landing bug-115534-20130514192318.patch text/plain 4799 mihnea U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGIzZGRkMWVjZDA5MzVk ZDVjODU5N2Q2YmFhYjMwNDVhOTU1ZjYyYi4uOWE0NmQzNjkwMzZjZTdhZDA0ZWNjMmVlMmViMGUz ZDI2YTBlZmE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA1LTE0ICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1NSZWdpb25zXSBJ bXByb3ZlIGhpdCB0ZXN0aW5nIGZvciBlbXB0eSByZWdpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU1MzQKKworICAgICAgICBSZXZpZXdlZCBi eSBEYXZpZCBIeWF0dC4KKworICAgICAgICBBcyBhIGJldHRlciBmb2xsb3cgdXAgYWZ0ZXIgV2Vi S2l0IGJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NzUyLAor ICAgICAgICB3ZSBjYW4gaW1wcm92ZSB0aGUgY29kZSBieSBub3QgZG9pbmcgaGl0IHRlc3Rpbmcg b24gdGhlIHJlbmRlciBmbG93IHRocmVhZCBvYmplY3Qgd2hlbgorICAgICAgICB3ZSBhcmUgdHJ5 aW5nIHRvIGhpdCB0ZXN0IHRoZSByZW5kZXIgZmxvdyB0aHJlYWQgYmFja2dyb3VuZC4gSW4gdGhp cyBjYXNlLCB3ZSBzaG91bGQganVzdCBiYWlsIG91dC4KKyAgICAgICAgTm8gbmV3IHRlc3RzLCBj b3ZlcmVkIGJ5IGV4aXN0aW5nIHJlZ2lvbnMgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyRmxvd1RocmVhZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFk Ojpub2RlQXRQb2ludCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckZsb3dUaHJlYWQ6OmhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oOgorCiAyMDEzLTA1LTE0ICBEYWtlciBG ZXJuYW5kZXMgUGluaGVpcm8gIDxkYWtlci5waW5oZWlyb0BvcGVuYm9zc2Eub3JnPgogCiAgICAg ICAgIFJlbW92ZSBSZW5kZXJUaGVtZTo6c3VwcG9ydHNDYWxlbmRhclBpY2tlcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCmluZGV4IGI3YWJkMDE4NDRj YTY5ZDYzOTc2MjQ4ODUxYjNlOWYxYmY5NWE5MWIuLmM2YzA2N2I1MjMwNzdhYjg1NjEwNDY1YjQy Yjk1NzJkZjU4ZDBjNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxv d1RocmVhZC5jcHAKQEAgLTMwOCw2ICszMDgsMTMgQEAgdm9pZCBSZW5kZXJGbG93VGhyZWFkOjpw YWludEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUGFpbnRJbmZvJiBwYWludEluZm8sIFJlbmQK ICAgICB9CiB9CiAKK2Jvb2wgUmVuZGVyRmxvd1RocmVhZDo6bm9kZUF0UG9pbnQoY29uc3QgSGl0 VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSGl0VGVz dExvY2F0aW9uJiBsb2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11 bGF0ZWRPZmZzZXQsIEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikKK3sKKyAgICBpZiAoaGl0 VGVzdEFjdGlvbiA9PSBIaXRUZXN0QmxvY2tCYWNrZ3JvdW5kKQorICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgcmV0dXJuIFJlbmRlckJsb2NrOjpub2RlQXRQb2ludChyZXF1ZXN0LCByZXN1bHQs IGxvY2F0aW9uSW5Db250YWluZXIsIGFjY3VtdWxhdGVkT2Zmc2V0LCBoaXRUZXN0QWN0aW9uKTsK K30KKwogYm9vbCBSZW5kZXJGbG93VGhyZWFkOjpoaXRUZXN0Rmxvd1RocmVhZFBvcnRpb25JblJl Z2lvbihSZW5kZXJSZWdpb24qIHJlZ2lvbiwgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvblJl Y3QsIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRpb25PdmVyZmxvd1JlY3QsIGNvbnN0IEhpdFRl c3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGNvbnN0IEhpdFRlc3RM b2NhdGlvbiYgbG9jYXRpb25JbkNvbnRhaW5lciwgY29uc3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxh dGVkT2Zmc2V0KSBjb25zdAogewogICAgIExheW91dFJlY3QgcmVnaW9uQ2xpcHBpbmdSZWN0ID0g Y29tcHV0ZVJlZ2lvbkNsaXBwaW5nUmVjdChhY2N1bXVsYXRlZE9mZnNldCwgZmxvd1RocmVhZFBv cnRpb25SZWN0LCBmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCk7CkBAIC0zMjQsMTcgKzMz MSwxMSBAQCBib29sIFJlbmRlckZsb3dUaHJlYWQ6OmhpdFRlc3RGbG93VGhyZWFkUG9ydGlvbklu UmVnaW9uKFJlbmRlclJlZ2lvbiogcmVnaW9uLCBMYQogCiAgICAgLy8gQWx3YXlzIGlnbm9yZSBj bGlwcGluZywgc2luY2UgdGhlIFJlbmRlckZsb3dUaHJlYWQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0 aCB0aGUgYm91bmRzIG9mIHRoZSBGcmFtZVZpZXcuCiAgICAgSGl0VGVzdFJlcXVlc3QgbmV3UmVx dWVzdChyZXF1ZXN0LnR5cGUoKSB8IEhpdFRlc3RSZXF1ZXN0OjpJZ25vcmVDbGlwcGluZyB8IEhp dFRlc3RSZXF1ZXN0OjpEaXNhbGxvd1NoYWRvd0NvbnRlbnQpOwotICAgIEhpdFRlc3RSZXN1bHQg dGVtcFJlc3VsdChyZXN1bHQpOwogCiAgICAgLy8gTWFrZSBhIG5ldyB0ZW1wb3JhcnkgSGl0VGVz dExvY2F0aW9uIGluIHRoZSBuZXcgcmVnaW9uLgogICAgIEhpdFRlc3RMb2NhdGlvbiBuZXdIaXRU ZXN0TG9jYXRpb24obG9jYXRpb25JbkNvbnRhaW5lciwgLXJlbmRlckZsb3dUaHJlYWRPZmZzZXQs IHJlZ2lvbik7CiAKLSAgICBib29sIGlzUG9pbnRJbnNpZGVGbG93VGhyZWFkID0gbGF5ZXIoKS0+ aGl0VGVzdChuZXdSZXF1ZXN0LCBuZXdIaXRUZXN0TG9jYXRpb24sIHRlbXBSZXN1bHQpOwotCi0g ICAgLy8gV2Ugd2FudCB0byBtYWtlIHN1cmUgd2UgaGl0IGEgbm9kZSBmcm9tIHRoZSBjb250ZW50 IGluc2lkZSB0aGUgZmxvdyB0aHJlYWQuCi0gICAgaXNQb2ludEluc2lkZUZsb3dUaHJlYWQgPSBp c1BvaW50SW5zaWRlRmxvd1RocmVhZCAmJiAhdGVtcFJlc3VsdC5pbm5lck5vZGUoKS0+aXNEb2N1 bWVudE5vZGUoKTsKLSAgICBpZiAoaXNQb2ludEluc2lkZUZsb3dUaHJlYWQpCi0gICAgICAgIHJl c3VsdCA9IHRlbXBSZXN1bHQ7CisgICAgYm9vbCBpc1BvaW50SW5zaWRlRmxvd1RocmVhZCA9IGxh eWVyKCktPmhpdFRlc3QobmV3UmVxdWVzdCwgbmV3SGl0VGVzdExvY2F0aW9uLCByZXN1bHQpOwog CiAgICAgLy8gRklYTUU6IFNob3VsZCB3ZSBzZXQgcmVzdWx0Lm1fbG9jYWxQb2ludCBiYWNrIHRv IHRoZSBSZW5kZXJSZWdpb24ncyBjb29yZGluYXRlIHNwYWNlIG9yIGxlYXZlIGl0IGluIHRoZSBS ZW5kZXJGbG93VGhyZWFkJ3MgY29vcmRpbmF0ZQogICAgIC8vIHNwYWNlPyBSaWdodCBub3cgaXQn cyBzdGF5aW5nIGluIHRoZSBSZW5kZXJGbG93VGhyZWFkJ3MgY29vcmRpbmF0ZSBzcGFjZSwgd2hp Y2ggbWF5IGVuZCB1cCBiZWluZyBvay4gV2Ugd2lsbCBrbm93IG1vcmUgd2hlbiB3ZSBnZXQgYXJv dW5kIHRvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1Ro cmVhZC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaAppbmRl eCBiZTk0NzRmOTBmYTA3ZjI4OWMwYWQyZDc3NDRlYWIxY2EzYjI0MmY3Li44ZGU4N2Q2NzBmNmQ0 YmYxZjQ5OThmNTcwM2ZhYzUyMWViZDJiYjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbG93VGhyZWFkLmgKQEAgLTc5LDYgKzc5LDcgQEAgcHVibGljOgogCiAgICAgdm9p ZCBwYWludEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUGFpbnRJbmZvJiwgUmVuZGVyUmVnaW9u KiwgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvblJlY3QsIExheW91dFJlY3QgZmxvd1RocmVh ZFBvcnRpb25PdmVyZmxvd1JlY3QsIGNvbnN0IExheW91dFBvaW50JikgY29uc3Q7CiAgICAgYm9v bCBoaXRUZXN0Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lvbihSZW5kZXJSZWdpb24qLCBMYXlvdXRS ZWN0IGZsb3dUaHJlYWRQb3J0aW9uUmVjdCwgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvbk92 ZXJmbG93UmVjdCwgY29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgY29uc3Qg SGl0VGVzdExvY2F0aW9uJiBsb2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYg YWNjdW11bGF0ZWRPZmZzZXQpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBub2RlQXRQb2ludChj b25zdCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRlc3RSZXN1bHQmLCBjb25zdCBIaXRUZXN0TG9jYXRp b24mIGxvY2F0aW9uSW5Db250YWluZXIsIGNvbnN0IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9m ZnNldCwgSGl0VGVzdEFjdGlvbikgT1ZFUlJJREU7CiAKICAgICBib29sIGhhc1JlZ2lvbnMoKSBj b25zdCB7IHJldHVybiBtX3JlZ2lvbkxpc3Quc2l6ZSgpOyB9CiAgICAgLy8gQ2hlY2sgaWYgdGhl IGNvbnRlbnQgaXMgZmxvd24gaW50byBhdCBsZWFzdCBhIHJlZ2lvbiB3aXRoIHJlZ2lvbiBzdHls aW5nIHJ1bGVzLgo=