115522 2013-05-02 12:27:14 -0700 Fix potential bug in lookup logic 2013-05-02 13:58:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 883890 0 oliver 2013-05-02 12:27:14 -0700 Fix potential bug in lookup logic 883893 1 200329 oliver 2013-05-02 12:32:09 -0700 Created attachment 200329 Patch 883894 2 200329 fpizlo 2013-05-02 12:33:32 -0700 Comment on attachment 200329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200329&action=review > Source/JavaScriptCore/ChangeLog:12 > + in BytecodeGenerator actually limits itself to scopes that > + static. What are scopes that static? 883895 3 oliver 2013-05-02 12:35:18 -0700 <rdar://problem/13795064> 883896 4 200330 oliver 2013-05-02 12:36:38 -0700 Created attachment 200330 Patch 883908 5 200330 mhahnenberg 2013-05-02 13:56:48 -0700 Comment on attachment 200330 Patch r=me 883909 6 oliver 2013-05-02 13:58:42 -0700 Committed r149496: <http://trac.webkit.org/changeset/149496> 200329 2013-05-02 12:32:09 -0700 2013-05-02 12:36:35 -0700 Patch bug-115522-20130502123124.patch text/plain 2870 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ODA1NzEwMDA0YzU1NWJiNTE5NGYxOGYyNzZiNGY5Y2U5M2Y0OGEyLi4wNmQxNWZjZWJlY2M4MzBj Y2UzMTg3N2FkMWIyZWU2N2EzYTRiYjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMy0wNS0wMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBwb3RlbnRpYWwgYnVnIGluIGxvb2t1cCBsb2dpYworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhvdWdoIG5vdCBhIHByb2JsZW0g aW4gcHJhY3Rpc2UsIGl0IGlzIHRlY2huaWNhbGx5IHBvc3NpYmxlCisgICAgICAgIHRvIGluamVj dCBhbiB1bi1wcm94aWVkIGdsb2JhbCBvYmplY3QgaW50byB0aGUgc2NvcGUgY2hhaW4KKyAgICAg ICAgdmlhIHRoZSBDIEFQSS4gIFRoaXMgY2hhbmdlIG1ha2VzIHN1cmUgdGhhdCB0aGUgc2NvcGUg d2FsaworICAgICAgICBpbiBCeXRlY29kZUdlbmVyYXRvciBhY3R1YWxseSBsaW1pdHMgaXRzZWxm IHRvIHNjb3BlcyB0aGF0CisgICAgICAgIHN0YXRpYy4KKworICAgICAgICAqIGJ5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9y OjpyZXNvbHZlKToKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0Lmg6CisgICAgICAgIChKU09i amVjdCk6CisgICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6aXNTdGF0aWNT Y29wZU9iamVjdCk6CisKIDIwMTMtMDUtMDEgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxl LmNvbT4KIAogICAgICAgICBTZXQgUGF0aCBpbiBtYWtlZmlsZSBmb3IgQXBwbGVXaW4uCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJh dG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5l cmF0b3IuY3BwCmluZGV4IDcyNTVhNDgyOTEyYjM0NTZkYjNiYzc5NzNmNjAyZjU0OTk0MDE4YWYu LmY3NGQ1MmVkYTcwYzVmMzdhZGJlMzk0Mzk2YjlhYmIyYWRiMjg3MTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu Y3BwCkBAIC0xMTg3LDcgKzExODcsNyBAQCBSZXNvbHZlUmVzdWx0IEJ5dGVjb2RlR2VuZXJhdG9y OjpyZXNvbHZlKGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5KQogICAgIHVuc2lnbmVkIGZsYWdz ID0gMDsKICAgICBmb3IgKDsgaXRlciAhPSBlbmQ7ICsraXRlciwgKytkZXB0aCkgewogICAgICAg ICBKU09iamVjdCogY3VycmVudFNjb3BlID0gaXRlci5nZXQoKTsKLSAgICAgICAgaWYgKCFjdXJy ZW50U2NvcGUtPmlzVmFyaWFibGVPYmplY3QoKSkKKyAgICAgICAgaWYgKCFjdXJyZW50U2NvcGUt PmlzU3RhdGljU2NvcGVPYmplY3QoKSkKICAgICAgICAgICAgIHJldHVybiBSZXNvbHZlUmVzdWx0 OjpkeW5hbWljUmVzb2x2ZSgpOwogCiAgICAgICAgIEpTU3ltYm9sVGFibGVPYmplY3QqIGN1cnJl bnRWYXJpYWJsZU9iamVjdCA9IGpzQ2FzdDxKU1N5bWJvbFRhYmxlT2JqZWN0Kj4oY3VycmVudFNj b3BlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCmluZGV4IGFkNmE5 MDRhODM5OGE0OTM0MGU3OTlhMWQzYjQ4NjA5YTk3OTM1ODIuLmIxNTEwMzlhM2ZmNDFjMDJlNDk3 YjE5NTEzMTA5MWFjYmNmYWI5OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTT2JqZWN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP YmplY3QuaApAQCAtNTcxLDYgKzU3MSw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNHbG9iYWxP YmplY3QoKSBjb25zdDsKICAgICBib29sIGlzVmFyaWFibGVPYmplY3QoKSBjb25zdDsKKyAgICBi b29sIGlzU3RhdGljU2NvcGVPYmplY3QoKSBjb25zdDsKICAgICBib29sIGlzTmFtZVNjb3BlT2Jq ZWN0KCkgY29uc3Q7CiAgICAgYm9vbCBpc0FjdGl2YXRpb25PYmplY3QoKSBjb25zdDsKICAgICBi b29sIGlzRXJyb3JJbnN0YW5jZSgpIGNvbnN0OwpAQCAtMTA4MSw2ICsxMDgyLDE0IEBAIGlubGlu ZSBib29sIEpTT2JqZWN0Ojppc1ZhcmlhYmxlT2JqZWN0KCkgY29uc3QKICAgICByZXR1cm4gc3Ry dWN0dXJlKCktPnR5cGVJbmZvKCkudHlwZSgpID49IFZhcmlhYmxlT2JqZWN0VHlwZTsKIH0KIAor CitpbmxpbmUgYm9vbCBKU09iamVjdDo6aXNTdGF0aWNTY29wZU9iamVjdCgpIGNvbnN0Cit7Cisg ICAgSlNUeXBlIHR5cGUgPSBzdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS50eXBlKCk7CisgICAgcmV0 dXJuIHR5cGUgPT0gTmFtZVNjb3BlT2JqZWN0VHlwZSB8fCB0eXBlID09IEFjdGl2YXRpb25PYmpl Y3RUeXBlOworfQorCisKIGlubGluZSBib29sIEpTT2JqZWN0Ojppc05hbWVTY29wZU9iamVjdCgp IGNvbnN0CiB7CiAgICAgcmV0dXJuIHN0cnVjdHVyZSgpLT50eXBlSW5mbygpLnR5cGUoKSA9PSBO YW1lU2NvcGVPYmplY3RUeXBlOwo= 200330 2013-05-02 12:36:38 -0700 2013-05-02 13:56:48 -0700 Patch bug-115522-20130502123553.patch text/plain 2887 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ODA1NzEwMDA0YzU1NWJiNTE5NGYxOGYyNzZiNGY5Y2U5M2Y0OGEyLi40MjlkZDczMTQ5ZWYxZTMx ODEzNzQ4YzBhN2JjYzA4NTEyNDhmY2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMy0wNS0wMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBwb3RlbnRpYWwgYnVnIGluIGxvb2t1cCBsb2dpYworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhvdWdoIG5vdCBhIHByb2JsZW0g aW4gcHJhY3Rpc2UsIGl0IGlzIHRlY2huaWNhbGx5IHBvc3NpYmxlCisgICAgICAgIHRvIGluamVj dCBhbiB1bi1wcm94aWVkIGdsb2JhbCBvYmplY3QgaW50byB0aGUgc2NvcGUgY2hhaW4KKyAgICAg ICAgdmlhIHRoZSBDIEFQSS4gIFRoaXMgY2hhbmdlIG1ha2VzIHN1cmUgdGhhdCB0aGUgc2NvcGUg d2FsaworICAgICAgICBpbiBCeXRlY29kZUdlbmVyYXRvciBhY3R1YWxseSBsaW1pdHMgaXRzZWxm IHRvIHNjb3BlcyB0aGF0CisgICAgICAgIGFyZSBzdGF0aWNhbGx5IGJpbmRhYmxlLgorCisgICAg ICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6 Qnl0ZWNvZGVHZW5lcmF0b3I6OnJlc29sdmUpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3Qu aDoKKyAgICAgICAgKEpTT2JqZWN0KToKKyAgICAgICAgKEpTQyk6CisgICAgICAgIChKU0M6OkpT T2JqZWN0Ojppc1N0YXRpY1Njb3BlT2JqZWN0KToKKwogMjAxMy0wNS0wMSAgUm9nZXIgRm9uZyAg PHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNldCBQYXRoIGluIG1ha2VmaWxlIGZv ciBBcHBsZVdpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGls ZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21w aWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggNzI1NWE0ODI5MTJiMzQ1NmRiM2JjNzk3 M2Y2MDJmNTQ5OTQwMThhZi4uZjc0ZDUyZWRhNzBjNWYzN2FkYmUzOTQzOTZiOWFiYjJhZGIyODcx NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9C eXRlY29kZUdlbmVyYXRvci5jcHAKQEAgLTExODcsNyArMTE4Nyw3IEBAIFJlc29sdmVSZXN1bHQg Qnl0ZWNvZGVHZW5lcmF0b3I6OnJlc29sdmUoY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHkpCiAg ICAgdW5zaWduZWQgZmxhZ3MgPSAwOwogICAgIGZvciAoOyBpdGVyICE9IGVuZDsgKytpdGVyLCAr K2RlcHRoKSB7CiAgICAgICAgIEpTT2JqZWN0KiBjdXJyZW50U2NvcGUgPSBpdGVyLmdldCgpOwot ICAgICAgICBpZiAoIWN1cnJlbnRTY29wZS0+aXNWYXJpYWJsZU9iamVjdCgpKQorICAgICAgICBp ZiAoIWN1cnJlbnRTY29wZS0+aXNTdGF0aWNTY29wZU9iamVjdCgpKQogICAgICAgICAgICAgcmV0 dXJuIFJlc29sdmVSZXN1bHQ6OmR5bmFtaWNSZXNvbHZlKCk7CiAKICAgICAgICAgSlNTeW1ib2xU YWJsZU9iamVjdCogY3VycmVudFZhcmlhYmxlT2JqZWN0ID0ganNDYXN0PEpTU3ltYm9sVGFibGVP YmplY3QqPihjdXJyZW50U2NvcGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNPYmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2Jq ZWN0LmgKaW5kZXggYWQ2YTkwNGE4Mzk4YTQ5MzQwZTc5OWExZDNiNDg2MDlhOTc5MzU4Mi4uYjE1 MTAzOWEzZmY0MWMwMmU0OTdiMTk1MTMxMDkxYWNiY2ZhYjk5MiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09iamVjdC5oCkBAIC01NzEsNiArNTcxLDcgQEAgcHVibGljOgogCiAg ICAgYm9vbCBpc0dsb2JhbE9iamVjdCgpIGNvbnN0OwogICAgIGJvb2wgaXNWYXJpYWJsZU9iamVj dCgpIGNvbnN0OworICAgIGJvb2wgaXNTdGF0aWNTY29wZU9iamVjdCgpIGNvbnN0OwogICAgIGJv b2wgaXNOYW1lU2NvcGVPYmplY3QoKSBjb25zdDsKICAgICBib29sIGlzQWN0aXZhdGlvbk9iamVj dCgpIGNvbnN0OwogICAgIGJvb2wgaXNFcnJvckluc3RhbmNlKCkgY29uc3Q7CkBAIC0xMDgxLDYg KzEwODIsMTQgQEAgaW5saW5lIGJvb2wgSlNPYmplY3Q6OmlzVmFyaWFibGVPYmplY3QoKSBjb25z dAogICAgIHJldHVybiBzdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS50eXBlKCkgPj0gVmFyaWFibGVP YmplY3RUeXBlOwogfQogCisKK2lubGluZSBib29sIEpTT2JqZWN0Ojppc1N0YXRpY1Njb3BlT2Jq ZWN0KCkgY29uc3QKK3sKKyAgICBKU1R5cGUgdHlwZSA9IHN0cnVjdHVyZSgpLT50eXBlSW5mbygp LnR5cGUoKTsKKyAgICByZXR1cm4gdHlwZSA9PSBOYW1lU2NvcGVPYmplY3RUeXBlIHx8IHR5cGUg PT0gQWN0aXZhdGlvbk9iamVjdFR5cGU7Cit9CisKKwogaW5saW5lIGJvb2wgSlNPYmplY3Q6Omlz TmFtZVNjb3BlT2JqZWN0KCkgY29uc3QKIHsKICAgICByZXR1cm4gc3RydWN0dXJlKCktPnR5cGVJ bmZvKCkudHlwZSgpID09IE5hbWVTY29wZU9iamVjdFR5cGU7Cg==