115519 2013-05-02 11:31:23 -0700 Make BloomFilter Fast-Allocated 2013-05-03 10:06:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham benjamin bfulgham cmarcelo commit-queue oldest_to_newest 883851 0 bfulgham 2013-05-02 11:31:23 -0700 While tracking down some memory allocation problems on Windows (see Bug 115130), I noticed that BloomFilter did not use the WTF_MAKE_FAST_ALLOCATED macro. Under Windows, the global replacement of operator new/delete should cause this to be fast allocated, but in practice results in a mismatch (allocating with system new, deallocating with fastFree). Under Gtk/EFL/Qt and perhaps others, BloomFilter is not fast allocated at all. This change simply instructs the system to build BloomFilter as a fast-allocated object, removing the error case under Windows and potentially speeding up memory allocation on other platforms. 883856 1 200323 bfulgham 2013-05-02 11:33:20 -0700 Created attachment 200323 Patch 883877 2 200323 ggaren 2013-05-02 12:05:45 -0700 Comment on attachment 200323 Patch r=me 883904 3 bfulgham 2013-05-02 13:47:56 -0700 Committed r149493: <http://trac.webkit.org/changeset/149493> 884183 4 bfulgham 2013-05-03 09:49:17 -0700 Reopening to attach new patch. 884184 5 200425 bfulgham 2013-05-03 09:49:19 -0700 Created attachment 200425 Patch 884190 6 200425 benjamin 2013-05-03 09:57:34 -0700 Comment on attachment 200425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200425&action=review > Source/WTF/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=115519 Wrong bug URL. That bug was about BloomFilter. 884196 7 bfulgham 2013-05-03 10:06:02 -0700 Whoops. Attached to wrong bug. Nothing to see here... 200323 2013-05-02 11:33:20 -0700 2013-05-03 09:49:15 -0700 Patch bug-115519-20130502113233.patch text/plain 1050 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDk0ODkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTAyICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIEJsb29tRmlsdGVyIGZhc3QgYWxsb2Nh dGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1 NTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvQmxvb21GaWx0ZXIuaDoKKyAgICAgICAgKEJsb29tRmlsdGVyKTogTWFrZSBCbG9vbUZpbHRl ciBGYXN0LWFsbG9jYXRlZC4KKwogMjAxMy0wNS0wMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2Zm QGFwcGxlLmNvbT4KIAogICAgICAgICBGYXN0TWFsbG9jLmNwcCBzaG91bGQgdXNlIHN5c3RlbSBk ZWZpbmVkIHBhZ2Ugc2l6ZSBpbnN0ZWFkIG9mIGxpdGVyYWwgY29uc3RhbnQKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL0Jsb29tRmlsdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQmxv b21GaWx0ZXIuaAkocmV2aXNpb24gMTQ5NDg5KQorKysgU291cmNlL1dURi93dGYvQmxvb21GaWx0 ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIC8v IGtleXMgYW5kIG0gaXMgdGhlIHRhYmxlIHNpemUgKD09Ml5rZXlCaXRzKS4KIHRlbXBsYXRlIDx1 bnNpZ25lZCBrZXlCaXRzPgogY2xhc3MgQmxvb21GaWx0ZXIgeworICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOwogcHVibGljOgogICAgIENPTVBJTEVfQVNTRVJUKGtleUJpdHMgPD0gMTYsIGJs b29tX2ZpbHRlcl9rZXlfc2l6ZSk7CiAK 200425 2013-05-03 09:49:19 -0700 2013-05-03 10:05:39 -0700 Patch bug-115519-20130503094830.patch text/plain 1117 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDk1MjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTAzICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIFRocmVhZEZ1bmN0aW9uSW52b2NhdGlv biBmYXN0IGFsbG9jYXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTUxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogd3RmL1RocmVhZEZ1bmN0aW9uSW52b2NhdGlvbi5oOgorICAgICAgICAoVGhy ZWFkRnVuY3Rpb25JbnZvY2F0aW9uKTogTWFrZSBGYXN0LWFsbG9jYXRlZC4KKwogMjAxMy0wNS0w MiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dpbkNh aXJvXSBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1RocmVhZEZ1 bmN0aW9uSW52b2NhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1RocmVhZEZ1 bmN0aW9uSW52b2NhdGlvbi5oCShyZXZpc2lvbiAxNDk1MjEpCisrKyBTb3VyY2UvV1RGL3d0Zi9U aHJlYWRGdW5jdGlvbkludm9jYXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsOCBA QCBuYW1lc3BhY2UgV1RGIHsKIHR5cGVkZWYgdm9pZCAoKlRocmVhZEZ1bmN0aW9uKSh2b2lkKiBh cmd1bWVudCk7CiAKIHN0cnVjdCBUaHJlYWRGdW5jdGlvbkludm9jYXRpb24geworICAgIFdURl9N QUtFX0ZBU1RfQUxMT0NBVEVEOworcHVibGljOgogICAgIFRocmVhZEZ1bmN0aW9uSW52b2NhdGlv bihUaHJlYWRGdW5jdGlvbiBmdW5jdGlvbiwgdm9pZCogZGF0YSkKICAgICAgICAgOiBmdW5jdGlv bihmdW5jdGlvbikKICAgICAgICAgLCBkYXRhKGRhdGEpCg==