115507 2013-05-01 23:10:07 -0700 [EFL] Correct documentation for ewk_settings APIs 2013-05-08 01:01:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jose.lejin webkit-unassigned cdumez commit-queue gyuyoung.kim kangil.han lucas.de.marchi rakuco oldest_to_newest 883733 0 jose.lejin 2013-05-01 23:10:07 -0700 Some of the APIs documentation wrong in ewk_settings APIs. 1)EAPI const char *ewk_settings_web_database_path_get(void); * By default, the value is @c ~/.webkit 2)EAPI void ewk_settings_local_storage_path_set(const char* path); EAPI const char* ewk_settings_local_storage_path_get(void); * By default, the value is @c ~/.webkit 3)EAPI const char *ewk_settings_application_cache_path_get(void); * By default, the path is @c NULL, indicating that the feature is disabled. 883734 1 200302 jose.lejin 2013-05-02 00:59:19 -0700 Created attachment 200302 Patch 883735 2 jose.lejin 2013-05-02 01:00:09 -0700 (In reply to comment #1) > Created an attachment (id=200302) [details] > Patch Please comment if any other documentation to be corrected with this bug. 884149 3 kangil.han 2013-05-03 06:02:39 -0700 LGTM, thanks! 886173 4 200302 gyuyoung.kim 2013-05-08 00:01:08 -0700 Comment on attachment 200302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200302&action=review > Source/WebKit/efl/ewk/ewk_settings.h:60 > + * By default, the value is @c $HOME/.cache/WebKitEfl/Databases Doesn't "/" mean home directory ? It looks "~/" is more simple than $HOME. > Source/WebKit/efl/ewk/ewk_settings.h:-200 > - * By default, the path is @c NULL, indicating that the feature is disabled. Once the path is set, the feature is enabled >> Once the path is set, the feature is enabled and the path cannot be changed Why do you remove existing comment ? Isn't this comment still valid ? 886180 5 jose.lejin 2013-05-08 00:14:46 -0700 (In reply to comment #4) > (From update of attachment 200302 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200302&action=review > > > Source/WebKit/efl/ewk/ewk_settings.h:60 > > + * By default, the value is @c $HOME/.cache/WebKitEfl/Databases > > Doesn't "/" mean home directory ? It looks "~/" is more simple than $HOME. I will correct this to ~/ > > > Source/WebKit/efl/ewk/ewk_settings.h:-200 > > - * By default, the path is @c NULL, indicating that the feature is disabled. Once the path is set, the feature is enabled > > >> Once the path is set, the feature is enabled and the path cannot be changed > > Why do you remove existing comment ? Isn't this comment still valid ? I will add this "Once the path is set, the feature is enabled and the path cannot be changed" 886183 6 201034 jose.lejin 2013-05-08 00:26:58 -0700 Created attachment 201034 Patch Updated patch 886205 7 201034 commit-queue 2013-05-08 01:01:45 -0700 Comment on attachment 201034 Patch Clearing flags on attachment: 201034 Committed r149719: <http://trac.webkit.org/changeset/149719> 886206 8 commit-queue 2013-05-08 01:01:48 -0700 All reviewed patches have been landed. Closing bug. 200302 2013-05-02 00:59:19 -0700 2013-05-08 00:26:49 -0700 Patch bug-115507-20130502132801.patch text/plain 3203 jose.lejin SW5kZXg6IFNvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTQ4MykKKysrIFNvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTAy ICBKb3NlIExlamluIFBKICA8am9zZS5sZWppbkBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0g Q29ycmVjdCBkb2N1bWVudGF0aW9uIGZvciBld2tfc2V0dGluZ3MgQVBJcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdGVkIGRvY3VtZW50YXRp b24gZm9yIGV3a19zZXR0aW5ncyBBUElzLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5o OgorCiAyMDEzLTA0LTI2ICBKb3NlIExlamluIFBKICA8am9zZS5sZWppbkBnbWFpbC5jb20+CiAK ICAgICAgICAgW0VGTF0gQWRkIHVuaXQgdGVzdCBjYXNlcyBmb3IgZXdrX3NldHRpbmdzIEFQSXMK SW5kZXg6IFNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgJKHJldmlzaW9uIDE0OTE3NSkK KysrIFNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpA QCAtNTcsNyArNTcsNyBAQCBFQVBJIHZvaWQgICAgICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9k CiAgKiBTZXRzIHRoZSBjdXJyZW50IHBhdGggdG8gdGhlIGRpcmVjdG9yeSBXZWJLaXQgd2lsbCB3 cml0ZSBXZWIKICAqIERhdGFiYXNlIGRhdGFiYXNlcy4KICAqCi0gKiBCeSBkZWZhdWx0LCB0aGUg dmFsdWUgaXMgQGMgfi8ud2Via2l0CisgKiBCeSBkZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgJEhP TUUvLmNhY2hlL1dlYktpdEVmbC9EYXRhYmFzZXMKICAqCiAgKiBAcGFyYW0gcGF0aCB0aGUgbmV3 IGRhdGFiYXNlIGRpcmVjdG9yeSBwYXRoCiAgKi8KQEAgLTY4LDcgKzY4LDcgQEAgRUFQSSB2b2lk ICAgICAgICAgICAgIGV3a19zZXR0aW5nc193ZWJfZAogICogSFRNTDUgbG9jYWwgc3RvcmFnZSBp bmRleGluZyBkYXRhYmFzZSAodGhlIG9uZSBrZWVwaW5nIHRyYWNrIG9mCiAgKiBpbmRpdmlkdWFs IHZpZXdzJyBsb2NhbCBzdG9yYWdlIGRhdGFiYXNlcykuCiAgKgotICogQnkgZGVmYXVsdCwgdGhl IHZhbHVlIGlzIEBjIH4vLndlYmtpdAorICogQnkgZGVmYXVsdCwgdGhlIHZhbHVlIGlzIEBjICRI T01FLy5sb2NhbC9zaGFyZS9XZWJLaXRFZmwvTG9jYWxTdG9yYWdlCiAgKgogICogQHBhcmFtIHBh dGggdGhlIG5ldyBsb2NhbCBzdG9yYWdlIGRhdGFiYXNlIGRpcmVjdG9yeSBwYXRoCiAgKgpAQCAt ODYsNiArODYsOCBAQCBFQVBJIHZvaWQgZXdrX3NldHRpbmdzX2xvY2FsX3N0b3JhZ2VfcGF0CiAg KiBzYXZlIHlvdXJzZWxmIHNvbWUgY3B1IGN5Y2xlcyBhbmQgdXNlIGVpbmFfc3RyaW5nc2hhcmVf cmVmKCkKICAqIGluc3RlYWQgb2YgZWluYV9zdHJpbmdzaGFyZV9hZGQoKSBvciBzdHJkdXAoKS4K ICAqCisgKiBCeSBkZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgJEhPTUUvLmxvY2FsL3NoYXJlL1dl YktpdEVmbC9Mb2NhbFN0b3JhZ2UKKyAqCiAgKiBAcmV0dXJuIGRhdGFiYXNlIHBhdGggb3IgQGMg TlVMTCwgb24gZXJyb3JzLgogICoKICAqIEBzZWUgZXdrX3NldHRpbmdzX2xvY2FsX3N0b3JhZ2Vf cGF0aF9zZXQoKQpAQCAtMTEzLDcgKzExNSw3IEBAIEVBUEkgdm9pZCBld2tfc2V0dGluZ3NfbG9j YWxfc3RvcmFnZV9kYXQKIC8qKgogICogUmV0dXJucyBkaXJlY3RvcnkgcGF0aCB3aGVyZSB3ZWIg ZGF0YWJhc2UgaXMgc3RvcmVkLgogICoKLSAqIEJ5IGRlZmF1bHQsIHRoZSB2YWx1ZSBpcyBAYyB+ Ly53ZWJraXQKKyAqIEJ5IGRlZmF1bHQsIHRoZSB2YWx1ZSBpcyBAYyAkSE9NRS8uY2FjaGUvV2Vi S2l0RWZsL0RhdGFiYXNlcwogICoKICAqIFRoaXMgaXMgZ3VhcmFudGVlZCB0byBiZSBlaW5hX3N0 cmluZ3NoYXJlLCBzbyB3aGVuZXZlciBwb3NzaWJsZQogICogc2F2ZSB5b3Vyc2VsZiBzb21lIGNw dSBjeWNsZXMgYW5kIHVzZSBlaW5hX3N0cmluZ3NoYXJlX3JlZigpCkBAIC0xOTcsOCArMTk5LDcg QEAgRUFQSSBFdmFzX09iamVjdCAgICAgKmV3a19zZXR0aW5nc19pY29uXwogICogVGhlIE9mZmxp bmUgQXBwbGljYXRpb24gQ2FjaGluZyBBUElzIGFyZSBwYXJ0IG9mIEhUTUw1IGFuZCBhbGxvdyBh cHBsaWNhdGlvbnMgdG8gc3RvcmUgZGF0YSBsb2NhbGx5IHRoYXQgaXMgYWNjZXNzZWQKICAqIHdo ZW4gdGhlIG5ldHdvcmsgY2Fubm90IGJlIHJlYWNoZWQuCiAgKgotICogQnkgZGVmYXVsdCwgdGhl IHBhdGggaXMgQGMgTlVMTCwgaW5kaWNhdGluZyB0aGF0IHRoZSBmZWF0dXJlIGlzIGRpc2FibGVk LiBPbmNlIHRoZSBwYXRoIGlzIHNldCwgdGhlIGZlYXR1cmUgaXMgZW5hYmxlZAotICogYW5kIHRo ZSBwYXRoIGNhbm5vdCBiZSBjaGFuZ2VkLgorICogQnkgZGVmYXVsdCwgdGhlIHBhdGggaXMgQGMg JEhPTUUvLmNhY2hlL1dlYktpdEVmbC9BcHBsaWNhdGlvbnMKICAqCiAgKiBAcGFyYW0gcGF0aCB3 aGVyZSB0byBzdG9yZSBjYWNoZSwgbXVzdCBiZSB3cml0ZS1hYmxlLgogICoKQEAgLTIxMiw3ICsy MTMsNyBAQCBFQVBJIHZvaWQgICAgICAgICAgICAgZXdrX3NldHRpbmdzX2FwcGxpCiAgKiBUaGUg T2ZmbGluZSBBcHBsaWNhdGlvbiBDYWNoaW5nIEFQSXMgYXJlIHBhcnQgb2YgSFRNTDUgYW5kIGFs bG93IGFwcGxpY2F0aW9ucyB0byBzdG9yZSBkYXRhIGxvY2FsbHkgdGhhdCBpcyBhY2Nlc3NlZAog ICogd2hlbiB0aGUgbmV0d29yayBjYW5ub3QgYmUgcmVhY2hlZC4KICAqCi0gKiBCeSBkZWZhdWx0 LCB0aGUgcGF0aCBpcyBAYyBOVUxMLCBpbmRpY2F0aW5nIHRoYXQgdGhlIGZlYXR1cmUgaXMgZGlz YWJsZWQuCisgKiBCeSBkZWZhdWx0LCB0aGUgcGF0aCBpcyBAYyAkSE9NRS8uY2FjaGUvV2ViS2l0 RWZsL0FwcGxpY2F0aW9ucwogICoKICAqIEByZXR1cm4gZWluYV9zdHJpbmdzaGFyZSdkIHBhdGgg dmFsdWUuCiAgKgo= 201034 2013-05-08 00:26:58 -0700 2013-05-08 01:01:45 -0700 Patch bug-115507-20130508125519.patch text/plain 3290 jose.lejin SW5kZXg6IFNvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTcxNSkKKysrIFNvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA1LTA4 ICBKb3NlIExlamluIFBKICA8am9zZS5sZWppbkBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0g Q29ycmVjdCBkb2N1bWVudGF0aW9uIGZvciBld2tfc2V0dGluZ3MgQVBJcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdGVkIGRvY3VtZW50YXRp b24gZm9yIGV3a19zZXR0aW5ncyBBUElzLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5o OgorCiAyMDEzLTA1LTA3ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBbRUZMXSBSZW1vdmUgdGhlIGV3a19zZXR0aW5nc19zaGFkb3dfZG9tX2VuYWJs ZV9zZXQvZ2V0IEFQSXMgZnJvbSB1bml0IHRlc3QKSW5kZXg6IFNvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfc2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3NldHRpbmdzLmgJKHJldmlzaW9uIDE0OTE3NSkKKysrIFNvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfc2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcsNyBAQCBFQVBJIHZvaWQg ICAgICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9kCiAgKiBTZXRzIHRoZSBjdXJyZW50IHBhdGgg dG8gdGhlIGRpcmVjdG9yeSBXZWJLaXQgd2lsbCB3cml0ZSBXZWIKICAqIERhdGFiYXNlIGRhdGFi YXNlcy4KICAqCi0gKiBCeSBkZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgfi8ud2Via2l0CisgKiBC eSBkZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgfi8uY2FjaGUvV2ViS2l0RWZsL0RhdGFiYXNlcwog ICoKICAqIEBwYXJhbSBwYXRoIHRoZSBuZXcgZGF0YWJhc2UgZGlyZWN0b3J5IHBhdGgKICAqLwpA QCAtNjgsNyArNjgsNyBAQCBFQVBJIHZvaWQgICAgICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9k CiAgKiBIVE1MNSBsb2NhbCBzdG9yYWdlIGluZGV4aW5nIGRhdGFiYXNlICh0aGUgb25lIGtlZXBp bmcgdHJhY2sgb2YKICAqIGluZGl2aWR1YWwgdmlld3MnIGxvY2FsIHN0b3JhZ2UgZGF0YWJhc2Vz KS4KICAqCi0gKiBCeSBkZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgfi8ud2Via2l0CisgKiBCeSBk ZWZhdWx0LCB0aGUgdmFsdWUgaXMgQGMgfi8ubG9jYWwvc2hhcmUvV2ViS2l0RWZsL0xvY2FsU3Rv cmFnZQogICoKICAqIEBwYXJhbSBwYXRoIHRoZSBuZXcgbG9jYWwgc3RvcmFnZSBkYXRhYmFzZSBk aXJlY3RvcnkgcGF0aAogICoKQEAgLTg2LDYgKzg2LDggQEAgRUFQSSB2b2lkIGV3a19zZXR0aW5n c19sb2NhbF9zdG9yYWdlX3BhdAogICogc2F2ZSB5b3Vyc2VsZiBzb21lIGNwdSBjeWNsZXMgYW5k IHVzZSBlaW5hX3N0cmluZ3NoYXJlX3JlZigpCiAgKiBpbnN0ZWFkIG9mIGVpbmFfc3RyaW5nc2hh cmVfYWRkKCkgb3Igc3RyZHVwKCkuCiAgKgorICogQnkgZGVmYXVsdCwgdGhlIHZhbHVlIGlzIEBj IH4vLmxvY2FsL3NoYXJlL1dlYktpdEVmbC9Mb2NhbFN0b3JhZ2UKKyAqCiAgKiBAcmV0dXJuIGRh dGFiYXNlIHBhdGggb3IgQGMgTlVMTCwgb24gZXJyb3JzLgogICoKICAqIEBzZWUgZXdrX3NldHRp bmdzX2xvY2FsX3N0b3JhZ2VfcGF0aF9zZXQoKQpAQCAtMTEzLDcgKzExNSw3IEBAIEVBUEkgdm9p ZCBld2tfc2V0dGluZ3NfbG9jYWxfc3RvcmFnZV9kYXQKIC8qKgogICogUmV0dXJucyBkaXJlY3Rv cnkgcGF0aCB3aGVyZSB3ZWIgZGF0YWJhc2UgaXMgc3RvcmVkLgogICoKLSAqIEJ5IGRlZmF1bHQs IHRoZSB2YWx1ZSBpcyBAYyB+Ly53ZWJraXQKKyAqIEJ5IGRlZmF1bHQsIHRoZSB2YWx1ZSBpcyBA YyB+Ly5jYWNoZS9XZWJLaXRFZmwvRGF0YWJhc2VzCiAgKgogICogVGhpcyBpcyBndWFyYW50ZWVk IHRvIGJlIGVpbmFfc3RyaW5nc2hhcmUsIHNvIHdoZW5ldmVyIHBvc3NpYmxlCiAgKiBzYXZlIHlv dXJzZWxmIHNvbWUgY3B1IGN5Y2xlcyBhbmQgdXNlIGVpbmFfc3RyaW5nc2hhcmVfcmVmKCkKQEAg LTE5Nyw4ICsxOTksOCBAQCBFQVBJIEV2YXNfT2JqZWN0ICAgICAqZXdrX3NldHRpbmdzX2ljb25f CiAgKiBUaGUgT2ZmbGluZSBBcHBsaWNhdGlvbiBDYWNoaW5nIEFQSXMgYXJlIHBhcnQgb2YgSFRN TDUgYW5kIGFsbG93IGFwcGxpY2F0aW9ucyB0byBzdG9yZSBkYXRhIGxvY2FsbHkgdGhhdCBpcyBh Y2Nlc3NlZAogICogd2hlbiB0aGUgbmV0d29yayBjYW5ub3QgYmUgcmVhY2hlZC4KICAqCi0gKiBC eSBkZWZhdWx0LCB0aGUgcGF0aCBpcyBAYyBOVUxMLCBpbmRpY2F0aW5nIHRoYXQgdGhlIGZlYXR1 cmUgaXMgZGlzYWJsZWQuIE9uY2UgdGhlIHBhdGggaXMgc2V0LCB0aGUgZmVhdHVyZSBpcyBlbmFi bGVkCi0gKiBhbmQgdGhlIHBhdGggY2Fubm90IGJlIGNoYW5nZWQuCisgKiBCeSBkZWZhdWx0LCB0 aGUgcGF0aCBpcyBAYyB+Ly5jYWNoZS9XZWJLaXRFZmwvQXBwbGljYXRpb25zCisgKiBPbmNlIHRo ZSBwYXRoIGlzIHNldCwgdGhlIGZlYXR1cmUgaXMgZW5hYmxlZCBhbmQgdGhlIHBhdGggY2Fubm90 IGJlIGNoYW5nZWQuCiAgKgogICogQHBhcmFtIHBhdGggd2hlcmUgdG8gc3RvcmUgY2FjaGUsIG11 c3QgYmUgd3JpdGUtYWJsZS4KICAqCkBAIC0yMTIsNyArMjE0LDcgQEAgRUFQSSB2b2lkICAgICAg ICAgICAgIGV3a19zZXR0aW5nc19hcHBsaQogICogVGhlIE9mZmxpbmUgQXBwbGljYXRpb24gQ2Fj aGluZyBBUElzIGFyZSBwYXJ0IG9mIEhUTUw1IGFuZCBhbGxvdyBhcHBsaWNhdGlvbnMgdG8gc3Rv cmUgZGF0YSBsb2NhbGx5IHRoYXQgaXMgYWNjZXNzZWQKICAqIHdoZW4gdGhlIG5ldHdvcmsgY2Fu bm90IGJlIHJlYWNoZWQuCiAgKgotICogQnkgZGVmYXVsdCwgdGhlIHBhdGggaXMgQGMgTlVMTCwg aW5kaWNhdGluZyB0aGF0IHRoZSBmZWF0dXJlIGlzIGRpc2FibGVkLgorICogQnkgZGVmYXVsdCwg dGhlIHBhdGggaXMgQGMgfi8uY2FjaGUvV2ViS2l0RWZsL0FwcGxpY2F0aW9ucwogICoKICAqIEBy ZXR1cm4gZWluYV9zdHJpbmdzaGFyZSdkIHBhdGggdmFsdWUuCiAgKgo=