115502 2013-05-01 18:02:09 -0700 FastMalloc.cpp should use system defined page size instead of literal constant 2013-05-01 18:22:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin cmarcelo commit-queue oldest_to_newest 883691 0 msaboff 2013-05-01 18:02:09 -0700 FastMalloc.cpp uses kPageShift to derive page size of the OS for various data structures. Currently it is set at 12: static const size_t kPageShift = 12 Instead FastMalloc.cpp should use a system define. For Mac this is PAGE_SHIFT (and possibly other OS'es as well). 883695 1 200293 msaboff 2013-05-01 18:09:43 -0700 Created attachment 200293 Patch Only added Mac specific use of system define. Other platform partners can add appropriate values. 883696 2 200293 ggaren 2013-05-01 18:15:08 -0700 Comment on attachment 200293 Patch r=me 883700 3 msaboff 2013-05-01 18:22:03 -0700 Committed r149472: <http://trac.webkit.org/changeset/149472> 200293 2013-05-01 18:09:43 -0700 2013-05-01 18:15:08 -0700 Patch 115502.patch text/plain 2038 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDk0NjkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA1LTAxICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEZhc3RNYWxsb2MuY3BwIHNob3VsZCB1c2Ugc3lz dGVtIGRlZmluZWQgcGFnZSBzaXplIGluc3RlYWQgb2YgbGl0ZXJhbCBjb25zdGFudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NTAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCBrUGFnZVNo aWZ0IHRvIGJlIFBBR0VfU0hJRlQgZm9yIE1hYy4gIENoYW5nZWQga01heFNpemUgdG8gYmUgZml4 ZWQgYXQgMzJLLgorICAgICAgICBVcGRhdGVkIGtOdW1DbGFzc2VzIGZvciA0SyBhbmQgMTZLIHBh Z2Ugc2l6ZXMuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisgICAgICAgIGtQYWdl U2hpZnQ6IENoYW5nZWQgdGhpcyB0byBiZSBQQUdFX1NISUZUIG9uIG1hYy4KKwogMjAxMy0wNS0w MSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNldCBQYXRo IGluIG1ha2VmaWxlIGZvciBBcHBsZVdpbi4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxs b2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwCShyZXZp c2lvbiAxNDkyODIpCisrKyBTb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjI4LDEyICs2MjgsMjUgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdWludDMyX3Qg ZnJlZWRPYmplYwogLy8gTm90IGFsbCBwb3NzaWJsZSBjb21iaW5hdGlvbnMgb2YgdGhlIGZvbGxv d2luZyBwYXJhbWV0ZXJzIG1ha2UKIC8vIHNlbnNlLiAgSW4gcGFydGljdWxhciwgaWYga01heFNp emUgaW5jcmVhc2VzLCB5b3UgbWF5IGhhdmUgdG8KIC8vIGluY3JlYXNlIGtOdW1DbGFzc2VzIGFz IHdlbGwuCi1zdGF0aWMgY29uc3Qgc2l6ZV90IGtQYWdlU2hpZnQgID0gMTI7CisjaWYgT1MoREFS V0lOKQorIyAgICBkZWZpbmUgS19QQUdFX1NISUZUIFBBR0VfU0hJRlQKKyMgICAgaWYgKEtfUEFH RV9TSElGVCA9PSAxMikKKyMgICAgICAgIGRlZmluZSBLX05VTV9DTEFTU0VTIDY4CisjICAgIGVs aWYgKEtfUEFHRV9TSElGVCA9PSAxNCkKKyMgICAgICAgIGRlZmluZSBLX05VTV9DTEFTU0VTIDc3 CisjICAgIGVsc2UKKyMgICAgICAgIGVycm9yICJVbnN1cHBvcnRlZCBQQUdFX1NISUZUIGFtb3Vu dCIKKyMgICAgZW5kaWYKKyNlbHNlCisjICAgIGRlZmluZSBLX1BBR0VfU0hJRlQgMTIKKyMgICAg ZGVmaW5lIEtfTlVNX0NMQVNTRVMgNjgKKyNlbmRpZgorc3RhdGljIGNvbnN0IHNpemVfdCBrUGFn ZVNoaWZ0ICA9IEtfUEFHRV9TSElGVDsKIHN0YXRpYyBjb25zdCBzaXplX3Qga1BhZ2VTaXplICAg PSAxIDw8IGtQYWdlU2hpZnQ7Ci1zdGF0aWMgY29uc3Qgc2l6ZV90IGtNYXhTaXplICAgID0gOHUg KiBrUGFnZVNpemU7CitzdGF0aWMgY29uc3Qgc2l6ZV90IGtNYXhTaXplICAgID0gMzJ1ICogMTAy NDsKIHN0YXRpYyBjb25zdCBzaXplX3Qga0FsaWduU2hpZnQgPSAzOwogc3RhdGljIGNvbnN0IHNp emVfdCBrQWxpZ25tZW50ICA9IDEgPDwga0FsaWduU2hpZnQ7Ci1zdGF0aWMgY29uc3Qgc2l6ZV90 IGtOdW1DbGFzc2VzID0gNjg7CitzdGF0aWMgY29uc3Qgc2l6ZV90IGtOdW1DbGFzc2VzID0gS19O VU1fQ0xBU1NFUzsKIAogLy8gQWxsb2NhdGVzIGEgYmlnIGJsb2NrIG9mIG1lbW9yeSBmb3IgdGhl IHBhZ2VtYXAgb25jZSB3ZSByZWFjaCBtb3JlIHRoYW4KIC8vIDEyOE1CCg==