115485 2013-05-01 12:20:25 -0700 TextTrackMenu crashes in ports where MediaElement players are lazily created 2013-05-01 12:54:36 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue eric.carlson esprehn+autocc glenn jer.noble oldest_to_newest 883494 0 joepeck 2013-05-01 12:20:25 -0700 iOS is a port that lazily creates its player. HTMLMediaElement frequently null checks m_player, but doesn't in the PLATFORM_TEXT_TRACK_MENU code. We should add the null checks. 883495 1 200234 joepeck 2013-05-01 12:22:03 -0700 Created attachment 200234 [PATCH] Proposed Fix 883497 2 200234 eric.carlson 2013-05-01 12:27:07 -0700 Comment on attachment 200234 [PATCH] Proposed Fix Thanks! 883499 3 200234 commit-queue 2013-05-01 12:54:34 -0700 Comment on attachment 200234 [PATCH] Proposed Fix Clearing flags on attachment: 200234 Committed r149447: <http://trac.webkit.org/changeset/149447> 883500 4 commit-queue 2013-05-01 12:54:36 -0700 All reviewed patches have been landed. Closing bug. 200234 2013-05-01 12:22:03 -0700 2013-05-01 12:54:34 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 1665 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMGU1YzMzLi43ZWJkNzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDUtMDEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBUZXh0VHJhY2tNZW51IGNyYXNoZXMgaW4gcG9ydHMgd2hlcmUgTWVkaWFFbGVtZW50 IHBsYXllcnMgYXJlIGxhemlseSBjcmVhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0ODUKKworICAgICAgICBOdWxsIGNoZWNrIHRoZSBwbGF5 ZXIgZm9yIHBvcnRzLCBsaWtlIGlPUywgdGhhdCBsYXppbHkgY3JlYXRlIHRoZSBwbGF5ZXIuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 cGxhdGZvcm1UZXh0VHJhY2tNZW51KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6OmNsb3NlQ2FwdGlvblRyYWNrc0NoYW5nZWQpOgorCiAyMDEzLTA0LTMwICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIENsb3NlZCBjYXB0aW9uIGxpbmVzIG92 ZXJsYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGQ2ZDU4 ZDkuLjc4Mzc4MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApA QCAtMjkzOCw3ICsyOTM4LDcgQEAgUGxhdGZvcm1UZXh0VHJhY2tNZW51SW50ZXJmYWNlKiBIVE1M TWVkaWFFbGVtZW50OjpwbGF0Zm9ybVRleHRUcmFja01lbnUoKQogICAgIGlmIChtX3BsYXRmb3Jt TWVudSkKICAgICAgICAgcmV0dXJuIG1fcGxhdGZvcm1NZW51LmdldCgpOwogCi0gICAgaWYgKCFt X3BsYXllci0+aW1wbGVtZW50c1RleHRUcmFja0NvbnRyb2xzKCkpCisgICAgaWYgKCFtX3BsYXll ciB8fCAhbV9wbGF5ZXItPmltcGxlbWVudHNUZXh0VHJhY2tDb250cm9scygpKQogICAgICAgICBy ZXR1cm4gMDsKIAogICAgIG1fcGxhdGZvcm1NZW51ID0gbV9wbGF5ZXItPnRleHRUcmFja01lbnUo KTsKQEAgLTI5NTcsNyArMjk1Nyw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y2xvc2VDYXB0 aW9uVHJhY2tzQ2hhbmdlZCgpCiAgICAgICAgIG1lZGlhQ29udHJvbHMoKS0+Y2xvc2VkQ2FwdGlv blRyYWNrc0NoYW5nZWQoKTsKIAogI2lmIFVTRShQTEFURk9STV9URVhUX1RSQUNLX01FTlUpCi0g ICAgaWYgKG1fcGxheWVyLT5pbXBsZW1lbnRzVGV4dFRyYWNrQ29udHJvbHMoKSkKKyAgICBpZiAo bV9wbGF5ZXIgJiYgbV9wbGF5ZXItPmltcGxlbWVudHNUZXh0VHJhY2tDb250cm9scygpKQogICAg ICAgICBzY2hlZHVsZURlbGF5ZWRBY3Rpb24oVGV4dFRyYWNrQ2hhbmdlc05vdGlmaWNhdGlvbik7 CiAjZW5kaWYKIH0K