115477 2013-05-01 10:26:12 -0700 handle enum in overloaded methods 2015-11-11 10:01:28 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 a.renevier a.renevier cdumez commit-queue dbates esprehn+autocc ggaren haraken sam oldest_to_newest 883445 0 a.renevier 2013-05-01 10:26:12 -0700 Hi, currently, enum are not handled correctly in overloaded methods: The check done is: The binding try to check if argument is an object of type whateverEnum. Instead, it should check if it's a string. 883449 1 200220 a.renevier 2013-05-01 10:35:52 -0700 Created attachment 200220 patch proposal 883474 2 ggaren 2013-05-01 11:26:21 -0700 Can you give an example of how this will be used? Why do we want to use strings for enumerated values, instead of numbers? 883476 3 haraken 2013-05-01 11:29:25 -0700 > Why do we want to use strings for enumerated values, instead of numbers? Because it's speced: http://dev.w3.org/2006/webapi/WebIDL/#idl-enums > Can you give an example of how this will be used? arno: Enum is used more and more in the spec (but is poorly supported in WebKit and Blink), so your patch basically looks good. What use case do you have in mind? 883477 4 a.renevier 2013-05-01 11:30:46 -0700 (In reply to comment #3) > arno: Enum is used more and more in the spec (but is poorly supported in WebKit and Blink), so your patch basically looks good. What use case do you have in mind? the overloaded fill method of canvas2d: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#2dcontext 1141134 5 200220 andersca 2015-11-11 10:01:28 -0800 Comment on attachment 200220 patch proposal This patch hasn't been touched in over 2.5 years, so I think we can go ahead and clear the review flag now. 200220 2013-05-01 10:35:52 -0700 2015-11-11 10:01:28 -0800 patch proposal bug-115477-20130501103505.patch text/plain 5367 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMyNDM0ZWQ5OTY4Y2I2 ZmFhYTQ1NzM3ZmJhNDgxMDk5M2I5YzhmOS4uY2I2NThmMWVjMDcxMmMyMjBkMGMxZjg4MTExZWFl MDMzZmJjYzdmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA1LTAxICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgaGFu ZGxlIGVudW0gaW4gb3ZlcmxvYWRlZCBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0NzcKKworICAgICAgICBDaGVjayB0aGF0IG9wdGlv bmFsIGVudW0gYXJndW1lbnQgaXMgb2YgdHlwZSBzdHJpbmcgb3Igb2JqZWN0IHRvCisgICAgICAg IGRldGVybWluZSB0aGUgY29ycmVjdCBvdmVybG9hZGVkIG1ldGhvZC4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBiaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVGVzdE9iai5pZGwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2tFeHByZXNzaW9uKToK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZDEx KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6anNUZXN0T2JqUHJvdG90 eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kMTIpOgorICAgICAgICAoV2ViQ29yZTo6anNUZXN0 T2JqUHJvdG90eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kKToKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL3Rlc3QvVGVzdE9iai5pZGw6CisKIDIwMTMtMDMtMjggIEFybmF1ZCBSZW5ldmll ciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBtZWFzdXJlVGV4dCgp IGltcHJvdmVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQppbmRleCBmNzllNWIwNzFiYzc5NmZmMDk4NDE3NTc0M2U4ZDk3ZWI4 NWU3MDE3Li40NGViMmEzMTE4NTdmYWZhYzMzZmViZTFmNDE3NGE3ZTJkNGYyNGQyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpA QCAtMTI5NCw2ICsxMjk0LDkgQEAgc3ViIEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNrRXhwcmVzc2lv bgogICAgICAgICAgICAgICAgIHB1c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNVbmRl ZmluZWRPck51bGwoKSB8fCAke3ZhbHVlfS5pc1N0cmluZygpIHx8ICR7dmFsdWV9LmlzT2JqZWN0 KCkpIik7CiAgICAgICAgICAgICAgICAgJHVzZWRBcmd1bWVudHN7JHBhcmFtZXRlckluZGV4fSA9 IDE7CiAgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzaWYgKCRjb2RlR2VuZXJhdG9yLT5Jc0Vu dW1UeXBlKCR0eXBlKSkgeworICAgICAgICAgICAgcHVzaChAYW5kRXhwcmVzc2lvbiwgIigke3Zh bHVlfS5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8ICR7dmFsdWV9LmlzU3RyaW5nKCkgfHwgJHt2YWx1 ZX0uaXNPYmplY3QoKSkiKTsKKyAgICAgICAgICAgICR1c2VkQXJndW1lbnRzeyRwYXJhbWV0ZXJJ bmRleH0gPSAxOwogICAgICAgICB9IGVsc2lmICgkY29kZUdlbmVyYXRvci0+SXNDYWxsYmFja0lu dGVyZmFjZSgkcGFyYW1ldGVyLT50eXBlKSkgewogICAgICAgICAgICAgIyBGb3IgQ2FsbGJhY2tz IG9ubHkgY2hlY2tzIGlmIHRoZSB2YWx1ZSBpcyBudWxsIG9yIG9iamVjdC4KICAgICAgICAgICAg IHB1c2goQGFuZEV4cHJlc3Npb24sICIoJHt2YWx1ZX0uaXNOdWxsKCkgfHwgJHt2YWx1ZX0uaXNG dW5jdGlvbigpKSIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAppbmRleCAzYzNiYjZjYWZhMGJmMDgwYTljNmU1Mzg3Yzgw OWVlZDhkMjZjZDk5Li5lYzBlMjdjOTNhOGRiOTI3ODE2ZTljNGU4ZmZiZDhhYTU0Y2ZmM2JjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0 T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNU ZXN0T2JqLmNwcApAQCAtMjU1Miw2ICsyNTUyLDI1IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZDEx CiAgICAgVGVzdE9iaiogaW1wbCA9IHN0YXRpY19jYXN0PFRlc3RPYmoqPihjYXN0ZWRUaGlzLT5p bXBsKCkpOwogICAgIGlmIChleGVjLT5hcmd1bWVudENvdW50KCkgPCAxKQogICAgICAgICByZXR1 cm4gdGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZU5vdEVub3VnaEFyZ3VtZW50c0Vycm9yKGV4ZWMp KTsKKyAgICBjb25zdCBTdHJpbmcgZW51bUFyZyhleGVjLT5hcmd1bWVudCgwKS5pc0VtcHR5KCkg PyBTdHJpbmcoKSA6IGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVj KSk7CisgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQorICAgICAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworICAgIGlmIChlbnVtQXJnICE9ICIiICYmIGVudW1B cmcgIT0gIkVudW1WYWx1ZTEiICYmIGVudW1BcmcgIT0gIkVudW1WYWx1ZTIiICYmIGVudW1Bcmcg IT0gIkVudW1WYWx1ZTMiKQorICAgICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihleGVjKTsK KyAgICBpbXBsLT5vdmVybG9hZGVkTWV0aG9kKGVudW1BcmcpOworICAgIHJldHVybiBKU1ZhbHVl OjplbmNvZGUoanNVbmRlZmluZWQoKSk7Cit9CisKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0Nf SE9TVF9DQUxMIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZDEyKEV4 ZWNTdGF0ZSogZXhlYykKK3sKKyAgICBKU1ZhbHVlIHRoaXNWYWx1ZSA9IGV4ZWMtPmhvc3RUaGlz VmFsdWUoKTsKKyAgICBpZiAoIXRoaXNWYWx1ZS5pbmhlcml0cygmSlNUZXN0T2JqOjpzX2luZm8p KQorICAgICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihleGVjKTsKKyAgICBKU1Rlc3RPYmoq IGNhc3RlZFRoaXMgPSBqc0Nhc3Q8SlNUZXN0T2JqKj4oYXNPYmplY3QodGhpc1ZhbHVlKSk7Cisg ICAgQVNTRVJUX0dDX09CSkVDVF9JTkhFUklUUyhjYXN0ZWRUaGlzLCAmSlNUZXN0T2JqOjpzX2lu Zm8pOworICAgIFRlc3RPYmoqIGltcGwgPSBzdGF0aWNfY2FzdDxUZXN0T2JqKj4oY2FzdGVkVGhp cy0+aW1wbCgpKTsKKyAgICBpZiAoZXhlYy0+YXJndW1lbnRDb3VudCgpIDwgMSkKKyAgICAgICAg cmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVOb3RFbm91Z2hBcmd1bWVudHNFcnJvcihl eGVjKSk7CiAgICAgY29uc3QgU3RyaW5nJiBzdHJBcmcoZXhlYy0+YXJndW1lbnQoMCkuaXNFbXB0 eSgpID8gU3RyaW5nKCkgOiBleGVjLT5hcmd1bWVudCgwKS50b1N0cmluZyhleGVjKS0+dmFsdWUo ZXhlYykpOwogICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKQEAgLTI1ODQsOCArMjYwMywxMCBAQCBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3Zlcmxv YWRlZE1ldGhvZChFeGVjU3RhdAogICAgICAgICByZXR1cm4ganNUZXN0T2JqUHJvdG90eXBlRnVu Y3Rpb25PdmVybG9hZGVkTWV0aG9kOShleGVjKTsKICAgICBpZiAoKGFyZ3NDb3VudCA9PSAxICYm IChhcmcwLmlzT2JqZWN0KCkgJiYgaXNKU0FycmF5KGFyZzApKSkpCiAgICAgICAgIHJldHVybiBq c1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk92ZXJsb2FkZWRNZXRob2QxMChleGVjKTsKLSAgICBp ZiAoYXJnc0NvdW50ID09IDEpCisgICAgaWYgKChhcmdzQ291bnQgPT0gMSAmJiAoYXJnMC5pc1Vu ZGVmaW5lZE9yTnVsbCgpIHx8IGFyZzAuaXNTdHJpbmcoKSB8fCBhcmcwLmlzT2JqZWN0KCkpKSkK ICAgICAgICAgcmV0dXJuIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhv ZDExKGV4ZWMpOworICAgIGlmIChhcmdzQ291bnQgPT0gMSkKKyAgICAgICAgcmV0dXJuIGpzVGVz dE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZDEyKGV4ZWMpOwogICAgIGlmIChh cmdzQ291bnQgPCAxKQogICAgICAgICByZXR1cm4gdGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZU5v dEVub3VnaEFyZ3VtZW50c0Vycm9yKGV4ZWMpKTsKICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJv cihleGVjKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9UZXN0T2JqLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0 T2JqLmlkbAppbmRleCA1NmQ3NGY4NWIxNGE0NTFhNjNjYjc2ZTEwYWRlODYwZDcyZTdmOWM3Li44 NWQ5NzAxMjgxNDE5NmUxMDYzZTliMWZkY2IzMmQ5NGIzNjg5YzFkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdE9iai5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RPYmouaWRsCkBAIC0xODYsNiArMTg2 LDcgQEAgZW51bSBUZXN0RW51bVR5cGUgeyAiIiwgIkVudW1WYWx1ZTEiLCAiRW51bVZhbHVlMiIs ICJFbnVtVmFsdWUzIiB9OwogICAgIHZvaWQgICAgb3ZlcmxvYWRlZE1ldGhvZChUZXN0T2JqIG9i akFyZyk7CiAgICAgdm9pZCAgICBvdmVybG9hZGVkTWV0aG9kKERPTVN0cmluZ1tdIGFycmF5QXJn KTsKICAgICB2b2lkICAgIG92ZXJsb2FkZWRNZXRob2Qoc2VxdWVuY2U8dW5zaWduZWQgbG9uZz4g YXJyYXlBcmcpOworICAgIHZvaWQgICAgb3ZlcmxvYWRlZE1ldGhvZChUZXN0RW51bVR5cGUgZW51 bUFyZyk7CiAgICAgdm9pZCAgICBvdmVybG9hZGVkTWV0aG9kKERPTVN0cmluZyBzdHJBcmcpOwog I2VuZGlmCiAK