115468 2013-05-01 00:00:21 -0700 fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe 2013-05-01 16:00:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 115300 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 883397 0 fpizlo 2013-05-01 00:00:21 -0700 Patch forthcoming. This is blocking https://bugs.webkit.org/show_bug.cgi?id=115300 because the StringImpl assertions show this being called from the compilation thread. 883542 1 200242 fpizlo 2013-05-01 14:50:33 -0700 Created attachment 200242 the patch 883543 2 200242 ggaren 2013-05-01 14:56:36 -0700 Comment on attachment 200242 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=200242&action=review > Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:204 > + Structure* transition = Structure::addPropertyTransitionToExistingStructureConcurrently(structure, ident, 0, 0, offset); This function could use a better name that doesn't imply that it performs an add. 883570 3 fpizlo 2013-05-01 16:00:55 -0700 Landed in http://trac.webkit.org/changeset/149459 200242 2013-05-01 14:50:33 -0700 2013-05-01 14:56:35 -0700 the patch blah.patch text/plain 6747 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ5NDU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDEzLTA1LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogU3RydWN0dXJlOjphZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3Ry dWN0dXJlIHNob3VsZCBiZSB0aHJlYWQtc2FmZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIG1ha2VzIHRoZSBtYWluIHRocmVhZCBt b2RpZnkgdGhlIHRyYW5zaXRpb24gdGFibGUgd2hpbGUgaG9sZGluZyBhIGxvY2suIE5vdGUKKyAg ICAgICAgdGhhdCB0aGUgR0MgbWlnaHQgbW9kaWZ5IGl0cyB3ZWFrIHBvaW50ZXJzIHdpdGhvdXQg bG9ja2luZywgYnV0IHRoZSBHQyB3aWxsIGxvY2sgb3V0CisgICAgICAgIHRoZSBjb21waWxhdGlv biB0aHJlYWQgYW55d2F5LiBUaGUgbWFwIHdpbGwgdGhlbiBvbmx5IHJlc2hhcGUgaW4gcmVzcG9u c2UgdG8gYWRkKCkKKyAgICAgICAgYW5kIHNldCgpLCB3aGljaCBoYXBwZW4gd2hpbGUgaG9sZGlu ZyBhIGxvY2suCisgICAgICAgIAorICAgICAgICBUaGlzIGFsbG93cyB0aGUgY29tcGlsYXRpb24g dGhyZWFkIHRvIG5vdyBxdWVyeSB0cmFuc2l0aW9uIHRhYmxlcyBzYWZlbHksIHByb3ZpZGVkIGl0 CisgICAgICAgIGhvbGRzIGEgbG9jayB3aGVuIGRvaW5nIHNvLgorCisgICAgICAgICogYnl0ZWNv ZGUvUHV0QnlJZFN0YXR1cy5jcHA6CisgICAgICAgIChKU0M6OlB1dEJ5SWRTdGF0dXM6OmNvbXB1 dGVGb3IpOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpTQzo6 U3RydWN0dXJlOjphZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3RydWN0dXJlSW1wbCk6 CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6YWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGlu Z1N0cnVjdHVyZSk6CisgICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OmFk ZFByb3BlcnR5VHJhbnNpdGlvblRvRXhpc3RpbmdTdHJ1Y3R1cmVDb25jdXJyZW50bHkpOgorICAg ICAgICAoSlNDOjpTdHJ1Y3R1cmU6OmFkZFByb3BlcnR5VHJhbnNpdGlvbik6CisgICAgICAgIChK U0M6OlN0cnVjdHVyZTo6bm9uUHJvcGVydHlUcmFuc2l0aW9uKToKKyAgICAgICAgKiBydW50aW1l L1N0cnVjdHVyZS5oOgorICAgICAgICAoU3RydWN0dXJlKToKKwogMjAxMy0wNC0zMCAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIGZvdXJ0aFRpZXI6IFN0cnVjdHVy ZTo6Z2V0Q29uY3VycmVudGx5KCkgbWF5IGJlIGNhbGxlZCBmcm9tIGZvciB1bmNhY2hlYWJsZSBk aWN0aW9uYXJpZXMsIGFuZCB0aGlzIGlzIHNhZmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9QdXRCeUlkU3RhdHVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvUHV0QnlJZFN0YXR1cy5jcHAJKHJldmlzaW9uIDE0OTQ1NSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9QdXRCeUlkU3RhdHVzLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjAxLDcgKzIwMSw3IEBAIFB1dEJ5SWRTdGF0dXMgUHV0QnlJZFN0YXR1czo6 Y29tcHV0ZUZvcigKICAgICAvLyAtIElmIHdlJ3JlIG5vdCBzdG9yaW5nIGEgdmFsdWUgdGhhdCBj b3VsZCBiZSBzcGVjaWZpYzogYWdhaW4sIHRoaXMgd291bGQgb25seSBiZSBhCiAgICAgLy8gICBw cm9ibGVtIGlmIHRoZSBleGlzdGluZyB0cmFuc2l0aW9uIGRpZCBoYXZlIGEgc3BlY2lmaWMgdmFs dWUsIHdoaWNoIHdlIGNoZWNrIGZvcgogICAgIC8vICAgYnkgcGFzc2luZyAwIGZvciB0aGUgc3Bl Y2lmaWNWYWx1ZS4KLSAgICBTdHJ1Y3R1cmUqIHRyYW5zaXRpb24gPSBTdHJ1Y3R1cmU6OmFkZFBy b3BlcnR5VHJhbnNpdGlvblRvRXhpc3RpbmdTdHJ1Y3R1cmUoc3RydWN0dXJlLCBpZGVudCwgMCwg MCwgb2Zmc2V0KTsKKyAgICBTdHJ1Y3R1cmUqIHRyYW5zaXRpb24gPSBTdHJ1Y3R1cmU6OmFkZFBy b3BlcnR5VHJhbnNpdGlvblRvRXhpc3RpbmdTdHJ1Y3R1cmVDb25jdXJyZW50bHkoc3RydWN0dXJl LCBpZGVudCwgMCwgMCwgb2Zmc2V0KTsKICAgICBpZiAoIXRyYW5zaXRpb24pCiAgICAgICAgIHJl dHVybiBQdXRCeUlkU3RhdHVzKFRha2VzU2xvd1BhdGgpOyAvLyBUaGlzIG9jY3VycyBpbiBiaXph cnJlIGNhc2VzIG9ubHkuIFNlZSBhYm92ZS4KICAgICBBU1NFUlQoIXRyYW5zaXRpb24tPnRyYW5z aXRpb25EaWRJbnZvbHZlU3BlY2lmaWNWYWx1ZSgpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAkocmV2aXNpb24gMTQ5NDU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzIxLDcgKzMyMSw3IEBAIHZvaWQgU3RydWN0dXJlOjpkZXNwZWNpZnlEaWN0aW9uYXJ5RnVuY3QK ICAgICBlbnRyeS0+c3BlY2lmaWNWYWx1ZS5jbGVhcigpOwogfQogCi1TdHJ1Y3R1cmUqIFN0cnVj dHVyZTo6YWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGluZ1N0cnVjdHVyZShTdHJ1Y3R1cmUq IHN0cnVjdHVyZSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgdW5zaWduZWQgYXR0cmlidXRl cywgSlNDZWxsKiBzcGVjaWZpY1ZhbHVlLCBQcm9wZXJ0eU9mZnNldCYgb2Zmc2V0KQorU3RydWN0 dXJlKiBTdHJ1Y3R1cmU6OmFkZFByb3BlcnR5VHJhbnNpdGlvblRvRXhpc3RpbmdTdHJ1Y3R1cmVJ bXBsKFN0cnVjdHVyZSogc3RydWN0dXJlLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCB1bnNp Z25lZCBhdHRyaWJ1dGVzLCBKU0NlbGwqIHNwZWNpZmljVmFsdWUsIFByb3BlcnR5T2Zmc2V0JiBv ZmZzZXQpCiB7CiAgICAgQVNTRVJUKCFzdHJ1Y3R1cmUtPmlzRGljdGlvbmFyeSgpKTsKICAgICBB U1NFUlQoc3RydWN0dXJlLT5pc09iamVjdCgpKTsKQEAgLTMzOCw2ICszMzgsMTggQEAgU3RydWN0 dXJlKiBTdHJ1Y3R1cmU6OmFkZFByb3BlcnR5VHJhbnNpdAogICAgIHJldHVybiAwOwogfQogCitT dHJ1Y3R1cmUqIFN0cnVjdHVyZTo6YWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGluZ1N0cnVj dHVyZShTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgdW5z aWduZWQgYXR0cmlidXRlcywgSlNDZWxsKiBzcGVjaWZpY1ZhbHVlLCBQcm9wZXJ0eU9mZnNldCYg b2Zmc2V0KQoreworICAgIEFTU0VSVCghaXNDb21waWxhdGlvblRocmVhZCgpKTsKKyAgICByZXR1 cm4gYWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGluZ1N0cnVjdHVyZUltcGwoc3RydWN0dXJl LCBwcm9wZXJ0eU5hbWUsIGF0dHJpYnV0ZXMsIHNwZWNpZmljVmFsdWUsIG9mZnNldCk7Cit9CisK K1N0cnVjdHVyZSogU3RydWN0dXJlOjphZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3Ry dWN0dXJlQ29uY3VycmVudGx5KFN0cnVjdHVyZSogc3RydWN0dXJlLCBQcm9wZXJ0eU5hbWUgcHJv cGVydHlOYW1lLCB1bnNpZ25lZCBhdHRyaWJ1dGVzLCBKU0NlbGwqIHNwZWNpZmljVmFsdWUsIFBy b3BlcnR5T2Zmc2V0JiBvZmZzZXQpCit7CisgICAgTG9ja2VyIGxvY2tlcihzdHJ1Y3R1cmUtPm1f bG9jayk7CisgICAgcmV0dXJuIGFkZFByb3BlcnR5VHJhbnNpdGlvblRvRXhpc3RpbmdTdHJ1Y3R1 cmVJbXBsKHN0cnVjdHVyZSwgcHJvcGVydHlOYW1lLCBhdHRyaWJ1dGVzLCBzcGVjaWZpY1ZhbHVl LCBvZmZzZXQpOworfQorCiBib29sIFN0cnVjdHVyZTo6YW55T2JqZWN0SW5DaGFpbk1heUludGVy Y2VwdEluZGV4ZWRBY2Nlc3NlcygpIGNvbnN0CiB7CiAgICAgZm9yIChjb25zdCBTdHJ1Y3R1cmUq IGN1cnJlbnQgPSB0aGlzOyA7KSB7CkBAIC00MDUsNyArNDE3LDEwIEBAIFN0cnVjdHVyZSogU3Ry dWN0dXJlOjphZGRQcm9wZXJ0eVRyYW5zaXQKICAgICBvZmZzZXQgPSB0cmFuc2l0aW9uLT5wdXRT cGVjaWZpY1ZhbHVlKHZtLCBwcm9wZXJ0eU5hbWUsIGF0dHJpYnV0ZXMsIHNwZWNpZmljVmFsdWUp OwogCiAgICAgY2hlY2tPZmZzZXQodHJhbnNpdGlvbi0+bV9vZmZzZXQsIHRyYW5zaXRpb24tPmlu bGluZUNhcGFjaXR5KCkpOwotICAgIHN0cnVjdHVyZS0+bV90cmFuc2l0aW9uVGFibGUuYWRkKHZt LCB0cmFuc2l0aW9uKTsKKyAgICB7CisgICAgICAgIExvY2tlciBsb2NrZXIoc3RydWN0dXJlLT5t X2xvY2spOworICAgICAgICBzdHJ1Y3R1cmUtPm1fdHJhbnNpdGlvblRhYmxlLmFkZCh2bSwgdHJh bnNpdGlvbik7CisgICAgfQogICAgIHRyYW5zaXRpb24tPmNoZWNrT2Zmc2V0Q29uc2lzdGVuY3ko KTsKICAgICBzdHJ1Y3R1cmUtPmNoZWNrT2Zmc2V0Q29uc2lzdGVuY3koKTsKICAgICByZXR1cm4g dHJhbnNpdGlvbjsKQEAgLTYwNCw3ICs2MTksMTAgQEAgU3RydWN0dXJlKiBTdHJ1Y3R1cmU6Om5v blByb3BlcnR5VHJhbnNpdAogICAgIHRyYW5zaXRpb24tPm1fb2Zmc2V0ID0gc3RydWN0dXJlLT5t X29mZnNldDsKICAgICBjaGVja09mZnNldCh0cmFuc2l0aW9uLT5tX29mZnNldCwgdHJhbnNpdGlv bi0+aW5saW5lQ2FwYWNpdHkoKSk7CiAgICAgCi0gICAgc3RydWN0dXJlLT5tX3RyYW5zaXRpb25U YWJsZS5hZGQodm0sIHRyYW5zaXRpb24pOworICAgIHsKKyAgICAgICAgTG9ja2VyIGxvY2tlcihz dHJ1Y3R1cmUtPm1fbG9jayk7CisgICAgICAgIHN0cnVjdHVyZS0+bV90cmFuc2l0aW9uVGFibGUu YWRkKHZtLCB0cmFuc2l0aW9uKTsKKyAgICB9CiAgICAgdHJhbnNpdGlvbi0+Y2hlY2tPZmZzZXRD b25zaXN0ZW5jeSgpOwogICAgIHJldHVybiB0cmFuc2l0aW9uOwogfQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgJKHJldmlzaW9uIDE0OTQ1NSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCSh3b3JraW5nIGNvcHkpCkBA IC05Nyw2ICs5Nyw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgdm9pZCBkdW1wU3RhdGlzdGljcygp OwogCiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIFN0cnVjdHVyZSogYWRkUHJvcGVydHlU cmFuc2l0aW9uKFZNJiwgU3RydWN0dXJlKiwgUHJvcGVydHlOYW1lLCB1bnNpZ25lZCBhdHRyaWJ1 dGVzLCBKU0NlbGwqIHNwZWNpZmljVmFsdWUsIFByb3BlcnR5T2Zmc2V0Jik7CisgICAgc3RhdGlj IFN0cnVjdHVyZSogYWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGluZ1N0cnVjdHVyZUNvbmN1 cnJlbnRseShTdHJ1Y3R1cmUqLCBQcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMsIEpT Q2VsbCogc3BlY2lmaWNWYWx1ZSwgUHJvcGVydHlPZmZzZXQmKTsKICAgICBKU19FWFBPUlRfUFJJ VkFURSBzdGF0aWMgU3RydWN0dXJlKiBhZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3Ry dWN0dXJlKFN0cnVjdHVyZSosIFByb3BlcnR5TmFtZSwgdW5zaWduZWQgYXR0cmlidXRlcywgSlND ZWxsKiBzcGVjaWZpY1ZhbHVlLCBQcm9wZXJ0eU9mZnNldCYpOwogICAgIHN0YXRpYyBTdHJ1Y3R1 cmUqIHJlbW92ZVByb3BlcnR5VHJhbnNpdGlvbihWTSYsIFN0cnVjdHVyZSosIFByb3BlcnR5TmFt ZSwgUHJvcGVydHlPZmZzZXQmKTsKICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RydWN0 dXJlKiBjaGFuZ2VQcm90b3R5cGVUcmFuc2l0aW9uKFZNJiwgU3RydWN0dXJlKiwgSlNWYWx1ZSBw cm90b3R5cGUpOwpAQCAtMzY3LDYgKzM2OCw4IEBAIHByaXZhdGU6CiAKICAgICBzdGF0aWMgU3Ry dWN0dXJlKiBjcmVhdGUoVk0mLCBjb25zdCBTdHJ1Y3R1cmUqKTsKICAgICAKKyAgICBzdGF0aWMg U3RydWN0dXJlKiBhZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3RydWN0dXJlSW1wbChT dHJ1Y3R1cmUqLCBQcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMsIEpTQ2VsbCogc3Bl Y2lmaWNWYWx1ZSwgUHJvcGVydHlPZmZzZXQmKTsKKwogICAgIC8vIFRoaXMgd2lsbCByZXR1cm4g dGhlIHN0cnVjdHVyZSB0aGF0IGhhcyBhIHVzYWJsZSBwcm9wZXJ0eSB0YWJsZSwgdGhhdCBwcm9w ZXJ0eSB0YWJsZSwKICAgICAvLyBhbmQgdGhlIGxpc3Qgb2Ygc3RydWN0dXJlcyB0aGF0IHdlIHZp c2l0ZWQgYmVmb3JlIHdlIGdvdCB0byBpdC4gSWYgaXQgcmV0dXJucyBhCiAgICAgLy8gbm9uLW51 bGwgc3RydWN0dXJlLCBpdCB3aWxsIGFsc28gbG9jayB0aGUgc3RydWN0dXJlIHRoYXQgaXQgcmV0 dXJuczsgaXQgaXMgeW91ciBqb2IK