115442 2013-04-30 12:25:46 -0700 Page::pageCount() is inaccurate when we allow the first paint in App Mode 2013-04-30 12:53:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin commit-queue esprehn+autocc hyatt oldest_to_newest 883204 0 bdakin 2013-04-30 12:25:46 -0700 Page::pageCount() is inaccurate when we allow the first paint in App Mode, which happens when Document::setVisualUpdatesAllowed(true) is called. It should be accurate. After layout is updated, the page count should be accurate, but it is not for paginated content that contains images because auto-height images are given a layout height of 0 after the first pass. They require a second pass to get the right height. They shouldn't. <rdar://problem/13758445> 883207 1 200141 bdakin 2013-04-30 12:30:36 -0700 Created attachment 200141 Patch 883210 2 200141 hyatt 2013-04-30 12:52:23 -0700 Comment on attachment 200141 Patch r=me 883211 3 bdakin 2013-04-30 12:53:42 -0700 Thanks, Dave! http://trac.webkit.org/changeset/149393 200141 2013-04-30 12:30:36 -0700 2013-04-30 12:52:23 -0700 Patch for-review.txt text/plain 1617 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdlOjpwYWdlQ291bnQoKSBpcyBp bmFjY3VyYXRlIHdoZW4gd2UgYWxsb3cgdGhlIGZpcnN0IHBhaW50IGluIEFwcCBNb2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0NDIKKyAgICAg ICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTM3NTg0NDU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hv dWxkIHNldCB0aGUgaGVpZ2h0IGhlcmUgYWxsIHRoZSB0aW1lLCBldmVuIGlmIGl0IGlzIHRoZSBm aXJzdCBsYXlvdXQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjaGVja0ZvclBhZ2luYXRpb25Mb2dpY2FsSGVpZ2h0 Q2hhbmdlKToKKwogMjAxMy0wNC0zMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBDYXAgbWF4IENBTGF5ZXIgdHJlZSBkZXB0aCB0byBhdm9pZCBjcmFz aGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlz aW9uIDE0OTMyMikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE1MTcsMTAgKzE1MTcsMTEgQEAgdm9pZCBSZW5kZXJCbG9jazo6 Y2hlY2tGb3JQYWdpbmF0aW9uTG9naQogICAgICAgICAgICAgfQogICAgICAgICAgICAgc2V0TG9n aWNhbEhlaWdodCgwKTsKICAgICAgICAgfQotICAgICAgICBpZiAoY29sSW5mby0+Y29sdW1uSGVp Z2h0KCkgIT0gcGFnZUxvZ2ljYWxIZWlnaHQgJiYgZXZlckhhZExheW91dCgpKSB7Ci0gICAgICAg ICAgICBjb2xJbmZvLT5zZXRDb2x1bW5IZWlnaHQocGFnZUxvZ2ljYWxIZWlnaHQpOworCisgICAg ICAgIGlmIChjb2xJbmZvLT5jb2x1bW5IZWlnaHQoKSAhPSBwYWdlTG9naWNhbEhlaWdodCAmJiBl dmVySGFkTGF5b3V0KCkpCiAgICAgICAgICAgICBwYWdlTG9naWNhbEhlaWdodENoYW5nZWQgPSB0 cnVlOwotICAgICAgICB9CisKKyAgICAgICAgY29sSW5mby0+c2V0Q29sdW1uSGVpZ2h0KHBhZ2VM b2dpY2FsSGVpZ2h0KTsKICAgICAgICAgCiAgICAgICAgIGlmICghaGFzU3BlY2lmaWVkUGFnZUxv Z2ljYWxIZWlnaHQgJiYgIXBhZ2VMb2dpY2FsSGVpZ2h0KQogICAgICAgICAgICAgY29sSW5mby0+ Y2xlYXJGb3JjZWRCcmVha3MoKTsK