115435 2013-04-30 11:33:16 -0700 More StorageTracker cleanup 2013-04-30 15:04:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 883180 0 andersca 2013-04-30 11:33:16 -0700 More StorageTracker cleanup 883182 1 200137 andersca 2013-04-30 11:35:11 -0700 Created attachment 200137 Patch 883190 2 200137 kling 2013-04-30 11:54:10 -0700 Comment on attachment 200137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200137&action=review > Source/WebCore/storage/StorageTracker.cpp:-437 > - ASSERT(isMainThread()); Removing this assert, I see. 883240 3 andersca 2013-04-30 15:04:50 -0700 Committed r149402: <http://trac.webkit.org/changeset/149402> 200137 2013-04-30 11:35:11 -0700 2013-04-30 11:54:10 -0700 Patch bug-115435-20130430113426.patch text/plain 5178 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhMWU0ZTkzNjcxNjY0 ZjFiYTk5ZmNkM2NmNTc0ODcyN2YwZjZjNS4uOGE1YmIyZGExOTc4ZTlmMGNmM2M3ODYyYzk2ZjVm OTY4ZjgzNGQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTA0LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW9yZSBTdG9yYWdl VHJhY2tlciBjbGVhbnVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTU0MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgYmluZCBpbnN0ZWFkIG9mICJvbk1haW5UaHJlYWQiIGhlbHBlciBmdW5jdGlv bnMuCisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VBcmVhU3luYy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdG9yYWdlQXJlYVN5bmM6OmRlbGV0ZUVtcHR5RGF0YWJhc2UpOgorICAgICAgICAq IHN0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZVRy YWNrZXI6OnN5bmNJbXBvcnRPcmlnaW5JZGVudGlmaWVycyk6CisgICAgICAgIChXZWJDb3JlOjpT dG9yYWdlVHJhY2tlcjo6c3luY0ZpbGVTeXN0ZW1BbmRUcmFja2VyRGF0YWJhc2UpOgorICAgICAg ICAoV2ViQ29yZTo6U3RvcmFnZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbldpdGhJZGVudGlmaWVyKToK KyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmg6CisgICAgICAgIChTdG9yYWdlVHJh Y2tlcik6CisKKzIwMTMtMDQtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KKwogICAgICAgICBGaXggYnVpbGQuCiAKICAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFTeW5jLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFTeW5jLmNwcAppbmRleCAyY2U5OTA3OTM5 NDMzZTFlYmZlNDg3MzQ4OTI0ZmViODMyOThlZTllLi41NmYzYTQyOTk4NDZhMDk2ODk3NWIyZjcw ZDg2Y2ZhYjc1YzYxYTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2VBcmVhU3luYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlQXJlYVN5 bmMuY3BwCkBAIC01MDksNyArNTA5LDcgQEAgdm9pZCBTdG9yYWdlQXJlYVN5bmM6OmRlbGV0ZUVt cHR5RGF0YWJhc2UoKQogICAgICAgICBxdWVyeS5maW5hbGl6ZSgpOwogICAgICAgICBtX2RhdGFi YXNlLmNsb3NlKCk7CiAgICAgICAgIGlmIChTdG9yYWdlVHJhY2tlcjo6dHJhY2tlcigpLmlzQWN0 aXZlKCkpCi0gICAgICAgICAgICBTdG9yYWdlVHJhY2tlcjo6dHJhY2tlcigpLmRlbGV0ZU9yaWdp bihtX2RhdGFiYXNlSWRlbnRpZmllcik7CisgICAgICAgICAgICBTdG9yYWdlVHJhY2tlcjo6dHJh Y2tlcigpLmRlbGV0ZU9yaWdpbldpdGhJZGVudGlmaWVyKG1fZGF0YWJhc2VJZGVudGlmaWVyKTsK ICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBTdHJpbmcgZGF0YWJhc2VGaWxlbmFtZSA9IG1f c3luY01hbmFnZXItPmZ1bGxEYXRhYmFzZUZpbGVuYW1lKG1fZGF0YWJhc2VJZGVudGlmaWVyKTsK ICAgICAgICAgICAgIGlmICghU1FMaXRlRmlsZVN5c3RlbTo6ZGVsZXRlRGF0YWJhc2VGaWxlKGRh dGFiYXNlRmlsZW5hbWUpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9y YWdlVHJhY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNw cAppbmRleCAyOTNmMTY2NjBmMTI4NTkyY2YwNzE1ZjY0YmJkMmVhYzVjZDZiMzRhLi5iNGE0YWMz ZjE5YzkyYTljZTNiMTQ2NTgxMDE1YjNlMWI2YzkzMDg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9y YWdlL1N0b3JhZ2VUcmFja2VyLmNwcApAQCAtMTcwLDExICsxNzAsNiBAQCB2b2lkIFN0b3JhZ2VU cmFja2VyOjppbXBvcnRPcmlnaW5JZGVudGlmaWVycygpCiAgICAgbV90aHJlYWQtPmRpc3BhdGNo KGJpbmQoJlN0b3JhZ2VUcmFja2VyOjpzeW5jSW1wb3J0T3JpZ2luSWRlbnRpZmllcnMsIHRoaXMp KTsKIH0KIAotdm9pZCBTdG9yYWdlVHJhY2tlcjo6bm90aWZ5RmluaXNoZWRJbXBvcnRpbmdPcmln aW5JZGVudGlmaWVyc09uTWFpblRocmVhZCh2b2lkKikKLXsKLSAgICB0cmFja2VyKCkuZmluaXNo ZWRJbXBvcnRpbmdPcmlnaW5JZGVudGlmaWVycygpOwotfQotCiB2b2lkIFN0b3JhZ2VUcmFja2Vy OjpmaW5pc2hlZEltcG9ydGluZ09yaWdpbklkZW50aWZpZXJzKCkKIHsKICAgICBNdXRleExvY2tl ciBsb2NrZXIobV9kYXRhYmFzZU11dGV4KTsKQEAgLTIzMiw3ICsyMjcsNyBAQCB2b2lkIFN0b3Jh Z2VUcmFja2VyOjpzeW5jSW1wb3J0T3JpZ2luSWRlbnRpZmllcnMoKQogICAgICAgICB9CiAgICAg fQogCi0gICAgY2FsbE9uTWFpblRocmVhZChub3RpZnlGaW5pc2hlZEltcG9ydGluZ09yaWdpbklk ZW50aWZpZXJzT25NYWluVGhyZWFkLCAwKTsKKyAgICBjYWxsT25NYWluVGhyZWFkKGJpbmQoJlN0 b3JhZ2VUcmFja2VyOjpmaW5pc2hlZEltcG9ydGluZ09yaWdpbklkZW50aWZpZXJzLCB0aGlzKSk7 CiB9CiAgICAgCiB2b2lkIFN0b3JhZ2VUcmFja2VyOjpzeW5jRmlsZVN5c3RlbUFuZFRyYWNrZXJE YXRhYmFzZSgpCkBAIC0yNzgsOCArMjczLDcgQEAgdm9pZCBTdG9yYWdlVHJhY2tlcjo6c3luY0Zp bGVTeXN0ZW1BbmRUcmFja2VyRGF0YWJhc2UoKQogICAgICAgICBpZiAoZm91bmRPcmlnaW5zLmNv bnRhaW5zKG9yaWdpbklkZW50aWZpZXIpKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAg ICAgUmVmUHRyPFN0cmluZ0ltcGw+IG9yaWdpbklkZW50aWZpZXJJbXBsID0gb3JpZ2luSWRlbnRp Zmllci5pc29sYXRlZENvcHkoKS5pbXBsKCk7Ci0gICAgICAgIGNhbGxPbk1haW5UaHJlYWQoZGVs ZXRlT3JpZ2luT25NYWluVGhyZWFkLCBvcmlnaW5JZGVudGlmaWVySW1wbC5yZWxlYXNlKCkubGVh a1JlZigpKTsKKyAgICAgICAgY2FsbE9uTWFpblRocmVhZChiaW5kKCZTdG9yYWdlVHJhY2tlcjo6 ZGVsZXRlT3JpZ2luV2l0aElkZW50aWZpZXIsIHRoaXMsIG9yaWdpbklkZW50aWZpZXIuaXNvbGF0 ZWRDb3B5KCkpKTsKICAgICB9CiB9CiAKQEAgLTQzMiwxNSArNDI2LDcgQEAgdm9pZCBTdG9yYWdl VHJhY2tlcjo6c3luY0RlbGV0ZUFsbE9yaWdpbnMoKQogICAgIFNRTGl0ZUZpbGVTeXN0ZW06OmRl bGV0ZUVtcHR5RGF0YWJhc2VEaXJlY3RvcnkobV9zdG9yYWdlRGlyZWN0b3J5UGF0aCk7CiB9CiAK LXZvaWQgU3RvcmFnZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbk9uTWFpblRocmVhZCh2b2lkKiBvcmln aW5JZGVudGlmaWVyKQotewotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0KLSAgICBTdHJp bmcgaWRlbnRpZmllciA9IGFkb3B0UmVmKHJlaW50ZXJwcmV0X2Nhc3Q8U3RyaW5nSW1wbCo+KG9y aWdpbklkZW50aWZpZXIpKTsKLSAgICB0cmFja2VyKCkuZGVsZXRlT3JpZ2luKGlkZW50aWZpZXIp OwotfQotCi12b2lkIFN0b3JhZ2VUcmFja2VyOjpkZWxldGVPcmlnaW4oY29uc3QgU3RyaW5nJiBv cmlnaW5JZGVudGlmaWVyKQordm9pZCBTdG9yYWdlVHJhY2tlcjo6ZGVsZXRlT3JpZ2luV2l0aElk ZW50aWZpZXIoY29uc3QgU3RyaW5nJiBvcmlnaW5JZGVudGlmaWVyKQogewogICAgIGRlbGV0ZU9y aWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmllcihvcmlnaW5J ZGVudGlmaWVyKS5nZXQoKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdl L1N0b3JhZ2VUcmFja2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2Vy LmgKaW5kZXggODkyY2QxY2JlNTVlNmNmOTE4ZTVlNTk2Y2E3ZmM0ZmUzNjRiZDBkZi4uZmY5Nzlk MjgwZDY1MmVkMzY1NGEyZTUzNjc5Mjg4NGFjZDJhYTgzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvU3RvcmFnZVRyYWNrZXIuaApAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAgICAgCiAgICAg dm9pZCBkZWxldGVBbGxPcmlnaW5zKCk7CiAgICAgdm9pZCBkZWxldGVPcmlnaW4oU2VjdXJpdHlP cmlnaW4qKTsKLSAgICB2b2lkIGRlbGV0ZU9yaWdpbihjb25zdCBTdHJpbmcmIG9yaWdpbklkZW50 aWZpZXIpOworICAgIHZvaWQgZGVsZXRlT3JpZ2luV2l0aElkZW50aWZpZXIoY29uc3QgU3RyaW5n JiBvcmlnaW5JZGVudGlmaWVyKTsKICAgICB2b2lkIG9yaWdpbnMoVmVjdG9yPFJlZlB0cjxTZWN1 cml0eU9yaWdpbj4gPiYgcmVzdWx0KTsKICAgICBsb25nIGxvbmcgZGlza1VzYWdlRm9yT3JpZ2lu KFNlY3VyaXR5T3JpZ2luKik7CiAgICAgCkBAIC03Niw3ICs3Niw2IEBAIHByaXZhdGU6CiAgICAg dm9pZCBvcGVuVHJhY2tlckRhdGFiYXNlKGJvb2wgY3JlYXRlSWZEb2VzTm90RXhpc3QpOwogCiAg ICAgdm9pZCBpbXBvcnRPcmlnaW5JZGVudGlmaWVycygpOwotICAgIHN0YXRpYyB2b2lkIG5vdGlm eUZpbmlzaGVkSW1wb3J0aW5nT3JpZ2luSWRlbnRpZmllcnNPbk1haW5UaHJlYWQodm9pZCopOwog ICAgIHZvaWQgZmluaXNoZWRJbXBvcnRpbmdPcmlnaW5JZGVudGlmaWVycygpOwogICAgIAogICAg IHZvaWQgZGVsZXRlVHJhY2tlckZpbGVzKCk7CkBAIC04NSw3ICs4NCw2IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBjYW5EZWxldGVPcmlnaW4oY29uc3QgU3RyaW5nJiBvcmlnaW5JZGVudGlmaWVyKTsK ICAgICB2b2lkIHdpbGxEZWxldGVPcmlnaW4oY29uc3QgU3RyaW5nJiBvcmlnaW5JZGVudGlmaWVy KTsKICAgICB2b2lkIHdpbGxEZWxldGVBbGxPcmlnaW5zKCk7Ci0gICAgc3RhdGljIHZvaWQgZGVs ZXRlT3JpZ2luT25NYWluVGhyZWFkKHZvaWQqIG9yaWdpbklkZW50aWZpZXIpOwogCiAgICAgdm9p ZCBvcmlnaW5GaWxlUGF0aHMoVmVjdG9yPFN0cmluZz4mIHBhdGhzKTsKICAgICAK