115434 2013-04-30 11:30:34 -0700 Cleanup HTMLOListElement<->RenderListItem bridge 2013-04-30 15:22:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abucur abucur commit-queue esprehn+autocc rniwa oldest_to_newest 883179 0 abucur 2013-04-30 11:30:34 -0700 RenderListItem exposes the internal function nextListItem because HTMLOListElement needs it. Find a better way to count the list items and invalidate them of a parent OL element. 883186 1 200138 abucur 2013-04-30 11:49:27 -0700 Created attachment 200138 Patch 883312 2 commit-queue 2013-04-30 15:21:36 -0700 The commit-queue encountered the following flaky tests while processing attachment 200138: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/shorthand-border-transitions.html bug 114205 (authors: ojan@chromium.org and simon.fraser@apple.com) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) The commit-queue is continuing to process your patch. 883315 3 200138 commit-queue 2013-04-30 15:22:31 -0700 Comment on attachment 200138 Patch Clearing flags on attachment: 200138 Committed r149405: <http://trac.webkit.org/changeset/149405> 883316 4 commit-queue 2013-04-30 15:22:34 -0700 All reviewed patches have been landed. Closing bug. 200138 2013-04-30 11:49:27 -0700 2013-04-30 15:22:31 -0700 Patch bug-115434-20130430114842.patch text/plain 6376 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ1NWIyMzY3YTg4MmY0 YWU5MWQ3ZjcyMTM3ODRiYmI1YTgyNDdkZC4uZDgwNjIzNDlhZmQxZTRkNzEzMzgyZTRkOWZjMGY5 YzZmYjYyM2Y1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA0LTMwICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIENsZWFudXAgSFRNTE9MaXN0 RWxlbWVudDwtPlJlbmRlckxpc3RJdGVtIGJyaWRnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NDM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0b3IgdGhlIHdheSBIVE1MT0xpc3RFbGVtZW50 IGlzIGFjY2Vzc2luZyBpdHMgbGlzdCBpdGVtcy4gSW5zdGVhZAorICAgICAgICBvZiBleHBvc2lu ZyB0aGUgbmV4dExpc3RJdGVtIGZ1bmN0aW9uLCB3cmFwIHRoZSBkZXNpcmVkZnVuY3Rpb25hbGl0 eQorICAgICAgICBpbiBzdGF0aWMgbWV0aG9kcyBvbiBSZW5kZXJMaXN0SXRlbS4gVGhpcyBzaG91 bGQgbWFrZSB0aGUgY29kZSBtb3JlIHJlYWRhYmxlLgorICAgICAgICBJJ3ZlIGFsc28gYWRkZWQg bW9yZSBjb25zdG5lc3MgdG8gc29tZSBmdW5jdGlvbnMgaW4gUmVuZGVyTGlzdEl0ZW0uCisKKyAg ICAgICAgVGVzdHM6IE5vIG5ldyB0ZXN0cywganVzdCByZWZhY3RvcmluZy4KKworICAgICAgICAq IGh0bWwvSFRNTE9MaXN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MT0xpc3RF bGVtZW50Ojp1cGRhdGVJdGVtVmFsdWVzKTogVXNlIHVwZGF0ZUl0ZW1WYWx1ZXNGb3JPcmRlcmVk TGlzdC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxPTGlzdEVsZW1lbnQ6OnJlY2FsY3VsYXRlSXRl bUNvdW50KTogVXNlIGl0ZW1Db3VudEZvck9yZGVyZWRMaXN0LgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMaXN0SXRlbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0xpc3QpOiBBZGQgbW9y ZSBjb25zdG5lc3MuCisgICAgICAgIChXZWJDb3JlOjpuZXh0TGlzdEl0ZW0pOiBNYWtlIGxvY2Fs IHRvIHRoZSBDUFAgYW5kIGFkZCBjb25zdG5lc3MuCisgICAgICAgIChXZWJDb3JlOjpwcmV2aW91 c0xpc3RJdGVtKTogQWRkIGNvbnN0bmVzcy4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RJ dGVtOjp1cGRhdGVJdGVtVmFsdWVzRm9yT3JkZXJlZExpc3QpOiBDYWxsZWQgYnkgT0wgZWxlbWVu dHMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMaXN0SXRlbTo6aXRlbUNvdW50Rm9yT3JkZXJl ZExpc3QpOiBDYWxsZWQgYnkgT0wgZWxlbWVudHMuCisgICAgICAgIChXZWJDb3JlOjpwcmV2aW91 c09yTmV4dEl0ZW0pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5oOiBBZGQg dXBkYXRlSXRlbVZhbHVlc0Zvck9yZGVyZWRMaXN0IGFuZCBpdGVtQ291bnRGb3JPcmRlcmVkTGlz dC4KKwogMjAxMy0wNC0zMCAgTWlrZSBMYXR0YW56aW8gIDxtbGF0dGFuemlvQGJsYWNrYmVycnku Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlIGxlYWtp bmcgbWVtb3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPTGlzdEVsZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT0xpc3RFbGVtZW50LmNwcAppbmRleCAz OTZlMzQwNGZlOTMxNjQ2NjIwMThkYTI1NGQwMDhiNGZlNTRiNThlLi5iY2NjYzU4NzU0OTJlODdh MjBkOTAwZTM5MDQwMDg0NjkxMWM0Mjg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxPTGlzdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9MaXN0 RWxlbWVudC5jcHAKQEAgLTEwNiwxNyArMTA2LDEyIEBAIHZvaWQgSFRNTE9MaXN0RWxlbWVudDo6 c2V0U3RhcnQoaW50IHN0YXJ0KQogCiB2b2lkIEhUTUxPTGlzdEVsZW1lbnQ6OnVwZGF0ZUl0ZW1W YWx1ZXMoKQogewotICAgIGZvciAoUmVuZGVyTGlzdEl0ZW0qIGxpc3RJdGVtID0gUmVuZGVyTGlz dEl0ZW06Om5leHRMaXN0SXRlbSh0aGlzKTsgbGlzdEl0ZW07IGxpc3RJdGVtID0gUmVuZGVyTGlz dEl0ZW06Om5leHRMaXN0SXRlbSh0aGlzLCBsaXN0SXRlbSkpCi0gICAgICAgIGxpc3RJdGVtLT51 cGRhdGVWYWx1ZSgpOworICAgIFJlbmRlckxpc3RJdGVtOjp1cGRhdGVJdGVtVmFsdWVzRm9yT3Jk ZXJlZExpc3QodGhpcyk7CiB9CiAKIHZvaWQgSFRNTE9MaXN0RWxlbWVudDo6cmVjYWxjdWxhdGVJ dGVtQ291bnQoKQogewotICAgIG1faXRlbUNvdW50ID0gMDsKLQotICAgIGZvciAoUmVuZGVyTGlz dEl0ZW0qIGxpc3RJdGVtID0gUmVuZGVyTGlzdEl0ZW06Om5leHRMaXN0SXRlbSh0aGlzKTsgbGlz dEl0ZW07IGxpc3RJdGVtID0gUmVuZGVyTGlzdEl0ZW06Om5leHRMaXN0SXRlbSh0aGlzLCBsaXN0 SXRlbSkpCi0gICAgICAgIG1faXRlbUNvdW50Kys7Ci0KKyAgICBtX2l0ZW1Db3VudCA9IFJlbmRl ckxpc3RJdGVtOjppdGVtQ291bnRGb3JPcmRlcmVkTGlzdCh0aGlzKTsKICAgICBtX3Nob3VsZFJl Y2FsY3VsYXRlSXRlbUNvdW50ID0gZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGlzdEl0ZW0uY3BwCmluZGV4IDdhN2U3YzcwNjk5MDkwNjJjYzk3Yjc5NzNjOTBi N2FkMzhmZDU2MGMuLjYyMGQzYmI1NzYzNzE3ZmIyZjM1ZTVlNjk0ZTVjYjFmMTRkNDI4ZjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcApAQCAtOTIsNyAr OTIsNyBAQCB2b2lkIFJlbmRlckxpc3RJdGVtOjp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKQogICAg IHVwZGF0ZUxpc3RNYXJrZXJOdW1iZXJzKCk7CiB9CiAKLXN0YXRpYyBib29sIGlzTGlzdChOb2Rl KiBub2RlKQorc3RhdGljIGJvb2wgaXNMaXN0KGNvbnN0IE5vZGUqIG5vZGUpCiB7CiAgICAgcmV0 dXJuIChub2RlLT5oYXNUYWdOYW1lKHVsVGFnKSB8fCBub2RlLT5oYXNUYWdOYW1lKG9sVGFnKSk7 CiB9CkBAIC0xMTcsMTIgKzExNywxMiBAQCBzdGF0aWMgTm9kZSogZW5jbG9zaW5nTGlzdChjb25z dCBSZW5kZXJMaXN0SXRlbSogbGlzdEl0ZW0pCiB9CiAKIC8vIFJldHVybnMgdGhlIG5leHQgbGlz dCBpdGVtIHdpdGggcmVzcGVjdCB0byB0aGUgRE9NIG9yZGVyLgotUmVuZGVyTGlzdEl0ZW0qIFJl bmRlckxpc3RJdGVtOjpuZXh0TGlzdEl0ZW0oTm9kZSogbGlzdE5vZGUsIGNvbnN0IFJlbmRlckxp c3RJdGVtKiBpdGVtKQorc3RhdGljIFJlbmRlckxpc3RJdGVtKiBuZXh0TGlzdEl0ZW0oY29uc3Qg Tm9kZSogbGlzdE5vZGUsIGNvbnN0IFJlbmRlckxpc3RJdGVtKiBpdGVtID0gMCkKIHsKICAgICBp ZiAoIWxpc3ROb2RlKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIE5vZGUqIGN1cnJlbnQgPSBp dGVtID8gaXRlbS0+bm9kZSgpIDogbGlzdE5vZGU7CisgICAgY29uc3QgTm9kZSogY3VycmVudCA9 IGl0ZW0gPyBpdGVtLT5ub2RlKCkgOiBsaXN0Tm9kZTsKICAgICBjdXJyZW50ID0gRWxlbWVudFRy YXZlcnNhbDo6bmV4dEluY2x1ZGluZ1BzZXVkbyhjdXJyZW50LCBsaXN0Tm9kZSk7CiAKICAgICB3 aGlsZSAoY3VycmVudCkgewpAQCAtMTQ0LDcgKzE0NCw3IEBAIFJlbmRlckxpc3RJdGVtKiBSZW5k ZXJMaXN0SXRlbTo6bmV4dExpc3RJdGVtKE5vZGUqIGxpc3ROb2RlLCBjb25zdCBSZW5kZXJMaXN0 SXRlCiB9CiAKIC8vIFJldHVybnMgdGhlIHByZXZpb3VzIGxpc3QgaXRlbSB3aXRoIHJlc3BlY3Qg dG8gdGhlIERPTSBvcmRlci4KLXN0YXRpYyBSZW5kZXJMaXN0SXRlbSogcHJldmlvdXNMaXN0SXRl bShOb2RlKiBsaXN0Tm9kZSwgY29uc3QgUmVuZGVyTGlzdEl0ZW0qIGl0ZW0pCitzdGF0aWMgUmVu ZGVyTGlzdEl0ZW0qIHByZXZpb3VzTGlzdEl0ZW0oY29uc3QgTm9kZSogbGlzdE5vZGUsIGNvbnN0 IFJlbmRlckxpc3RJdGVtKiBpdGVtKQogewogICAgIE5vZGUqIGN1cnJlbnQgPSBpdGVtLT5ub2Rl KCk7CiAgICAgZm9yIChjdXJyZW50ID0gRWxlbWVudFRyYXZlcnNhbDo6cHJldmlvdXNJbmNsdWRp bmdQc2V1ZG8oY3VycmVudCwgbGlzdE5vZGUpOyBjdXJyZW50OyBjdXJyZW50ID0gRWxlbWVudFRy YXZlcnNhbDo6cHJldmlvdXNJbmNsdWRpbmdQc2V1ZG8oY3VycmVudCwgbGlzdE5vZGUpKSB7CkBA IC0xNjUsNiArMTY1LDI1IEBAIHN0YXRpYyBSZW5kZXJMaXN0SXRlbSogcHJldmlvdXNMaXN0SXRl bShOb2RlKiBsaXN0Tm9kZSwgY29uc3QgUmVuZGVyTGlzdEl0ZW0qIGl0CiAgICAgcmV0dXJuIDA7 CiB9CiAKK3ZvaWQgUmVuZGVyTGlzdEl0ZW06OnVwZGF0ZUl0ZW1WYWx1ZXNGb3JPcmRlcmVkTGlz dChjb25zdCBIVE1MT0xpc3RFbGVtZW50KiBsaXN0Tm9kZSkKK3sKKyAgICBBU1NFUlQobGlzdE5v ZGUpOworCisgICAgZm9yIChSZW5kZXJMaXN0SXRlbSogbGlzdEl0ZW0gPSBuZXh0TGlzdEl0ZW0o bGlzdE5vZGUpOyBsaXN0SXRlbTsgbGlzdEl0ZW0gPSBuZXh0TGlzdEl0ZW0obGlzdE5vZGUsIGxp c3RJdGVtKSkKKyAgICAgICAgbGlzdEl0ZW0tPnVwZGF0ZVZhbHVlKCk7Cit9CisKK3Vuc2lnbmVk IFJlbmRlckxpc3RJdGVtOjppdGVtQ291bnRGb3JPcmRlcmVkTGlzdChjb25zdCBIVE1MT0xpc3RF bGVtZW50KiBsaXN0Tm9kZSkKK3sKKyAgICBBU1NFUlQobGlzdE5vZGUpOworCisgICAgdW5zaWdu ZWQgaXRlbUNvdW50ID0gMDsKKyAgICBmb3IgKFJlbmRlckxpc3RJdGVtKiBsaXN0SXRlbSA9IG5l eHRMaXN0SXRlbShsaXN0Tm9kZSk7IGxpc3RJdGVtOyBsaXN0SXRlbSA9IG5leHRMaXN0SXRlbShs aXN0Tm9kZSwgbGlzdEl0ZW0pKQorICAgICAgICBpdGVtQ291bnQrKzsKKworICAgIHJldHVybiBp dGVtQ291bnQ7Cit9CisKIGlubGluZSBpbnQgUmVuZGVyTGlzdEl0ZW06OmNhbGNWYWx1ZSgpIGNv bnN0CiB7CiAgICAgaWYgKG1faGFzRXhwbGljaXRWYWx1ZSkKQEAgLTQ2NCw3ICs0ODMsNyBAQCB2 b2lkIFJlbmRlckxpc3RJdGVtOjpjbGVhckV4cGxpY2l0VmFsdWUoKQogCiBzdGF0aWMgUmVuZGVy TGlzdEl0ZW0qIHByZXZpb3VzT3JOZXh0SXRlbShib29sIGlzTGlzdFJldmVyc2VkLCBOb2RlKiBs aXN0LCBSZW5kZXJMaXN0SXRlbSogaXRlbSkKIHsKLSAgICByZXR1cm4gaXNMaXN0UmV2ZXJzZWQg PyBwcmV2aW91c0xpc3RJdGVtKGxpc3QsIGl0ZW0pIDogUmVuZGVyTGlzdEl0ZW06Om5leHRMaXN0 SXRlbShsaXN0LCBpdGVtKTsKKyAgICByZXR1cm4gaXNMaXN0UmV2ZXJzZWQgPyBwcmV2aW91c0xp c3RJdGVtKGxpc3QsIGl0ZW0pIDogbmV4dExpc3RJdGVtKGxpc3QsIGl0ZW0pOwogfQogCiB2b2lk IFJlbmRlckxpc3RJdGVtOjp1cGRhdGVMaXN0TWFya2VyTnVtYmVycygpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5oCmluZGV4IDdkZDNlYWY4OTQyYjgxNjQ2NjE2NmMx YWQ0Yzk4M2RkOWJmNGE5MGYuLmYzMTljZmQ3MGU4MWE2NTA5ZDljMzc1ODg4ZDY1ODY3MjQ5NGYy NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5oCkBAIC0yNyw2 ICsyNyw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgSFRNTE9MaXN0RWxlbWVu dDsKIGNsYXNzIFJlbmRlckxpc3RNYXJrZXI7CiAKIGNsYXNzIFJlbmRlckxpc3RJdGVtIDogcHVi bGljIFJlbmRlckJsb2NrIHsKQEAgLTQ5LDcgKzUwLDggQEAgcHVibGljOgogCiAgICAgdm9pZCB1 cGRhdGVMaXN0TWFya2VyTnVtYmVycygpOwogCi0gICAgc3RhdGljIFJlbmRlckxpc3RJdGVtKiBu ZXh0TGlzdEl0ZW0oTm9kZSosIGNvbnN0IFJlbmRlckxpc3RJdGVtKiA9IDApOworICAgIHN0YXRp YyB2b2lkIHVwZGF0ZUl0ZW1WYWx1ZXNGb3JPcmRlcmVkTGlzdChjb25zdCBIVE1MT0xpc3RFbGVt ZW50Kik7CisgICAgc3RhdGljIHVuc2lnbmVkIGl0ZW1Db3VudEZvck9yZGVyZWRMaXN0KGNvbnN0 IEhUTUxPTGlzdEVsZW1lbnQqKTsKIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGNvbnN0IGNoYXIq IHJlbmRlck5hbWUoKSBjb25zdCB7IHJldHVybiAiUmVuZGVyTGlzdEl0ZW0iOyB9Cg==