115432 2013-04-30 11:08:20 -0700 REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align 2013-05-04 00:45:20 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 robert robert commit-queue esprehn+autocc jchaffraix robert oldest_to_newest 883166 0 robert 2013-04-30 11:08:20 -0700 This is the webkit counterpart to https://code.google.com/p/chromium/issues/detail?id=227017 883168 1 200133 robert 2013-04-30 11:09:28 -0700 Created attachment 200133 Reduction 883212 2 200142 robert 2013-04-30 12:54:10 -0700 Created attachment 200142 Patch 883844 3 200142 jchaffraix 2013-05-02 11:20:04 -0700 Comment on attachment 200142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200142&action=review > Source/WebCore/rendering/RenderTableCell.cpp:408 > + if (oldStyle && style()->verticalAlign() != oldStyle->verticalAlign()) Let's add a comment about why this is required. 884491 4 robert 2013-05-04 00:45:20 -0700 Committed r149553: <http://trac.webkit.org/changeset/149553> 200133 2013-04-30 11:09:28 -0700 2013-04-30 11:09:28 -0700 Reduction chrome_26_table (1).html text/html 1142 robert PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCiAgICA8aGVhZD4NCiAgICAgICAgPHN0eWxlPg0KICAg ICAgICAgICAgdGQgew0KICAgICAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGdyYXk7DQog ICAgICAgICAgICB9DQogICAgICAgICAgICBpbnB1dCB7DQogICAgICAgICAgICAgICAgdmlzaWJp bGl0eTogaGlkZGVuOw0KICAgICAgICAgICAgfQ0KICAgICAgICA8L3N0eWxlPg0KICAgICAgICA8 c2NyaXB0Pg0KICAgICAgICAgICAgZnVuY3Rpb24gcmVsYXlvdXQoKQ0KICAgICAgICAgICAgew0K ICAgICAgICAgICAgICAgIHZhciBjZWxscyA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1l KCJ0ZCIpOw0KICAgICAgICAgICAgICAgIC8vIEVuc3VyZSBsYXlvdXQgaGFzIHJ1biBzbyB0aGF0 IHdlIHByb3Blcmx5IGludmFsaWRhdGUuDQogICAgICAgICAgICAgICAgY2VsbHNbMF0ub2Zmc2V0 TGVmdDsNCiAgICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNlbGxzLmxlbmd0aDsg KytpKQ0KICAgICAgICAgICAgICAgICAgICBjZWxsc1tpXS5zdHlsZS52ZXJ0aWNhbEFsaWduID0g ImJhc2VsaW5lIjsNCg0KICAgICAgICAgICAgICAgIGNlbGxzWzBdLm9mZnNldExlZnQ7DQogICAg ICAgICAgICB9DQogICAgICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIHJl bGF5b3V0LCBmYWxzZSk7DQogICAgICAgIDwvc2NyaXB0Pg0KICAgIDwvaGVhZD4NCiAgICA8Ym9k eT4NCiAgICAgICAgPGZvcm0+DQogICAgICAgICAgICA8dGFibGU+DQogICAgICAgICAgICAgICAg PHRyPg0KICAgICAgICAgICAgICAgICAgICA8dGQ+PGlucHV0IG5hbWU9ImEiLz48L3RkPg0KICAg ICAgICAgICAgICAgICAgICA8dGQ+PGlucHV0IG5hbWU9ImIiLz48L3RkPg0KICAgICAgICAgICAg ICAgIDwvdHI+DQogICAgICAgICAgICAgICAgPHRyPg0KICAgICAgICAgICAgICAgICAgICA8dGQ+ c2hvcnQ8L3RkPg0KICAgICAgICAgICAgICAgICAgICA8dGQ+bGluZSAxPGJyPmxpbmUgMjxicj5s aW5lIDM8YnI+bGluZSA0PGJyPmxpbmUgNTwvdGQ+DQogICAgICAgICAgICAgICAgPC90cj4NCiAg ICAgICAgICAgIDwvdGFibGU+DQogICAgICAgIDwvZm9ybT4NCiAgICA8L2JvZHk+DQo8L2h0bWw+ DQo= 200142 2013-04-30 12:54:10 -0700 2013-05-02 11:20:03 -0700 Patch bug-115432-20130430205315.patch text/plain 4888 robert U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk0NGNhZTI3OTMyNGU2 ZTllMWUwN2E3YTgzNTBiMTU5YWI0NWQxMC4uYTUzODNmMDIyNDc3MmFiYzhmNWVhMzcyYzlkYmY1 ZTFmMDk1NjcwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTMwICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNDA5 MDcpOiBJbmNvcnJlY3QgYmFzZWxpbmUgb24gY2VsbHMgYWZ0ZXIgdXBkYXRpbmcgdmVydGljYWwt YWxpZ24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NTQzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElm IGEgY2VsbCBjaGFuZ2VzIHZlcnRpY2FsLWFsaWduIGFueSBpbnRyaW5zaWMgcGFkZGluZyBpdCBo YXMgaXMgbm93IHJlZHVuZGFudC4gSXQKKyAgICAgICAgbmVlZHMgdG8gY2FsY3VsYXRlIGl0cyBu ZXcgaGVpZ2h0IGZyb20gUmVuZGVyVGFibGVSb3c6OmxheW91dCgpIGFuZCB0aGVuIGZpbmQgaXRz CisgICAgICAgIG5ldyBpbnRyaW5zaWMgcGFkZGluZyBpbiBSZW5kZXJUYWJsZVNlY3Rpb246Omxh eW91dFJvd3MoKS4KKworICAgICAgICBUZXN0OiBmYXN0L3RhYmxlL2NvcnJlY3QtYmFzZWxpbmUt YWZ0ZXItc3R5bGUtY2hhbmdlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJs ZUNlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVDZWxsOjpzdHlsZURpZENo YW5nZSk6CisKIDIwMTMtMDQtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFdpZGdldCBzaG91bGQgbm90IGRlcGVuZCBvbiBBWE9iamVjdENh Y2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCmluZGV4 IDM0ZGY0Njg3NWI5OTA1YjJjMjEyNDQyNDNhMDM1MDhjZWU3Mzc4YjMuLjY5Nzc3MjlkZDQyMzg3 MjA4ZTY0ODExZTA4MjczOGJlOTNjODlkMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUYWJsZUNlbGwuY3BwCkBAIC00MDUsNiArNDA1LDkgQEAgdm9pZCBSZW5kZXJUYWJs ZUNlbGw6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJT dHlsZSogb2wKICAgICBpZiAocGFyZW50KCkgJiYgc2VjdGlvbigpICYmIG9sZFN0eWxlICYmIHN0 eWxlKCktPmhlaWdodCgpICE9IG9sZFN0eWxlLT5oZWlnaHQoKSkKICAgICAgICAgc2VjdGlvbigp LT5yb3dMb2dpY2FsSGVpZ2h0Q2hhbmdlZChyb3dJbmRleCgpKTsKIAorICAgIGlmIChvbGRTdHls ZSAmJiBzdHlsZSgpLT52ZXJ0aWNhbEFsaWduKCkgIT0gb2xkU3R5bGUtPnZlcnRpY2FsQWxpZ24o KSkKKyAgICAgICAgY2xlYXJJbnRyaW5zaWNQYWRkaW5nKCk7CisKICAgICAvLyBJZiBib3JkZXIg d2FzIGNoYW5nZWQsIG5vdGlmeSB0YWJsZS4KICAgICBpZiAocGFyZW50KCkpIHsKICAgICAgICAg UmVuZGVyVGFibGUqIHRhYmxlID0gdGhpcy0+dGFibGUoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0ZWUyODc1Y2VlOTEx YTY2NmY0MmYxNzgzY2JjMjE0NGM0Yjk3OGNkLi44OTcyY2ZlN2QyODgxZDFlZGUzM2I3MDE3ZmNh YWVlY2E5NmNlYmI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDQtMzAgIFJvYmVydCBI b2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0MDkwNyk6 IEluY29ycmVjdCBiYXNlbGluZSBvbiBjZWxscyBhZnRlciB1cGRhdGluZyB2ZXJ0aWNhbC1hbGln bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NDMy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0 L3RhYmxlL2NvcnJlY3QtYmFzZWxpbmUtYWZ0ZXItc3R5bGUtY2hhbmdlLWV4cGVjdGVkLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvY29ycmVjdC1iYXNlbGluZS1hZnRlci1zdHls ZS1jaGFuZ2UuaHRtbDogQWRkZWQuCisKIDIwMTMtMDQtMjEgIENocmlzdG9waGUgRHVtZXogIDxj aC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgRUZMIGdhcmRl bmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvY29ycmVjdC1iYXNlbGlu ZS1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGFi bGUvY29ycmVjdC1iYXNlbGluZS1hZnRlci1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi41ZjU1M2UxMzIzMmE2OTI4OTI1MmEwM2YxN2FlYzM3ZTBmZjY4YzNjCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jb3JyZWN0LWJhc2VsaW5lLWFmdGVy LXN0eWxlLWNoYW5nZS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjUgQEAKKzwhRE9DVFlQRSBo dG1sPg0KKzxodG1sPg0KKyAgICA8aGVhZD4NCisgICAgICAgIDxzdHlsZT4NCisgICAgICAgICAg ICB0ZCB7DQorICAgICAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGdyYXk7DQorICAgICAg ICAgICAgICAgIHZlcnRpY2FsLWFsaWduOiBiYXNlbGluZTsNCisgICAgICAgICAgICB9DQorICAg ICAgICAgICAgaW5wdXQgew0KKyAgICAgICAgICAgICAgICB2aXNpYmlsaXR5OiBoaWRkZW47DQor ICAgICAgICAgICAgfQ0KKyAgICAgICAgPC9zdHlsZT4NCisgICAgPC9oZWFkPg0KKyAgICA8Ym9k eT4NCisgICAgICAgIDxwPndlYmtpdC5vcmcvYi8xMTU0MzI6IFRoZXJlIHNob3VsZCBiZSBubyBl eHRyYSBzcGFjZSBiZXR3ZWVuIHRoZSB0b3Agb2YgdGhlIHRleHQgYW5kIHRoZSB0b3Agb2YgdGhl IHRhYmxlLjwvcD4NCisgICAgICAgIDxmb3JtPg0KKyAgICAgICAgICAgIDx0YWJsZT4NCisgICAg ICAgICAgICAgICAgPHRyPg0KKyAgICAgICAgICAgICAgICAgICAgPHRkPlRleHQ8L3RkPg0KKyAg ICAgICAgICAgICAgICAgICAgPHRkPlRleHQ8YnI+VGV4dDxicj5UZXh0PC90ZD4NCisgICAgICAg ICAgICAgICAgPC90cj4NCisgICAgICAgICAgICA8L3RhYmxlPg0KKyAgICAgICAgPC9mb3JtPg0K KyAgICA8L2JvZHk+DQorPC9odG1sPg0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGFi bGUvY29ycmVjdC1iYXNlbGluZS1hZnRlci1zdHlsZS1jaGFuZ2UuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvdGFibGUvY29ycmVjdC1iYXNlbGluZS1hZnRlci1zdHlsZS1jaGFuZ2UuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi44ZDA2ZGE5NTQxYTQ0NWI4YjAxNmQ2OWFjNTFlMjBhNzA3ODZlNjkzCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jb3JyZWN0LWJhc2VsaW5lLWFmdGVy LXN0eWxlLWNoYW5nZS5odG1sCkBAIC0wLDAgKzEsMzIgQEAKKzwhRE9DVFlQRSBodG1sPg0KKzxo dG1sPg0KKyAgICA8aGVhZD4NCisgICAgICAgIDxzdHlsZT4NCisgICAgICAgICAgICB0ZCB7DQor ICAgICAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGdyYXk7DQorICAgICAgICAgICAgfQ0K KyAgICAgICAgICAgIGlucHV0IHsNCisgICAgICAgICAgICAgICAgdmlzaWJpbGl0eTogaGlkZGVu Ow0KKyAgICAgICAgICAgIH0NCisgICAgICAgIDwvc3R5bGU+DQorICAgIDwvaGVhZD4NCisgICAg PGJvZHk+DQorICAgICAgICA8cD53ZWJraXQub3JnL2IvMTE1NDMyOiBUaGVyZSBzaG91bGQgYmUg bm8gZXh0cmEgc3BhY2UgYmV0d2VlbiB0aGUgdG9wIG9mIHRoZSB0ZXh0IGFuZCB0aGUgdG9wIG9m IHRoZSB0YWJsZS48L3A+DQorICAgICAgICA8Zm9ybT4NCisgICAgICAgICAgICA8dGFibGU+DQor ICAgICAgICAgICAgICAgIDx0cj4NCisgICAgICAgICAgICAgICAgICAgIDx0ZD5UZXh0PC90ZD4N CisgICAgICAgICAgICAgICAgICAgIDx0ZD5UZXh0PGJyPlRleHQ8YnI+VGV4dDwvdGQ+DQorICAg ICAgICAgICAgICAgIDwvdHI+DQorICAgICAgICAgICAgPC90YWJsZT4NCisgICAgICAgIDwvZm9y bT4NCisgICAgICAgIDxzY3JpcHQ+DQorICAgICAgICAgICAgdmFyIGNlbGxzID0gZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoInRkIik7DQorICAgICAgICAgICAgLy8gRW5zdXJlIGxheW91 dCBoYXMgcnVuIHNvIHRoYXQgd2UgcHJvcGVybHkgaW52YWxpZGF0ZS4NCisgICAgICAgICAgICBj ZWxsc1swXS5vZmZzZXRMZWZ0Ow0KKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgY2Vs bHMubGVuZ3RoOyArK2kpDQorICAgICAgICAgICAgICAgIGNlbGxzW2ldLnN0eWxlLnZlcnRpY2Fs QWxpZ24gPSAiYmFzZWxpbmUiOw0KKyAgICAgICAgICAgIGNlbGxzWzBdLm9mZnNldExlZnQ7DQor ICAgICAgICA8L3NjcmlwdD4NCisgICAgPC9ib2R5Pg0KKzwvaHRtbD4NCg==