115426 2013-04-30 09:30:14 -0700 [Mac] Remove adoptNS/retain pairs, since the two cancel each other out 2013-04-30 22:18:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue simon.fraser oldest_to_newest 883110 0 darin 2013-04-30 09:30:14 -0700 [Mac] Remove adoptNS/retain pairs, since the two cancel each other out 883112 1 200124 darin 2013-04-30 09:31:25 -0700 Created attachment 200124 Patch 883385 2 200124 commit-queue 2013-04-30 22:18:15 -0700 Comment on attachment 200124 Patch Clearing flags on attachment: 200124 Committed r149423: <http://trac.webkit.org/changeset/149423> 883386 3 commit-queue 2013-04-30 22:18:17 -0700 All reviewed patches have been landed. Closing bug. 200124 2013-04-30 09:31:25 -0700 2013-04-30 22:18:15 -0700 Patch bug-115426-20130430093040.patch text/plain 6280 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ1NWIyMzY3YTg4MmY0 YWU5MWQ3ZjcyMTM3ODRiYmI1YTgyNDdkZC4uZTJlYjEyZDNlMGZmNzAxNjA2NWM1OGQ0Y2E0ZWMy ZjNlNGIxODM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTMwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBSZW1vdmUgYWRvcHRO Uy9yZXRhaW4gcGFpcnMsIHNpbmNlIHRoZSB0d28gY2FuY2VsIGVhY2ggb3RoZXIgb3V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0MjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBQW5pbWF0aW9uTWFjLm1tOgorICAgICAgICAoUGxhdGZv cm1DQUFuaW1hdGlvbjo6UGxhdGZvcm1DQUFuaW1hdGlvbik6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2EvbWFjL1BsYXRmb3JtQ0FGaWx0ZXJzTWFjLm1tOgorICAgICAgICAoUGxhdGZv cm1DQUZpbHRlcnM6OmZpbHRlclZhbHVlRm9yT3BlcmF0aW9uKToKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VSZXNwb25zZTo6bnNVUkxSZXNwb25zZSk6CisgICAgICAgIFJlbW92ZSBhZG9wdE5T IGFuZCByZWxlYXNlIGZyb20gY29kZSB0aGF0IGlzIGRvaW5nIGJvdGguCisKIDIwMTMtMDQtMzAg IE1pa2UgTGF0dGFuemlvICA8bWxhdHRhbnppb0BibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBb QmxhY2tCZXJyeV0gSW1hZ2VCdWZmZXI6OmNvcHlJbWFnZSBsZWFraW5nIG1lbW9yeQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nCmluZGV4IGJlZmZiNjgxOTdlNjUwYjk0ZDEwY2U5MDA1MmMzZmUxNWYyZjMyYzAuLjYx ODdhYWFiMTc0MmJiY2I4Yjc4MDg5NTIwZTYyMGEwYWVlNTg5MzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMyBAQAorMjAxMy0wNC0zMCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CisKKyAgICAgICAgW01hY10gUmVtb3ZlIGFkb3B0TlMvcmV0YWluIHBhaXJzLCBzaW5jZSB0 aGUgdHdvIGNhbmNlbCBlYWNoIG90aGVyIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1NDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luU3RyZWFtLm1t OgorICAgICAgICAoV2ViTmV0c2NhcGVQbHVnaW5TdHJlYW06OmRlbGl2ZXJEYXRhVG9GaWxlKTog UmVtb3ZlIGFkb3B0TlMgYW5kIHJlbGVhc2UuCisKIDIwMTMtMDQtMzAgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBBbmltYXRpb25zIGZhaWwgdG8gc3RhcnQgb24g aHR0cDovL3d3dy5nb29nbGUuY29tL2luc2lkZXNlYXJjaC9ob3dzZWFyY2h3b3Jrcy90aGVzdG9y eS8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9Q bGF0Zm9ybUNBQW5pbWF0aW9uTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvbWFjL1BsYXRmb3JtQ0FBbmltYXRpb25NYWMubW0KaW5kZXggMzczNzM1MGVmZjFmMTJh MTdjZGJkMWU3ZTM3NDEyNjVkYmUzNTdlYi4uNjk2NjU0OWZjMDQ0NDQ4NzIxNzY3MmY0MjRhZWJj NDFiNTdhODdmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvbWFjL1BsYXRmb3JtQ0FBbmltYXRpb25NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1BsYXRmb3JtQ0FBbmltYXRpb25NYWMubW0KQEAgLTE2Miw5 ICsxNjIsOSBAQCBQbGF0Zm9ybUNBQW5pbWF0aW9uOjpQbGF0Zm9ybUNBQW5pbWF0aW9uKEFuaW1h dGlvblR5cGUgdHlwZSwgY29uc3QgU3RyaW5nJiBrZXlQYQogICAgIDogbV90eXBlKHR5cGUpCiB7 CiAgICAgaWYgKHR5cGUgPT0gQmFzaWMpCi0gICAgICAgIG1fYW5pbWF0aW9uID0gYWRvcHROUyhb W0NBQmFzaWNBbmltYXRpb24gYW5pbWF0aW9uV2l0aEtleVBhdGg6a2V5UGF0aF0gcmV0YWluXSk7 CisgICAgICAgIG1fYW5pbWF0aW9uID0gW0NBQmFzaWNBbmltYXRpb24gYW5pbWF0aW9uV2l0aEtl eVBhdGg6a2V5UGF0aF07CiAgICAgZWxzZQotICAgICAgICBtX2FuaW1hdGlvbiA9IGFkb3B0TlMo W1tDQUtleWZyYW1lQW5pbWF0aW9uIGFuaW1hdGlvbldpdGhLZXlQYXRoOmtleVBhdGhdIHJldGFp bl0pOworICAgICAgICBtX2FuaW1hdGlvbiA9IFtDQUtleWZyYW1lQW5pbWF0aW9uIGFuaW1hdGlv bldpdGhLZXlQYXRoOmtleVBhdGhdOwogfQogCiBQbGF0Zm9ybUNBQW5pbWF0aW9uOjpQbGF0Zm9y bUNBQW5pbWF0aW9uKFBsYXRmb3JtQW5pbWF0aW9uUmVmIGFuaW1hdGlvbikKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBRmlsdGVy c01hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9y bUNBRmlsdGVyc01hYy5tbQppbmRleCBiMDFlNzk0NDY1MTA1YzBmNTkzMWM2YWY5NjQ5ZjI4ODA2 MmQzY2E2Li41ZTIxNzE1YzcyYzQzZTU2ZmQxZWFjMTY4NWYxODFhMzY3YzA4NzJiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvUGxhdGZvcm1DQUZp bHRlcnNNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFj L1BsYXRmb3JtQ0FGaWx0ZXJzTWFjLm1tCkBAIC0zNDgsNyArMzQ4LDcgQEAgUmV0YWluUHRyPE5T VmFsdWU+IFBsYXRmb3JtQ0FGaWx0ZXJzOjpmaWx0ZXJWYWx1ZUZvck9wZXJhdGlvbihjb25zdCBG aWx0ZXJPcGVyYXQKICAgICAgICAgICAgIGNvbnN0IEJhc2ljQ29sb3JNYXRyaXhGaWx0ZXJPcGVy YXRpb24qIG9wID0gc3RhdGljX2Nhc3Q8Y29uc3QgQmFzaWNDb2xvck1hdHJpeEZpbHRlck9wZXJh dGlvbio+KG9wZXJhdGlvbik7CiAgICAgICAgICAgICBhbW91bnQgPSBvcC0+YW1vdW50KCk7CiAg ICAgICAgIH0KLSAgICAgICAgdmFsdWUgPSBhZG9wdE5TKFtbTlNOdW1iZXIgbnVtYmVyV2l0aERv dWJsZTphbW91bnRdIHJldGFpbl0pOworICAgICAgICB2YWx1ZSA9IFtOU051bWJlciBudW1iZXJX aXRoRG91YmxlOmFtb3VudF07CiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIEZpbHRl ck9wZXJhdGlvbjo6U0VQSUE6IHsKQEAgLTM4OSw3ICszODksNyBAQCBSZXRhaW5QdHI8TlNWYWx1 ZT4gUGxhdGZvcm1DQUZpbHRlcnM6OmZpbHRlclZhbHVlRm9yT3BlcmF0aW9uKGNvbnN0IEZpbHRl ck9wZXJhdAogICAgICAgICAgICAgYW1vdW50ID0gb3AtPmFtb3VudCgpOwogICAgICAgICB9CiAg ICAgICAgIAotICAgICAgICB2YWx1ZSA9IGFkb3B0TlMoW1tOU051bWJlciBudW1iZXJXaXRoRG91 YmxlOmFtb3VudF0gcmV0YWluXSk7CisgICAgICAgIHZhbHVlID0gW05TTnVtYmVyIG51bWJlcldp dGhEb3VibGU6YW1vdW50XTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgRmlsdGVy T3BlcmF0aW9uOjpIVUVfUk9UQVRFOiB7CkBAIC00MDEsNyArNDAxLDcgQEAgUmV0YWluUHRyPE5T VmFsdWU+IFBsYXRmb3JtQ0FGaWx0ZXJzOjpmaWx0ZXJWYWx1ZUZvck9wZXJhdGlvbihjb25zdCBG aWx0ZXJPcGVyYXQKICAgICAgICAgICAgIGFtb3VudCA9IG9wLT5hbW91bnQoKTsKICAgICAgICAg fQogICAgICAgICBhbW91bnQgPSBkZWcycmFkKGFtb3VudCk7Ci0gICAgICAgIHZhbHVlID0gYWRv cHROUyhbW05TTnVtYmVyIG51bWJlcldpdGhEb3VibGU6YW1vdW50XSByZXRhaW5dKTsKKyAgICAg ICAgdmFsdWUgPSBbTlNOdW1iZXIgbnVtYmVyV2l0aERvdWJsZTphbW91bnRdOwogICAgICAgICBi cmVhazsKICAgICB9CiAgICAgY2FzZSBGaWx0ZXJPcGVyYXRpb246OklOVkVSVDogewpAQCAtNDg4 LDcgKzQ4OCw3IEBAIFJldGFpblB0cjxOU1ZhbHVlPiBQbGF0Zm9ybUNBRmlsdGVyczo6ZmlsdGVy VmFsdWVGb3JPcGVyYXRpb24oY29uc3QgRmlsdGVyT3BlcmF0CiAgICAgICAgICAgICBhbW91bnQg PSBvcC0+YW1vdW50KCk7CiAgICAgICAgIH0KIAotICAgICAgICB2YWx1ZSA9IGFkb3B0TlMoW1tO U051bWJlciBudW1iZXJXaXRoRG91YmxlOmFtb3VudF0gcmV0YWluXSk7CisgICAgICAgIHZhbHVl ID0gW05TTnVtYmVyIG51bWJlcldpdGhEb3VibGU6YW1vdW50XTsKICNlbmRpZgogICAgICAgICBi cmVhazsKICAgICB9CkBAIC01MDIsNyArNTAyLDcgQEAgUmV0YWluUHRyPE5TVmFsdWU+IFBsYXRm b3JtQ0FGaWx0ZXJzOjpmaWx0ZXJWYWx1ZUZvck9wZXJhdGlvbihjb25zdCBGaWx0ZXJPcGVyYXQK ICAgICAgICAgICAgIGFtb3VudCA9IGZsb2F0VmFsdWVGb3JMZW5ndGgob3AtPnN0ZERldmlhdGlv bigpLCAwKTsKICAgICAgICAgfQogICAgICAgICAKLSAgICAgICAgdmFsdWUgPSBhZG9wdE5TKFtb TlNOdW1iZXIgbnVtYmVyV2l0aERvdWJsZTphbW91bnRdIHJldGFpbl0pOworICAgICAgICB2YWx1 ZSA9IFtOU051bWJlciBudW1iZXJXaXRoRG91YmxlOmFtb3VudF07CiAgICAgICAgIGJyZWFrOwog ICAgIH0KICAgICBkZWZhdWx0OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0KaW5kZXggZGRkMTliOGU2NTA0 NjY0NGY4YmM4ZmZkMGYyYjM3ZmUwZTJiNWIxOS4uOTdmY2Y4N2Y1M2I2YzRmYTYyMTFmYjc0YTUz NmRhZTk5MGJmMTVkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tCkBAIC04MCw3ICs4MCw3IEBAIE5T VVJMUmVzcG9uc2UgKlJlc291cmNlUmVzcG9uc2U6Om5zVVJMUmVzcG9uc2UoKSBjb25zdAogICAg ICAgICByZXR1cm4gbmlsOwogCiAgICAgaWYgKCFtX25zUmVzcG9uc2UpCi0gICAgICAgIG1fbnNS ZXNwb25zZSA9IGFkb3B0TlMoW1tOU1VSTFJlc3BvbnNlIF9yZXNwb25zZVdpdGhDRlVSTFJlc3Bv bnNlOm1fY2ZSZXNwb25zZS5nZXQoKV0gcmV0YWluXSk7CisgICAgICAgIG1fbnNSZXNwb25zZSA9 IFtOU1VSTFJlc3BvbnNlIF9yZXNwb25zZVdpdGhDRlVSTFJlc3BvbnNlOm1fY2ZSZXNwb25zZS5n ZXQoKV07CiAKICAgICByZXR1cm4gbV9uc1Jlc3BvbnNlLmdldCgpOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblN0cmVhbS5tbSBiL1Nv dXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5TdHJlYW0ubW0KaW5kZXgg MWZiZGE3YTc1YmJjNzk0ZjRlMmVlM2VmZWNlZjcwYmJhN2U1ZTNkMi4uNGMzMjZhNjQ2NzVmZWRj OTUwZDRjZDBjMTE0NjZhMWZjZWNlMWJkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMv UGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblN0cmVhbS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21h Yy9QbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luU3RyZWFtLm1tCkBAIC01NzIsNyArNTcyLDcgQEAg dm9pZCBXZWJOZXRzY2FwZVBsdWdpblN0cmVhbTo6ZGVsaXZlckRhdGFUb0ZpbGUoTlNEYXRhICpk YXRhKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgbV9wYXRoID0g YWRvcHROUyhbW05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOnRlbXBvcmFyeUZpbGVOYW1l XSByZXRhaW5dKTsKKyAgICAgICAgbV9wYXRoID0gW05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4U3Ry aW5nOnRlbXBvcmFyeUZpbGVOYW1lXTsKICAgICAgICAgZnJlZSh0ZW1wb3JhcnlGaWxlTmFtZSk7 CiAgICAgfQogCg==