115425 2013-04-30 09:20:40 -0700 String::isolatedCopy() can avoid a copy if the original is a temporary 2013-04-30 09:30:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 883106 0 andersca 2013-04-30 09:20:40 -0700 String::isolatedCopy() can avoid a copy if the original is a temporary 883107 1 200123 andersca 2013-04-30 09:25:31 -0700 Created attachment 200123 Patch 883109 2 commit-queue 2013-04-30 09:27:19 -0700 Attachment 200123 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Compiler.h', u'Source/WTF/wtf/text/WTFString.cpp', u'Source/WTF/wtf/text/WTFString.h']" exit_code: 1 Source/WTF/wtf/text/WTFString.cpp:659: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/text/WTFString.cpp:665: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WTF/wtf/text/WTFString.cpp:666: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 883111 3 andersca 2013-04-30 09:30:44 -0700 Committed r149372: <http://trac.webkit.org/changeset/149372> 200123 2013-04-30 09:25:31 -0700 2013-04-30 09:26:53 -0700 Patch bug-115425-20130430092446.patch text/plain 3853 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYwYTJmMDcyYzAwOGY5MzJlNWQwMTYz MGMxZTIzOGE2ZmU5MGY1ZTcuLjRjY2I1Y2IzM2NiM2VlNGIyNjA4NDMzMzM2OGQ2MzBhZjNhYzY0 ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMDQtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmc6Omlzb2xhdGVkQ29weSgpIGNhbiBh dm9pZCBhIGNvcHkgaWYgdGhlIG9yaWdpbmFsIGlzIGEgdGVtcG9yYXJ5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU0MjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOgorICAg ICAgICBBZGQgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9SRUZFUkVOQ0VfUVVBTElGSUVEX0ZV TkNUSU9OUyBkZWZpbmUuCisKKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuY3BwOgorICAg ICAgICAoV1RGOjpTdHJpbmc6Omlzb2xhdGVkQ29weSk6CisgICAgICAgICogd3RmL3RleHQvV1RG U3RyaW5nLmg6CisgICAgICAgIElmIENPTVBJTEVSX1NVUFBPUlRTKENYWF9SRUZFUkVOQ0VfUVVB TElGSUVEX0ZVTkNUSU9OUykgaXMgdHJ1ZSwgYWRkIHR3byBvdmVybG9hZHMgb2YgU3RyaW5nOjpp c29sYXRlZENvcHkoKS4KKyAgICAgICAgT25lIGlzIHVzZWQgaWYgKnRoaXMgaXMgYW4gbHZhbHVl LCBhbmQgb25lIGlzIHVzZWQgaWYgKnRoaXMgaXMgYW4gcnZhbHVlLiBJbiB0aGUgbGF0dGVyIGNh c2UsIHdlIGtub3cgdGhhdCB0aGUgb3JpZ2luYWwKKyAgICAgICAgU3RyaW5nIG9iamVjdCBpcyBh IHRlbXBvcmFyeSBhbmQgd2lsbCBiZSBnb2luZyBhd2F5LCBzbyBpZiBpdCdzIHNhZmUgdG8gc2Vu ZCBpdCB0byBhbm90aGVyIHRocmVhZCAoaWYgaXQncyBub3QgYW4gQXRvbWljU3RyaW5nLAorICAg ICAgICBhbmQgaWYgaXQncyByZWZjb3VudCBpcyAxKSwgdGhlbiB3ZSBjYW4ganVzdCBzdGVhbCB0 aGUgU3RyaW5nSW1wbCBmcm9tIHRoZSBvcmlnaW5hbCBhbmQgYXZvaWQgYSBjb3B5IGFsdG9nZXRo ZXIuCisKIDIwMTMtMDQtMzAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBBbmltYXRpb25zIGZhaWwgdG8gc3RhcnQgb24gaHR0cDovL3d3dy5nb29nbGUuY29tL2lu c2lkZXNlYXJjaC9ob3dzZWFyY2h3b3Jrcy90aGVzdG9yeS8KZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL0NvbXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCmluZGV4IGI4ODZm MzcxNTEyOTI4NTFmMzExMzA2YjkwZmE1YjliYzI4ODBlMDYuLmYzMDdiM2I5MWM1MzE5N2JkMzIx ZDY2ZjBkNDE0OWQ4NmJhOWE2OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVy LmgKKysrIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaApAQCAtNjQsNiArNjQsNyBAQAogI2Rl ZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX09WRVJSSURFX0NPTlRST0wgX19oYXNfZXh0 ZW5zaW9uKGN4eF9vdmVycmlkZV9jb250cm9sKQogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9S VFNfSEFTX1RSSVZJQUxfREVTVFJVQ1RPUiBfX2hhc19leHRlbnNpb24oaGFzX3RyaXZpYWxfZGVz dHJ1Y3RvcikKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9TVFJPTkdfRU5VTVMg X19oYXNfZXh0ZW5zaW9uKGN4eF9zdHJvbmdfZW51bXMpCisjZGVmaW5lIFdURl9DT01QSUxFUl9T VVBQT1JUU19DWFhfUkVGRVJFTkNFX1FVQUxJRklFRF9GVU5DVElPTlMgX19oYXNfZXh0ZW5zaW9u KGN4eF9yZWZlcmVuY2VfcXVhbGlmaWVkX2Z1bmN0aW9ucykKIAogI2VuZGlmCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3Rl eHQvV1RGU3RyaW5nLmNwcAppbmRleCA3NWU3NjkzODhjOTNjYmNlOTdiZTJmZTIzNzZlOGVhYTVl N2U4OWJlLi5iOTc5YzU4NWJkOGI2MzQzOGNiOTFhZGE3NWJjZDg3M2Y0NjdlZjk5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvdGV4dC9XVEZTdHJpbmcuY3BwCkBAIC02NTQsMTIgKzY1NCwzNSBAQCBmbG9hdCBTdHJpbmc6 OnRvRmxvYXQoYm9vbCogb2spIGNvbnN0CiAgICAgcmV0dXJuIG1faW1wbC0+dG9GbG9hdChvayk7 CiB9CiAKKyNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUkVGRVJFTkNFX1FVQUxJRklFRF9GVU5D VElPTlMpCitTdHJpbmcgU3RyaW5nOjppc29sYXRlZENvcHkoKSBjb25zdCAmCit7CisgICAgaWYg KCFtX2ltcGwpCisgICAgICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICByZXR1cm4gbV9pbXBsLT5p c29sYXRlZENvcHkoKTsKK30KKworU3RyaW5nIFN0cmluZzo6aXNvbGF0ZWRDb3B5KCkgY29uc3Qg JiYKK3sKKyAgICBpZiAoaXNTYWZlVG9TZW5kVG9Bbm90aGVyVGhyZWFkKCkpIHsKKyAgICAgICAg Ly8gU2luY2Ugd2Uga25vdyB0aGF0IG91ciBzdHJpbmcgaXMgYSB0ZW1wb3JhcnkgdGhhdCB3aWxs IGJlIGRlc3Ryb3llZAorICAgICAgICAvLyB3ZSBjYW4ganVzdCBzdGVhbCB0aGUgbV9pbXBsIGZy b20gaXQsIHRodXMgYXZvaWRpbmcgYSBjb3B5LgorICAgICAgICByZXR1cm4gU3RyaW5nKHN0ZDo6 bW92ZSgqdGhpcykpOworICAgIH0KKworICAgIGlmICghbV9pbXBsKQorICAgICAgICByZXR1cm4g U3RyaW5nKCk7CisKKyAgICByZXR1cm4gbV9pbXBsLT5pc29sYXRlZENvcHkoKTsKK30KKyNlbHNl CiBTdHJpbmcgU3RyaW5nOjppc29sYXRlZENvcHkoKSBjb25zdAogewogICAgIGlmICghbV9pbXBs KQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgcmV0dXJuIG1faW1wbC0+aXNvbGF0ZWRD b3B5KCk7CiB9CisjZW5kaWYKIAogYm9vbCBTdHJpbmc6OmlzU2FmZVRvU2VuZFRvQW5vdGhlclRo cmVhZCgpIGNvbnN0CiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmlu Zy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAppbmRleCBjNDU0ZTRkOWM5NzMy MzRmZjZjNTY5N2FkM2ZiOGQ5NGEwYWE2Zjk1Li5jM2NhYjE5OGJkOTQ5ZWEwZTgwZWUyYTI5YzJj YjYwYWY0ZDZhY2Y2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTM5OCw3ICszOTgsMTMg QEAgcHVibGljOgogCiAgICAgYm9vbCBwZXJjZW50YWdlKGludCYgcGVyY2VudGFnZSkgY29uc3Q7 CiAKKyNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUkVGRVJFTkNFX1FVQUxJRklFRF9GVU5DVElP TlMpCisgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFN0cmluZyBpc29sYXRlZENvcHkoKSBjb25z dCAmOworICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBTdHJpbmcgaXNvbGF0ZWRDb3B5KCkgY29u c3QgJiY7CisjZWxzZQogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBTdHJpbmcgaXNvbGF0ZWRD b3B5KCkgY29uc3Q7CisjZW5kaWYKKwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBib29sIGlz U2FmZVRvU2VuZFRvQW5vdGhlclRocmVhZCgpIGNvbnN0OwogCiAgICAgLy8gUHJldmVudCBTdHJp bmdzIGZyb20gYmVpbmcgaW1wbGljaXRseSBjb252ZXJ0YWJsZSB0byBib29sIGFzIGl0IHdpbGwg YmUgYW1iaWd1b3VzIG9uIGFueSBwbGF0Zm9ybSB0aGF0Cg==