115410 2013-04-30 04:31:58 -0700 Change HashTraits<RefPtr >::PassOutType to PassRefPtr for better performance 2013-05-06 09:41:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca benjamin cmarcelo commit-queue darin kling oldest_to_newest 883015 0 mikhail.pozdnyakov 2013-04-30 04:31:58 -0700 SSIA. 883018 1 200099 mikhail.pozdnyakov 2013-04-30 04:56:05 -0700 Created attachment 200099 WIP Do we want to take after HashTraits<OwnPtr > and use std::nullptr_t for EmptyValueType? 883020 2 200099 mikhail.pozdnyakov 2013-04-30 05:11:52 -0700 Comment on attachment 200099 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=200099&action=review > Source/WTF/wtf/HashTraits.h:145 > + static PassRefPtr passOut(const RefPtr& value) { return value; } that would be better to call release here, but that would break constness. 883093 3 200099 darin 2013-04-30 08:59:07 -0700 Comment on attachment 200099 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=200099&action=review >> Source/WTF/wtf/HashTraits.h:145 >> + static PassRefPtr passOut(const RefPtr& value) { return value; } > > that would be better to call release here, but that would break constness. The release() is where the performance benefit comes from. So this is not useful to do without the release(). This should instead be: typedef PassRefPtr PassOutType; static PassRefPtr passOut(RefPtr& value) { return value.release(); } Could you test to see if that compiles on various platforms and what it does? 883094 4 darin 2013-04-30 09:00:09 -0700 (In reply to comment #1) > Do we want to take after HashTraits<OwnPtr > and use std::nullptr_t for EmptyValueType? Yes, I think we will need to do that so that the take function compiles. 883228 5 mikhail.pozdnyakov 2013-04-30 14:21:35 -0700 (In reply to comment #3) > (From update of attachment 200099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200099&action=review > > >> Source/WTF/wtf/HashTraits.h:145 > >> + static PassRefPtr passOut(const RefPtr& value) { return value; } > > > > that would be better to call release here, but that would break constness. > > The release() is where the performance benefit comes from. So this is not useful to do without the release(). This should instead be: > > typedef PassRefPtr PassOutType; > static PassRefPtr passOut(RefPtr& value) { return value.release(); } > > Could you test to see if that compiles on various platforms and what it does? in order to make it compile-able we will need to use std::nullptr_t as empty type, provide corresponding constructors to RefPtr/PassRefPtr and probably also add one more equal() method to hash translator.. but I can do it :) 883738 6 mikhail.pozdnyakov 2013-05-02 01:51:55 -0700 > > The release() is where the performance benefit comes from. So this is not useful to do without the release(). > This should instead be: > > > > typedef PassRefPtr PassOutType; > > static PassRefPtr passOut(RefPtr& value) { return value.release(); } > > > > Could you test to see if that compiles on various platforms and what it does? > > in order to make it compile-able we will need to use std::nullptr_t as empty type, provide corresponding constructors to RefPtr/PassRefPtr and probably also add one more equal() method to hash translator.. but I can do it :) This is actually much more complex to support std::nullptr_t as empty type: 1) there is necessity to add "==" operators accepting nullptr into a lot of places. 2) having both constructors accepting raw pointer to 'T' and std::nullptr_t inside RefPtr/PassRefPtr brings ambiguousness to some calls. So I would choose another way of solving the initial compiling issue: having following method inside HashTraits<RefPtr > static RefPtr& emptyValue() { static RefPtr& null = *(new RefPtr); return null; } 883740 7 200304 mikhail.pozdnyakov 2013-05-02 01:53:43 -0700 Created attachment 200304 patch 883813 8 darin 2013-05-02 09:22:55 -0700 (In reply to comment #6) > So I would choose another way of solving the initial compiling issue: > having following method inside HashTraits<RefPtr > > > static RefPtr& emptyValue() > { > static RefPtr& null = *(new RefPtr); > return null; > } This won’t be good for performance. Null needs to be more efficient than this. Please don’t do this. 883814 9 200304 darin 2013-05-02 09:25:43 -0700 Comment on attachment 200304 patch View in context: https://bugs.webkit.org/attachment.cgi?id=200304&action=review If we are having trouble making nullptr work, maybe we can make a zero work? I’m sure there is some way to do this. I think you are learning now why I landed this with a FIXME rather than doing this task originally. > Source/WTF/wtf/HashTraits.h:145 > + static RefPtr& emptyValue() > + { > + static RefPtr& null = *(new RefPtr); > + return null; > + } I understand this is easier to get right than the alternative, but it’s not going to be efficient to fetch a global variable all the time. Since the whole point of this is to get better performance, we must not make this change! 884130 10 mikhail.pozdnyakov 2013-05-03 04:07:53 -0700 (In reply to comment #9) > (From update of attachment 200304 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200304&action=review > > If we are having trouble making nullptr work, maybe we can make a zero work? think it's gonna work with '0'. I’m sure there is some way to do this. I think you are learning now why I landed this with a FIXME rather than doing this task originally. yeah I got it :) 884131 11 200406 mikhail.pozdnyakov 2013-05-03 04:13:28 -0700 Created attachment 200406 patch v2 Use '0' as empty value. 884146 12 200406 mikhail.pozdnyakov 2013-05-03 05:27:08 -0700 Comment on attachment 200406 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=200406&action=review > Source/WTF/wtf/HashTraits.h:141 > + static P* emptyValue() { return 0; } it's probably worth adding "static const bool emptyValueIsZero = true;" 884147 13 mikhail.pozdnyakov 2013-05-03 05:33:20 -0700 (In reply to comment #11) > Created an attachment (id=200406) [details] > patch v2 > > Use '0' as empty value. An alternate solution could be the following: template<typename P> struct HashTraits<RefPtr > : SimpleClassHashTraits<RefPtr > { .......... typedef PassRefPtr PassOutType; static PassRefPtr passOut(RefPtr& value) { return value.release(); } static PassRefPtr passOut(const RefPtr& value) // Overload for temporary, must be used for empty value only. { ASSERT(!value); return 0; } }; what do you think? 885041 14 200406 darin 2013-05-06 09:07:46 -0700 Comment on attachment 200406 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=200406&action=review > Source/WTF/wtf/HashTable.h:304 > template<typename T> static bool equal(const T& a, const T& b) { return HashFunctions::equal(a, b); } > + template<typename T, typename U> static bool equal(const T& a, const U& b) { return HashFunctions::equal(a, b); } When we add the two-type equal function template, we should remove the old single-type function template. No need to keep both. >> Source/WTF/wtf/HashTraits.h:141 >> + static P* emptyValue() { return 0; } > > it's probably worth adding "static const bool emptyValueIsZero = true;" Doesn’t need to be added. SimpleClassHashTraits provides that. > Source/WTF/wtf/HashTraits.h:149 > + static PassRefPtr passOut(P* value) { return value; } > // FIXME: We should consider changing PeekType to a raw pointer for better performance, I suggest a blank line here so that PassOutType and PeekType are in separate paragraphs. 885067 15 mikhail.pozdnyakov 2013-05-06 09:41:13 -0700 Committed r149602: <http://trac.webkit.org/changeset/149602> 200099 2013-04-30 04:56:05 -0700 2013-05-02 01:53:43 -0700 WIP bug115410 text/plain 1650 mikhail.pozdnyakov Y29tbWl0IDkwYzIyZWM3OWViZmQ2YjBkY2YxMzQyNDM1ODVhNzJiYWRmYjA0NDYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIEFwciAzMCAxNDo1MDo0MyAyMDEzICswMzAwCgogICAgYnVnMTE1NDEwCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAxM2Vi MTVmLi4zZmUxYzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTMwICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIENoYW5n ZSBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+OjpQYXNzT3V0VHlwZSB0byBQYXNzUmVmUHRyIGZvciBi ZXR0ZXIgcGVyZm9ybWFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0eXBlIEhhc2hUcmFpdHM8UmVmUHRyPFA+ID46OlBhc3NPdXRUeXBlIGlz IFBhc3NSZWZQdHIgbm93IHRvCisgICAgICAgIGF2b2lkIGV4dHJhIHJlZi91bnJlZmluZyBvbiBy ZXR1cm4gZnJvbSBIYXNoTWFwIG1ldGhvZHMgdGhhdCB0cmFuc2ZlcgorICAgICAgICBvd25lcnNo aXAsIHN1Y2ggYXMgdGFrZS4KKworICAgICAgICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisKIDIwMTMt MDQtMjkgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBb QVJNXSBFeHBhbmQgdGhlIHVzZSBvZiBpbnRlZ2VyIGRpdmlzaW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmgKaW5k ZXggYjA2ZTc4NS4uM2NlYmE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvSGFzaFRyYWl0 cy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaApAQCAtMTQxLDcgKzE0MSw4IEBA IG5hbWVzcGFjZSBXVEYgewogICAgICAgICB0eXBlZGVmIFBhc3NSZWZQdHI8UD4gUGFzc0luVHlw ZTsKICAgICAgICAgc3RhdGljIHZvaWQgc3RvcmUoUGFzc1JlZlB0cjxQPiB2YWx1ZSwgUmVmUHRy PFA+JiBzdG9yYWdlKSB7IHN0b3JhZ2UgPSB2YWx1ZTsgfQogCi0gICAgICAgIC8vIEZJWE1FOiBX ZSBzaG91bGQgY2hhbmdlIFBhc3NPdXRUeXBlIHRvIFBhc3NSZWZQdHIgZm9yIGJldHRlciBwZXJm b3JtYW5jZS4KKyAgICAgICAgdHlwZWRlZiBQYXNzUmVmUHRyPFA+IFBhc3NPdXRUeXBlOworICAg ICAgICBzdGF0aWMgUGFzc1JlZlB0cjxQPiBwYXNzT3V0KGNvbnN0IFJlZlB0cjxQPiYgdmFsdWUp IHsgcmV0dXJuIHZhbHVlOyB9CiAgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY29uc2lkZXIg Y2hhbmdpbmcgUGVla1R5cGUgdG8gYSByYXcgcG9pbnRlciBmb3IgYmV0dGVyIHBlcmZvcm1hbmNl LAogICAgICAgICAvLyBidXQgdGhlbiBjYWxsZXJzIHdvbid0IG5lZWQgdG8gY2FsbCBnZXQ7IGRv aW5nIHNvIHdpbGwgcmVxdWlyZSB1cGRhdGluZyBtYW55IGNhbGwgc2l0ZXMuCiAgICAgfTsK 200304 2013-05-02 01:53:43 -0700 2013-05-03 04:13:28 -0700 patch bug115410 text/plain 1906 mikhail.pozdnyakov Y29tbWl0IDI1ODVlMGI2Y2I4YjlhMzQwZWQ1ZjBhZDYwNzI0ZjQ1OWEzNmZlZWQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIEFwciAzMCAxNDo1MDo0MyAyMDEzICswMzAwCgogICAgYnVnMTE1NDEwCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAxM2Vi MTVmLi4zZmUxYzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTMwICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIENoYW5n ZSBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+OjpQYXNzT3V0VHlwZSB0byBQYXNzUmVmUHRyIGZvciBi ZXR0ZXIgcGVyZm9ybWFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0eXBlIEhhc2hUcmFpdHM8UmVmUHRyPFA+ID46OlBhc3NPdXRUeXBlIGlz IFBhc3NSZWZQdHIgbm93IHRvCisgICAgICAgIGF2b2lkIGV4dHJhIHJlZi91bnJlZmluZyBvbiBy ZXR1cm4gZnJvbSBIYXNoTWFwIG1ldGhvZHMgdGhhdCB0cmFuc2ZlcgorICAgICAgICBvd25lcnNo aXAsIHN1Y2ggYXMgdGFrZS4KKworICAgICAgICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisKIDIwMTMt MDQtMjkgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBb QVJNXSBFeHBhbmQgdGhlIHVzZSBvZiBpbnRlZ2VyIGRpdmlzaW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmgKaW5k ZXggYjA2ZTc4NS4uNjlkZjhiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvSGFzaFRyYWl0 cy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaApAQCAtMTM4LDEwICsxMzgsMTcg QEAgbmFtZXNwYWNlIFdURiB7CiAgICAgfTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFA+IHN0 cnVjdCBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+IDogU2ltcGxlQ2xhc3NIYXNoVHJhaXRzPFJlZlB0 cjxQPiA+IHsKKyAgICAgICAgc3RhdGljIFJlZlB0cjxQPiYgZW1wdHlWYWx1ZSgpCisgICAgICAg IHsKKyAgICAgICAgICAgIHN0YXRpYyBSZWZQdHI8UD4mIG51bGwgPSAqKG5ldyBSZWZQdHI8UD4p OworICAgICAgICAgICAgcmV0dXJuIG51bGw7CisgICAgICAgIH0KKwogICAgICAgICB0eXBlZGVm IFBhc3NSZWZQdHI8UD4gUGFzc0luVHlwZTsKICAgICAgICAgc3RhdGljIHZvaWQgc3RvcmUoUGFz c1JlZlB0cjxQPiB2YWx1ZSwgUmVmUHRyPFA+JiBzdG9yYWdlKSB7IHN0b3JhZ2UgPSB2YWx1ZTsg fQogCi0gICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY2hhbmdlIFBhc3NPdXRUeXBlIHRvIFBh c3NSZWZQdHIgZm9yIGJldHRlciBwZXJmb3JtYW5jZS4KKyAgICAgICAgdHlwZWRlZiBQYXNzUmVm UHRyPFA+IFBhc3NPdXRUeXBlOworICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxQPiBwYXNzT3V0 KFJlZlB0cjxQPiYgdmFsdWUpIHsgcmV0dXJuIHZhbHVlLnJlbGVhc2UoKTsgfQogICAgICAgICAv LyBGSVhNRTogV2Ugc2hvdWxkIGNvbnNpZGVyIGNoYW5naW5nIFBlZWtUeXBlIHRvIGEgcmF3IHBv aW50ZXIgZm9yIGJldHRlciBwZXJmb3JtYW5jZSwKICAgICAgICAgLy8gYnV0IHRoZW4gY2FsbGVy cyB3b24ndCBuZWVkIHRvIGNhbGwgZ2V0OyBkb2luZyBzbyB3aWxsIHJlcXVpcmUgdXBkYXRpbmcg bWFueSBjYWxsIHNpdGVzLgogICAgIH07Cg== 200406 2013-05-03 04:13:28 -0700 2013-05-06 09:07:46 -0700 patch v2 bug115410_v2 text/plain 2625 mikhail.pozdnyakov Y29tbWl0IDFkZjBlOTJkMmJmNGMwOWZkNTRkNWUxNzY5MmIxOGM2OGRmNjc3NjAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIEFwciAzMCAxNDo1MDo0MyAyMDEzICswMzAwCgogICAgYnVnMTE1NDEwCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCA3OWI1 MDY4Li5lMDYyNGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTAzICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIENoYW5n ZSBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+OjpQYXNzT3V0VHlwZSB0byBQYXNzUmVmUHRyIGZvciBi ZXR0ZXIgcGVyZm9ybWFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0eXBlIEhhc2hUcmFpdHM8UmVmUHRyPFA+ID46OlBhc3NPdXRUeXBlIGlz IFBhc3NSZWZQdHIgbm93IHRvCisgICAgICAgIGF2b2lkIGV4dHJhIHJlZi91bnJlZmluZyBvbiBy ZXR1cm4gZnJvbSBIYXNoTWFwIG1ldGhvZHMgdGhhdCB0cmFuc2ZlcgorICAgICAgICBvd25lcnNo aXAsIHN1Y2ggYXMgdGFrZS4KKworICAgICAgICAqIHd0Zi9IYXNoVGFibGUuaDoKKyAgICAgICAg KFdURjo6SWRlbnRpdHlIYXNoVHJhbnNsYXRvcjo6ZXF1YWwpOgorICAgICAgICAqIHd0Zi9IYXNo VHJhaXRzLmg6CisKIDIwMTMtMDUtMDIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtXaW5DYWlyb10gVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJs ZS5oCmluZGV4IGJiNzhjNjYuLjU2OWI1MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0hh c2hUYWJsZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCkBAIC0zMDEsNiArMzAx LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgcHVibGljOgogICAgICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBUPiBzdGF0aWMgdW5zaWduZWQgaGFzaChjb25zdCBUJiBrZXkpIHsgcmV0dXJuIEhhc2hG dW5jdGlvbnM6Omhhc2goa2V5KTsgfQogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0 aWMgYm9vbCBlcXVhbChjb25zdCBUJiBhLCBjb25zdCBUJiBiKSB7IHJldHVybiBIYXNoRnVuY3Rp b25zOjplcXVhbChhLCBiKTsgfQorICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFt ZSBVPiBzdGF0aWMgYm9vbCBlcXVhbChjb25zdCBUJiBhLCBjb25zdCBVJiBiKSB7IHJldHVybiBI YXNoRnVuY3Rpb25zOjplcXVhbChhLCBiKTsgfQogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU LCB0eXBlbmFtZSBVPiBzdGF0aWMgdm9pZCB0cmFuc2xhdGUoVCYgbG9jYXRpb24sIGNvbnN0IFUm LCBjb25zdCBUJiB2YWx1ZSkgeyBsb2NhdGlvbiA9IHZhbHVlOyB9CiAgICAgfTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5oIGIvU291cmNlL1dURi93dGYvSGFzaFRy YWl0cy5oCmluZGV4IGIwNmU3ODUuLmFlNGY4MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L0hhc2hUcmFpdHMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmgKQEAgLTEzOCwx MCArMTM4LDE0IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIH07CiAKICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBQPiBzdHJ1Y3QgSGFzaFRyYWl0czxSZWZQdHI8UD4gPiA6IFNpbXBsZUNsYXNzSGFzaFRy YWl0czxSZWZQdHI8UD4gPiB7CisgICAgICAgIHN0YXRpYyBQKiBlbXB0eVZhbHVlKCkgeyByZXR1 cm4gMDsgfQorCiAgICAgICAgIHR5cGVkZWYgUGFzc1JlZlB0cjxQPiBQYXNzSW5UeXBlOwogICAg ICAgICBzdGF0aWMgdm9pZCBzdG9yZShQYXNzUmVmUHRyPFA+IHZhbHVlLCBSZWZQdHI8UD4mIHN0 b3JhZ2UpIHsgc3RvcmFnZSA9IHZhbHVlOyB9CiAKLSAgICAgICAgLy8gRklYTUU6IFdlIHNob3Vs ZCBjaGFuZ2UgUGFzc091dFR5cGUgdG8gUGFzc1JlZlB0ciBmb3IgYmV0dGVyIHBlcmZvcm1hbmNl LgorICAgICAgICB0eXBlZGVmIFBhc3NSZWZQdHI8UD4gUGFzc091dFR5cGU7CisgICAgICAgIHN0 YXRpYyBQYXNzUmVmUHRyPFA+IHBhc3NPdXQoUmVmUHRyPFA+JiB2YWx1ZSkgeyByZXR1cm4gdmFs dWUucmVsZWFzZSgpOyB9CisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFA+IHBhc3NPdXQoUCog dmFsdWUpIHsgcmV0dXJuIHZhbHVlOyB9CiAgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY29u c2lkZXIgY2hhbmdpbmcgUGVla1R5cGUgdG8gYSByYXcgcG9pbnRlciBmb3IgYmV0dGVyIHBlcmZv cm1hbmNlLAogICAgICAgICAvLyBidXQgdGhlbiBjYWxsZXJzIHdvbid0IG5lZWQgdG8gY2FsbCBn ZXQ7IGRvaW5nIHNvIHdpbGwgcmVxdWlyZSB1cGRhdGluZyBtYW55IGNhbGwgc2l0ZXMuCiAgICAg fTsK