115389 2013-04-29 17:24:28 -0700 It should be an error to use adoptPtr with RefCounted subclasses 2013-04-29 17:45:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue darin oldest_to_newest 882854 0 andersca 2013-04-29 17:24:28 -0700 It should be an error to use adoptPtr with RefCounted subclasses 882855 1 200063 andersca 2013-04-29 17:25:10 -0700 Created attachment 200063 Patch 882867 2 200063 benjamin 2013-04-29 17:34:53 -0700 Comment on attachment 200063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200063&action=review I loooove this. Great idea. > Source/WTF/wtf/PassOwnPtr.h:151 > + COMPILE_ASSERT(!(IsSubclass<T, RefCounted<T> >::value), DoNotUseAdoptPtrWithRefCounted); > + COMPILE_ASSERT(!(IsSubclass<T, ThreadSafeRefCounted<T> >::value), DoNotUseAdoptPtrWithThreadSafeRefCounted); +RefCountedBase 882869 3 andersca 2013-04-29 17:38:58 -0700 (In reply to comment #2) > (From update of attachment 200063 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200063&action=review > > I loooove this. Great idea. > > > Source/WTF/wtf/PassOwnPtr.h:151 > > + COMPILE_ASSERT(!(IsSubclass<T, RefCounted<T> >::value), DoNotUseAdoptPtrWithRefCounted); > > + COMPILE_ASSERT(!(IsSubclass<T, ThreadSafeRefCounted<T> >::value), DoNotUseAdoptPtrWithThreadSafeRefCounted); > > +RefCountedBase I’ll use ThreadSafeRefCountedBase and RefCountedBase instead. 882870 4 andersca 2013-04-29 17:45:18 -0700 Committed r149341: <http://trac.webkit.org/changeset/149341> 200063 2013-04-29 17:25:10 -0700 2013-04-29 17:34:51 -0700 Patch bug-115389-20130429172426.patch text/plain 1625 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM3ZDU3ZGUyNzNmZGY4ZDdjZDE5Y2Zm YjU2NzM5MmY2MTQ4MzlhMGMuLmZkMTJhOWU1MDdlMjc1ZjIyMTM3NzExZTI3ZjY4OGYyOTk2YTQ0 ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDQtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBJdCBzaG91bGQgYmUgYW4gZXJyb3IgdG8gdXNl IGFkb3B0UHRyIHdpdGggUmVmQ291bnRlZCBzdWJjbGFzc2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTUzODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QYXNzT3duUHRyLmg6CisgICAgICAg IChXVEY6OmFkb3B0UHRyKToKKyAgICAgICAgQWRkIENPTVBJTEVfQVNTRVJUcy4KKwogMjAxMy0w NC0yOSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBb V0lOXSBBZGQgd29ya2Fyb3VuZCBmb3IgVU5VU0VEX1BBUkFNKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL1Bhc3NPd25QdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1Bhc3NPd25QdHIuaAppbmRl eCA1ZWJmODNkNjVhYTFiMjA2Mjg5MDA4YTQ0YzljNTc5OWMxMzgwYWNjLi5mNzhiZTdlNjBlNzYz NDliNWJjNDMzN2ZmZmQ5OGFlZjkyZmQzOTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q YXNzT3duUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFzc093blB0ci5oCkBAIC0zOSw2ICsz OSw5IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIFBh c3NPd25QdHI7CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gUGFzc093blB0cjxUPiBhZG9wdFB0 cihUKik7CiAKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBSZWZDb3VudGVkOworICAg IHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIFRocmVhZFNhZmVSZWZDb3VudGVkOworCiAgICAg dGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgUGFzc093blB0ciB7CiAgICAgcHVibGljOgogICAg ICAgICB0eXBlZGVmIHR5cGVuYW1lIFJlbW92ZVBvaW50ZXI8VD46OlR5cGUgVmFsdWVUeXBlOwpA QCAtMTQ0LDYgKzE0Nyw5IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gaW5saW5lIFBhc3NPd25QdHI8VD4gYWRvcHRQdHIoVCogcHRyKQogICAgIHsKKyAgICAg ICAgQ09NUElMRV9BU1NFUlQoIShJc1N1YmNsYXNzPFQsIFJlZkNvdW50ZWQ8VD4gPjo6dmFsdWUp LCBEb05vdFVzZUFkb3B0UHRyV2l0aFJlZkNvdW50ZWQpOworICAgICAgICBDT01QSUxFX0FTU0VS VCghKElzU3ViY2xhc3M8VCwgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8VD4gPjo6dmFsdWUpLCBEb05v dFVzZUFkb3B0UHRyV2l0aFRocmVhZFNhZmVSZWZDb3VudGVkKTsKKwogICAgICAgICByZXR1cm4g UGFzc093blB0cjxUPihwdHIpOwogICAgIH0KIAo=